dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
32,883 Commits 2 Branches 0 Tags
49a61ba3f53a135cd7ce6085fb0afc642c50d123
Commit Graph

8371 Commits

Author SHA1 Message Date
Todd Turnidge 49a61ba3f5 Allow users to remove evaluation results. 
BUG=20555
R=rmacnak@google.com

Review URL: https://codereview.chromium.org//1275163002 .
 2015-08-06 17:08:33 -07:00
John McCutchan ca6deda0e4 Fix test failure on analyzer bot 
- Fix a freudian slip

Review URL: https://codereview.chromium.org//1276103004 .
 2015-08-06 16:50:36 -07:00
Ryan Macnak b34267d0d7 Replace is_synthetic bit on Fields with is_reflectable. Mark private fields of dart:* as non-reflectable. 
This fixes an inconsistency in mirrors where some classes in dart:* would claim to have a field but throw NSM if one attempts to access it, and prevents accessing private static fields of dart:* that don't have implicit getters or setters.

R=asiva@google.com

Review URL: https://codereview.chromium.org//1280713002 .
 2015-08-06 16:48:01 -07:00
John McCutchan 0f13b9c931 Allow Dart code to register service protocol handlers 
- Add 'registerExtension' to dart:developer
- A service protocol handler must implement ServiceExtensionHandler
- Service extensions can report result OR error code / message

R=turnidge@google.com

Review URL: https://codereview.chromium.org//1270103002 .
 2015-08-06 16:20:56 -07:00
John McCutchan 40fc39ba2a Fix build error in last CL 2015-08-06 14:31:57 -07:00
John McCutchan 09893f7e3b Make sure that profile_vm is turned off when running profiler tests. 
BUG=

Review URL: https://codereview.chromium.org//1276053002 .
 2015-08-06 14:21:55 -07:00
John McCutchan f58dac21c1 Win64 doesn't support inline assembly. UNIMPLEMENTED for now. 
BUG=

Review URL: https://codereview.chromium.org//1271333003 .
 2015-08-06 14:14:26 -07:00
John McCutchan a04ff66090 Attempt to fix inline assembly on Windows 
BUG=

Review URL: https://codereview.chromium.org//1278943002 .
 2015-08-06 13:52:55 -07:00
John McCutchan a1798f7e45 Enable native stack walking for allocation profiling 
- Use native stack walker for allocation profiling when --profile-vm is passed
- Helpers for retrieving SP, FP, and PC registers
- Refactor sampler code to share more code between allocation sampling / interrupt sampling
- Export all symbols into the dynamic symbol table for run_vm_tests (already doing this for Dart executable)

R=regis@google.com

Review URL: https://codereview.chromium.org//1274663004 .
 2015-08-06 13:31:56 -07:00
Todd Turnidge 38b9945cfd Improve display of library dependency information. 
BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org//1276013002 .
 2015-08-06 12:55:33 -07:00
Siva Annamalai 521dee763c 1. Fix the type arguments recursion problem that gets introduced when canonicalization of type arguments is deferred while reading a script snapshot. This problem was shows up as random stack overflow crashes when running pub 
2. Patching of the type arguments field in a GrowableObjectArray was missed

BUG=23930
R=regis@google.com, rmacnak@google.com

Review URL: https://codereview.chromium.org//1276753002 .
 2015-08-06 10:55:48 -07:00
Todd Turnidge 227010d9dc Order the vm's isolate list by isolate start time. 
This has the effect of making isolate lists more predictable for the user.

BUG=23717
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1275713002 .
 2015-08-06 10:17:07 -07:00
Florian Schneider 28c5ba6bdc VM: Simplify assembler test by removing unused parameter. 
No need to pass a Context into assembler tests.

BUG=
R=srdjan@google.com

Review URL: https://codereview.chromium.org//1272223002 .
 2015-08-06 10:24:14 +02:00
Ryan Macnak b6c979f20b Hoist InstanceMirror.delegate to ObjectMirror. 
BUG=http://dartbug.com/14827
R=gbracha@google.com

Review URL: https://codereview.chromium.org//1273983002 .
 2015-08-05 17:09:59 -07:00
Ivan Posva ee9c0cbb2c - Make sure to close the port if a packages file was passed on the 
command line without actually loading packages.

BUG=23991
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1278623002 .
 2015-08-05 16:34:50 -07:00
Matthias Hausner 223e5a6bb5 Adapt C?.m to latest spec version 
BUG=23794
R=srdjan@google.com

Review URL: https://codereview.chromium.org//1269413005 .
 2015-08-05 15:41:31 -07:00
Ivan Posva e974b952a7 - Prevent getting an unmodifiable list being returned from List.from. 
R=srdjan@google.com

Review URL: https://codereview.chromium.org//1275703002 .
 2015-08-05 13:25:32 -07:00
Ryan Macnak edf288280e Tree-shaking: use a hash set for tracking live selectors; drop uncompiled functions. 
hello_world 8.8 -> 7.4MB heap

R=srdjan@google.com

Review URL: https://codereview.chromium.org//1275653002 .
 2015-08-05 13:21:42 -07:00
Todd Turnidge f73b8aa019 Resolve some input focus issues for the debugger. 
We were dropping clicks with selection type "None" on the floor, mistakenly.

BUG=
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1275543004 .
 2015-08-05 12:43:20 -07:00
Matthias Hausner 1426ac4f77 Reuse constructor closures 
Previously created constructor closures now get
reused when the parent function is recompiled.

BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org//1271343003 .
 2015-08-05 11:07:52 -07:00
Zachary Anderson 4ca87e6d88 Revert VM thread cleanup 
TBR

BUG=

Review URL: https://codereview.chromium.org//1270323002 .
 2015-08-05 01:27:01 -07:00
Florian Schneider 63a8e5227d VM: More abstract interface for generating stub calls. 
This makes the code in the code generator independent from how stubs
are actually called (i.e. directly embedding the target address, or
indirectly by loading the target address from the code object).

BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org//1270803003 .
 2015-08-05 10:18:35 +02:00
Zachary Anderson 5012c7483c Update status file for VM test. 
TBR

BUG=

Review URL: https://codereview.chromium.org//1275433003 .
 2015-08-05 00:19:39 -07:00
Ivan Posva 337931709a - Implement loading of .packages files from http. 
- Fix bad type annotation in builtin.dart when getting an async
  load error.

Review URL: https://codereview.chromium.org//1268313002 .
 2015-08-05 00:13:39 -07:00
Zachary Anderson 174d552574 Enables clean VM shutdown. 
. Disables isolate spawning during Dart_Cleanup.
. Adds a static call Isolate::KillAllIsolates, which sends the
  OOB Kill message to all isolates when called from
  Dart_Cleanup.
. Modifies thread pool shutdown to block until all threads have
  exited.
. Fixes tests.

BUG=
R=turnidge@google.com

Review URL: https://codereview.chromium.org//1177153005 .
 2015-08-04 23:29:25 -07:00
Srdjan Mitrovic caa3cce77e Fix some TODOs 
BUG=
R=regis@google.com

Review URL: https://codereview.chromium.org//1263963003 .
 2015-08-04 17:13:22 -07:00
Regis Crelier 5e2dbbbba4 This fixes a typo. 
R=asiva@google.com

Review URL: https://codereview.chromium.org//1271013005 .
 2015-08-04 16:46:08 -07:00
Ryan Macnak e8320e4081 Adjust implementation of the hash-closurization to work with --no-lazy-dispatchers. 
R=hausner@google.com

Review URL: https://codereview.chromium.org//1269143003 .
 2015-08-04 16:11:55 -07:00
Regis Crelier a42e6199da Relax debug check to allow for type arguments of a canonical signature type to 
be bounded.

Same as lost https://codereview.chromium.org/1270093004/

Review URL: https://codereview.chromium.org//1269013003 .
 2015-08-04 15:47:21 -07:00
Ivan Posva f63db4960c - Implement resource loading via the Resource class. 
R=asiva@google.com

Review URL: https://codereview.chromium.org//1264413002 .
 2015-08-04 15:39:14 -07:00
Ryan Macnak ba88435b7d Add --observe to standalone embedder's help message. 
BUG=http://dartbug.com/23743
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1256263010 .
 2015-08-04 15:14:48 -07:00
John McCutchan 286c1722f5 Support profiler code transition tags 
- Optionally insert tags when transitioning between unoptimized, optimized, and inlined frames.
- Extend inlined function unit test to verify code transition tags.

R=srdjan@google.com

Review URL: https://codereview.chromium.org//1268803006 .
 2015-08-04 15:02:51 -07:00
Daniel Andersson 7d82391e89 Fix race and limit access to mutator_thread_. 
Unsynchronized access to the contents of another thread is dangerous, even for just ASSERTs, as shown by issue 23958.

Verify the bidirectional Isolate<->Thread pointer invariant when *setting* the mutator_thread_ field, and
limit the interface to comparisons with NULL and the current thread.

BUG=https://github.com/dart-lang/sdk/issues/23958
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1260283007 .
 2015-08-04 13:30:50 -07:00
Matthias Hausner 90adbb2968 Fix constructor closures in checked mode 
The parameters of constructor closures must be dynamic.
The Spec says so, and it’s necessary. The formal type
of constructor parameters may not be valid in the context
of the closure function, e.g. if it is a type parameter.

BUG=
R=regis@google.com

Review URL: https://codereview.chromium.org//1269783004 .
 2015-08-04 12:36:13 -07:00
Ryan Macnak 8fce21e456 Fix 32-bit build. 
BUG=

Review URL: https://codereview.chromium.org//1271003003 .
 2015-08-04 11:41:29 -07:00
Ryan Macnak 5ea1f9eb39 Initial tree-shaking for precompilation: only selective compilation, no removal of unused Functions/Classes. 
hello world 23.1 -> 8.1 MB heap

R=fschneider@google.com

Review URL: https://codereview.chromium.org//1259123009 .
 2015-08-04 11:35:36 -07:00
Daniel Andersson 0897409f59 Allow threads to exit an isolate during rendezvous. 
The state is saved and will be visited, so this is safe.

Also clarify that nested calls to SafepointThreads from the same thread is not supported, and check for this.

BUG=
R=iposva@google.com

Review URL: https://codereview.chromium.org//1271773003 .
 2015-08-04 09:30:08 -07:00
John McCutchan 7a0501ce87 Fix shutdown failure path 
BUG=
R=asiva@google.com

Review URL: https://codereview.chromium.org//1255793005 .
 2015-08-04 08:45:01 -07:00
John McCutchan 4505a79e58 Increment next sequence number 
BUG=

Review URL: https://codereview.chromium.org//1260343004 .
 2015-08-04 07:59:13 -07:00
John McCutchan a2757141b0 Make dart:developer log more user friendly 
- Make required arguments required.
- Validate required arguments in Dart before calling native.
- timestamp is now a DateTime.
- level has a default (ALL).
- sequence number is last + 1 if not provided.

R=lrn@google.com

Review URL: https://codereview.chromium.org//1266053003 .
 2015-08-04 07:12:39 -07:00
John McCutchan 7640cf4b85 Fix test failure 
patch from issue 1271693003 at patchset 20001 (http://crrev.com/1271693003#ps20001)

Review URL: https://codereview.chromium.org//1270953003 .
 2015-08-04 07:05:34 -07:00
William Hesse bdda0eff52 Revert "Change msg to message in debugger function." 
This reverts commit 2ae214316c.

BUG=

Review URL: https://codereview.chromium.org//1261203005 .
 2015-08-04 15:22:47 +02:00
Lasse R.H. Nielsen 2ae214316c Change msg to message in debugger function. 
BUG=23949
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1271693003 .
 2015-08-04 14:58:13 +02:00
Florian Loitsch 277bfc3355 Update status files. 
Review URL: https://codereview.chromium.org//1269023006 .
 2015-08-04 14:16:14 +02:00
Ryan Macnak db8ed04981 Hack around dart:io being loaded into non-service isolates in Dartium. 
BUG=http://dartbug.com/23940
R=asiva@google.com

Review URL: https://codereview.chromium.org//1259893006 .
 2015-08-03 16:59:32 -07:00
Matthias Hausner 4ebab25d8f Implement constructor closures 
One detail that isn't implemented yet is canonicalization of constructor tear-offs. At the moment, two tear-offs of the same constructor result in closures that are not equal.

BUG=
R=regis@google.com

Review URL: https://codereview.chromium.org//1255063005 .
 2015-08-03 15:50:46 -07:00
Todd Turnidge 2eeb8ef945 Fix failing version test. 
BUG=
R=nweiz@google.com

Review URL: https://codereview.chromium.org//1267183002 .
 2015-08-03 15:12:44 -07:00
Natalie Weizenbaum 1b7c33a5b5 Bump the VM service protocol version to 2.0. 
This reflects the breaking changes since version 1.0, which was released
in Dart 1.11. It also gets rid of the "draft" language in the VM service
protocol documentation, since it will be (and has been) shipped in a
stable Dart release.

R=turnidge@google.com

Review URL: https://codereview.chromium.org//1270603003 .
 2015-08-03 14:58:51 -07:00
Todd Turnidge 401075fbbf Remember when a variable has been expanded/unexpanded in the debugger. 
BUG=
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1269083006 .
 2015-08-03 14:54:23 -07:00
John McCutchan 59f50474c2 Add box slow path allocation stub to static calls target table 
- Fixes a crash when tracing double allocation in optimized code.

R=rmacnak@google.com

Review URL: https://codereview.chromium.org//1266033003 .
 2015-08-03 13:19:57 -07:00