Commit Graph

32883 Commits

Author SHA1 Message Date
Todd Turnidge 49a61ba3f5 Allow users to remove evaluation results.
BUG=20555
R=rmacnak@google.com

Review URL: https://codereview.chromium.org//1275163002 .
2015-08-06 17:08:33 -07:00
John McCutchan ca6deda0e4 Fix test failure on analyzer bot
- Fix a freudian slip

Review URL: https://codereview.chromium.org//1276103004 .
2015-08-06 16:50:36 -07:00
Ryan Macnak b34267d0d7 Replace is_synthetic bit on Fields with is_reflectable. Mark private fields of dart:* as non-reflectable.
This fixes an inconsistency in mirrors where some classes in dart:* would claim to have a field but throw NSM if one attempts to access it, and prevents accessing private static fields of dart:* that don't have implicit getters or setters.

R=asiva@google.com

Review URL: https://codereview.chromium.org//1280713002 .
2015-08-06 16:48:01 -07:00
John McCutchan 0f13b9c931 Allow Dart code to register service protocol handlers
- Add 'registerExtension' to dart:developer
- A service protocol handler must implement ServiceExtensionHandler
- Service extensions can report result OR error code / message

R=turnidge@google.com

Review URL: https://codereview.chromium.org//1270103002 .
2015-08-06 16:20:56 -07:00
danrubel 3b8b7ee7a2 suggest "deferred as" rather than "deferred"
suggest show and hide in import declaration

fixes #23967

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1276843007 .
2015-08-06 16:02:58 -07:00
Brian Wilkerson 2fd3bad64e Cause "implement methods" to be sorted before "make abstract"
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1276963003 .
2015-08-06 14:40:50 -07:00
John McCutchan 40fc39ba2a Fix build error in last CL 2015-08-06 14:31:57 -07:00
John McCutchan 09893f7e3b Make sure that profile_vm is turned off when running profiler tests.
BUG=

Review URL: https://codereview.chromium.org//1276053002 .
2015-08-06 14:21:55 -07:00
John McCutchan f58dac21c1 Win64 doesn't support inline assembly. UNIMPLEMENTED for now.
BUG=

Review URL: https://codereview.chromium.org//1271333003 .
2015-08-06 14:14:26 -07:00
John McCutchan a04ff66090 Attempt to fix inline assembly on Windows
BUG=

Review URL: https://codereview.chromium.org//1278943002 .
2015-08-06 13:52:55 -07:00
John McCutchan a1798f7e45 Enable native stack walking for allocation profiling
- Use native stack walker for allocation profiling when --profile-vm is passed
- Helpers for retrieving SP, FP, and PC registers
- Refactor sampler code to share more code between allocation sampling / interrupt sampling
- Export all symbols into the dynamic symbol table for run_vm_tests (already doing this for Dart executable)

R=regis@google.com

Review URL: https://codereview.chromium.org//1274663004 .
2015-08-06 13:31:56 -07:00
Todd Turnidge 38b9945cfd Improve display of library dependency information.
BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org//1276013002 .
2015-08-06 12:55:33 -07:00
Konstantin Shcheglov 65941839b7 Remove also duplicate imports.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1277983002 .
2015-08-06 12:42:30 -07:00
Brian Wilkerson e4052e936f More fixes for the Windows bot
R=paulberry@google.com

Review URL: https://codereview.chromium.org//1276973002 .
2015-08-06 11:39:43 -07:00
Paul Berry e21c112313 Upgrade analysis_server's dependency on analyzer to 0.26.1-alpha.0.
This is necessary in order to take advantage of the new signature for
the PathFilter constructor introduced in
d977370e3f.

Also the dependency on dart_style had to be widened since older
versions of dart_style force analyzer version <0.26.0.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1278853002 .
2015-08-06 11:33:13 -07:00
Paul Berry d977370e3f Fix PathFilter constructor to be backward compatible with analyzer 0.26.0.
Commit 24189ea4f9 modified the
PathFilter constructor signature in a backwards-incompatible way, and
made corresponding changes to analysis_server, causing warnings to
show up in analysis_server when analyzed using the version of analyzer
in its pubspec.

This CL switches to a backwards-compatible signature and updates the
analyzer pubspec in preparation for publishing.  Once the new version
of analyzer is published I will update analysis_server's pubspec to
point to it, which should fix the warnings.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1278823002 .
2015-08-06 11:03:55 -07:00
Siva Annamalai 521dee763c 1. Fix the type arguments recursion problem that gets introduced when canonicalization of type arguments is deferred while reading a script snapshot. This problem was shows up as random stack overflow crashes when running pub
2. Patching of the type arguments field in a GrowableObjectArray was missed

BUG=23930
R=regis@google.com, rmacnak@google.com

Review URL: https://codereview.chromium.org//1276753002 .
2015-08-06 10:55:48 -07:00
Todd Turnidge 227010d9dc Order the vm's isolate list by isolate start time.
This has the effect of making isolate lists more predictable for the user.

BUG=23717
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1275713002 .
2015-08-06 10:17:07 -07:00
Brian Wilkerson 9aa45d4cf0 Capture more data when instrumenting exceptions
R=lukechurch@google.com

Review URL: https://codereview.chromium.org//1257023003 .
2015-08-06 08:50:39 -07:00
William Hesse 60c7a3d0ab Factor failing tests out of language/async_star_test.dart
Make async_star_test no longer a multitest, and stop using package:test in
the factored tests.

BUG=dartbug.com/2238, dartbug.com/22853
R=lrn@google.com

Review URL: https://codereview.chromium.org//1270413002 .
2015-08-06 14:56:30 +02:00
Johnni Winther 29cdb17f39 Refactor visitSendSet for super compounds and assignment.
BUG=
R=karlklose@google.com

Review URL: https://codereview.chromium.org//1274073003.
2015-08-06 14:38:05 +02:00
William Hesse 13335ebf97 Update DEPS with new mirrored repos.
BUG=dartbug.com/23864,dartbug.com/23865,dartbug.com/23881
R=ricow@google.com

Review URL: https://codereview.chromium.org//1280603002 .
2015-08-06 14:03:42 +02:00
Karl Klose 4bd727ff6c dart2js: Add a failing test case for the async rewriter.
R=sigurdm@google.com

Review URL: https://codereview.chromium.org//1275003002 .
2015-08-06 12:55:19 +02:00
Sigurd 37fdc0a102 update co19 status file.
BUG=
R=floitsch@google.com

Review URL: https://codereview.chromium.org//1272643002 .
2015-08-06 12:06:30 +02:00
Florian Schneider 28c5ba6bdc VM: Simplify assembler test by removing unused parameter.
No need to pass a Context into assembler tests.

BUG=
R=srdjan@google.com

Review URL: https://codereview.chromium.org//1272223002 .
2015-08-06 10:24:14 +02:00
Ryan Macnak b6c979f20b Hoist InstanceMirror.delegate to ObjectMirror.
BUG=http://dartbug.com/14827
R=gbracha@google.com

Review URL: https://codereview.chromium.org//1273983002 .
2015-08-05 17:09:59 -07:00
Ivan Posva ee9c0cbb2c - Make sure to close the port if a packages file was passed on the
command line without actually loading packages.

BUG=23991
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1278623002 .
2015-08-05 16:34:50 -07:00
Matthias Hausner 223e5a6bb5 Adapt C?.m to latest spec version
BUG=23794
R=srdjan@google.com

Review URL: https://codereview.chromium.org//1269413005 .
2015-08-05 15:41:31 -07:00
Ivan Posva e974b952a7 - Prevent getting an unmodifiable list being returned from List.from.
R=srdjan@google.com

Review URL: https://codereview.chromium.org//1275703002 .
2015-08-05 13:25:32 -07:00
Ryan Macnak edf288280e Tree-shaking: use a hash set for tracking live selectors; drop uncompiled functions.
hello_world 8.8 -> 7.4MB heap

R=srdjan@google.com

Review URL: https://codereview.chromium.org//1275653002 .
2015-08-05 13:21:42 -07:00
Todd Turnidge f73b8aa019 Resolve some input focus issues for the debugger.
We were dropping clicks with selection type "None" on the floor, mistakenly.

BUG=
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1275543004 .
2015-08-05 12:43:20 -07:00
keertip 7f375e3ec1 update dartdoc in DEPS
BUG=
R=pquitslund@google.com

Review URL: https://codereview.chromium.org//1277443004 .
2015-08-05 11:12:00 -07:00
Matthias Hausner 1426ac4f77 Reuse constructor closures
Previously created constructor closures now get
reused when the parent function is recompiled.

BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org//1271343003 .
2015-08-05 11:07:52 -07:00
Seth Ladd 8a173bf278 Merge pull request #23983 from dart-lang/sethladd-patch-2
Links to how to get the source and build it.
2015-08-05 09:10:07 -07:00
Brian Wilkerson f05106f7d1 Fix ToStringVisitor to handle external functions (issue 23968)
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1269393002 .
2015-08-05 08:27:52 -07:00
Brian Wilkerson 848386fddc (TBR) Add missed file
Review URL: https://codereview.chromium.org//1272273003 .
2015-08-05 08:23:43 -07:00
Brian Wilkerson 908708d655 More fixes for failures on the Windows bot
R=paulberry@google.com

Review URL: https://codereview.chromium.org//1266923004 .
2015-08-05 08:13:28 -07:00
Seth Ladd 409c325ead Links to how to get the source and build it. 2015-08-05 08:05:07 -07:00
Florian Loitsch 6377f18587 dart2js: use correct Compiler class.
Review URL: https://codereview.chromium.org//1272613003 .
2015-08-05 14:24:36 +02:00
Florian Loitsch 49daca25d0 dart2js: Set the name to null for parameter stubs of static functions.
R=sigmund@google.com

Review URL: https://codereview.chromium.org//1252543002 .
2015-08-05 13:48:52 +02:00
Florian Loitsch 7e9fcbf5d6 dart2js: Add a header to the output of the startup emitter.
R=sigmund@google.com

Review URL: https://codereview.chromium.org//1271953003 .
2015-08-05 13:47:39 +02:00
Florian Loitsch 3cbedb02e4 dart2js: Add --fast-startup flag.
R=sigmund@google.com

Review URL: https://codereview.chromium.org//1273503002 .
2015-08-05 13:06:29 +02:00
Lasse R.H. Nielsen 0a35f7be3b Update Changelog.
Fix various typos and style nits.

BUG=23961
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//1272593002 .
2015-08-05 12:58:30 +02:00
Søren Gjesse 2ca0bc6d5a Echo the WebSocket close reason as well as the close code
When receiving a close frame with a code and reason both the code
and the reason are now added to the close frame send as response.
Before only the code was added

BUG=https://github.com/dart-lang/sdk/issues/23964
R=kustermann@google.com

Review URL: https://codereview.chromium.org//1273663002 .
2015-08-05 11:53:32 +02:00
Sigurd 58c18aaa9b Fix typos in doc-string.
R=johnniwinther@google.com

Review URL: https://codereview.chromium.org//371523006 .
2015-08-05 11:15:39 +02:00
Zachary Anderson 4ca87e6d88 Revert VM thread cleanup
TBR

BUG=

Review URL: https://codereview.chromium.org//1270323002 .
2015-08-05 01:27:01 -07:00
Florian Schneider 63a8e5227d VM: More abstract interface for generating stub calls.
This makes the code in the code generator independent from how stubs
are actually called (i.e. directly embedding the target address, or
indirectly by loading the target address from the code object).

BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org//1270803003 .
2015-08-05 10:18:35 +02:00
Zachary Anderson 5012c7483c Update status file for VM test.
TBR

BUG=

Review URL: https://codereview.chromium.org//1275433003 .
2015-08-05 00:19:39 -07:00
Ivan Posva 337931709a - Implement loading of .packages files from http.
- Fix bad type annotation in builtin.dart when getting an async
  load error.

Review URL: https://codereview.chromium.org//1268313002 .
2015-08-05 00:13:39 -07:00
Zachary Anderson 174d552574 Enables clean VM shutdown.
. Disables isolate spawning during Dart_Cleanup.
. Adds a static call Isolate::KillAllIsolates, which sends the
  OOB Kill message to all isolates when called from
  Dart_Cleanup.
. Modifies thread pool shutdown to block until all threads have
  exited.
. Fixes tests.

BUG=
R=turnidge@google.com

Review URL: https://codereview.chromium.org//1177153005 .
2015-08-04 23:29:25 -07:00