dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity
32,883 Commits 2 Branches 0 Tags
49a61ba3f53a135cd7ce6085fb0afc642c50d123
Commit Graph

7078 Commits

Author SHA1 Message Date
danrubel 3b8b7ee7a2 suggest "deferred as" rather than "deferred" 
suggest show and hide in import declaration

fixes #23967

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1276843007 .
 2015-08-06 16:02:58 -07:00
Brian Wilkerson 2fd3bad64e Cause "implement methods" to be sorted before "make abstract" 
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1276963003 .
 2015-08-06 14:40:50 -07:00
Konstantin Shcheglov 65941839b7 Remove also duplicate imports. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1277983002 .
 2015-08-06 12:42:30 -07:00
Brian Wilkerson e4052e936f More fixes for the Windows bot 
R=paulberry@google.com

Review URL: https://codereview.chromium.org//1276973002 .
 2015-08-06 11:39:43 -07:00
Paul Berry e21c112313 Upgrade analysis_server's dependency on analyzer to 0.26.1-alpha.0. 
This is necessary in order to take advantage of the new signature for
the PathFilter constructor introduced in
d977370e3f.

Also the dependency on dart_style had to be widened since older
versions of dart_style force analyzer version <0.26.0.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1278853002 .
 2015-08-06 11:33:13 -07:00
Paul Berry d977370e3f Fix PathFilter constructor to be backward compatible with analyzer 0.26.0. 
Commit 24189ea4f9 modified the
PathFilter constructor signature in a backwards-incompatible way, and
made corresponding changes to analysis_server, causing warnings to
show up in analysis_server when analyzed using the version of analyzer
in its pubspec.

This CL switches to a backwards-compatible signature and updates the
analyzer pubspec in preparation for publishing.  Once the new version
of analyzer is published I will update analysis_server's pubspec to
point to it, which should fix the warnings.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1278823002 .
 2015-08-06 11:03:55 -07:00
Brian Wilkerson 9aa45d4cf0 Capture more data when instrumenting exceptions 
R=lukechurch@google.com

Review URL: https://codereview.chromium.org//1257023003 .
 2015-08-06 08:50:39 -07:00
Johnni Winther 29cdb17f39 Refactor visitSendSet for super compounds and assignment. 
BUG=
R=karlklose@google.com

Review URL: https://codereview.chromium.org//1274073003.
 2015-08-06 14:38:05 +02:00
Ryan Macnak b6c979f20b Hoist InstanceMirror.delegate to ObjectMirror. 
BUG=http://dartbug.com/14827
R=gbracha@google.com

Review URL: https://codereview.chromium.org//1273983002 .
 2015-08-05 17:09:59 -07:00
Brian Wilkerson f05106f7d1 Fix ToStringVisitor to handle external functions (issue 23968) 
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1269393002 .
 2015-08-05 08:27:52 -07:00
Brian Wilkerson 848386fddc (TBR) Add missed file 
Review URL: https://codereview.chromium.org//1272273003 .
 2015-08-05 08:23:43 -07:00
Brian Wilkerson 908708d655 More fixes for failures on the Windows bot 
R=paulberry@google.com

Review URL: https://codereview.chromium.org//1266923004 .
 2015-08-05 08:13:28 -07:00
Florian Loitsch 6377f18587 dart2js: use correct Compiler class. 
Review URL: https://codereview.chromium.org//1272613003 .
 2015-08-05 14:24:36 +02:00
Florian Loitsch 49daca25d0 dart2js: Set the name to null for parameter stubs of static functions. 
R=sigmund@google.com

Review URL: https://codereview.chromium.org//1252543002 .
 2015-08-05 13:48:52 +02:00
Florian Loitsch 7e9fcbf5d6 dart2js: Add a header to the output of the startup emitter. 
R=sigmund@google.com

Review URL: https://codereview.chromium.org//1271953003 .
 2015-08-05 13:47:39 +02:00
Florian Loitsch 3cbedb02e4 dart2js: Add --fast-startup flag. 
R=sigmund@google.com

Review URL: https://codereview.chromium.org//1273503002 .
 2015-08-05 13:06:29 +02:00
danrubel a6ea45883d add location to suggestions from local file 
fixes #23905

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1267203002 .
 2015-08-04 22:12:01 -07:00
danrubel bf05b75f43 update suggestion element return type to have type param 
cleanup loadLibrary suggestion to have correct element

dartbug.com/23905

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1260593005 .
 2015-08-04 22:08:55 -07:00
Konstantin Shcheglov d11b644cc5 Issue 23963. Improve to/from block/expression body with void expressions. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/23963

Review URL: https://codereview.chromium.org//1267333003 .
 2015-08-04 16:16:17 -07:00
Konstantin Shcheglov fbb7aedee5 WEB-17598. Name new libraries according to the Dart Style Guide. 
R=brianwilkerson@google.com
BUG= https://youtrack.jetbrains.com/issue/WEB-17598
     https://github.com/dart-lang/sdk/issues/23972

Review URL: https://codereview.chromium.org//1253103007 .
 2015-08-04 14:47:30 -07:00
pq d4d7e300f4 Flip .packages server support bit. 
R=brianwilkerson@google.com, paulberry@google.com

Review URL: https://codereview.chromium.org//1253183015 .
 2015-08-04 14:01:49 -07:00
Konstantin Shcheglov 60ab26dc30 Simplify directive's optimizer edit. 
There was also a bug in computing common range.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1272013002 .
 2015-08-04 13:14:27 -07:00
Konstantin Shcheglov ca28e0ff4b Forgotten test. 
TBR

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1259263004 .
 2015-08-04 08:35:53 -07:00
Florian Loitsch c33930b5d9 dart2js: Fix lazy statics in the startup-emitter. 
R=sigmund@google.com

Review URL: https://codereview.chromium.org//1264283003 .
 2015-08-04 14:21:16 +02:00
Florian Loitsch 47c5878757 dart2js: fix a few TODOs in the startup emitter. 
R=sigmund@google.com

Review URL: https://codereview.chromium.org//1264303002 .
 2015-08-04 14:17:15 +02:00
Florian Loitsch 277bfc3355 Update status files. 
Review URL: https://codereview.chromium.org//1269023006 .
 2015-08-04 14:16:14 +02:00
Florian Loitsch e9b91c7c92 Default values for static functions are now inside closures. (in the startup emitter). 
Since static closures are const values, they can reference each other in the default values:

foo([x = bar]) => null;
bar([x = foo]) => null;

Therefore, we must not reference the default values during tear-off installation (as was the case until now).

The corresponding test has been uploaded in https://chromiumcodereview.appspot.com/1255083008/

R=sigmund@google.com

Review URL: https://codereview.chromium.org//1266903004 .
 2015-08-04 13:56:28 +02:00
Konstantin Shcheglov 92f49b892d Implementation of 'edit.organizeDirectives'. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1255413003 .
 2015-08-03 22:44:35 -07:00
Brian Wilkerson 58199fbad9 Propagate a type in asynchonous for-in statements (issue 23945) 
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1268733004 .
 2015-08-03 17:23:35 -07:00
danrubel fde3b1b335 better completions in switch statements 
Closes #23527

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1255953004 .
 2015-08-03 14:06:30 -07:00
danrubel e8e6cf823a fix completion replacement offset/length for invalid token in switch statement 
Closes #23947

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1271723002 .
 2015-08-03 14:02:40 -07:00
John McCutchan dfc35faaf9 Make exclude list also exclude contexts 
- Only create a context if the directory/.packages/pubspec.yaml is not excluded.
- Add tests.

Fixes: https://github.com/dart-lang/sdk/issues/23941

R=brianwilkerson@google.com, devoncarew@google.com, paulberry@google.com, pquitslund@google.com

Review URL: https://codereview.chromium.org//1263443005 .
 2015-08-03 13:54:17 -07:00
danrubel 9d5154a1fd include exported library namespace in prefixed import suggestions 
Closes #23946

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1263093003 .
 2015-08-03 13:52:44 -07:00
Konstantin Shcheglov 64ff591f56 Organize directives implementation. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1266393002 .
 2015-08-03 13:49:57 -07:00
Konstantin Shcheglov e5b4713f03 'Import library' and 'Create class' Quick Fixes for unresolved class-like name in list literals. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1269043003 .
 2015-08-03 13:03:28 -07:00
Florian Loitsch 98edcfaee5 dart2js: support checked setters in startup-emitter. 
R=sigmund@google.com

Review URL: https://codereview.chromium.org//1249833005 .
 2015-08-03 18:07:10 +02:00
Florian Loitsch 0231f6ba39 dart2js: fix named arguments with Function.apply in the startup emitter. 
This includes a full rewrite of the Function.apply in the runtime.

R=sigmund@google.com

Review URL: https://codereview.chromium.org//1252533003 .
 2015-08-03 18:06:31 +02:00
Florian Loitsch f6b142c5f4 dart2js: Support const symbols in the startup emitter. 
R=sigmund@google.com

Review URL: https://codereview.chromium.org//1253443003 .
 2015-08-03 17:56:34 +02:00
Florian Loitsch 8d6063d806 dart2js: support isolates in the startup-emitter. 
R=sigmund@google.com

Review URL: https://codereview.chromium.org//1249023002 .
 2015-08-03 17:48:43 +02:00
Florian Loitsch 3880150e3a dart2js: Add an empty "MANGLED_NAMES" embedded global to the startup-emitter. 
There will be another update on this embedded global. In fact it is needed for const symbols.

For simplicity I would prefer committing this CL first (to avoid too much merging/rebasing).

R=sigmund@google.com

Review URL: https://codereview.chromium.org//1250023002 .
 2015-08-03 17:47:45 +02:00
Florian Loitsch 5d30039ccc dart2js: Use the correct hashes for deferred code in the startup-emitter. 
Also support source-maps.

R=sigmund@google.com

Review URL: https://codereview.chromium.org//1235973004 .
 2015-08-03 17:46:39 +02:00
Florian Loitsch 9a633402a7 dart2js: Support natives in the startup emitter. 
R=sigmund@google.com

Review URL: https://codereview.chromium.org//1234623002 .
 2015-08-03 17:45:23 +02:00
Florian Loitsch fd6e27c11d dart2js: Add embedded globals to startup emitter. 
R=sigmund@google.com

Review URL: https://codereview.chromium.org//1233693002 .
 2015-08-03 17:42:08 +02:00
Florian Loitsch 62b49eadc6 dart2js: support tear-offs in the startup emitter. 
R=sigmund@google.com

Review URL: https://codereview.chromium.org//1229923005 .
 2015-08-03 17:02:31 +02:00
Konstantin Shcheglov aa30cad380 Proposal for the 'edit.organizeDirectives' request. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/23921

Review URL: https://codereview.chromium.org//1258563008 .
 2015-08-03 07:59:26 -07:00
Konstantin Shcheglov b125399a95 Update LineInfo during incremental resolution. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-atom/dartlang/issues/116

Review URL: https://codereview.chromium.org//1262453007 .
 2015-07-31 10:37:33 -07:00
Brian Wilkerson 24189ea4f9 Make PathFilter use the resource providers path context 
R=paulberry@google.com

Review URL: https://codereview.chromium.org//1260443006 .
 2015-07-31 10:06:38 -07:00
Konstantin Shcheglov 8eb0de07f3 Issue 23919. Fix for line starts in multiline comments. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/23919

Review URL: https://codereview.chromium.org//1271553002 .
 2015-07-31 08:33:38 -07:00
Johnni Winther 0a1b5dfbef Handle super index SendSet operations. 
BUG=
R=floitsch@google.com

Review URL: https://codereview.chromium.org//1262363003.
 2015-07-31 15:42:05 +02:00
pq 818229cbae Server options file rename. 
Clone of https://codereview.chromium.org/1256113004/ which I couldn't cleanly land...

Review URL: https://codereview.chromium.org//1261203003 .
 2015-07-30 16:15:44 -07:00