8bed532218
Tweak toString() for better type inference
...
These changes ensure dart2js can infer toString() returns a non-null String on some of our samples.
One tactic is to always write toString method for which all returned expressions are a an interpolation (or literal), or a call to StringBuffer.toString.
R=alanknight@google.com , lrn@google.com
Review URL: https://codereview.chromium.org//895813002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43534 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-06 00:24:51 +00:00
7516e95066
Redo "Use @Native annotation on dart2js DOM native classes"
...
BUG=
Review URL: https://codereview.chromium.org//410863002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38488 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-23 04:27:48 +00:00
9a4f73207e
Revert "Use @Native annotation on dart2js DOM native classes"
...
TBR=blois@google.com
BUG=
Review URL: https://codereview.chromium.org//410823002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38486 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-23 01:44:13 +00:00
11a19d95be
Use @Native annotation on dart2js DOM native classes
...
This is one of many steps to removing non-standard syntax from the dart2js libraries.
R=blois@google.com
Review URL: https://codereview.chromium.org//409053002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38484 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-23 00:23:17 +00:00
9dd81d94a7
Fixing up DOM constructors.
...
This is a continuation of https://codereview.chromium.org/17063007/
Basically I changed it so factory constructors are only added if the class derives from a native type. Otherwise the native type now extends Interceptor.
BUG=
R=sra@google.com
Review URL: https://codereview.chromium.org//18054021
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24619 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-29 00:14:23 +00:00
6b44f65407
Revert "Making all DOM types abstract and removing superfluous Dartium constructors."
...
This reverts commit http://code.google.com/p/dart/source/detail?r=24241 .
Compiler error, not sure of best fix.
BUG=
Review URL: https://codereview.chromium.org//17508002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24245 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-20 19:37:47 +00:00
c3547d4e9b
Making all DOM types abstract and removing superfluous Dartium constructors.
...
Adding factory constructors to all classes to suppress missing generative constructor warnings.
Adding a throw to Dartium's base DOM class to prevent construction of native objects.
This also includes the changes necessary to make all DOM types abstract, but I'm running into a dart2js issue which is preventing that.
BUG=
R=vsm@google.com
Review URL: https://codereview.chromium.org//17063007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24241 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-20 17:31:36 +00:00
3dc9e79521
Consolidating platform code into dart:html_common
...
Basically a number of our platform checks are only accessible from dart:html and not other libs. Moved Device class over to html_common and added more platform logic which was distributed elsewhere.
Also fixing up Device to cache the platform checks.
BUG=
Review URL: https://codereview.chromium.org//12541020
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19833 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-12 00:49:27 +00:00
cd51673fce
Removed some cruft from ApiDoc.
...
Review URL: https://codereview.chromium.org//12208017
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18151 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-05 19:00:21 +00:00
de9fbf0e90
Renaming dart:html library from 'html' to 'dart.html'
...
This should be invisible to end users, but basically brings dart:html in-line with the core libraries.
BUG=
Review URL: https://codereview.chromium.org//12061008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17929 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-31 17:25:55 +00:00
4a6c2ca155
Regenerate libs for case sensitive file systems. (Why is mac case
...
insensitive?!?)
BUG=
Review URL: https://codereview.chromium.org//11983004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17181 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-17 01:33:57 +00:00
sra@google.com