Commit Graph

29635 Commits

Author SHA1 Message Date
sgjesse@google.com 47236d71e5 Fix checked mode test
TBR=ricow@google.com
BUG=

Review URL: https://codereview.chromium.org//920823002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43727 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-12 14:20:38 +00:00
kustermann@google.com f5e64533a3 Fix multipart transformer in package:mime
The error codition occures in the following scenario:
A multipart transformer returns a new multipart, that part is listened on, but
the subscription for more parts is cancelled. This used to cause cancellation of
the byte stream into the multipart parser, which caused the first part to never
be read completely.

R=lrn@google.com, sgjesse@google.com

Review URL: https://codereview.chromium.org//874223002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43726 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-12 13:51:18 +00:00
kustermann@google.com e06874c751 Fix potential use-after-free bug in windows eventhandler
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//925443002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43725 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-12 13:47:45 +00:00
asgerf@google.com abc37952d4 dart2js: Refactoring, documentation, and a few bugfixes in Namer class.
See long doc comment in namer.dart.

BUG=
R=floitsch@google.com

Committed: https://code.google.com/p/dart/source/detail?r=43588

Reverted: https://code.google.com/p/dart/source/detail?r=43590

Review URL: https://codereview.chromium.org//891673003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43724 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-12 13:43:25 +00:00
sgjesse@google.com 59f8932c9d Update documentation for Platform.version
Add test that Platform.version does start with a valid semver string.

BUG=http://dartbug/22244
R=ricow@google.com

Review URL: https://codereview.chromium.org//921733002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43723 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-12 13:35:56 +00:00
sgjesse@google.com 3fe2af43d1 Reafctor to use 'const RawAddr&' or 'RawAddr*' in the eventhandler code
Also pass the port as part of RawAddr instead of in a separate argument
when both addr and port are passed.

R=kustermann@google.com
BUG=

Review URL: https://codereview.chromium.org//910183003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43722 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-12 11:39:20 +00:00
lrn@google.com a4dc421974 Fix last-minute-typo.
Review URL: https://codereview.chromium.org//921713002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43721 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-12 10:37:40 +00:00
sigurdm@google.com 4f0f538076 Let the CPS ir builder bail out when given a non-sync function.
BUG=
R=johnniwinther@google.com, karlklose@google.com

Review URL: https://codereview.chromium.org//912293004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43720 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-12 09:47:48 +00:00
sigurdm@google.com 4150b44a24 Fix checked-mode return for async-functions.
BUG= dartbug.com/22332
R=floitsch@google.com

Review URL: https://codereview.chromium.org//914143002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43719 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-12 09:35:44 +00:00
lrn@google.com 688d50f1c9 Add String.replaceFirstMapped.
Also refactory VM implementation of checking if a string is one-byte,
and adds dart2js implementation of replaceFirst for non-string/regexp pattern.

BUG= http://dartbug.com/2979
R=floitsch@google.com, iposva@google.com

Committed: https://code.google.com/p/dart/source/detail?r=43716

Review URL: https://codereview.chromium.org//920453002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43718 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-12 09:16:57 +00:00
lrn@google.com 7c9248c642 Revert "Add String.replaceFirstMapped."
Changes to interpolation should be separate CL.

Review URL: https://codereview.chromium.org//917663004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43717 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-12 09:12:06 +00:00
lrn@google.com 6b9ff4c4d4 Add String.replaceFirstMapped.
Also refactory VM implementation of checking if a string is one-byte,
and adds dart2js implementation of replaceFirst for non-string/regexp pattern.

BUG= http://dartbug.com/2979
R=floitsch@google.com, iposva@google.com

Review URL: https://codereview.chromium.org//920453002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43716 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-12 09:04:09 +00:00
sgjesse@google.com 57f7d429d6 Make an enumeration added for 1.9 a real enum
R=lrn@google.com
BUG=

Review URL: https://codereview.chromium.org//909103002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43714 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-12 08:11:39 +00:00
ricow@google.com ee49895197 Archive more debug builds for manual inspection of binary differences
R=koda@google.com
BUG=

Review URL: https://codereview.chromium.org//920673002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43713 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-12 07:24:02 +00:00
sra@google.com 5852e9ef90 Redo "Steps towards making dart2js JS AST templates an indepentent library."
Adds fix for dart2js_incremental

TBR=floitsch@google.com

Review URL: https://codereview.chromium.org//917033002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43712 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-12 01:58:01 +00:00
sra@google.com ba909cfb3e Revert "Redo "Steps towards making dart2js JS AST templates an indepentent library.""
Investigating failure of dart2js_incremental.

TBR=floitsch@google.com

Review URL: https://codereview.chromium.org//922463002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43710 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-12 01:18:03 +00:00
hausner@google.com 2cab6733b2 Fix test expectations for minified dart2dart
Review URL: https://codereview.chromium.org//918873002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43709 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-12 00:51:15 +00:00
brianwilkerson@google.com 06b1a16819 Include source info in status AST dump
R=scheglov@google.com

Review URL: https://codereview.chromium.org//922453002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43708 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-12 00:41:38 +00:00
hausner@google.com 2f0d13af3b Fix yield statements in catch blocks
This is a partial fix for issue 22300. The VM no longer setfaults when
using yield in try statements. Yield in catch blocks work. What’s still
not working right is if a value is yielded before an exception is
propagated to the caller.

R=regis@google.com

Review URL: https://codereview.chromium.org//914303006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43707 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-12 00:12:07 +00:00
asiva@google.com ea16b41a0b Fix race condition an isolate is being added to the isolate list before the name for the isolate is setup, the service isolate starts registering the isolate and accesses the name which is NULL.
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//918823002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43706 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-11 23:39:43 +00:00
scheglov@google.com 3f5da18831 Add packageUriResolver before ResourceUriResolver.
Otherwise execution.mapUri always restores file:// URI.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//922433002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43705 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-11 23:06:48 +00:00
sra@google.com b1a31838f2 Redo "Steps towards making dart2js JS AST templates an indepentent library."
TBR=floitsch@google.com

Review URL: https://codereview.chromium.org//917873002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43703 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-11 22:52:24 +00:00
brianwilkerson@google.com 0efb52aa0f More complete state transition data
R=scheglov@google.com

Review URL: https://codereview.chromium.org//916973002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43700 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-11 22:04:51 +00:00
scheglov@google.com 303d94e89d Add SourceEntry.CONTENT_ERRORS data descriptor.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//914283002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43698 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-11 21:04:18 +00:00
regis@google.com 163f1c2244 Improve _toInt64() and _toUint64() conversions in TypedData.
Add missing conversions of exponent and modulus in Bigint.modPow().
Fix typos in Bigint Classic reduction (modPow tests coming in later cl).
Address a few more TODOs.

R=srdjan@google.com

Review URL: https://codereview.chromium.org//916153002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43697 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-11 20:57:33 +00:00
sra@google.com 068d8a7349 Revert "Steps towards making dart2js JS AST templates an indepentent library."
Investigating snapshot issues.

TBR=floitsch@google.com
BUG=

Review URL: https://codereview.chromium.org//884013011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43696 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-11 18:43:07 +00:00
sra@google.com 4585a0df9d Steps towards making dart2js JS AST templates an indepentent library.
- Removed unused type Blob
- Remove use of CodeBuffer, Compiler, SourceInformation
- Moved existing code into library js_ast
- Added new library js that re-exports js_ast and adds dart2js specific code.

The next step is to move the code into its own package under pkg.

BUG=
R=floitsch@google.com

Review URL: https://codereview.chromium.org//915533002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43695 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-11 18:24:43 +00:00
scheglov@google.com 84655a3ad3 Report an error on Dart Source reading exception.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//909373003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43694 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-11 18:22:27 +00:00
kustermann@google.com be70a52106 Reorder includes and remove platform/globals include
TBR=sgjesse@google.com

Review URL: https://codereview.chromium.org//915083002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43693 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-11 17:24:37 +00:00
whesse@google.com 3466fb448b Update co19 status for flaky tests.
BUG=
R=kustermann@google.com

Review URL: https://codereview.chromium.org//917843002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43692 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-11 17:01:24 +00:00
kustermann@google.com dbd56a9b5c Add unittest for CircularLinkedList + bugfix
BUG=
R=whesse@google.com

Review URL: https://codereview.chromium.org//914203002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43691 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-11 16:20:18 +00:00
danrubel@google.com c762e94a1c check for null completion node
BUG=dartbug.com/22371
R=scheglov@google.com

Review URL: https://codereview.chromium.org//915023002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43690 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-11 15:44:21 +00:00
asgerf@google.com 9dfa76057f Fix method rename in analyzer2dart.
An incomplete refactoring did not touch analyzer2dart.

BUG=

Review URL: https://codereview.chromium.org//916793003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43686 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-11 15:29:36 +00:00
paulberry@google.com be3c32b38b Fix typo in error message.
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//917783002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43685 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-11 15:17:44 +00:00
asgerf@google.com ec384eb0ad dart2js cps: Handle optional parameters in builder.
For static invocations, default values are inlined.

For all invocations, named parameters are reordered alphabetically.

BUG=
R=karlklose@google.com

Committed: https://code.google.com/p/dart/source/detail?r=43643

Reverted: https://code.google.com/p/dart/source/detail?r=43679

Review URL: https://codereview.chromium.org//908863003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43684 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-11 15:13:40 +00:00
kustermann@google.com aeba7a23b1 Fix race condition in tests/standalone/io/file_test
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//920473002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43683 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-11 14:32:55 +00:00
brianwilkerson@google.com 921e9592ad Count task frequency in new task model
R=paulberry@google.com

Review URL: https://codereview.chromium.org//914783002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43682 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-11 14:26:26 +00:00
fschneider@google.com f7a97fa4d4 VM: Fix slow-path deoptimization environment.
The number of pushed arguments needs to be accounted for.

BUG=dartbug.com/22331
R=vegorov@google.com

Review URL: https://codereview.chromium.org//914133002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43681 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-11 13:34:15 +00:00
kustermann@google.com 70ca358a33 Send destroy events for each closed listening socket instead of waiting for all listening sockets to be done
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//914103002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43680 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-11 11:34:47 +00:00
asgerf@google.com 096a40419e Revert "dart2js cps: Handle optional parameters in builder."
This reverts commit 43643.

BUG=
R=johnniwinther@google.com

Review URL: https://codereview.chromium.org//879483005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43679 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-11 10:19:25 +00:00
kustermann@google.com 615d1a01ac Reland "Introduce optional 'bool shared' parameter to ServerSocket.bind() ..."
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//913753002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43678 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-11 10:01:20 +00:00
zarah@google.com c7a791d13c dart2js: store typeVariableReader stubs in the model.
R=floitsch@google.com

Review URL: https://codereview.chromium.org//895813006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43677 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-11 09:49:06 +00:00
sigurdm@google.com 0c5709bd0e Fix dart2dart status file.
BUG=

Review URL: https://codereview.chromium.org//918523002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43676 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-11 08:04:18 +00:00
scheglov@google.com 0b922f3d22 Quick Fix for an undefined class in is/as expressions.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//913923002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43675 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-11 01:31:53 +00:00
scheglov@google.com 7b59c01e8a Use async/await in refactorings.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//913903002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43674 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-11 01:21:43 +00:00
rmacnak@google.com 4de5f89b99 Rename IsConstructor to IsGenerativeConstructor.
This matches the terminology in the spec, and it avoids confusion with the function kind kConstructor, which indicates either a generative constructor or a factory constructor.

R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//910313002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43673 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-11 00:59:19 +00:00
brianwilkerson@google.com 52af26ea3d Minimal initial performance reporting
R=paulberry@google.com

Review URL: https://codereview.chromium.org//913853002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43672 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-10 23:09:40 +00:00
paulberry@google.com 181b3b71c3 Work around warning in new duration2_test.
TBR=floitsch@google.com

Review URL: https://codereview.chromium.org//912973002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43670 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-10 22:50:31 +00:00
asiva@google.com 58c14696fb Fix a windows build issue
../../dart/runtime/vm/flags.cc:58:26: error: invalid suffix on literal; C++11 requires a space between literal and identifier [-Wreserved-user-defined-literal]
        OS::Print("%s: %"Pu64" (%s)\n", name_, *this->uint64_ptr_, comment_);

R=regis@google.com

Review URL: https://codereview.chromium.org//909253002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43669 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-10 21:30:28 +00:00
scheglov@google.com 9aaa9a6a99 Use ExitDetector.exists(node).
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//912023002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43668 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-10 20:46:47 +00:00