904433bd7c
Revert "Annotate dart:html constructor expressions with precise non-nullable types."
...
Need to fix some html/element_types_test cases.
TBR=alanknight@google.com
Review URL: https://codereview.chromium.org//904663005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43579 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-07 00:35:32 +00:00
f74e57786d
Annotate dart:html constructor expressions with precise non-nullable types.
...
This addresses issue http://dartbug.com/22264
R=alanknight@google.com
Review URL: https://codereview.chromium.org//896723009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43578 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-06 23:24:19 +00:00
60bae5bb5d
Cleanup method signatures that were incorrect due to a lack of understanding about how Dart generics work.
...
BUG=
R=alanknight@google.com , terry@google.com
Review URL: https://codereview.chromium.org//896293003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43562 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-06 19:15:49 +00:00
8bed532218
Tweak toString() for better type inference
...
These changes ensure dart2js can infer toString() returns a non-null String on some of our samples.
One tactic is to always write toString method for which all returned expressions are a an interpolation (or literal), or a call to StringBuffer.toString.
R=alanknight@google.com , lrn@google.com
Review URL: https://codereview.chromium.org//895813002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43534 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-06 00:24:51 +00:00
69e76a7b28
Clamp scrollX, scrollY, pageXOffset, and pageYOffset from double to int
...
TBR=vsm@google.com ,asiva@google.com
Review URL: https://codereview.chromium.org//898993002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43477 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-04 16:59:12 +00:00
b68a69329f
Add type annotations to some dart:html closures
...
This helps code quality when the types can be trusted or verified.
R=jacobr@google.com
Review URL: https://codereview.chromium.org//891583002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43349 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-30 23:08:39 +00:00
604106c107
Add webkitAudioPannerNode as an optional name
...
BUG=
R=terry@google.com
Review URL: https://codereview.chromium.org//873803002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43149 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-26 20:27:23 +00:00
721034fa84
BUG=
...
R=alanknight@google.com
Review URL: https://codereview.chromium.org//863713003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43029 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-20 23:04:27 +00:00
7a46d4232b
Simplify _FrozenElementList
...
There is no need to filter the NodeList since it can contain only Elements.
R=jacobr@google.com
Review URL: https://codereview.chromium.org//802603002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42306 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-12 01:40:31 +00:00
b4cfeafc5e
Revert "Workaround for canPlayType in Dartium"
...
This keeps the test.
R=leafp@google.com
Review URL: https://codereview.chromium.org//748883004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42089 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-03 19:25:35 +00:00
e04af71146
Workaround for canPlayType in Dartium
...
BUG=http://dartbug.com/21702
R=leafp@google.com
Review URL: https://codereview.chromium.org//758123003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41967 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-25 20:12:05 +00:00
c3229b7ee1
Fixed pointerlock* getters
...
Fixed onPointerLockChange, onPointerLockError and pointerLockElement not exposed after webkit prefix wa removed.
Review=vsm@google.com
BUG=21376
R=vsm@google.com
Review URL: https://codereview.chromium.org//750093002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41916 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-21 20:12:17 +00:00
42dac4c7b4
Add some ArgumentError and RangeError constructors that capture more information.
...
Switch some uses of RangeError.range to RangeError.index.
Fix bug in Queue where elementAt allowed `length` as input.
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//711003002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41653 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-11 07:55:47 +00:00
09fbe78e71
Move dart2js from sdk/lib/_internal/compiler to pkg/compiler
...
BUG=
Review URL: https://codereview.chromium.org//694353007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41514 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-05 08:51:01 +00:00
8637cfd322
Revert "Move dart2js from sdk/lib/_internal/compiler to pkg/compiler"
...
This reverts commit r41512.
BUG=
Review URL: https://codereview.chromium.org//693183006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41513 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-05 08:15:26 +00:00
2b336e17f0
Move dart2js from sdk/lib/_internal/compiler to pkg/compiler
...
BUG=
Review URL: https://codereview.chromium.org//690103004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41512 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-05 07:09:04 +00:00
be08f872c5
Redirect blink calls through instance
...
Use a singleton instance object for dispatching calls from dart:html to dart:blink to make code more resilient against changes in web idl.
BUG=
R=vsm@google.com
Review URL: https://codereview.chromium.org//684783005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41379 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-28 23:11:51 +00:00
e7dfea4301
Stop generating dart:blink from dart scripts
...
This removes the dart:blink generation code from the dart html scripts. The _blink_dartium template is removed, and the blink_nativeDOMImplementation html_nativeDOMImplementation split is eliminated, with the code for the former in the dartium generated code, and the latter moved back to native_DOMImplementation.dart.
BUG=
R=vsm@google.com
Review URL: https://codereview.chromium.org//680913006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41346 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-27 23:59:26 +00:00
78e328a2f2
More dart:html and dart:blink tweaks
...
Methods with no arguments mangled properly (python None and 0 are both false...).
Abstract classes generated from pure interfaces have no method bodies.
Add missing pure interfaces.
Emit dart:blink methods in sorted order.
BUG=
R=vsm@google.com
Review URL: https://codereview.chromium.org//671023003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41288 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-24 17:47:14 +00:00
302af90f0f
Fix History Cross Frame resolver string
...
TBR=vsm@google.com
BUG=
Review URL: https://codereview.chromium.org//665413002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41239 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-21 21:25:12 +00:00
6de1786199
Arity indexing in dart:blink entry points
...
This CL replaces type mangling on the blink entry points with arity indexing. So overloaded methods or methods with optional arguments now dispatch to blink entries specific to their number of arguments (but not their types). This relies on C++ overload resolution being in place on the blink side (see https://codereview.chromium.org/668733002/ ). For the time being, the dart side overload resolution code is left in place.
Resolver strings now have no type or arity info as well.
BUG=
R=vsm@google.com
Review URL: https://codereview.chromium.org//667983002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41236 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-21 20:46:55 +00:00
de9ba250c5
Reapply "Stop suppressing generation of bindings with Promise. Add some tests for DOM APIs that answer promises."
...
Fix static warning in storage_quota_test.
Fix status of fontface_loaded_test.
R=leafp@google.com
Review URL: https://codereview.chromium.org//658903005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41210 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-20 18:27:03 +00:00
23b5353b0e
Suppress new Request type in dart:html
...
This is conflicting with the Request type in IDB. Hiding it for now. We may want to expose with a different name or factor out into a service worker library.
BUG=http://dartbug.com/21341
R=blois@google.com
Review URL: https://codereview.chromium.org//666543004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41208 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-20 17:57:14 +00:00
f310862906
Revert "Stop suppressing generation of bindings with Promise. Add some tests for DOM APIs that answer promises."
...
TBR=vsm@google.com
Review URL: https://codereview.chromium.org//661603003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41138 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-16 02:54:14 +00:00
5178314123
Stop suppressing generation of bindings with Promise. Add some tests for DOM APIs that answer promises.
...
R=vsm@google.com
Review URL: https://codereview.chromium.org//605853003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41136 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-16 01:17:45 +00:00
8a39ccb8df
Fix for web_gl statics
...
This was fixed on trunk / 1.7 separately. Here's the same for bleeding_edge:
BUG=https://code.google.com/p/dart/issues/detail?id=21173
R=leafp@google.com
Review URL: https://codereview.chromium.org//618323004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41045 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-10 16:40:01 +00:00
be78d098a0
Make Node.nodes.insertAll work for an end-positioned index.
...
R=blois@google.com
Review URL: https://codereview.chromium.org//613063002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40819 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-30 17:54:03 +00:00
905ee314e0
Starting cleanup
...
Reviewers=vsm@google.com ,leafp@google.com
R=vsm@google.com
Review URL: https://codereview.chromium.org//609403004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40784 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-29 20:11:59 +00:00
94095d64a2
Merge 38 changes to bleeding edge
...
TBR=terry@google.com ,leafp@google.com
BUG=
Review URL: https://codereview.chromium.org//605083004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40774 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-29 15:56:25 +00:00
5e96fad938
Fixing treeshaking problem with 37 roll
...
Reviewers=vsm@google.com , sra@google.com
R=sra@google.com , vsm@google.com
Review URL: https://codereview.chromium.org//597363002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40665 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-25 02:40:36 +00:00
1c4bb5f363
Revert "Chrome 38 script changes from integration branch"
...
This reverts commit r40567.
TBR=leafp@google.com
Review URL: https://codereview.chromium.org//589253002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40570 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-22 21:11:34 +00:00
9e25106514
Chrome 38 script changes from integration branch
...
TBR=leafp@google.com
Review URL: https://codereview.chromium.org//593853002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40567 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-22 20:45:57 +00:00
42a229cbb7
Fixed removing of pure interface (implements) operations
...
Reviewers:vsm@google.com ,leafp@google.com
R=vsm@google.com
Review URL: https://codereview.chromium.org//560263004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40227 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-12 23:50:35 +00:00
2b9b3a132f
Temporary fix for CanvasRenderingContext2D.arc
...
TBR=terry@google.com
Review URL: https://codereview.chromium.org//558703004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40221 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-12 21:42:36 +00:00
e379d380bc
Migrate to Chrome 37 IDL
...
This enables terry's new scripts with fixes from vsm and leafp (tested in the dartium_integration branch).
R=leafp@google.com
Review URL: https://codereview.chromium.org//569783002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40219 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-12 21:18:06 +00:00
9fa7c2cff9
Suppport DartCustom for proper native callback
...
Reviews:vsm,leafp
R=vsm@google.com
Review URL: https://codereview.chromium.org//558173002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40096 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-10 16:22:08 +00:00
ddf659197c
Reviewers=vsm,leafp
...
Fixed emitting problems with default/optional.
R=leafp@google.com , vsm@google.com
Review URL: https://codereview.chromium.org//551713003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40054 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-09 20:59:03 +00:00
ecceb75d35
Begin hookup of Blink IDL parser for dart:* libraries.
...
BUG=
R=vsm@google.com
Committed: https://code.google.com/p/dart/source/detail?r=39948
Review URL: https://codereview.chromium.org//444743002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40026 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-09 13:18:24 +00:00
8e3aaa4e75
Blink uses types in entry points
...
This CL changes the way that blink entry points are named to
use the type signature uniformly. This makes us somewhat
more robust against changes in the idl.
BUG=
R=vsm@google.com
Review URL: https://codereview.chromium.org//552533004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40006 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-09 00:17:15 +00:00
ac72bce2f1
"Reverting 39948"
...
BUG=
Review URL: https://codereview.chromium.org//554853002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39999 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-08 20:58:19 +00:00
cf0c6a3565
Begin hookup of Blink IDL parser for dart:* libraries.
...
BUG=
R=vsm@google.com
Review URL: https://codereview.chromium.org//444743002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39948 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-08 02:33:50 +00:00
c67d8ea77f
Update idlsync to pull in bindings python scripts
...
R=terry@google.com
Review URL: https://codereview.chromium.org//537703002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39830 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-03 20:24:54 +00:00
6e19ede429
Fix Try Dart newline handling on IE11.
...
BUG=dartbug.com/20593
R=ahe@google.com , blois@google.com , efortuna@google.com
Review URL: https://codereview.chromium.org//494253002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39626 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-27 23:12:19 +00:00
d7919adbb9
A type for unsupported browser objects
...
This should fix the crash in bug 20592. We currently crash if we do not find the right type in the type table. Siva found it on AnimationTimeline, but there may be others now and going forward.
(Note, objects of this type could actually be used in dart:_blink since they have the right c++ pointer and type id.)
This is the Blink side:
https://chromiumcodereview.appspot.com/490033005/
BUG=dartbug.com/20592
R=leafp@google.com
Review URL: https://codereview.chromium.org//483263004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39577 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-27 07:47:32 +00:00
61fe00cb78
Round Touch attributes back to int for backwards compatibility
...
Most of the attributes in the Touch interface (clientX/Y, screenX/Y, pageX/Y, webkitRadiusX/Y) have changed to use double instead of int. Since we are generating dart:html from old idl, this immediately breaks for us as soon as these are used. This CL wraps calls to these with a round to retain the old API.
BUG=http://dartbug.com/20587
R=blois@google.com
Review URL: https://codereview.chromium.org//493843003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39426 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-20 20:29:36 +00:00
3ab2f9d392
Add parseJson to DartUtilities and mark xhr_test/json as passing.
...
BUG=http://dartbug.com/13069
R=vsm@google.com
Review URL: https://codereview.chromium.org//414193002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39158 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-12 18:44:00 +00:00
1c90159fe2
Document DOMApplicationCache as fix for https://code.google.com/p/dart/issues/detail?id=3688 .
...
BUG=
R=blois@google.com
Review URL: https://codereview.chromium.org//456043002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39096 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-11 17:56:53 +00:00
7cbe70fb2c
Deprecate MouseEvent.elementTo and elementFrom since they have the same
...
functionality as relatedTarget.
BUG=
R=blois@google.com
Review URL: https://codereview.chromium.org//454043004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39050 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-08 21:07:24 +00:00
43063f3ad8
Do regular expression for camelCase CSS processing in JS.
...
BUG=
R=sra@google.com
Review URL: https://codereview.chromium.org//448413002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39018 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-08 00:50:20 +00:00
672bb377bc
Make camelcasing use a regular expression for CSS properties.
...
BUG=
R=sra@google.com
Review URL: https://codereview.chromium.org//455483002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39012 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-07 23:00:52 +00:00
sra@google.com