dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity
29,635 Commits 2 Branches 0 Tags
47236d71e50bf7548e94de28b1767da63e0a8d3d
Commit Graph

40 Commits

Author SHA1 Message Date
pquitslund@google.com ac08a9a570 Async/await/yield[*] support for dart_fmt 
R=brianwilkerson@google.com, paulberry@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//882233004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43529 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-05 22:37:23 +00:00
pquitslund@google.com f6da9b87c4 Enum handling for dart_fmt. 
R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//901743002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43494 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-05 03:38:15 +00:00
scheglov@google.com 413de8f419 Support for 'async' in the old formatter. 
We still use it, and now we have asynchronous code to format :-)

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//884513002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43205 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-27 21:00:37 +00:00
scheglov@google.com a12312f39f Improve formatting of variable declarations/assignments. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//477373002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39320 260f80e4-7a28-3924-810f-c04153c831b5
 2014-08-17 20:24:07 +00:00
scheglov@google.com c8e533be3a Tweak for formatting constructor initializers. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//474363002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39313 260f80e4-7a28-3924-810f-c04153c831b5
 2014-08-15 21:12:36 +00:00
scheglov@google.com 0a09f96271 Improve wrapping during formatting. 
It will wrap on spaces with the lowest priority first, and if required - on the next priority, etc.

R=brianwilkerson@google.com, pquitslund@google.com
BUG=

Review URL: https://codereview.chromium.org//381663004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38109 260f80e4-7a28-3924-810f-c04153c831b5
 2014-07-09 22:26:30 +00:00
scheglov@google.com 591ecb6f1e Formatter: keep a right parenthesis ')' with the last argument. 
R=brianwilkerson@google.com, pquitslund@google.com
BUG=

Review URL: https://codereview.chromium.org//321513006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37087 260f80e4-7a28-3924-810f-c04153c831b5
 2014-06-06 17:09:51 +00:00
scheglov@google.com be92cd5009 Tweaks for long formal parameters and method body '{' formatting. 
R=brianwilkerson@google.com, pquitslund@google.com
BUG=

Review URL: https://codereview.chromium.org//320503002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37084 260f80e4-7a28-3924-810f-c04153c831b5
 2014-06-06 15:33:56 +00:00
scheglov@google.com 979d9be919 Formatter: do not use a space when using < and > for a map literal. 
R=brianwilkerson@google.com, pquitslund@google.com
BUG=

Review URL: https://codereview.chromium.org//322483002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37082 260f80e4-7a28-3924-810f-c04153c831b5
 2014-06-06 15:29:54 +00:00
pquitslund@google.com c9bf850f58 Support for new 'deferred' import declaration modifier. 
R=brianwilkerson@google.com, jwren@google.com

Review URL: https://codereview.chromium.org//264473002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35553 260f80e4-7a28-3924-810f-c04153c831b5
 2014-04-29 23:06:25 +00:00
pquitslund@google.com 7095d194ab Test fixes to catch up with Parser changes (dartbug.com/18315). 
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//254133006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35547 260f80e4-7a28-3924-810f-c04153c831b5
 2014-04-29 22:23:25 +00:00
pquitslund@google.com 9f93ab5937 Annotation whitespace convention fixes (dartbug.com/17837). 
R=scheglov@google.com

Review URL: https://codereview.chromium.org//225863005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34902 260f80e4-7a28-3924-810f-c04153c831b5
 2014-04-09 22:22:31 +00:00
pquitslund@google.com 3edb0efcf4 Fix constructor initializer space conventions (dartbug.com/17642). 
R=scheglov@google.com

Review URL: https://codereview.chromium.org//231743002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34893 260f80e4-7a28-3924-810f-c04153c831b5
 2014-04-09 20:25:36 +00:00
pquitslund@google.com 8a54c6f9d2 Fix handling of 'else if' statement blocks (dartbug.com/17363). 
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//196983003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33613 260f80e4-7a28-3924-810f-c04153c831b5
 2014-03-12 21:11:30 +00:00
pquitslund@google.com ca7f5ebf71 Support for removing empty statements (dartbug.com/16810). 
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//169283013

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32918 260f80e4-7a28-3924-810f-c04153c831b5
 2014-02-21 19:20:32 +00:00
pquitslund@google.com 7b7b87ed97 Fix to ensure decls with initializers get their own lines (dartbug.com/16849). 
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//170403004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32873 260f80e4-7a28-3924-810f-c04153c831b5
 2014-02-20 22:46:24 +00:00
pquitslund@google.com 79f352e4c2 Constructor initializer indent fixes. 
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//141443011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32396 260f80e4-7a28-3924-810f-c04153c831b5
 2014-02-07 00:15:24 +00:00
pquitslund@google.com 18c4e5c74e Fixes for empty class and method bodies. 
See Kevin's nits CL for more context: https://codereview.chromium.org/153623006/

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//151243003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32378 260f80e4-7a28-3924-810f-c04153c831b5
 2014-02-06 19:28:18 +00:00
pquitslund@google.com eaae0b64dc Fix to ensure no breaks after new and general zero-length space support (dartbug.com/16379). 
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//156033002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32332 260f80e4-7a28-3924-810f-c04153c831b5
 2014-02-05 18:41:14 +00:00
pquitslund@google.com 5c26be4b49 Indent fix for trailing comments (dartbug.com/16383). 
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//153203002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32287 260f80e4-7a28-3924-810f-c04153c831b5
 2014-02-04 20:50:12 +00:00
pquitslund@google.com 07888b2f25 Indent fix for switch statement defaults (dartbug.com/16406). 
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//150533003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32174 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-30 21:39:28 +00:00
pquitslund@google.com 18ad816d5f Max line length test fix (dartbug.com/16405). 
The rub: two off by ones! --- Proof that two wrongs don't make a right! :)

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//149913002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32166 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-30 18:35:17 +00:00
pquitslund@google.com 9d5f39180c Empty map formatting fix (dartbug.com/16382). 
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//149793003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32143 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-29 22:02:26 +00:00
pquitslund@google.com 4260d5a585 Fix to allow single method cascades to fit on one line (dartbug.com/16384). 
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//149743002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32138 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-29 20:57:44 +00:00
pquitslund@google.com d6d365cdcc Format fix for assert statements. 
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//149363007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32133 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-29 19:46:52 +00:00
pquitslund@google.com b66342b854 Remove workaround for missing setter function returns (dartbug.com/15914). 
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//145953006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32091 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-28 22:51:27 +00:00
pquitslund@google.com 99595ef86b Remove workaround for missing abstract keyword for ClassTypeAliases (dartbug.com/15912). 
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//144743003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32086 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-28 22:25:38 +00:00
pquitslund@google.com 13961dc1f6 Improved linebreaking for imports (darbug.com/16366) and non-breaking line support. 
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//147983005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32084 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-28 21:37:05 +00:00
pquitslund@google.com aac07d9e6b dartfmt line wrapping bypass option support. 
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//139263011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32034 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-27 22:23:52 +00:00
pquitslund@google.com 7605b96c4b Interpolated String hack-around. 
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//136453008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31846 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-15 19:18:25 +00:00
pquitslund@google.com bb92c20bfb Test roll-back pending line-breaker fixes [TBR]. 
Net-net: the line-breaker is dropping tokens and needs to be disabled while I investigate; until it is re-enabled, this test will fail.

Review URL: https://codereview.chromium.org//138213006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31792 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-14 16:49:23 +00:00
pquitslund@google.com fdb7d2f1a0 Whitespace testing fixes and bit-flip to turn on simple line breaking. 
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//137533005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31791 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-14 16:46:05 +00:00
pquitslund@google.com b8ce88220a Fix to handle loop variables not declared in the for. 
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//118333003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31554 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-07 17:02:08 +00:00
pquitslund@google.com ad48998e7e Formatter fixes (symbols, natives, function type aliases, oh my). 
Last stragglers that make a run over the SDK go green (modulo patch files that is).

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//124863004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31513 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-06 22:22:53 +00:00
pquitslund@google.com bff4cb2a13 Formatter support for metadata. 
As per the spec:

"Metadata can appear before a library, class, typedef, type parameter, constructor, factory, function, field, parameter, or variable declaration and before an import or export directive."

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//125253005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31502 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-06 19:15:08 +00:00
pquitslund@google.com b85d86bb23 Function Decl formatter fixes (external and getters/setters) --- (dartbug.com/15914). 
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//102763007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31491 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-06 17:51:40 +00:00
pquitslund@google.com 49d306b1e0 Formatter workaround for missing abstract keyword in ClassTypeAliases (dartbug.com/15912). 
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//125103003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31484 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-06 17:11:36 +00:00
pquitslund@google.com 2f1411eada Fix and test for leading comment handling (dartbug.com/15876). 
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//109153006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31453 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-03 22:29:25 +00:00
pquitslund@google.com 45ef7ffacc Style guide acceptance tests. 
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//119323005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31444 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-03 19:03:11 +00:00
pquitslund@google.com 21730c7eb8 Test jig for data-driving dartfmt tests. 
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//98693013

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31283 260f80e4-7a28-3924-810f-c04153c831b5
 2013-12-19 17:02:50 +00:00