Commit Graph

80 Commits

Author SHA1 Message Date
brianwilkerson@google.com 03ca35e01e Fix for issue 22178
R=scheglov@google.com

Review URL: https://codereview.chromium.org//900683002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43422 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-03 19:30:30 +00:00
brianwilkerson@google.com cb6c16922f Fix for issue 22052
R=scheglov@google.com

Review URL: https://codereview.chromium.org//881403002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43292 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-29 16:01:58 +00:00
scheglov@google.com a38a503d86 Replace @ReflectiveTestCase() with @reflectiveTest.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//849863002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42821 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-13 17:11:24 +00:00
brianwilkerson@google.com dd306dc9eb Enable enum and deferred import support
R=scheglov@google.com

Review URL: https://codereview.chromium.org//829133007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42704 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-08 17:51:49 +00:00
brianwilkerson@google.com 54df418597 Enable async support
R=danrubel@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//842503003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42666 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-07 16:51:14 +00:00
paulberry@google.com 280657737f Annotate analyzer tests with @ReflectiveTestCase().
Fixes analyzer tests when run under dart2js.

R=scheglov@google.com

Review URL: https://codereview.chromium.org//780763004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42181 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-08 21:00:51 +00:00
brianwilkerson@google.com 59f66641c8 Partial fix for issue 1934
R=scheglov@google.com

Review URL: https://codereview.chromium.org//765923003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42155 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-06 01:04:23 +00:00
brianwilkerson@google.com e15eff9ed2 Fix for issue 3001
R=scheglov@google.com

Review URL: https://codereview.chromium.org//780403002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42154 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-06 01:00:11 +00:00
brianwilkerson@google.com 7e19f48c13 Fix for issue 4070
R=scheglov@google.com

Review URL: https://codereview.chromium.org//781133002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42143 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-05 20:09:58 +00:00
brianwilkerson@google.com 625b422a82 Fix for issue 4482
R=scheglov@google.com

Review URL: https://codereview.chromium.org//785573002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42136 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-05 18:12:19 +00:00
brianwilkerson@google.com 6b378d5007 Fix for issue 18244
R=scheglov@google.com

Review URL: https://codereview.chromium.org//772423004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42097 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-04 00:48:11 +00:00
brianwilkerson@google.com 3696e4601d Fix for issue 18598
R=scheglov@google.com

Review URL: https://codereview.chromium.org//749283007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42091 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-03 20:07:29 +00:00
scheglov@google.com f499514469 Extract DocumentationCommentToken with field.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//768233002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42056 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-02 01:39:25 +00:00
scheglov@google.com cd3d01103b Updated detached tokens of references in documentation comments.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//764243003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42050 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-01 22:22:59 +00:00
paulberry@google.com f9afec6a18 Fix incremental scanner's computation of scanEnd.
Previously, if the last token to be replaced (oldLast) was followed by
a lot of whitespace, we ended the scan at the end of oldLast (adjusted
by delta), which meant that we missed tokens inserted into the
whitespace region.  The correct place to end the scan is at the start
of the first token to be kept (oldRightToken), since that ensures that
we include the whitespace region.

Also, change the expression for scanStart to use oldLeftToken rather
than oldFirst (the two are equivalent) in order to highlight the
symmetry between the expressions for scanStart and scanEnd.

This bug was discovered by the incremental parse stress tester.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//717393006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42002 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-26 16:41:40 +00:00
paulberry@google.com f822139cc5 Add incremental parser test for splitting a combinator.
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//762703004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42001 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-26 16:28:30 +00:00
paulberry@google.com e93f6ff2ea Fix incremental parsing when class name is changed.
This bug was discovered by the incremental parse stress tester.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//760863002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42000 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-26 16:22:00 +00:00
paulberry@google.com a36d6c0a6c Fix incremental parsing of import combinators.
This bug was discovered by the incremental parse stress tester.

R=scheglov@google.com

Review URL: https://codereview.chromium.org//759183002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41993 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-26 14:05:47 +00:00
paulberry@google.com 8d7842bc3f Incremental parser fix: handle insertion of method parameters.
This bug was discovered by the incremental parse stress tester.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//738133002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41864 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-20 19:22:31 +00:00
brianwilkerson@google.com e6686b2993 Move incremental scanner to separate file
R=scheglov@google.com

Review URL: https://codereview.chromium.org//746503002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41856 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-20 17:54:41 +00:00
paulberry@google.com 5ff3e4a594 Incremental parser fix: handle insertion of "final" before field decl.
This bug was discovered by the incremental parse stress tester.

R=scheglov@google.com

Review URL: https://codereview.chromium.org//739723003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41837 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-19 15:34:38 +00:00
paulberry@google.com 4ef51cb52e Fix incremental parsing of function literals in initializer lists.
One of the areas in which the Dart grammar is context sensitive is the
fact that function literals are disallowed inside initializer lists
(unless they are enclosed inside (), [], {}, or "${}").

To deal with this context sentitivity in incremental parsing, we must
rebuild the correct parser state for the subexpression we are going to
re-parse before parsing it.  We do so with a new visitor,
IncrementalParseStateBuilder.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//736813002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41813 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-18 22:49:59 +00:00
scheglov@google.com b8da9bc651 Format and sort analyzer and analysis_server packages.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//725143004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41792 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-17 22:23:53 +00:00
brianwilkerson@google.com 35b13e0885 Make constant lists immutable
R=scheglov@google.com

Review URL: https://codereview.chromium.org//730783002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41757 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-15 01:33:57 +00:00
brianwilkerson@google.com bc1972c228 Add parser recovery tests. These correspond to some cases that dart2js is currently handling that I wanted to make sure we also handled.
R=paulberry@google.com

Review URL: https://codereview.chromium.org//703773004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41652 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-11 03:46:08 +00:00
brianwilkerson@google.com 93cecbd276 Fix hurt recovery
R=paulberry@google.com

Review URL: https://codereview.chromium.org//713953002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41646 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-10 19:38:15 +00:00
brianwilkerson@google.com c258a1d7f6 Create fewer unnecessary lists
R=scheglov@google.com

Review URL: https://codereview.chromium.org//712083003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41641 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-10 17:25:58 +00:00
brianwilkerson@google.com d23df4f448 Clean up references in comments
R=scheglov@google.com

Review URL: https://codereview.chromium.org//708263002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41623 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-08 15:45:19 +00:00
brianwilkerson@google.com f4f12546ad Fix for issue 20796
R=paulberry@google.com

Review URL: https://codereview.chromium.org//689383005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41622 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-08 04:48:44 +00:00
brianwilkerson@google.com 009128c945 Fix issue 20577
R=paulberry@google.com

Review URL: https://codereview.chromium.org//705393002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41616 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-07 21:33:44 +00:00
brianwilkerson@google.com debee8c776 Fix for issue 19100 - better recovery
R=scheglov@google.com

Review URL: https://codereview.chromium.org//692303003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41584 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-06 21:37:27 +00:00
scheglov@google.com e96b29143c Rename ForEachStatement.iterator -> iterable.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//689793003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41405 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-29 21:33:04 +00:00
scheglov@google.com 9a806f616d Replace EngineTestCase.assertSize() with hasLength().
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//686793002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41361 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-28 15:57:33 +00:00
scheglov@google.com 63523cf050 Inline JUnitTestCase 'assert' methods.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//685573002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41347 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-28 00:00:13 +00:00
scheglov@google.com 71a54f980b Replace ${name} with $name where possible.
...i.e. when the next character is not a part of an identifier.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//681003002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41333 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-27 19:43:44 +00:00
scheglov@google.com 78c7e8fc06 Convert most of the EngineTestCase.createSource invocations into multi-line String literals.
There are sill invocations in Angular tests, but these call it with List<String>,
I will clean them up in the following CL.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//682553002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41308 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-26 22:03:21 +00:00
brianwilkerson@google.com 66f7c97acf Remove JavaStringBuilder
R=scheglov@google.com

Review URL: https://codereview.chromium.org//680863002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41305 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-26 21:49:04 +00:00
scheglov@google.com a666399a06 Drop unnecessary toString() in interpolations.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//674183002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41286 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-24 16:17:57 +00:00
brianwilkerson@google.com 16d58cb0b6 Better recovery for getters in functions
R=scheglov@google.com

Review URL: https://codereview.chromium.org//668083002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41238 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-21 21:17:28 +00:00
scheglov@google.com ebf761a5af Convert all the generated tests to reflective.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//637003002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40974 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-07 19:48:40 +00:00
scheglov@google.com d682c178b4 Write end-of-block comments.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//624403002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40912 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-05 17:53:52 +00:00
scheglov@google.com b7189ea678 New analyzer snapshot.
We compute the parameter element for 'object.field = 42' now, so:
1. We can stop doing it in InlineMethodRefactoring.
2. We need to update the corresponding hover integration test.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org//535543003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39772 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-02 20:10:47 +00:00
scheglov@google.com a2cc52070c New analyzer snapshot.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//509073008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39654 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-28 14:54:20 +00:00
scheglov@google.com 8647752153 New analyzer snapshot.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//515543002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39599 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-27 15:51:56 +00:00
scheglov@google.com c74b350b50 New analyzer snapshot.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//489173002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39416 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-20 18:18:43 +00:00
scheglov@google.com 57f076f17f New analyzer snapshot.
Not to be published.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//435483002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38764 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-31 00:40:17 +00:00
scheglov@google.com a4dee8bf4c Resolve names in combinators for PropertyInducingElements instead of PropertyAccessorElements.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//384093002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38199 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-14 17:11:34 +00:00
scheglov@google.com 7a27ca20dd New analyzer snapshot.
Also includes the tweak for property accessor identifiers.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//382953002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38129 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-10 20:33:33 +00:00
scheglov@google.com 46b9b138d6 Move Tokenfactory, AstFactory and ElementFactory from tests to the testing/ Folder.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//351283003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37748 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-26 17:30:25 +00:00
scheglov@google.com d06a1cff08 New analyzer snapshot.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//322603002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37096 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-06 19:48:47 +00:00