303d94e89d
Add SourceEntry.CONTENT_ERRORS data descriptor.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//914283002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43698 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-11 21:04:18 +00:00
84655a3ad3
Report an error on Dart Source reading exception.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//909373003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43694 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-11 18:22:27 +00:00
ae2e608ff9
Send notificatinos after no-op changes.
...
This should solve the problem when client remove some part of the code,
so removes also error markers for it, and then quickly restores it,
so for the server it looks as an empty/no-op change. But information is
lost, and the server should resend it to the client.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//899753004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43521 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-05 20:42:17 +00:00
151d7d98b4
fix warning
...
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//878203002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43196 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-27 17:42:51 +00:00
69f751fc6e
Fix warnings introduced in r43163.
...
TBR=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//875263003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43164 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-27 00:14:07 +00:00
7bf029506d
Fix "reanalyze sources" when there are unsaved files.
...
The analysis server now maintains a single content cache which is
shared by all contexts; this allows it to persist the content cache
across reanalysis (which destroys all contexts and recreates them from
scratch).
Two other bugs are fixed in the process:
- If a file is analyzed in multiple contexts, then editing it will
cause all affected contexts to be notified of the change. (Note
that this could potentially account for some other strange behaviors
we've seen recently, such as incorrect semantic highlighting and
lingering errors/warnings.)
- If the client supplies a ChangeContentOverlay for a file which
currently has no overlay, the proper error is generated.
I plan to submit tests for these two bugs in a follow-up CL.
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//880643005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43163 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-26 23:26:45 +00:00
899de62bbf
(TBR) fix test_performAnalysisTask_importedLibraryAdd_html test
...
BUG=
Review URL: https://codereview.chromium.org//872553003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43091 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-23 03:00:12 +00:00
e20c2167a3
Linter API updates.
...
(A trimmed down version of: https://codereview.chromium.org//853123002 in a hopes of not unsettling the build.)
R=brianwilkerson@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//850343006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43023 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-20 19:38:14 +00:00
3a7594b9fe
Revert "Lint contribution refactoring.", r42967
...
This reverts commit r42967, https://codereview.chromium.org//853123002 .
The change causes an out-of-memory crash in analyzer batch mode, perhaps
a memory leak.
BUG=
R=ricow@google.com
Review URL: https://codereview.chromium.org//834323006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42979 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-19 09:26:45 +00:00
9b132e1032
Lint contribution refactoring.
...
A little shuffle to centralize the linter concern (and reduce the need to touch resolver.dart).
R=brianwilkerson@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//853123002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42967 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-16 18:29:41 +00:00
807a4fa8fa
Delegating AST Visitor and Linter refactoring.
...
R=brianwilkerson@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//813483007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42923 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-15 18:09:42 +00:00
a38a503d86
Replace @ReflectiveTestCase() with @reflectiveTest.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//849863002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42821 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-13 17:11:24 +00:00
e908f30d46
Pluggable lint verifiers first step and basic lint task tests.
...
R=brianwilkerson@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//848463003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42778 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-12 16:44:57 +00:00
11b1c09a10
Remove the Polymer support from the analyzer and analysis_server packages.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//830893003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42709 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-08 18:43:13 +00:00
eb6aac77be
Lint cleanup.
...
Missed an override in tests; incomplete refactoring of severity.
R=paulberry@google.com
Review URL: https://codereview.chromium.org//843583003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42706 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-08 17:55:19 +00:00
dd306dc9eb
Enable enum and deferred import support
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//829133007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42704 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-08 17:51:49 +00:00
4fe7a9dd3e
Remove Angular support from the analyzer and analysis_server packages.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//844593003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42697 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-08 16:04:17 +00:00
54df418597
Enable async support
...
R=danrubel@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//842503003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42666 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-07 16:51:14 +00:00
2546490ed5
Ensure that AnalysisContext futures are completed when context disposed.
...
It's possible for the analysis server to create or destroy contexts in
the background while the user is working (as a result of changes on
the filesystem). This ensures that if any code completions are
waiting for analysis when that happens, they are aborted.
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//807993002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42416 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-16 23:41:56 +00:00
3448724d3a
Improve nomenclature of new AnalysisContext async method.
...
R=danrubel@google.com
Review URL: https://codereview.chromium.org//809793002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42404 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-16 18:05:02 +00:00
d2f11b6c44
Make futures returned by AnalysisContext cancelable.
...
R=brianwilkerson@google.com , danrubel@google.com
Review URL: https://codereview.chromium.org//806733003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42400 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-16 17:01:22 +00:00
0b9ed18603
Allow completions to wait for analysis without requiring a busy wait loop.
...
Two new methods are added to the AnalysisContext which return
Futures--the futures complete with the result of analysis once it's
available, avoiding the need for a busy wait loop in the completion engine.
The futures are guaranteed to complete eventually (provided that
analysis reaches quiescence). If it is determined that the requested
analysis will never become available (e.g. because analysis was
requested for a file or file/library combination that is not subject
to analysis), the future will be completed with an
AnalysisNotScheduledError, so that the client isn't stalled forever
waiting for analysis results.
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//800723002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42339 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-12 18:22:34 +00:00
f58bf4dbc9
Remove old instrumentation
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//784623004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42267 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-10 21:53:08 +00:00
7cd5226565
Annotate remaining analyzer/analysis server tests with "@ReflectiveTestCase()"
...
In r42181, I failed to notice the need to annotate these tests because
they aren't currently being run under dart2js (most likely due to
slowness). I've modified runReflectiveTests() to check for the
presence of the annotation before running the tests, in order to
ensure that all the classes are properly annotated now, and so that we
won't forget to add annotations in the future.
R=scheglov@google.com
Review URL: https://codereview.chromium.org//742273005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42185 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-08 21:35:52 +00:00
5858d6558e
When the same contents is set for a source, we still need to reset its modification time.
...
Otherwise quick add/remove a character causes non-incremental resolution.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//750953005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42120 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-04 22:31:02 +00:00
b9ee97a93f
Rename all_the_rest.dart to all_the_rest_test.dart.
...
So that it will be run by the buildbots.
Also fix a bug which would have caused the test
'DirectoryBasedDartSdkTest.getSdkVersion' to fail when run by the
buildbots.
R=scheglov@google.com
Review URL: https://codereview.chromium.org//762823003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42068 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-02 16:29:30 +00:00
8cd596e82c
add source changed event stream
...
BUG=
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//737673002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41818 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-19 01:02:42 +00:00
58587a470e
Rollback r41807.
...
As discussed, it is not compatible with the incremental analysis.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//736603005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41809 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-18 18:50:28 +00:00
4032b4d86b
Use shorter DartElementLocation.
...
This improves analyzer + analysis_server analysis time from 21841 ms to 19839 ms.
I.e. about 9% faster.
However it is still 25% slower than without index at all - 15593 ms.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//738673002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41807 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-18 16:21:01 +00:00
b8da9bc651
Format and sort analyzer and analysis_server packages.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//725143004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41792 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-17 22:23:53 +00:00
c258a1d7f6
Create fewer unnecessary lists
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//712083003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41641 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-10 17:25:58 +00:00
d23df4f448
Clean up references in comments
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//708263002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41623 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-08 15:45:19 +00:00
678f9e2a3e
Fix issue 21379
...
R=danrubel@google.com , paulberry@google.com
Review URL: https://codereview.chromium.org//683673004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41426 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-30 21:07:50 +00:00
40ad9b8eeb
Improve cache entry tests
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//686293002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41408 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-29 21:56:56 +00:00
03b3d16691
Make table entries on analysis server's '/status' page clickable.
...
Clicking on a table entry now takes you to a list of files in the
given state.
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//685863003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41400 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-29 20:05:16 +00:00
abeba4c773
Replace custom EngineTestCase.assertEquals() with 'unorderedEquals'.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//673233003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41365 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-28 17:00:06 +00:00
9a806f616d
Replace EngineTestCase.assertSize() with hasLength().
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//686793002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41361 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-28 15:57:33 +00:00
2f937685fc
Code clean-up
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//667463004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41348 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-28 00:25:22 +00:00
63523cf050
Inline JUnitTestCase 'assert' methods.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//685573002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41347 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-28 00:00:13 +00:00
555b551ee5
Fix for AnalysisContext.getElement() for enums.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//685483003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41337 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-27 20:54:43 +00:00
71a54f980b
Replace ${name} with $name where possible.
...
...i.e. when the next character is not a part of an identifier.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//681003002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41333 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-27 19:43:44 +00:00
a22aa71cab
Remove JavaIterator and MapEntry
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//680913002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41321 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-27 15:37:24 +00:00
78c7e8fc06
Convert most of the EngineTestCase.createSource invocations into multi-line String literals.
...
There are sill invocations in Angular tests, but these call it with List<String>,
I will clean them up in the following CL.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//682553002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41308 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-26 22:03:21 +00:00
82c1b3550b
Add (as yet unused) task
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//660203003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41172 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-17 16:57:33 +00:00
77613046a5
Generalize source entry
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//661603004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41151 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-16 15:12:45 +00:00
c8d866aa4d
Remove unused time stamps
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//651643002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41063 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-12 20:15:29 +00:00
ebf761a5af
Convert all the generated tests to reflective.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//637003002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40974 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-07 19:48:40 +00:00
9f194c3548
Unify Entry and EntryImpl classes
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//630763004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40944 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-06 19:43:38 +00:00
d23930956a
Remove cache entry copying. This also removes the extractContext/mergeContext methods, but I don't believe that anyone is depending on them.
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//630743002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40936 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-06 16:06:03 +00:00
3fab2628f4
Uncomment and clean up engine_test.dart
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//627133002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40913 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-05 19:55:07 +00:00
scheglov@google.com