Commit Graph

476 Commits

Author SHA1 Message Date
brianwilkerson@google.com 0efb52aa0f More complete state transition data
R=scheglov@google.com

Review URL: https://codereview.chromium.org//916973002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43700 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-11 22:04:51 +00:00
scheglov@google.com 303d94e89d Add SourceEntry.CONTENT_ERRORS data descriptor.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//914283002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43698 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-11 21:04:18 +00:00
scheglov@google.com 84655a3ad3 Report an error on Dart Source reading exception.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//909373003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43694 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-11 18:22:27 +00:00
paulberry@google.com be3c32b38b Fix typo in error message.
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//917783002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43685 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-11 15:17:44 +00:00
brianwilkerson@google.com 921e9592ad Count task frequency in new task model
R=paulberry@google.com

Review URL: https://codereview.chromium.org//914783002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43682 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-11 14:26:26 +00:00
brianwilkerson@google.com 52af26ea3d Minimal initial performance reporting
R=paulberry@google.com

Review URL: https://codereview.chromium.org//913853002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43672 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-10 23:09:40 +00:00
scheglov@google.com 9aaa9a6a99 Use ExitDetector.exists(node).
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//912023002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43668 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-10 20:46:47 +00:00
scheglov@google.com ff4e2bfce1 Issue 22188. Verify that none or all execution flows return.
R=brianwilkerson@google.com, paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22188

Review URL: https://codereview.chromium.org//871013012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43663 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-10 19:14:01 +00:00
johnniwinther@google.com 827e265786 Revert "Add sharedfrontend package"
This reverts commit r43635.

BUG=

Review URL: https://codereview.chromium.org//914613002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43637 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-10 11:32:18 +00:00
johnniwinther@google.com d7118339b5 Add sharedfrontend package
- initial element model includes Element, LibraryElement and ClassElement
- AccessSemantics moved to sharedfrontend to be utilized from both analyzer2dart and dart2js.

BUG=
R=brianwilkerson@google.com, paulberry@google.com

Review URL: https://codereview.chromium.org//898113002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43635 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-10 10:44:56 +00:00
paulberry@google.com 6a869d5e34 Fix inference of the static type of an async function literal.
This implements the spec change currently under review here:
https://codereview.chromium.org/902703003

R=scheglov@google.com

Review URL: https://codereview.chromium.org//905293003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43613 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-09 21:21:36 +00:00
scheglov@google.com d7a2309a92 Fix for incremental resolution in case of inserting a new token into elegant comments.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//913573002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43607 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-09 19:12:04 +00:00
brianwilkerson@google.com ebad629834 Handle exception getting modification stamp
R=scheglov@google.com

Review URL: https://codereview.chromium.org//913513003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43603 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-09 17:19:00 +00:00
pquitslund@google.com e3a0244b58 Tweak to error formatter to fix LINT display name.
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//902383002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43582 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-08 21:01:35 +00:00
brianwilkerson@google.com c2d3ff3b95 Handle exception and clean-up code
R=scheglov@google.com

Review URL: https://codereview.chromium.org//907483004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43563 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-06 19:19:55 +00:00
brianwilkerson@google.com d682527d1e Fix a stack overflow
R=scheglov@google.com

Review URL: https://codereview.chromium.org//908603002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43559 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-06 18:00:16 +00:00
brianwilkerson@google.com 4468038300 Rework requests in execution domain
R=paulberry@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//904733003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43556 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-06 15:49:44 +00:00
paulberry@google.com cb0f691bb6 Fix analyzer type checking of "await" expressions.
This requires implementing the "flatten()" rule defined in the spec;
this rule also needs to be applied to static type checking of return
types in async functions.

BUG=dartbug.com/22291, dartbug.com/22293
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//904743003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43537 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-06 03:32:57 +00:00
pquitslund@google.com ac08a9a570 Async/await/yield[*] support for dart_fmt
R=brianwilkerson@google.com, paulberry@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//882233004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43529 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-05 22:37:23 +00:00
scheglov@google.com 3713a9eed7 Invalidate hints instead of computing them in the incremental resolver.
So, we don't need to prepare all the library parts before incremental resolution.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//901713004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43526 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-05 22:06:48 +00:00
scheglov@google.com ae2e608ff9 Send notificatinos after no-op changes.
This should solve the problem when client remove some part of the code,
so removes also error markers for it, and then quickly restores it,
so for the server it looks as an empty/no-op change. But information is
lost, and the server should resend it to the client.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//899753004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43521 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-05 20:42:17 +00:00
pquitslund@google.com f6da9b87c4 Enum handling for dart_fmt.
R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//901743002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43494 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-05 03:38:15 +00:00
brianwilkerson@google.com c7cb9dd4e8 Fix for issue 22110
R=jwren@google.com

Review URL: https://codereview.chromium.org//885283007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43453 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-04 01:16:57 +00:00
paulberry@google.com d0b87e247c Implement new "yield*" type checking rules in analyzer.
This updates analyzer to reflect the new static type checking rules
for yield each added in r43420.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//888943004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43446 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-03 23:13:09 +00:00
jwren@google.com 032115ecf3 NPE fix in ExitDetector visitor- in analyzer pkg
R=paulberry@google.com

Review URL: https://codereview.chromium.org//894453003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43440 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-03 22:15:18 +00:00
paulberry@google.com 3c315ba0bb Implement new return type checking rules in analyzer.
This updates the analyzer to reflect the new static type checking
rules for return types added in r43420.

R=scheglov@google.com

Review URL: https://codereview.chromium.org//897673003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43427 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-03 21:25:12 +00:00
paulberry@google.com 2cd86b7e29 Add static type checking of "yield*" statements to analyzer.
This does not include the new static typing rules that were introduced
in revision 43420.  I will address those in a later CL.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//895673005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43424 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-03 20:32:14 +00:00
brianwilkerson@google.com 03ca35e01e Fix for issue 22178
R=scheglov@google.com

Review URL: https://codereview.chromium.org//900683002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43422 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-03 19:30:30 +00:00
paulberry@google.com a3e5ed3347 Add static type checking of "yield" statements to analyzer.
Also fix inference of the return type of generator function expressions.

R=scheglov@google.com

Review URL: https://codereview.chromium.org//895113002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43418 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-03 18:51:27 +00:00
scheglov@google.com 658d3e949e Check PackageMapUriResolver constructor arguments.
R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org//887943004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43405 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-03 16:06:25 +00:00
brianwilkerson@google.com 25ea0e7ee0 Fix for issue 22245
R=scheglov@google.com

Review URL: https://codereview.chromium.org//896613003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43404 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-03 15:48:39 +00:00
paulberry@google.com fe8ad3584f Fix return type checking for generator functions.
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//894063004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43403 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-03 15:43:21 +00:00
jwren@google.com 27627f61f4 Don't use firstWhere as it throws an error if there is no such element
R=paulberry@google.com

Review URL: https://codereview.chromium.org//896623002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43372 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-02 23:26:56 +00:00
scheglov@google.com 61d844224e Match body modifiers in incremental resolver.
R=paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org//896573003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43371 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-02 23:23:09 +00:00
paulberry@google.com bde433f33a Report a compile-time error if async/sync/yield used as an identifier.
This error is only reported inside methods marked "async", "async*",
or "sync*".

BUG=dartbug.com/22206
R=scheglov@google.com

Review URL: https://codereview.chromium.org//890253003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43368 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-02 23:13:08 +00:00
paulberry@google.com ee39cfde16 Add a getter to TypeProvider for Future<Null>.
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//894853003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43366 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-02 23:09:46 +00:00
paulberry@google.com b40a5702b3 Fix async/await type checking in analyzer.
This required making the "async" library into TypeProvider so that we
can create Future<...> types when doing resolution and error/hint
checking.

BUG=21888,22053,22091,22092,22160,22164
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//898513002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43361 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-02 20:58:37 +00:00
brianwilkerson@google.com 890c99238c Make source be a target
R=paulberry@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//882813007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43355 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-02 17:08:28 +00:00
pquitslund@google.com 651ea223ca Fix to add lints to error report summary.
R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//874253004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43354 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-02 16:02:06 +00:00
pquitslund@google.com 21850bf962 Fix to ensure lint analysis option gets properly set.
R=brianwilkerson@google.com, danrubel@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//881403005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43298 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-29 16:58:13 +00:00
brianwilkerson@google.com cb6c16922f Fix for issue 22052
R=scheglov@google.com

Review URL: https://codereview.chromium.org//881403002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43292 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-29 16:01:58 +00:00
brianwilkerson@google.com f16e7b8d2e Add simple Dart tasks
R=paulberry@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//887433002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43261 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-28 21:56:42 +00:00
brianwilkerson@google.com fe471e8f02 Make test context more accurate
R=scheglov@google.com

Review URL: https://codereview.chromium.org//879373002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43246 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-28 17:11:38 +00:00
paulberry@google.com ea333d8459 Fix mixin resolution order when multiple mixins present.
BUG=dartbug.com/22069
R=scheglov@google.com

Review URL: https://codereview.chromium.org//879093002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43224 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-27 23:41:21 +00:00
scheglov@google.com 413de8f419 Support for 'async' in the old formatter.
We still use it, and now we have asynchronous code to format :-)

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//884513002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43205 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-27 21:00:37 +00:00
pquitslund@google.com b9f355d2a4 Library dependencies server API updates (to pass package maps).
R=brianwilkerson@google.com, jwren@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//874373003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43193 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-27 17:23:09 +00:00
paulberry@google.com 7bf029506d Fix "reanalyze sources" when there are unsaved files.
The analysis server now maintains a single content cache which is
shared by all contexts; this allows it to persist the content cache
across reanalysis (which destroys all contexts and recreates them from
scratch).

Two other bugs are fixed in the process:

- If a file is analyzed in multiple contexts, then editing it will
  cause all affected contexts to be notified of the change.  (Note
  that this could potentially account for some other strange behaviors
  we've seen recently, such as incorrect semantic highlighting and
  lingering errors/warnings.)

- If the client supplies a ChangeContentOverlay for a file which
  currently has no overlay, the proper error is generated.

I plan to submit tests for these two bugs in a follow-up CL.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//880643005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43163 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-26 23:26:45 +00:00
scheglov@google.com 2b8c66ea79 Rename ChangeNotice resolved Dart/Html unit fields.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//881463004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43147 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-26 19:58:19 +00:00
brianwilkerson@google.com 0d6228609d Improvements to task model
R=paulberry@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//867563004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43146 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-26 19:47:12 +00:00
scheglov@google.com dc144bb870 Issue 22155. Send outline for both parsed and resolved Dart units.
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22155

Review URL: https://codereview.chromium.org//876703003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43145 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-26 19:39:36 +00:00