dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity
29,635 Commits 2 Branches 0 Tags
47236d71e50bf7548e94de28b1767da63e0a8d3d
Commit Graph

68 Commits

Author SHA1 Message Date
paulberry@google.com acaed71dba Clean up analyzer and analysis server hints. 
R=scheglov@google.com

Review URL: https://codereview.chromium.org//908283002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43667 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-10 20:40:26 +00:00
scheglov@google.com ff4e2bfce1 Issue 22188. Verify that none or all execution flows return. 
R=brianwilkerson@google.com, paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22188

Review URL: https://codereview.chromium.org//871013012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43663 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-10 19:14:01 +00:00
scheglov@google.com 8d35890475 Convert refactoring tests to use 'await'. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//908463004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43573 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-06 22:13:37 +00:00
scheglov@google.com 81ebd5fd77 Fix for extracting local variable in if-else-if statements. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//879463004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43528 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-05 22:36:56 +00:00
scheglov@google.com 36ce6423a6 Fix for two semantic highlighting problems. 
1. We need to dispose the existing semantic highlighting manager before setting a new input.
   So, we would not apply old highlighting to the new file.

2. We need to clear "input" fields to correctly determine full file path.

R=danrubel@google.com
BUG=

Review URL: https://codereview.chromium.org//882203002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43254 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-28 19:55:25 +00:00
scheglov@google.com c5af5132fc Issue 22191. Grab the document lock before positionsLock to prevent deadlock. 
R=paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22191

Review URL: https://codereview.chromium.org//885653005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43251 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-28 18:33:16 +00:00
scheglov@google.com a016a7b56e Fix for 'Convert Method to Getter' when multiple files are changed. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//881943002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43221 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-27 23:12:23 +00:00
scheglov@google.com 2b8c66ea79 Rename ChangeNotice resolved Dart/Html unit fields. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//881463004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43147 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-26 19:58:19 +00:00
scheglov@google.com a38a503d86 Replace @ReflectiveTestCase() with @reflectiveTest. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//849863002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42821 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-13 17:11:24 +00:00
scheglov@google.com 9f64a926e6 Issue 21959. Check that type of parameters in 'Extract Method' occurrences are exactly the same. 
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21959

Review URL: https://codereview.chromium.org//832343004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42615 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-05 23:12:27 +00:00
scheglov@google.com dca42cafab Check if the method / accessor being inlined is synthetic. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//835093005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42606 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-05 19:36:39 +00:00
scheglov@google.com 97f90d4acc Fix for extracting from interpolated string. 
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21907

Review URL: https://codereview.chromium.org//820763002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42528 260f80e4-7a28-3924-810f-c04153c831b5
 2014-12-19 22:11:13 +00:00
scheglov@google.com e30b2b313d Ignore ButtonType when computing an extracted method return type. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//789543002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42201 260f80e4-7a28-3924-810f-c04153c831b5
 2014-12-09 02:19:54 +00:00
scheglov@google.com 3b73b01511 Issue 21740. Allow inlining local variables declared in SwitchCase. 
R=paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21740

Review URL: https://codereview.chromium.org//780653005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42191 260f80e4-7a28-3924-810f-c04153c831b5
 2014-12-08 22:33:07 +00:00
scheglov@google.com 0cd030eeb8 Issue 21613. Fix for renaming FieldFormalParameterElement. 
R=paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21613

Review URL: https://codereview.chromium.org//749173002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41929 260f80e4-7a28-3924-810f-c04153c831b5
 2014-11-24 16:00:28 +00:00
scheglov@google.com b8da9bc651 Format and sort analyzer and analysis_server packages. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//725143004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41792 260f80e4-7a28-3924-810f-c04153c831b5
 2014-11-17 22:23:53 +00:00
scheglov@google.com 30e11469c3 Use a better way to compute InterfaceTypes least upper bound. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//730803003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41761 260f80e4-7a28-3924-810f-c04153c831b5
 2014-11-15 16:52:58 +00:00
scheglov@google.com 0f0a275fc7 Issue 21612. Support for multiple returns in the 'Extract Method' refactoring. 
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21612

Review URL: https://codereview.chromium.org//725393002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41758 260f80e4-7a28-3924-810f-c04153c831b5
 2014-11-15 01:40:46 +00:00
scheglov@google.com 6a03e08cca Issue 21617. Replace explicit 'this' references and clean ups. 
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21617

Review URL: https://codereview.chromium.org//733663002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41753 260f80e4-7a28-3924-810f-c04153c831b5
 2014-11-14 23:16:13 +00:00
paulberry@google.com 9bc06fbf41 Workaround for ConstantVisitor dependency issues. 
This restores proper test functionality on the buildbots.  I plan to
follow up with a more permanent fix.

BUG=dartbug.com/21572
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//701583003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41676 260f80e4-7a28-3924-810f-c04153c831b5
 2014-11-11 22:55:58 +00:00
scheglov@google.com 772a0c6b22 Fix 'Unused local variable' hints in analyzer and analysis_server. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//709493002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41576 260f80e4-7a28-3924-810f-c04153c831b5
 2014-11-06 18:32:54 +00:00
scheglov@google.com 1d69da9c39 Issue 21496. Fix for inlining negate/decrement into negate. 
R=paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21496

Review URL: https://codereview.chromium.org//695383002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41466 260f80e4-7a28-3924-810f-c04153c831b5
 2014-11-03 20:29:57 +00:00
scheglov@google.com 15743f701e Support for inlining methods when some arguments are missing. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//694373002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41464 260f80e4-7a28-3924-810f-c04153c831b5
 2014-11-03 18:35:58 +00:00
scheglov@google.com 47532a7ba5 Tweak test for the new resolved/parsed AST management and restore it. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//695923003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41454 260f80e4-7a28-3924-810f-c04153c831b5
 2014-11-01 05:28:46 +00:00
brianwilkerson@google.com 9dad99f92c Disable a test until I can fix it 
Review URL: https://codereview.chromium.org//655353005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41428 260f80e4-7a28-3924-810f-c04153c831b5
 2014-10-30 21:47:58 +00:00
scheglov@google.com e446dd5227 Issue 21333. Constant names are not special anymore in the style guide (Dart version). 
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21333

Review URL: https://codereview.chromium.org//684863003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41373 260f80e4-7a28-3924-810f-c04153c831b5
 2014-10-28 21:42:46 +00:00
scheglov@google.com 227c5524d8 Issue 21375. Fix for FunctionTypeAliasElement-based FunctionType source. 
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21375

Review URL: https://codereview.chromium.org//672013002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41254 260f80e4-7a28-3924-810f-c04153c831b5
 2014-10-23 04:24:59 +00:00
scheglov@google.com 68831585dd Fix for renaming import without an import prefix. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//640253004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41021 260f80e4-7a28-3924-810f-c04153c831b5
 2014-10-09 16:25:07 +00:00
scheglov@google.com 53fe3d983f Issue 21233. Improve inlining strings into string interpolations. 
R=brianwilkerson@google.com, paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21233

Review URL: https://codereview.chromium.org//633823002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40963 260f80e4-7a28-3924-810f-c04153c831b5
 2014-10-07 17:21:40 +00:00
scheglov@google.com 6a3f946ec4 Fix for 'Extract Local' refactoring - take into account local variable elements. 
R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org//619723002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40823 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-30 20:16:40 +00:00
scheglov@google.com f4aabfb6e1 Issue 21071. Generate posix-style relative URIs. 
But parse using the target file system's Context.

R=paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21071

Review URL: https://codereview.chromium.org//603753002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40655 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-24 22:22:57 +00:00
scheglov@google.com 077de1fb02 'Convert Getter to Method' refactoring implementation. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//594503005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40574 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-22 21:55:15 +00:00
scheglov@google.com bb4bd6d889 'Convert Method to Getter' refactoring implementation. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//592643002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40541 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-22 14:53:19 +00:00
scheglov@google.com 66c1b3aacc Issue 18296. Harden the name checks. 
Don't allow to use invalid names in refactorings.

R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=18296

Review URL: https://codereview.chromium.org//585073002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40521 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-19 20:53:05 +00:00
scheglov@google.com eb0fde9cf3 Try to restore 'package:' URI reference to the file being moved. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//586863002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40519 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-19 20:28:18 +00:00
scheglov@google.com 604a9e760d Integration of MOVE_FILE into the server and a couple of fixes. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//583193005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40510 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-19 18:10:56 +00:00
scheglov@google.com cb8c9c654d Move file refactoring implementation. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//585803002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40500 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-19 16:23:14 +00:00
scheglov@google.com 7fde5deecc Send final problems even if 'validateOnly'. 
Also fix for reporting duplicate 'Rename Local' shadowing warnings.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//576703004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40332 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-16 17:48:19 +00:00
scheglov@google.com 3d6fff5735 Issue 18926. Rename refactoring for labels. 
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=18926

Review URL: https://codereview.chromium.org//573803002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40259 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-15 17:48:09 +00:00
scheglov@google.com caf4b0476e Issue 18895. Convert an expression function body into the block function body when Extract Local. 
R=paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=18895

Review URL: https://codereview.chromium.org//568333003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40250 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-15 15:28:31 +00:00
scheglov@google.com 210a4459b2 Issue 20358. Don't report referenced names of named parameters in named expressions as possible shadowing. 
R=paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=20358

Review URL: https://codereview.chromium.org//567083002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40240 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-15 14:48:36 +00:00
scheglov@google.com 59eac1e533 Issue 19800. Support for inlining getters/setters. 
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=19800

Review URL: https://codereview.chromium.org//565973006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40230 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-14 03:17:55 +00:00
scheglov@google.com 8269bc67c3 Issue 19801. Fix for inlining referenced function with an expression body. 
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=19801

Review URL: https://codereview.chromium.org//569723004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40214 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-12 19:41:59 +00:00
scheglov@google.com 778536d97c Issue 19682. New analyzer snapshot that fixes an inline refactoring problem. 
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=19682

Review URL: https://codereview.chromium.org//561373002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40193 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-11 22:47:29 +00:00
scheglov@google.com 19f017660a Return a feedback for the INLINE_METHOD refactoring. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//554053002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39993 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-08 19:56:26 +00:00
scheglov@google.com c0c0b51188 Send feedback for the INLINE_LOCAL_VARIABLE refactoring. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//547343004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39981 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-08 17:33:09 +00:00
scheglov@google.com 3661df5b0e Include additional information into RenameFeedback. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//545943003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39918 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-05 16:39:15 +00:00
scheglov@google.com 43b0e2d584 Use unit + offset as 'Inline Local' arguments. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//533273003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39821 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-03 18:45:18 +00:00
paulberry@google.com 8d8ee25cff Merge analysis_testing package into analysis_server. 
Note that analysis_server already contains a file test/mocks.dart, so
the mocks.dart file from analysis_testing has been imported as
test/mocks2.dart.  I will merge these two into a single file in a
future CL.

R=scheglov@google.com

Review URL: https://codereview.chromium.org//533243002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39814 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-03 18:11:42 +00:00
scheglov@google.com 47fe46e1a6 Integrate EXTRACT_METHOD refactoring into the server. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//534123002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39808 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-03 14:54:16 +00:00