Commit Graph

10 Commits

Author SHA1 Message Date
scheglov@google.com 768aeeac4b Use 'print' to send responses/notifications to the client.
Ensure that Java client reads lines in a separate thread,
so that server's stdout never overflows.

R=brianwilkerson@google.com, danrubel@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org//872633002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43123 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-23 21:33:40 +00:00
danrubel@google.com d284fef9db cleanup unused imports
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//868803006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43086 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-22 22:41:51 +00:00
brianwilkerson@google.com 44b69647a3 Rework instrumentation API
R=danrubel@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//801543002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42321 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-12 16:00:23 +00:00
brianwilkerson@google.com bdb6a6a61f Instrument communications
R=danrubel@google.com, lukechurch@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//790063002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42250 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-10 16:48:08 +00:00
paulberry@google.com 002769a47c Coalesce analysis server output messages into a single write call.
This ensures that only one call to stdout.write() is made per run of
the event loop, so the output of the analysis server should not fall
behind the rate of analysis.

R=scheglov@google.com

Review URL: https://codereview.chromium.org//758833004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41969 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-25 20:39:49 +00:00
paulberry@google.com 8a12fbbb59 Use write instead of writeln for client/server communication.
We have observed that each string sent from the server to the client
using stdout.write() takes at least one cycle of the event loop to
complete.  Since writeln() is implemented using two calls to write(),
this means that streaming of messages to the client was almost always
falling behind the actual rate of analysis, resulting in very annoying
delays for the user.

As a stopgap, send each message from server to client using a single
call to write().  This doesn't completely solve the problem, but it
should reduce its impact while we work on a better solution.

R=scheglov@google.com

Review URL: https://codereview.chromium.org//757013002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41959 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-25 16:06:30 +00:00
scheglov@google.com b8da9bc651 Format and sort analyzer and analysis_server packages.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//725143004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41792 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-17 22:23:53 +00:00
paulberry@google.com 24fac6c7e5 Flush analysis server output stream when closed.
This ensures that if the analysis server terminated with an exception,
the stacktrace will actually be written to stdout before the server
exits.

BUG=dartbug.com/21494
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//694413004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41495 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-04 16:11:55 +00:00
brianwilkerson@google.com f04d5d01ea Add timing of serialization
R=scheglov@google.com

Review URL: https://codereview.chromium.org//666913003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41270 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-23 19:38:17 +00:00
scheglov@google.com 5033317a13 Split channels library.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//544693002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39881 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-04 17:53:16 +00:00