Commit Graph

5 Commits

Author SHA1 Message Date
Johnni Winther 9ec8d9ff25 [ddc] Merge modular/issue37523 test into modular/nested_constants test
Change-Id: I5d60de4468f8608fe275fccd2e4f833a8bcfb89d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112340
Reviewed-by: Nicholas Shahan <nshahan@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
2019-08-09 17:33:44 +00:00
Vyacheslav Egorov 573789f7f1 [cfe] Insert default super initializer when outlining const constructor
This ensures that it is invoked when performing constant evaluation
in modular setting.

Fixes https://github.com/dart-lang/sdk/issues/37794

Bug: 37794
Change-Id: I26c891044e030ac7702f02b2d4996984f9e898c6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112383
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
2019-08-09 11:26:59 +00:00
Johnni Winther d68b482f26 [cfe] Handle constructor from external libraries
Closes #37532

Change-Id: I8b07addeb1da6bc4fe165ff535944fab8c6698b2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109261
Reviewed-by: Nicholas Shahan <nshahan@google.com>
2019-07-17 06:26:34 +00:00
Vijay Menon 5dc14be041 [dartdevc] add regression test for consts in outlines
Fixes https://github.com/dart-lang/sdk/issues/37161

Change-Id: I1718628fe92776dd5bc9f1ce51404e67ba7a70d2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106483
Commit-Queue: Vijay Menon <vsm@google.com>
Reviewed-by: Nate Bosch <nbosch@google.com>
2019-06-19 15:44:35 +00:00
Sigmund Cherem f6d67a549b Turn ddc and dart2js modular tests into suites and share their test cases
For this to work properly, we first need the test infrastructure to have support
for the `--output-directory` flag (see base CL)

Change-Id: I75f788d19ad3b4e9523830250c4a1c9de8418cda
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/104400
Reviewed-by: Johnni Winther <johnniwinther@google.com>
2019-06-07 21:54:56 +00:00