dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
65,857 Commits 2 Branches 0 Tags
3fe9ba152ff1072e79fc50737d71bdf76fe039fa
Commit Graph

65857 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Paul Berry 3fe9ba152f Migration: implement Variables._decorateDirectSupertypes. 
Change-Id: I0e35bf57628bcb72525577e646d6c5de168712bd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113844
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-08-20 20:42:09 +00:00
Brian Wilkerson d67eaefe77 Add more tests of the visibility of extension members 
This is the item labeled "scoping" in the task doc.

Change-Id: I9caf5cd548ecc7a1d1d986854081bf23a5e98de8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113903
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-08-20 20:41:49 +00:00
Sam Rawlins 72923471c4 strict-inference failures for untyped parameters: 
* Untyped function parameters are a strict-inference failure.
* Add tests for strict-inference failures on fields.

This finalizes the "untyped / uninferred variables" cases.

strict-inference spec: https://github.com/dart-lang/language/blob/master/resources/type-system/strict-inference.md

Bug: https://github.com/dart-lang/sdk/issues/33749
Change-Id: I1d01ad15418be1891c95588132a44d478c5905a7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112142
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-08-20 20:06:48 +00:00
Dan Rubel bfc7f8c4b5 Fix crash parsing invalid constructor initializer 
Fix https://github.com/dart-lang/sdk/issues/37414

Change-Id: I6ea202050e2278da50c92b26acd91bdc429d5341
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113861
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2019-08-20 20:04:19 +00:00
Dan Rubel 3e69627752 Fix type argument parsing crash 
Fix https://github.com/dart-lang/sdk/issues/37706

Change-Id: Ifc54c3fa4f57c772f8059d59e0265c4677a400fb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113860
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-08-20 20:04:19 +00:00
Dan Rubel e2777454cc Fix dartfmt bug 
... by changing ANNOTATION_WITH_TYPE_ARGUMENTS to be a syntax error

Fix https://github.com/dart-lang/dart_style/issues/836

Change-Id: I2ac1b1105b817b6728ecc3d73875581a9cf65861
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113760
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-08-20 20:04:19 +00:00
Ben Konyi d95bb2d74f [ package:vm_service ] Analyze package:vm_service on bots 
Change-Id: Ie68a7921d4ba38628997673d643a220505e5a528
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113862
Reviewed-by: Devon Carew <devoncarew@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2019-08-20 19:27:38 +00:00
Mayank Patke 38ca72a3e7 [dart2js] TrivialRuntimeTypesNeed should not say non-generic classes need type arguments. 
Change-Id: Idb791d3ec93ba7eedad0d85a3e12eb51318dd48f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113484
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Mayank Patke <fishythefish@google.com>
 2019-08-20 18:35:30 +00:00
Konstantin Shcheglov 04bd34ed87 Issue 37916. The name of ConstructorName cannot be shadowed. 
R=brianwilkerson@google.com

Bug: https://github.com/dart-lang/sdk/issues/37916
Change-Id: I905e0b9ebfa4514f9a7f28555f95a2154bcf2f04
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113846
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-08-20 18:31:41 +00:00
Mike Fairhurst 3865187956 [nnbd_migration] already-migrated types with 1:1 type args & params. 
Support creating decorated types for already migrated interface types
that have type arguments, so far as those type arguments equal in number
to the interface type's type parameters. This includes basic cases like
List<int>, which is tested as an api_test.

Reduces AlreadyMigratedCodeDecorator.decorate exceptions from 915 to
538.

Change-Id: Ic82d7fb598db964bfc2ca37898795f124796eba8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113750
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
Auto-Submit: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2019-08-20 17:48:40 +00:00
Devon Carew e2fee9c0dd [pkg:vm_service] fix an issue serializing list args 
Bug: https://github.com/dart-lang/sdk/issues/37872
Change-Id: Iba416907d62311c9eff1386ff93e2895814872d7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113843
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2019-08-20 17:19:50 +00:00
Ryan Macnak 37183f8865 [observatory] Remove stale asserts from heap snapshot processing. 
The new heap snapshot format includes VM isolate objects as objects with size 0 instead of excluding them.

Bug: https://github.com/dart-lang/sdk/issues/37919
Change-Id: I5bfd2ca1982e4d7a184907b8981838bdc280d8d2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113751
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
 2019-08-20 17:08:10 +00:00
Devon Carew 396613d884 [pkg:vm_service] be more lenient towards nulls json fields in the java library 
Bug: https://github.com/dart-lang/webdev/issues/586
Change-Id: I03307391813d801be5708aa9f65f25c79682bac6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113845
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2019-08-20 16:57:10 +00:00
Liam Appelbe 0fee296130 [vm] Add wasmer to third_party, and support building rust libraries 
This isn't linked in to anything yet, but I've verified that it works.

Bug: https://github.com/dart-lang/sdk/issues/37882
Change-Id: Ib65d7f11aacac1a20d93fc5d4f10ced19ecb1e51
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113263
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Liam Appelbe <liama@google.com>
 2019-08-20 16:56:10 +00:00
Samir Jindel 663a8630e6 Revert "[vm/ffi] Dispatch native callbacks through trampolines if we can't ensure callbacks will always be executable." 
This reverts commit bab592fd28.

Reason for revert: Breaks SIMARM_X64 build and crashes in hot-reload.

Original change's description:
> [vm/ffi] Dispatch native callbacks through trampolines if we can't ensure callbacks will always be executable.
> 
> Issue https://github.com/dart-lang/sdk/issues/37629
> 
> Change-Id: Ib61c32bde5a8b38d90b4da77e27e3874b8bfb7e2
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111432
> Commit-Queue: Samir Jindel <sjindel@google.com>
> Reviewed-by: Martin Kustermann <kustermann@google.com>

TBR=kustermann@google.com,alexmarkov@google.com,sjindel@google.com

Change-Id: Id7dc3068a97debc7a8f757df31ef33fb68bdcb44
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113827
Reviewed-by: Samir Jindel <sjindel@google.com>
Commit-Queue: Samir Jindel <sjindel@google.com>
 2019-08-20 16:27:32 +00:00
Samir Jindel e8c82c6784 [vm/ffi] Suppress irrelevant lint failures in FFI sources. 
Change-Id: I63893f54a43e7ea5deb8e5e62a0f91e7d0c44d70
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113826
Commit-Queue: Samir Jindel <sjindel@google.com>
Commit-Queue: Daco Harkes <dacoharkes@google.com>
Auto-Submit: Samir Jindel <sjindel@google.com>
Reviewed-by: Daco Harkes <dacoharkes@google.com>
 2019-08-20 15:55:19 +00:00
Samir Jindel bab592fd28 [vm/ffi] Dispatch native callbacks through trampolines if we can't ensure callbacks will always be executable. 
Issue https://github.com/dart-lang/sdk/issues/37629

Change-Id: Ib61c32bde5a8b38d90b4da77e27e3874b8bfb7e2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111432
Commit-Queue: Samir Jindel <sjindel@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
 2019-08-20 15:54:50 +00:00
Paul Berry e34c4319dc Migration: property decorate implicit bottom types. 
Change-Id: I5af76bbfb888ce25642cf61e590862b1b471d4b3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113841
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-08-20 15:20:00 +00:00
Paul Berry c6e2497569 Migration: capture more exception information and make it easier to examine stack traces. 
Change-Id: If509121fcf2b1f9b9e0a7bf722945241b90c647b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113840
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-08-20 15:20:00 +00:00
Jens Johansen fc16f8aa58 Apply flutter-engine patch to dump dart_package_config_tag version 
Change-Id: Ie877cb35e9784804a4d7a39ef7bc95a6bb7bcf06
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113823
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2019-08-20 14:22:40 +00:00
Danny Tuppeny 1e79aa6b7e Update LSP readme to link to dart-vim instructions 
Change-Id: Ie36803aa3012035acb3cf9dca012e55ad2ec4d79
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113696
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Danny Tuppeny <dantup@google.com>
 2019-08-20 14:18:00 +00:00
Johnni Winther 027071318f [cfe] Change outline test to test strong mode 
Closes #37904

Change-Id: I75cd093922dbcf29c0b073d6a37aaba9d6c1f5f2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113697
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
 2019-08-20 13:51:10 +00:00
Jens Johansen 363ae34c55 [CFE] Third batch of fixes for requiring explicit types 
Change-Id: Ie4c8e66acf942901602c91819640967e49044233
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113822
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2019-08-20 13:11:12 +00:00
Jens Johansen e60cbdfd9e [CFE] Add test for running old dills 
This CL:
* adds a test that runs the VM with old dills (compilations of dart2js
  with old checkouts) with the --compile_all argument (1).
* adds a number of old dills (for binary version 25, 27, 28, 29)
  (by mistake binary version 26 sort of didn't really happen)
* adds a PRESUBMIT check in kernel that verifies that we have an
  "old dill" for the current binary version, so one don't bump the
  version without creating a new dill.

(1): It uses --compile_all to force the VM to "read and understand"
     everything in the dill file. The hope being that we try out
     all/most language constructs and thus verifies that they can be
     read by the VM.

Old "old dill" files should be removed once the VM stops supporting that
version. That is a manual process, but a test should complain that the VM
cannot read the old "old dill"(s) once/if that happens.

This should (help) detect errors such as the one recently where a merge
error caused a single "if >= 28" (that should have been "if >= 29" and
thus stopped the VM from reading dills from version 28) to slip through
and require a lot of debugging a few days later.

Change-Id: Id79e16c7ad896c0ccc4e181465b05b67822ac31a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113698
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2019-08-20 12:27:52 +00:00
Clement Skau de45a83755 [test] Makes spawn_function_custom_class_test more robust. 
Adds exit port to spawned isolate to force main isolate and runtime
to wait until spawned isolate has completed.
This should improve potential flakiness stemming from racing.

Similar to:
- https://dart-review.googlesource.com/c/sdk/+/110913
- https://dart-review.googlesource.com/c/sdk/+/108410

Change-Id: I1055ca0e23f38bcfa67f485c5b810c39ef302dde
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113820
Commit-Queue: Clement Skau <cskau@google.com>
Reviewed-by: Daco Harkes <dacoharkes@google.com>
 2019-08-20 12:16:22 +00:00
Dan Rubel f5f942684b Fix invalid literal list element crash 
Fix https://github.com/dart-lang/sdk/issues/37697

Change-Id: Icefae7ca0c0f6b0d317c6aa48039fa6e6967409d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113705
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2019-08-20 12:03:12 +00:00
Johnni Winther d153e98447 Revert "[cfe] Gather constraints from both possibilities for FutureOr" 
This reverts commit 00e9561798.

Original change's description:
> [cfe] Gather constraints from both possibilities for FutureOr
> 
> Closes #37778.
> 
> Bug: http://dartbug.com/37778
> Change-Id: Ic06da9cf4e24e397e1f2a180b743190a4165dc3e
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113033
> Commit-Queue: Johnni Winther <johnniwinther@google.com>
> Reviewed-by: Johnni Winther <johnniwinther@google.com>

TBR=dmitryas@google.com,johnniwinther@google.com

Change-Id: I64677971c865180334958de13d2d82fec3daec85
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: http://dartbug.com/37778
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113821
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2019-08-20 10:57:52 +00:00
Jens Johansen b99df2be86 [CFE] Language versioning - additional tests 
Change-Id: I0dd93c3a1d422bbbbbd920fae21569a7bdc91e61
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112341
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2019-08-20 10:08:20 +00:00
Jens Johansen 10e63b7840 [CFE] Get fragment from default package - use language version if any 
Language versioning specifies that an empty-name-entry in .packages
specifies a sort of "default package" that a non-package file should
pretend to be a part of "for any purpose where that matters,
including choosing the default language level."

Change-Id: I16f4b2f5e4d3ca1e82d2189321e2be5c43e3b260
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112089
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2019-08-20 09:06:32 +00:00
Jonas Termansen 27c8d8b7a8 [benchmark] Stop benchmarking fasta in legacy mode. 
This mode is no longer relevant and doesn't need to be benchmarked.

I didn't remove the legacy entry points in

* pkg/front_end/tool/fasta_perf.dart
* pkg/front_end/tool/incremental_perf.dart

as that would allow a cascade of simplifications that's probably better done
by the front end team.

Change-Id: Iffd977cfdf322aa181025920423083f4ab9de75f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113688
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
 2019-08-20 09:02:12 +00:00
Jonas Termansen 464cea0a9f [benchmark] Test dart2js-x continues to work. 
Remove remnant of dart2js-checked.

Change-Id: I6714acc2cead23d4166eff1869ae51c3d3bac1ad
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113693
Reviewed-by: Alexander Thomas <athom@google.com>
 2019-08-20 08:48:28 +00:00
Johnni Winther 00e9561798 [cfe] Gather constraints from both possibilities for FutureOr 
Closes #37778.

Bug: http://dartbug.com/37778
Change-Id: Ic06da9cf4e24e397e1f2a180b743190a4165dc3e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113033
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2019-08-20 08:43:22 +00:00
Ryan Macnak 6e2b3f0326 [vm] Greatly reduce handle allocation during reload. 
Saves 10ms from non-empty reloads of Flutter Gallery.

Change-Id: If9a1f9970d562f8fd7996de875dfe231350efaa9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113282
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
 2019-08-20 00:49:52 +00:00
Brian Wilkerson 56b3dede78 Implement some missed methods for summary2 support 
Change-Id: I18cbec26512c4d660b6dbc3ea1e5325ff032a8d2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113753
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-08-20 00:31:52 +00:00
Devon Carew 209c6f8ab9 [pkg:vm_service] fix some analysis errors in the generated vm_service library 
Change-Id: I5a09116928e2eff9125ca8033458e485e7f15acb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113756
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2019-08-20 00:22:32 +00:00
Mayank Patke b52b2c3910 [dart2js] Don't produce '-2' for default type argument values with new RTI. 
TBR=sra@google.com

Change-Id: I20ea2b530285090ef8fb4bbb025c632b74be994b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113759
Commit-Queue: Mayank Patke <fishythefish@google.com>
Reviewed-by: Mayank Patke <fishythefish@google.com>
 2019-08-19 23:49:21 +00:00
Ryan Macnak f37fdef1c2 [vm, service] Fix out-of-bounds access when processing requestHeapSnapshot's arguments. 
As detected by the ASAN bots.

Change-Id: Ia10ad883afe886d573f0fa32c2096f9e0ac07083
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113757
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
 2019-08-19 23:46:32 +00:00
Sam Rawlins 5087b99361 Report final re-assignment in for-in parts. Fixes #30486 
Change-Id: I299db3e1e301d90a1a2260d5574f7b174fc29d00
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113580
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-08-19 23:24:22 +00:00
Devon Carew 0ad703b534 [pkg:vm_service] re-generate the library based on the latest spec 
Change-Id: Ie04198ae8726f3cbb3619c97e5c3bb83ee005dc2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113752
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2019-08-19 22:09:53 +00:00
Ryan Macnak f7902889b6 [vm, bytecode] Add missing class declaration loading during reload. 
Change-Id: I7e9fa36a0cc028aa194bba10ae2711894847df9c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113742
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Régis Crelier <regis@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
 2019-08-19 20:43:02 +00:00
Nate Bosch 6667b7fa45 Drop unused _dhelperRepl method 
This private method had been used only for the dev compiler debugger
extension which is no longer in use.

Change-Id: Id38418186ab34b6d403e307caca2dd2bd955d3da
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113741
Reviewed-by: Alan Knight <alanknight@google.com>
Commit-Queue: Nate Bosch <nbosch@google.com>
 2019-08-19 20:16:12 +00:00
Dan Rubel bb076a20c5 Fix unsupported initializer exception 
... and add a new ParserErrorCode.INVALID_INITIALIZER error code

Fix https://github.com/dart-lang/sdk/issues/37693

Change-Id: I0a30ad97f90aab35cd3af76d1546e1e78f1de2db
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113703
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2019-08-19 19:55:12 +00:00
Ben Konyi 9f13d07670 Revert "[dartdevc] Remove explicit calls of the constant evaluator in DDC." 
This reverts commit fb8df61606.

Reason for revert: Breaking Dart SDK -> Flutter engine build.

Original change's description:
> [dartdevc] Remove explicit calls of the constant evaluator in DDC.
> 
> These are unnecessary now that constant evaluation is performed as
> part of the front-end transformations.
> 
> Change-Id: I5de9bbf7ebab09528431f764895eb3e3b1b45379
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111430
> Commit-Queue: Aske Simon Christensen <askesc@google.com>
> Reviewed-by: Vijay Menon <vsm@google.com>

TBR=vsm@google.com,askesc@google.com

Change-Id: Ife7c6f207c38d86e390c98de8af81f9cc5b863c4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113746
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2019-08-19 19:41:15 +00:00
Ryan Macnak 6e987b6eb5 [vm, service] Add requestHeapSnapshot. 
This replaces _requestHeapSnapshot and _getObjectByAddresses, which relied on the invalid assumption that objects don't move and the heap hasn't mutated since the initial snapshot.

Updates Observatory to the new format. Adds treemap visualization of the dominator tree. Adds the ability to save and load heap snapshots to files. Removes analysis grouping references by source and target class. Removes ability to navigate from a pixel in the fragmentation view to inspector. Removes ability to query the top retaining instance from an ordinary class browser.

Change-Id: Ia7781c05d43bf3ec149f8b4ecab803b37c3ee981
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112181
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2019-08-19 19:31:42 +00:00
Martin Kustermann 8a9448138a [vm/compiler] Ensure the class check we insert is based on the same CidTargets we made the HasSingleTarget decision on 
This is a temporary fix until we implement some abstraction to ensure the BG compiler
has always a consistent view of megamorphic caches it's interested in.

Issue https://github.com/dart-lang/sdk/issues/37595

Change-Id: I98ec29db7a4ecd5776f724e11d50fb4535bacdd1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113694
Commit-Queue: Martin Kustermann <kustermann@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
 2019-08-19 19:02:22 +00:00
Alexander Markov 11910a0c9c [vm] Add --verbose-stack-overflow option to simplify investigation of stack overflow errors 
Change-Id: I646b0b27e88064665b8bb1f51b20d2de94614903
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113483
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Régis Crelier <regis@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
 2019-08-19 18:34:42 +00:00
Dan Rubel 3568f78fe7 ensure super constructor invocation param list not null during recovery 
Fix https://github.com/dart-lang/sdk/issues/37735

Change-Id: I727cd7aeb141c5abb779b3c15f338f3d43f6541f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113702
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2019-08-19 18:34:32 +00:00
Stephen Adams 0537c9d326 [dart2js] Fix DartType.subst 
DartType.subst would accidentally drop FunctionTypeVariables that had
bounds modified by substitution.

Use a visitor for printing, with changes that make it possible to see the accidentally
free FunctionTypeVariables that were dropped.

Change-Id: Ie6c8d0bb8f2a22b11db6f009067cf64e38ab93c7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113600
Commit-Queue: Stephen Adams <sra@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2019-08-19 18:11:42 +00:00
Kathy Walrath 0f109da0d1 Updating the package:js README 
Closes #37883
https://github.com/dart-lang/sdk/pull/37883

GitOrigin-RevId: e14be88991f39db80422e98399fab26c8e9c038e
Change-Id: Ic4e45420dcf6fe71b5c215c435cd72ffb6e665f4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113265
Reviewed-by: Nate Bosch <nbosch@google.com>
Commit-Queue: Kathy Walrath <kathyw@google.com>
 2019-08-19 17:52:57 +00:00
Dan Rubel a984c5ce57 improve invalid string literal recovery to fix crash 
Fix https://github.com/dart-lang/sdk/issues/37877

Change-Id: If9fe3d42659608bf7cd050de515ec41ca45a697b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113701
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2019-08-19 17:46:47 +00:00