dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity
65,857 Commits 2 Branches 0 Tags
3fe9ba152ff1072e79fc50737d71bdf76fe039fa
Commit Graph

195 Commits

Author SHA1 Message Date
Konstantin Shcheglov 04bd34ed87 Issue 37916. The name of ConstructorName cannot be shadowed. 
R=brianwilkerson@google.com

Bug: https://github.com/dart-lang/sdk/issues/37916
Change-Id: I905e0b9ebfa4514f9a7f28555f95a2154bcf2f04
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113846
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-08-20 18:31:41 +00:00
Konstantin Shcheglov 6408a9cc4d Tweaks for writeType() and summary2. 
R=brianwilkerson@google.com

Change-Id: If3c682f3dfc12a9e13d805bc25476b16249c7754
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113273
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-08-17 07:28:52 +00:00
Brian Wilkerson 802937e5a6 Add support for completions inside extension (and mixin) bodies 
Change-Id: I549e91ac7a8e293ea6592043988a67a2da680620
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113133
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Dan Rubel <danrubel@google.com>
 2019-08-15 16:39:05 +00:00
Konstantin Shcheglov 0e24437b81 Replace InterfaceType with Substitution in Member(s). 
I ran it in google3:
https://test.corp.google.com/ui#id=OCL:261214112:BASE:261244079:1564722983792:f6286cfb

Change-Id: I820d2dbbaefe495c20b0d8fe3f7c54f1766d5689
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111383
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-08-02 19:34:18 +00:00
Konstantin Shcheglov 1a0fe21fb2 Add ExecutableElement(s) based InheritanceManager3, and switch analyzer to it. 
This reverts commit b8614ca613.

Change-Id: Ic31ee323b21311d8a89f50bcb533316eb55f75e9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110941
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2019-07-29 19:02:24 +00:00
Konstantin Shcheglov ec5bf35152 Update analysis_server and analyzer_plugin to stop using DartType.isSubtypeOf(). 
R=brianwilkerson@google.com, paulberry@google.com

Change-Id: If7365bd82b97bd692af9508697307976ea7c69e7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110881
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-07-29 00:19:37 +00:00
Paul Berry b8614ca613 Revert InheritanceManager3 changes. 
These changes were inadvertenly rolled out in a way that breaks
clients, so we need to stage them out more gradually.  See discussion
at
https://dart-review.googlesource.com/c/sdk/+/110552/2/pkg/analyzer/lib/src/generated/resolver.dart#3768

This reverts commit 5b5ddeda92.
This reverts commit e76879acc4.
This reverts commit 27bec56744.

Change-Id: Ic80a577b1cdc4a6c89ca06afceae01af6621d3e5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110841
Auto-Submit: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-07-28 13:54:09 +00:00
Konstantin Shcheglov 27bec56744 Add ExecutableElement(s) based InheritanceManager3, and switch analyzer to it. 
Initial: 5d6bab4ed2.
Reverted: 39afa4e555
Change-Id: If611f96e6b0156ec218831dd64305e6ccf02e312
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110552
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-07-26 16:16:11 +00:00
Konstantin Shcheglov b0463ea7e0 Add DartFileEditBuilder.format(SourceRange) 
R=brianwilkerson@google.com

Change-Id: I65228f586119385e32d944d608cf21b6bd0dae87
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109549
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-07-18 20:18:22 +00:00
Konstantin Shcheglov 61dfbf6816 Change DartFileEditBuilderImpl to work with full ResolvedUnitResult. 
To make formatting work we need to know the content, and we already
included much of ResolvedUnitResult.

R=brianwilkerson@google.com

Change-Id: I26b79328c01b973803b7bc86b3b810055f6ad431
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109543
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-07-18 18:24:09 +00:00
Konstantin Shcheglov ad6b1ebbd6 Support for 'double' fields in protocol. 
R=brianwilkerson@google.com

Change-Id: If8dacd4578e01380f4d9e4ce1f809b9485bffc7f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108462
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-07-09 18:09:47 +00:00
Konstantin Shcheglov c1d3bf8506 Issue 36890. Ignore the name that contains the caret during completion. 
The previous implementation worked fine in tests, when we asked for
completion where the user does, but that's not what happens during
actual completion. Actually the 'offset' is at the start of the
identifier.

R=brianwilkerson@google.com

Bug: https://github.com/dart-lang/sdk/issues/36890
Change-Id: I5ceaff055580a18fe34d2c17ccacef8f4c7663b3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108282
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-07-08 17:03:32 +00:00
Devon Carew 966038ef58 [analyzer] update package:analyzer_plugin wrt some lints 
Change-Id: Ic8a8989d3dbaab583f8f308d4c3ebbe7accc24cc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108340
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2019-07-08 16:49:52 +00:00
Brian Wilkerson ea0e48a118 Guard against an NPE in completion code (issue 36788) 
Change-Id: I05fc48ac7ad495820c5e3f7efdb6db2096108e54
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107306
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-06-25 17:13:12 +00:00
Konstantin Shcheglov d63466041c Issue 131596231. Suggest names for SimpleFormalParameter(s). 
R=brianwilkerson@google.com, jwren@google.com

Change-Id: I9074ef1a5aaeee32303dcf247c2be86f9c173d14
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/104460
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Jaime Wren <jwren@google.com>
 2019-06-03 17:34:18 +00:00
Konstantin Shcheglov 58f3098650 Issue 36890. Improve importing elements when incomplete code. 
There might be some false negatives, when there *is* another top-level
declaration with the same name as we are removing. But this is a
pre-existing conflict, so I think we should not be very concerned. At
some point we might collect initial potentially conflicting names using
the same SyntacticScopeNamesCollector instead of element model. With
element model we don't know about parser recovery.

R=brianwilkerson@google.com

Bug: https://github.com/dart-lang/sdk/issues/36890
Change-Id: Ia05db299990f41f16feb493c2812237be84f3d2e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101902
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-05-08 23:31:49 +00:00
Brian Wilkerson f80f0bfcfd Reland "Implement the type Never" 
This reverts commit 78e50a5f9b.

Change-Id: I2ec4cdcfda4a6d199308a3b25a2ed0792e9d9a26
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101621
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-05-08 13:26:45 +00:00
Brian Wilkerson 78e50a5f9b Revert "Implement the type Never" 
This reverts commit 40a06c3a77.

Reason for revert: Introduced a bug that is blocking a roll.

Original change's description:
> Implement the type Never
> 
> Change-Id: Icbf407bc19f602c8382946b1e735905cc165c59c
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100993
> Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
> Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
> Reviewed-by: Paul Berry <paulberry@google.com>

TBR=paulberry@google.com,scheglov@google.com,brianwilkerson@google.com,mfairhurst@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: Iebb5b8327b0be7129298f39b343555b812314abf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101640
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-05-07 16:22:37 +00:00
Brian Wilkerson 0e4370d75f Fix exception when libraries cannot be resolved (issue 36863) 
Change-Id: I293cbcc2ba966a62bb40b1eba9c3d25b524cb8cb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101481
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-05-06 19:29:53 +00:00
Brian Wilkerson 40a06c3a77 Implement the type Never 
Change-Id: Icbf407bc19f602c8382946b1e735905cc165c59c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100993
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2019-05-02 16:31:23 +00:00
Konstantin Shcheglov e70273c306 Issue 36733. Completion in spread, if, and for elements. 
R=brianwilkerson@google.com

Bug: https://github.com/dart-lang/sdk/issues/36733
Change-Id: I019741086495eaaf1f2dc078d801f61a0919cc78
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100523
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-04-25 17:18:50 +00:00
Brian Wilkerson af0fa108da Add support for required named parameters 
Change-Id: Iebfd8da18c6f2158ed39043ab116e2670a7329c8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99717
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-04-19 19:25:01 +00:00
Konstantin Shcheglov 096b296390 Improve importing elements when incomplete code. 
R=brianwilkerson@google.com

Change-Id: I49db7a5904ac18d38d2986a5d8ae6fb94108bbe8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98876
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-04-09 15:53:43 +00:00
Jaime Wren ee248fef23 Add a fix for using relative imports when the missing import is in the same library. 
https://www.dartlang.org/guides/language/effective-dart/usage#prefer-relative-paths-when-importing-libraries-within-your-own-packages-lib-directory

Change-Id: I6a4d7f2906fa56dc91d05a86d53dd9da023d2bcf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98623
Commit-Queue: Jaime Wren <jwren@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-04-05 18:50:44 +00:00
danrubel a38dbf8575 update ChangeBuilder to lazily build the source change 
Change-Id: Id645c0538eb8a3391d78e24a3785fe26c7861777
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98626
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2019-04-04 23:20:53 +00:00
Paul Berry 7d277c4a32 Introduce methods and classes to replace "2" variants left over from "UI as code" work. 
The AST refactor for "UI as code" left behind a few things whose names
ended in "2".  This CL deprecates those things and creates
replacements that don't end in "2", so that we keep the API clean.  In
a future breaking change release of the analyzer we'll remove the
deprecated things.

The following methods and classes are added:
- ForStatement and ForStatementImpl
- ListLiteral.elements
- SetOrMapLiteral.elements
- AstVisitor.visitForStatement
- AstFactory.forStatement
- NodeLintRegistry.addForStatement

The following methods and classes are deprecated:
- ForStatement2 and ForStatement2Impl
- ListLiteral.elements2
- SetOrMapLiteral.elements2
- AstVisitor.visitForStatement2
- AstFactory.forStatement2
- NodeLintRegistry.addForStatement2

In a similar way to how we did the previous stage of AST migration,
the existing visitors have been modified so that the default
implementation of visitForStatement2 redirects to visitForStatement;
this allows clients to change their overrides of visitForStatement2 to
override visitForStatement instead.  Once all clients have been
migrated we will be able to delete the visitForStatement2 method.

Change-Id: Ife5949071fe4cb50791cd4f2f4b99a1bfaad54c1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97360
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-03-20 22:58:55 +00:00
Konstantin Shcheglov 632abb6a25 Improve 'Import Library' code generation when has 'part' directive. 
R=brianwilkerson@google.com

Change-Id: Idb3370dcbb67a935939a8ee2c072b897b866f7b0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96826
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-03-13 20:24:13 +00:00
Paul Berry 9a0a3fd8c1 Eliminate uses of old AST node types from analyzer_plugin 
Change-Id: I1dc8e1d51d96c5fc4e6b8c77b143c8cc9564f63e
Reviewed-on: https://dart-review.googlesource.com/c/94761
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-03-01 10:03:22 +00:00
Paul Berry a51c9f15cc Make optype compatible with previous versions of analyzer. 
Change-Id: Ifdf460a9a114fc10d6f1a4afc5d41c8894978840
Reviewed-on: https://dart-review.googlesource.com/c/94802
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-02-28 18:21:03 +00:00
Paul Berry a1349ac529 Remove childEntities and visitChildren from ForEachStatementImpl and ForStatementImpl. 
This paves the way for replacing these data structures with
ForStatement2Impl, by making them expose the same set of child nodes
that ForStatement2Impl would.

This required some fixes in the implementations of completion and
refactoring, since they make assumptions about the relationships
between nodes and their children.

Change-Id: I35e2873fcee2c88215c51c5caa5318934fc2a1a8
Reviewed-on: https://dart-review.googlesource.com/c/94401
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-02-27 21:41:00 +00:00
Brian Wilkerson 010052cb2b Add an assist to convert conditional expressions to a null aware operator (issue 35691) 
Change-Id: Ic9aa8d3fa0408653088c9eb91c14083622ede60f
Reviewed-on: https://dart-review.googlesource.com/c/94124
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-02-24 22:46:14 +00:00
Konstantin Shcheglov 266ce73e28 Remove CompletionSuggestion.elementUri, replaced with AvailableSuggestionSet. 
R=brianwilkerson@google.com

Context: https://github.com/JetBrains/intellij-plugins/pull/633#issuecomment-465725310
Change-Id: I03a1b7e7ec7cc0a5b0797dc960b72ca314a32132
Reviewed-on: https://dart-review.googlesource.com/c/93745
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-02-20 21:34:18 +00:00
Konstantin Shcheglov 5e2529c82e Remove 'importUri' from CompletionSuggestion. 
R=brianwilkerson@google.com

Change-Id: I1c06f7e6d84d5c2dd0eee7fa80f2e4bca3959513
Reviewed-on: https://dart-review.googlesource.com/c/93379
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-02-20 18:14:45 +00:00
Konstantin Shcheglov 273856c6e3 Issue 3204. Support for local mixins as types. 
However this is not what the issue is about.
But still a bug.

R=brianwilkerson@google.com

Bug: https://github.com/flutter/flutter-intellij/issues/3204
Change-Id: I743e1684f84844422bdfc8fcb30c2b3a051f4580
Reviewed-on: https://dart-review.googlesource.com/c/93376
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-02-20 03:28:01 +00:00
Konstantin Shcheglov 39afa4e555 Revert "Add ExecutableElement(s) based InheritanceManager3, and switch analyzer to it." 
This reverts commit 5d6bab4ed2.

Reason for revert: this change is API incompatible when rolling into mono-repo.

Original change's description:
> Add ExecutableElement(s) based InheritanceManager3, and switch analyzer to it.
> 
> Change-Id: I9d87619e05ae769f4df6a6ba26cd7901c7c98510
> Reviewed-on: https://dart-review.googlesource.com/c/93141
> Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>

TBR=scheglov@google.com,brianwilkerson@google.com

Change-Id: I98d478f56e8aea037cbcc8b6cb940c36edb732fd
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/93440
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-02-15 16:38:08 +00:00
Konstantin Shcheglov 078f8e67f8 Tests for invalid library id, and requested name. 
R=brianwilkerson@google.com

Change-Id: I75c7445bd2e9e25805c8789af9e648a3000b0668
Reviewed-on: https://dart-review.googlesource.com/c/93381
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-02-15 16:35:56 +00:00
Konstantin Shcheglov d1b15cc92c Support for FieldFormalParameter in SyntacticScopeNamesCollector. 
R=brianwilkerson@google.com

Change-Id: I2d1311de5c373bf81034e7764086ad09ac22a041
Reviewed-on: https://dart-review.googlesource.com/c/93280
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-02-14 19:26:29 +00:00
Konstantin Shcheglov 5d6bab4ed2 Add ExecutableElement(s) based InheritanceManager3, and switch analyzer to it. 
Change-Id: I9d87619e05ae769f4df6a6ba26cd7901c7c98510
Reviewed-on: https://dart-review.googlesource.com/c/93141
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-02-14 18:11:18 +00:00
Brian Wilkerson 5fe0202b0b Unify MapElement and CollectionElement 
Change-Id: Ia1be138d656d07bdf4c11640b79044abbc798986
Reviewed-on: https://dart-review.googlesource.com/c/92762
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2019-02-12 17:10:58 +00:00
Konstantin Shcheglov fdfe40ea95 Compute 'executableElement' and 'parameterElement' in CompletionTarget. 
R=brianwilkerson@google.com

Change-Id: I58904548a034cf927d9205bdbba3be9014c49328
Reviewed-on: https://dart-review.googlesource.com/c/92539
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-02-11 06:08:00 +00:00
Konstantin Shcheglov a49f7f1d44 Remove FunctionTypeAlias in _isFunctionalParameter(). 
It is not a type, but a node.

R=brianwilkerson@google.com

Change-Id: I603e958dda3c2486285a57bc23f2fd37491105f4
Reviewed-on: https://dart-review.googlesource.com/c/92528
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-02-10 17:11:18 +00:00
Konstantin Shcheglov 0a2de9238b Extract importLibraryElement() implementation, make it less pessimistic. 
R=brianwilkerson@google.com

Change-Id: I916d4b761c8a9886dc701206c03cfd88c9f047ef
Reviewed-on: https://dart-review.googlesource.com/c/92021
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-02-05 21:05:45 +00:00
Konstantin Shcheglov 8c891ec25e Include type parameters into suggested code completions. 
R=brianwilkerson@google.com

Bug: https://buganizer.corp.google.com/issues/120659839
Change-Id: I51ec6142b97b079c4db55ef1f2081354ee16dda5
Reviewed-on: https://dart-review.googlesource.com/c/91858
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-02-04 05:37:37 +00:00
Konstantin Shcheglov fe585471e3 Add DartFileEditBuilder.importLibraryElement(). 
R=brianwilkerson@google.com

Change-Id: I83e0f58bce36660d15c477f100fdb4052b3bb672
Reviewed-on: https://dart-review.googlesource.com/c/91687
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-02-01 22:59:05 +00:00
Paul Berry f353719b08 Ignore unnecessary_cast hint. 
The cast is no longer needed due to the class hierarchy changes in
https://dart-review.googlesource.com/c/sdk/+/89923.  But we don't want
to remove it yet, because we don't want to unnecessarily make the
analyzer_plugin to depend on the very latest analyzer.  So for now we
ignore the hint.

Change-Id: Ic5314181cd78d72e5c9b1d00f38302773f0a789c
Reviewed-on: https://dart-review.googlesource.com/c/90101
Commit-Queue: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Auto-Submit: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-01-17 19:52:56 +00:00
Konstantin Shcheglov c91a245e30 Use ChangeWorkspace to limit where DartChangeBuilder(s) can edit. 
R=brianwilkerson@google.com

Bug: https://github.com/dart-lang/sdk/issues/35402
Change-Id: If5f78b44b69f01d9ddc235401f70cc4aefd3ca37
Reviewed-on: https://dart-review.googlesource.com/c/87382
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-12-14 22:32:35 +00:00
Konstantin Shcheglov eb1153c546 Fix for override completion contributions for abstract void methods and setters. 
R=brianwilkerson@google.com

Change-Id: Ie505e4640095dac1f9a566a32bf9aa9f0a5926e9
Reviewed-on: https://dart-review.googlesource.com/c/85622
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-11-29 19:48:51 +00:00
Brian Wilkerson 60f02dd2aa Re-enable the no-implicit-casts option 
Change-Id: Id1a943971de703bd156410375211c70318ed7ca0
Reviewed-on: https://dart-review.googlesource.com/c/84361
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2018-11-14 16:40:03 +00:00
Konstantin Shcheglov da191665aa Issue 34709. Support generic type alias (AKA generic function type alias for now) in outline and completion. 
R=brianwilkerson@google.com

Bug: https://github.com/dart-lang/sdk/issues/34709
Change-Id: Ic18d98e07ba0cbd231ded27c4c32533ee013632b
Reviewed-on: https://dart-review.googlesource.com/c/84320
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-11-13 21:20:08 +00:00
Konstantin Shcheglov 7cf3382f8f Fix OpType.inXyzBody to actually being in body. 
R=brianwilkerson@google.com

Change-Id: I42ce480b63b4fcdfe04ebb1faa63b556759aa425
Reviewed-on: https://dart-review.googlesource.com/c/84125
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-11-12 19:08:39 +00:00