dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
65,857 Commits 2 Branches 0 Tags
3fe9ba152ff1072e79fc50737d71bdf76fe039fa
Commit Graph

6343 Commits

Author SHA1 Message Date
Sam Rawlins 72923471c4 strict-inference failures for untyped parameters: 
* Untyped function parameters are a strict-inference failure.
* Add tests for strict-inference failures on fields.

This finalizes the "untyped / uninferred variables" cases.

strict-inference spec: https://github.com/dart-lang/language/blob/master/resources/type-system/strict-inference.md

Bug: https://github.com/dart-lang/sdk/issues/33749
Change-Id: I1d01ad15418be1891c95588132a44d478c5905a7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112142
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-08-20 20:06:48 +00:00
Dan Rubel bfc7f8c4b5 Fix crash parsing invalid constructor initializer 
Fix https://github.com/dart-lang/sdk/issues/37414

Change-Id: I6ea202050e2278da50c92b26acd91bdc429d5341
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113861
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2019-08-20 20:04:19 +00:00
Dan Rubel e2777454cc Fix dartfmt bug 
... by changing ANNOTATION_WITH_TYPE_ARGUMENTS to be a syntax error

Fix https://github.com/dart-lang/dart_style/issues/836

Change-Id: I2ac1b1105b817b6728ecc3d73875581a9cf65861
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113760
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-08-20 20:04:19 +00:00
Brian Wilkerson 56b3dede78 Implement some missed methods for summary2 support 
Change-Id: I18cbec26512c4d660b6dbc3ea1e5325ff032a8d2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113753
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-08-20 00:31:52 +00:00
Sam Rawlins 5087b99361 Report final re-assignment in for-in parts. Fixes #30486 
Change-Id: I299db3e1e301d90a1a2260d5574f7b174fc29d00
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113580
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-08-19 23:24:22 +00:00
Dan Rubel bb076a20c5 Fix unsupported initializer exception 
... and add a new ParserErrorCode.INVALID_INITIALIZER error code

Fix https://github.com/dart-lang/sdk/issues/37693

Change-Id: I0a30ad97f90aab35cd3af76d1546e1e78f1de2db
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113703
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2019-08-19 19:55:12 +00:00
Brian Wilkerson ed69e2dc35 Add a hint if extension methods are used with an sdk version constraint that does not support them 
Also clean up some tests that were not correctly awaiting futures.

Change-Id: I646e24ec81edc3f2129ae8bacee5e0a0d0873981
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113272
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-08-19 17:44:52 +00:00
Konstantin Shcheglov 89c4f94b60 Trigger dependency on exporting a library. 
R=brianwilkerson@google.com, paulberry@google.com

Change-Id: Ib62a0bedfa4f99d7519f54d3a06ce272d4529e5e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113540
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-08-19 17:28:32 +00:00
Konstantin Shcheglov d22fd240ca When building summary1 for SDK, set 'useSummary2' to false. 
This is with what I started in https://dart-review.googlesource.com/c/sdk/+/113130
We don't need to have both SDK summaries internally.
However I forgot about external use case.
For analyzer_cli we need both summary1 and summary2, so that when we
link new summaries, we can link them against one or another version
of SDK.

R=brianwilkerson@google.com

Change-Id: I5d02b5ce3e6566ad16d3c9b271edb3955be5434c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113521
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-08-19 17:05:42 +00:00
Konstantin Shcheglov 547a83ddbd Remove ExecutableMember.from3() and use from2() instead. 
R=brianwilkerson@google.com

Change-Id: I666cb25688b75201428d73da4c3674ee09070e96
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113660
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-08-19 16:32:49 +00:00
Konstantin Shcheglov 9b80826f84 Don't record dependencies on arguments if the instantiated class is not generic. 
So, lifting a tiny bit of existing limitation of summary type inference.
Surprisingly this does not break build with summary1, but does break
one test with summary2. Probably with summary1 types are even more
broken, down to dynamic, so the types turn out to be compatible.

This passes internal tests with summary2 enabled.
https://test.corp.google.com/ui#id=OCL:263949410:BASE:263958385:1566144802009:6e0fe323

R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I14a8c483778817053796fa1e047408dfb9ae3b2a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113620
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-08-19 16:32:34 +00:00
Paul Berry 0ff0cc1229 Flow analysis: remove unnecessary argument to doStatement_end. 
And add unit testing of do statements.

Change-Id: I976780a400cbd852f71d915f1c67b5433ba8807c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113267
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-08-19 15:49:43 +00:00
Konstantin Shcheglov 0f331d42a2 Store default value code for default formal parameters. 
We probably could remove FormalParameterElement.defaultValueCode,
but it is used at least in dartdoc and linter, so this would take
more time.

R=brianwilkerson@google.com

Change-Id: I589c8d43e1bb204aaaf67c26fb2c3d2fb57354ab
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113460
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-08-16 21:34:10 +00:00
Paul Berry d635e3db83 Flow analysis: expose FlowAnalysisHelper.getLabelTarget. 
This method needs to be re-used by the migration tool.

Change-Id: I6b60f044d83c60e47215285ca10602153ca8a68d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113386
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-08-16 20:26:10 +00:00
Paul Berry 106901cb59 Flow analysis: extract a method for computing assigned variables. 
This will be needed by the migration engine.

Change-Id: Ic4bbdd1a871ba51e46e859f687f1309bebcd2ad7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113241
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-08-16 20:26:10 +00:00
Konstantin Shcheglov 19a0c3902b Fix LibraryElement.nameLength value. 
R=brianwilkerson@google.com

Change-Id: Id0d241548af4fa7cb5a94e2daaf3d5d22a4e90b2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113382
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-08-16 18:44:20 +00:00
Paul Berry 8ab978b6d4 Flow analysis: remove unnecessary parameters from conditional_* methods. 
Also rework the flow analysis tests a bit to allow tests to be written
in a more compact way.

Change-Id: I6642ce9987bb89b9b858e709575ce12510c8f442
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113380
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-08-16 18:44:00 +00:00
Aske Simon Christensen 528292bd30 Expire constant-update-2018 flag. 
All uses of no-constant-update-2018 in the Dart SDK, Flutter and
Fuchsia have been cleaned out, which means we can expire the flag.

Closes https://github.com/dart-lang/sdk/issues/37874

Change-Id: Ie31dfbf87db52d37fdf4218afa8c6f7a894bafff
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113182
Reviewed-by: Dan Rubel <danrubel@google.com>
Commit-Queue: Aske Simon Christensen <askesc@google.com>
 2019-08-16 13:48:27 +00:00
Konstantin Shcheglov e63768f76e When summary2, use defaultType in instantiateToBounds(). 
R=brianwilkerson@google.com

Change-Id: I00690e8869ae9c019d875614f2d6ca580ebfbd5a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113215
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-08-15 21:48:22 +00:00
Paul Berry fecc4c8f2d Breaking changes for analyzer version 0.38. 
Change-Id: I93fbcb9e86c6c809c4610d2d90dc8bc8b69c45c8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108162
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-08-15 19:42:31 +00:00
Brian Wilkerson 5f824e572d Return extensions from search.topLevelDeclarations 
Change-Id: Iaa6ccbf9f0b1060148d81ff96670315aa7ae73e9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113209
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-08-15 19:18:03 +00:00
Brian Wilkerson 7d510c2eb3 Produce diagnostic when a static member of an extension is accessed via an instance 
Change-Id: I9573f3fa339ad7be4e8965c9c15e9afbfbb2415a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113204
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-08-15 17:53:00 +00:00
Paul Berry 23387d636b Flow analysis: merge APIs for handling && and ||. 
This will make it easier to integrate flow analysis into the migration
tool, since the migration tool has a shared code path for handling
`&&` and `||`.

Change-Id: Ibf1c7362dfeaab505a2ecf7298b2569a40fca781
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113038
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-08-15 13:34:30 +00:00
Brian Wilkerson 05f119daee Generate an error if a getter/setter pair declared in an extension have mismatched types (issue 37856) 
Change-Id: I1dc6fdf861980921d47205aaa88febb09f27fb3d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113041
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-08-15 13:26:50 +00:00
Konstantin Shcheglov 29b9aa84e3 Build summary1 or summary2 for SDK depending on the useSummary2 flag. 
R=brianwilkerson@google.com

Change-Id: I553d12626302a4e6c3cd83e16136e7948a697678
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113130
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-08-15 02:00:48 +00:00
Konstantin Shcheglov 6a73fc8442 Fix for detecting constant class fields with summary2. 
R=brianwilkerson@google.com

Change-Id: Idfc1ed461071797cbd46eb06d5c19546aae200d8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113044
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-08-14 18:55:11 +00:00
Paul Berry edb7d0e1d4 Fix the documentation of TypeSystem.isAssignableTo 
Change-Id: Ic3e7aae0a5ee9cfbd803366caf25fef48bcfea71
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113045
Auto-Submit: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-08-14 18:44:52 +00:00
Brian Wilkerson 02dc398b6e Cover the invocation of a function-valued getter defined by an extension of a function type 
Change-Id: I97b9a71d19c51879d38f72894eee888cb3b2716c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113080
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-08-14 18:41:08 +00:00
Brian Wilkerson 3e6e0bb368 Enhance the documentation to call out that some members of a class can now be members of an extension 
Change-Id: Ie98e8331b265f4e3ce7af376bd21b11d842ad5b5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113043
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-08-14 18:33:01 +00:00
Paul Berry c121c8b021 Change InterfaceTypeImpl optional arguments to named. 
Change-Id: I8c2c3d03f0869703b211b30d55b07baf4f15d04a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112850
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-08-14 13:36:43 +00:00
Brian Wilkerson 32123b7d13 Add support for extensions on function types 
Change-Id: I5f025df04d8c2558972ecbe1ec5cde48ae3d1735
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112940
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-08-14 13:27:43 +00:00
Konstantin Shcheglov 37a483ef78 Set incorrectly referenced static element, and test CHANGE_TO_STATIC_ACCESS. 
R=brianwilkerson@google.com

Change-Id: I8d479ccd17fc3f6429d7fa17bc4e78955194095d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112935
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-08-14 00:33:06 +00:00
Konstantin Shcheglov 1f5b6bca12 Search for extensions and their members. 
R=brianwilkerson@google.com

Change-Id: I490c2b9a404de5d56b639b7e790560f98d426193
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112926
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-08-13 20:57:14 +00:00
Konstantin Shcheglov e556e23bfc Add getOverrideMember() to return the member with replaced type parmeters. 
R=brianwilkerson@google.com

Change-Id: Id1daa5a15bca6c08b8412e7e9e5af5346b51b5df
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112941
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-08-13 18:47:04 +00:00
Paul Berry a5772382dc Migration: refactor infrastructure for testing decorated types. 
I have a lot more testing of decorated types to land in follow-up CLs;
this CL introduces a mixin containing helper methods that should make
that testing a lot easier.

Change-Id: I29c17ffb4af65498fcd85704dc404343429e09ad
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112847
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-08-13 16:49:14 +00:00
Devon Carew f53388b50d [analyzer] enable implicit-casts: false for several projects 
Change-Id: Idd7ed77756d93a94f637dcc4abd7e0403a2f6d81
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112703
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-08-13 16:26:41 +00:00
Konstantin Shcheglov cd46a39bb7 Report TYPE_ARGUMENT_NOT_MATCHING_BOUNDS for extension overrides. 
R=brianwilkerson@google.com

Change-Id: I1ad9c98707dbdb8b03c8b5bd014e9c174d365bcc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112860
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-08-13 13:47:10 +00:00
Konstantin Shcheglov b8f1b8987e Extract TypeArgumentsVerifier. 
I did not do any cleaning up of the extract code.

R=brianwilkerson@google.com

Change-Id: Idbec6e6105f5ec2a32385296c4cfc437b63a17a9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112800
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-08-13 00:37:03 +00:00
Leaf Petersen 78efb23609 Fix typo in comment on GLB 
Change-Id: I065719fd60653bf6f8e1ac8b40da47c0030ccbdd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112492
Reviewed-by: Erik Ernst <eernst@google.com>
 2019-08-12 23:48:37 +00:00
Konstantin Shcheglov e94fed95e2 Extract DuplicateDefinitionVerifier. 
R=brianwilkerson@google.com

Change-Id: I5f2afef8dba33c0f911c5d4e723dfe3f6cf4d675
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112753
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-08-12 22:25:53 +00:00
Konstantin Shcheglov f444374bb7 Report COULD_NOT_INFER when inference fails for ExtensionOverride. 
R=brianwilkerson@google.com

Change-Id: Ibadc5deac6289216b3d1547b963a206560c64691
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112760
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-08-12 20:28:15 +00:00
Mike Fairhurst c5365106c3 [nnbd_migration] polish previous postdominator code 
Change-Id: Ic99389d331dfa9495c57c16f166610c7149e7fb9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112648
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
 2019-08-12 20:20:10 +00:00
Konstantin Shcheglov d5d69883b9 More tests for DUPLICATE_DEFINITION in extensions, fixes for static fields. 
R=brianwilkerson@google.com

Change-Id: Ib3657cd76d3edc06452618b7f7423163ada3a51d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112746
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-08-12 18:56:57 +00:00
Brian Wilkerson 9eb2e8d111 Stop reporting duplicate diagnostics for other ambiguous extensions 
Change-Id: Ia81c43f0ccd41aa09697b6f629fd1d5a3acd3923
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112643
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-08-12 18:04:11 +00:00
Brian Wilkerson e86ce41bcf Rename a hint code to be consistent with similar codes 
Change-Id: I916c97c2e3ef34f2cf8d613b2b192dcde96c87e7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112740
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-08-12 16:29:05 +00:00
Brian Wilkerson c9126333ab Rename misleading error codes 
In all three cases, the if the element in question were not a const we'd
produce a different code, so "non-constant" is misleading.

Change-Id: If04fb4a91815612b47dd1357806bdfc2b047841b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112700
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-08-12 12:46:05 +00:00
Brian Wilkerson 1dbcf2445a Remove an unnecessary error code 
Change-Id: Idb57f172535cd1233c0ffa4b4ac254c990ba75e3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112606
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-08-10 14:04:05 +00:00
Konstantin Shcheglov 9713ce16b9 Report EXTENSION_CONFLICTING_STATIC_AND_INSTANCE and DUPLICATE_DEFINITION for extensions. 
R=brianwilkerson@google.com

Change-Id: I237ee3edc6a2196693638c12c59d1530a1f15152
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112605
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-08-09 23:09:25 +00:00
Konstantin Shcheglov a244295301 Tests for AstRewriteVisitor. 
R=brianwilkerson@google.com

Change-Id: I811b2722cb78572bfabdf1fe4dd2c766f128736e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112604
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-08-09 23:06:05 +00:00
Brian Wilkerson cd42e2b19a Make InstantiatedExtension a private class 
Change-Id: If8ecb367f6bfa5ece794307058e732b1a816726a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112601
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-08-09 19:53:11 +00:00