dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
65,857 Commits 2 Branches 0 Tags
3fe9ba152ff1072e79fc50737d71bdf76fe039fa
Commit Graph

26405 Commits

Author SHA1 Message Date
Paul Berry 3fe9ba152f Migration: implement Variables._decorateDirectSupertypes. 
Change-Id: I0e35bf57628bcb72525577e646d6c5de168712bd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113844
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-08-20 20:42:09 +00:00
Brian Wilkerson d67eaefe77 Add more tests of the visibility of extension members 
This is the item labeled "scoping" in the task doc.

Change-Id: I9caf5cd548ecc7a1d1d986854081bf23a5e98de8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113903
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-08-20 20:41:49 +00:00
Sam Rawlins 72923471c4 strict-inference failures for untyped parameters: 
* Untyped function parameters are a strict-inference failure.
* Add tests for strict-inference failures on fields.

This finalizes the "untyped / uninferred variables" cases.

strict-inference spec: https://github.com/dart-lang/language/blob/master/resources/type-system/strict-inference.md

Bug: https://github.com/dart-lang/sdk/issues/33749
Change-Id: I1d01ad15418be1891c95588132a44d478c5905a7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112142
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-08-20 20:06:48 +00:00
Dan Rubel bfc7f8c4b5 Fix crash parsing invalid constructor initializer 
Fix https://github.com/dart-lang/sdk/issues/37414

Change-Id: I6ea202050e2278da50c92b26acd91bdc429d5341
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113861
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2019-08-20 20:04:19 +00:00
Dan Rubel 3e69627752 Fix type argument parsing crash 
Fix https://github.com/dart-lang/sdk/issues/37706

Change-Id: Ifc54c3fa4f57c772f8059d59e0265c4677a400fb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113860
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-08-20 20:04:19 +00:00
Dan Rubel e2777454cc Fix dartfmt bug 
... by changing ANNOTATION_WITH_TYPE_ARGUMENTS to be a syntax error

Fix https://github.com/dart-lang/dart_style/issues/836

Change-Id: I2ac1b1105b817b6728ecc3d73875581a9cf65861
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113760
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-08-20 20:04:19 +00:00
Mayank Patke 38ca72a3e7 [dart2js] TrivialRuntimeTypesNeed should not say non-generic classes need type arguments. 
Change-Id: Idb791d3ec93ba7eedad0d85a3e12eb51318dd48f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113484
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Mayank Patke <fishythefish@google.com>
 2019-08-20 18:35:30 +00:00
Konstantin Shcheglov 04bd34ed87 Issue 37916. The name of ConstructorName cannot be shadowed. 
R=brianwilkerson@google.com

Bug: https://github.com/dart-lang/sdk/issues/37916
Change-Id: I905e0b9ebfa4514f9a7f28555f95a2154bcf2f04
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113846
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-08-20 18:31:41 +00:00
Mike Fairhurst 3865187956 [nnbd_migration] already-migrated types with 1:1 type args & params. 
Support creating decorated types for already migrated interface types
that have type arguments, so far as those type arguments equal in number
to the interface type's type parameters. This includes basic cases like
List<int>, which is tested as an api_test.

Reduces AlreadyMigratedCodeDecorator.decorate exceptions from 915 to
538.

Change-Id: Ic82d7fb598db964bfc2ca37898795f124796eba8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113750
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
Auto-Submit: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2019-08-20 17:48:40 +00:00
Devon Carew e2fee9c0dd [pkg:vm_service] fix an issue serializing list args 
Bug: https://github.com/dart-lang/sdk/issues/37872
Change-Id: Iba416907d62311c9eff1386ff93e2895814872d7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113843
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2019-08-20 17:19:50 +00:00
Devon Carew 396613d884 [pkg:vm_service] be more lenient towards nulls json fields in the java library 
Bug: https://github.com/dart-lang/webdev/issues/586
Change-Id: I03307391813d801be5708aa9f65f25c79682bac6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113845
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2019-08-20 16:57:10 +00:00
Paul Berry e34c4319dc Migration: property decorate implicit bottom types. 
Change-Id: I5af76bbfb888ce25642cf61e590862b1b471d4b3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113841
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-08-20 15:20:00 +00:00
Paul Berry c6e2497569 Migration: capture more exception information and make it easier to examine stack traces. 
Change-Id: If509121fcf2b1f9b9e0a7bf722945241b90c647b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113840
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-08-20 15:20:00 +00:00
Danny Tuppeny 1e79aa6b7e Update LSP readme to link to dart-vim instructions 
Change-Id: Ie36803aa3012035acb3cf9dca012e55ad2ec4d79
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113696
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Danny Tuppeny <dantup@google.com>
 2019-08-20 14:18:00 +00:00
Johnni Winther 027071318f [cfe] Change outline test to test strong mode 
Closes #37904

Change-Id: I75cd093922dbcf29c0b073d6a37aaba9d6c1f5f2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113697
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
 2019-08-20 13:51:10 +00:00
Jens Johansen 363ae34c55 [CFE] Third batch of fixes for requiring explicit types 
Change-Id: Ie4c8e66acf942901602c91819640967e49044233
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113822
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2019-08-20 13:11:12 +00:00
Jens Johansen e60cbdfd9e [CFE] Add test for running old dills 
This CL:
* adds a test that runs the VM with old dills (compilations of dart2js
  with old checkouts) with the --compile_all argument (1).
* adds a number of old dills (for binary version 25, 27, 28, 29)
  (by mistake binary version 26 sort of didn't really happen)
* adds a PRESUBMIT check in kernel that verifies that we have an
  "old dill" for the current binary version, so one don't bump the
  version without creating a new dill.

(1): It uses --compile_all to force the VM to "read and understand"
     everything in the dill file. The hope being that we try out
     all/most language constructs and thus verifies that they can be
     read by the VM.

Old "old dill" files should be removed once the VM stops supporting that
version. That is a manual process, but a test should complain that the VM
cannot read the old "old dill"(s) once/if that happens.

This should (help) detect errors such as the one recently where a merge
error caused a single "if >= 28" (that should have been "if >= 29" and
thus stopped the VM from reading dills from version 28) to slip through
and require a lot of debugging a few days later.

Change-Id: Id79e16c7ad896c0ccc4e181465b05b67822ac31a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113698
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2019-08-20 12:27:52 +00:00
Dan Rubel f5f942684b Fix invalid literal list element crash 
Fix https://github.com/dart-lang/sdk/issues/37697

Change-Id: Icefae7ca0c0f6b0d317c6aa48039fa6e6967409d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113705
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2019-08-20 12:03:12 +00:00
Johnni Winther d153e98447 Revert "[cfe] Gather constraints from both possibilities for FutureOr" 
This reverts commit 00e9561798.

Original change's description:
> [cfe] Gather constraints from both possibilities for FutureOr
> 
> Closes #37778.
> 
> Bug: http://dartbug.com/37778
> Change-Id: Ic06da9cf4e24e397e1f2a180b743190a4165dc3e
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113033
> Commit-Queue: Johnni Winther <johnniwinther@google.com>
> Reviewed-by: Johnni Winther <johnniwinther@google.com>

TBR=dmitryas@google.com,johnniwinther@google.com

Change-Id: I64677971c865180334958de13d2d82fec3daec85
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: http://dartbug.com/37778
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113821
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2019-08-20 10:57:52 +00:00
Jens Johansen b99df2be86 [CFE] Language versioning - additional tests 
Change-Id: I0dd93c3a1d422bbbbbd920fae21569a7bdc91e61
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112341
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2019-08-20 10:08:20 +00:00
Jens Johansen 10e63b7840 [CFE] Get fragment from default package - use language version if any 
Language versioning specifies that an empty-name-entry in .packages
specifies a sort of "default package" that a non-package file should
pretend to be a part of "for any purpose where that matters,
including choosing the default language level."

Change-Id: I16f4b2f5e4d3ca1e82d2189321e2be5c43e3b260
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112089
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2019-08-20 09:06:32 +00:00
Johnni Winther 00e9561798 [cfe] Gather constraints from both possibilities for FutureOr 
Closes #37778.

Bug: http://dartbug.com/37778
Change-Id: Ic06da9cf4e24e397e1f2a180b743190a4165dc3e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113033
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2019-08-20 08:43:22 +00:00
Brian Wilkerson 56b3dede78 Implement some missed methods for summary2 support 
Change-Id: I18cbec26512c4d660b6dbc3ea1e5325ff032a8d2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113753
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-08-20 00:31:52 +00:00
Devon Carew 209c6f8ab9 [pkg:vm_service] fix some analysis errors in the generated vm_service library 
Change-Id: I5a09116928e2eff9125ca8033458e485e7f15acb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113756
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2019-08-20 00:22:32 +00:00
Mayank Patke b52b2c3910 [dart2js] Don't produce '-2' for default type argument values with new RTI. 
TBR=sra@google.com

Change-Id: I20ea2b530285090ef8fb4bbb025c632b74be994b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113759
Commit-Queue: Mayank Patke <fishythefish@google.com>
Reviewed-by: Mayank Patke <fishythefish@google.com>
 2019-08-19 23:49:21 +00:00
Sam Rawlins 5087b99361 Report final re-assignment in for-in parts. Fixes #30486 
Change-Id: I299db3e1e301d90a1a2260d5574f7b174fc29d00
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113580
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-08-19 23:24:22 +00:00
Devon Carew 0ad703b534 [pkg:vm_service] re-generate the library based on the latest spec 
Change-Id: Ie04198ae8726f3cbb3619c97e5c3bb83ee005dc2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113752
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2019-08-19 22:09:53 +00:00
Dan Rubel bb076a20c5 Fix unsupported initializer exception 
... and add a new ParserErrorCode.INVALID_INITIALIZER error code

Fix https://github.com/dart-lang/sdk/issues/37693

Change-Id: I0a30ad97f90aab35cd3af76d1546e1e78f1de2db
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113703
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2019-08-19 19:55:12 +00:00
Ben Konyi 9f13d07670 Revert "[dartdevc] Remove explicit calls of the constant evaluator in DDC." 
This reverts commit fb8df61606.

Reason for revert: Breaking Dart SDK -> Flutter engine build.

Original change's description:
> [dartdevc] Remove explicit calls of the constant evaluator in DDC.
> 
> These are unnecessary now that constant evaluation is performed as
> part of the front-end transformations.
> 
> Change-Id: I5de9bbf7ebab09528431f764895eb3e3b1b45379
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111430
> Commit-Queue: Aske Simon Christensen <askesc@google.com>
> Reviewed-by: Vijay Menon <vsm@google.com>

TBR=vsm@google.com,askesc@google.com

Change-Id: Ife7c6f207c38d86e390c98de8af81f9cc5b863c4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113746
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2019-08-19 19:41:15 +00:00
Dan Rubel 3568f78fe7 ensure super constructor invocation param list not null during recovery 
Fix https://github.com/dart-lang/sdk/issues/37735

Change-Id: I727cd7aeb141c5abb779b3c15f338f3d43f6541f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113702
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2019-08-19 18:34:32 +00:00
Stephen Adams 0537c9d326 [dart2js] Fix DartType.subst 
DartType.subst would accidentally drop FunctionTypeVariables that had
bounds modified by substitution.

Use a visitor for printing, with changes that make it possible to see the accidentally
free FunctionTypeVariables that were dropped.

Change-Id: Ie6c8d0bb8f2a22b11db6f009067cf64e38ab93c7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113600
Commit-Queue: Stephen Adams <sra@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2019-08-19 18:11:42 +00:00
Kathy Walrath 0f109da0d1 Updating the package:js README 
Closes #37883
https://github.com/dart-lang/sdk/pull/37883

GitOrigin-RevId: e14be88991f39db80422e98399fab26c8e9c038e
Change-Id: Ic4e45420dcf6fe71b5c215c435cd72ffb6e665f4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113265
Reviewed-by: Nate Bosch <nbosch@google.com>
Commit-Queue: Kathy Walrath <kathyw@google.com>
 2019-08-19 17:52:57 +00:00
Dan Rubel a984c5ce57 improve invalid string literal recovery to fix crash 
Fix https://github.com/dart-lang/sdk/issues/37877

Change-Id: If9fe3d42659608bf7cd050de515ec41ca45a697b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113701
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2019-08-19 17:46:47 +00:00
Dan Rubel bdd77cd0b2 Ensure function type param has non-null identifier 
Fix https://github.com/dart-lang/sdk/issues/37733

Change-Id: I552d67aa048eeb5ae4417205f641d71ca7ecadd0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113700
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-08-19 17:46:47 +00:00
Brian Wilkerson ed69e2dc35 Add a hint if extension methods are used with an sdk version constraint that does not support them 
Also clean up some tests that were not correctly awaiting futures.

Change-Id: I646e24ec81edc3f2129ae8bacee5e0a0d0873981
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113272
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-08-19 17:44:52 +00:00
Konstantin Shcheglov 89c4f94b60 Trigger dependency on exporting a library. 
R=brianwilkerson@google.com, paulberry@google.com

Change-Id: Ib62a0bedfa4f99d7519f54d3a06ce272d4529e5e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113540
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-08-19 17:28:32 +00:00
Konstantin Shcheglov d22fd240ca When building summary1 for SDK, set 'useSummary2' to false. 
This is with what I started in https://dart-review.googlesource.com/c/sdk/+/113130
We don't need to have both SDK summaries internally.
However I forgot about external use case.
For analyzer_cli we need both summary1 and summary2, so that when we
link new summaries, we can link them against one or another version
of SDK.

R=brianwilkerson@google.com

Change-Id: I5d02b5ce3e6566ad16d3c9b271edb3955be5434c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113521
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-08-19 17:05:42 +00:00
Konstantin Shcheglov 547a83ddbd Remove ExecutableMember.from3() and use from2() instead. 
R=brianwilkerson@google.com

Change-Id: I666cb25688b75201428d73da4c3674ee09070e96
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113660
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-08-19 16:32:49 +00:00
Konstantin Shcheglov 9b80826f84 Don't record dependencies on arguments if the instantiated class is not generic. 
So, lifting a tiny bit of existing limitation of summary type inference.
Surprisingly this does not break build with summary1, but does break
one test with summary2. Probably with summary1 types are even more
broken, down to dynamic, so the types turn out to be compatible.

This passes internal tests with summary2 enabled.
https://test.corp.google.com/ui#id=OCL:263949410:BASE:263958385:1566144802009:6e0fe323

R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I14a8c483778817053796fa1e047408dfb9ae3b2a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113620
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-08-19 16:32:34 +00:00
Paul Berry 0681cc2d36 Migration: extract a common method for doing null checks. 
Change-Id: I7864d93a7208357075583263c471f4faf20231ec
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113270
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-08-19 15:49:43 +00:00
Paul Berry 203038ffc6 Migration: integrate flow analysis of do and continue statements. 
Change-Id: I5f245046806d58b1eb850ee0b4f89dd16251bcee
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113268
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-08-19 15:49:43 +00:00
Paul Berry 0ff0cc1229 Flow analysis: remove unnecessary argument to doStatement_end. 
And add unit testing of do statements.

Change-Id: I976780a400cbd852f71d915f1c67b5433ba8807c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113267
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-08-19 15:49:43 +00:00
Johnni Winther ee37965e49 [cfe] Handle static access of static extension members 
Change-Id: I9c52ddc7b0c7ef0952471542ee41c231989d80d6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113441
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2019-08-19 14:47:33 +00:00
Karl Klose 966b7de1ff [infra] status file clean up tool: also remove sections with comments 
Change-Id: I9027ed4c937b4c06bfc30221bd42de307de8d1fd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113683
Commit-Queue: Karl Klose <karlklose@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
 2019-08-19 12:01:41 +00:00
Aske Simon Christensen fb8df61606 [dartdevc] Remove explicit calls of the constant evaluator in DDC. 
These are unnecessary now that constant evaluation is performed as
part of the front-end transformations.

Change-Id: I5de9bbf7ebab09528431f764895eb3e3b1b45379
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111430
Commit-Queue: Aske Simon Christensen <askesc@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>
 2019-08-19 08:29:45 +00:00
Jens Johansen 0e201edeeb [CFE] Second batch of fixes for requiring explicit types 
Change-Id: If4f35550e1df10763b4c13d15eba1d9f53e6095e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113324
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2019-08-19 07:19:45 +00:00
Karl Klose 2a8480e5a2 [infra] Add script to remove non essential status file entries 
Change-Id: Iafdde22eaa305b9a5550540f939db31aac04d46b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113181
Commit-Queue: Karl Klose <karlklose@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
 2019-08-19 06:38:55 +00:00
Johnni Winther 9c649e67df [cfe] Handle most accesses to extension members from within the extension 
Change-Id: I1be167bff0f398793c67834bb80328418e9bb4c8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113020
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2019-08-18 12:25:34 +00:00
lambdabaa c7ea359627 Check for null tokens while walking backward from cursor 
ML completion will start at the cursor token and walk backwards
along the token linked list until it's read some n tokens or
finds an EOF character. In some cases, there are null tokens which
we should treat as terminal when constructing model queries as well.

Bug: https://github.com/dart-lang/sdk/issues/37878
Change-Id: Id840d519f5cf1093a63881ee6cd41cde61dbc0fa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113285
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Dan Rubel <danrubel@google.com>
Commit-Queue: Ari Aye <ariaye@google.com>
 2019-08-18 02:02:23 +00:00
Konstantin Shcheglov 6408a9cc4d Tweaks for writeType() and summary2. 
R=brianwilkerson@google.com

Change-Id: If3c682f3dfc12a9e13d805bc25476b16249c7754
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113273
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-08-17 07:28:52 +00:00