8e0d5f98a3
[dart:html] Remove deprecated gridRowGap and gridColumnGap
...
After chatting offline, we decided we don't actually need
gridRowGap and gridColumnGap since the rowGap and columnGap
properties are the preferred names. Removing the deprecated
grid versions before it becomes a breaking change to do so,
and to keep dart:html bloat minimal.
Change-Id: I75a7de40a4bb1a5479723600987d19e7e42bf69c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/224700
Reviewed-by: Sigmund Cherem <sigmund@google.com >
Commit-Queue: Riley Porter <rileyporter@google.com >
2021-12-20 18:21:03 +00:00
fc8a65d4c8
[dart:html] Add gap, rowGap, gridRowGap, and gridColumnGap properties.
...
Adds gap, rowGap, gridRowGap, and gridColumnGap CSS style properties.
The columnGap property was already included through WebKit.
Relevant bugs:
https://github.com/dart-lang/sdk/issues/46077
https://github.com/dart-lang/sdk/issues/45789
Verified properties are accessible with this `foo.dart` file:
https://paste.googleplex.com/6379738705690624
Loaded with ddb in Chrome:
https://screenshot.googleplex.com/9hN4MTCFxY5EYQn.png
Change-Id: Ia62807a6588cd0fd21b204a2a98a120fa4c4b07b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/224500
Reviewed-by: Sigmund Cherem <sigmund@google.com >
Commit-Queue: Riley Porter <rileyporter@google.com >
2021-12-16 18:47:11 +00:00
79e478e50e
Fixed some links
...
**I fixed some links and some other minor flaws.**
I also found the following outdated links, which I didn't fix:
- [This link](https://github.com/dart-lang/pool/tree/zone.strong ) in [this file](https://github.com/dart-lang/sdk/blob/master/docs/newsletter/20170728.md ) (didn't fix because don't know new location and this is some sort of archive so the link should probably stay the original)
- [This link](https://www.dartlang.org/tools/analyzer ) in [this file](https://github.com/dart-lang/sdk/blob/master/pkg/analyzer_cli/lib/src/options.dart ) (didn't fix since the link is still working, it just gets redirected and the link is part of the programm, I don't want to break anything by changing it, all other links are in comments)
- [This link](https://github.com/domokit/mojo/issues/728 ) in [this file](https://github.com/dart-lang/sdk/blob/master/build/config/compiler/BUILD.gn ) (didn't fix since probably has no new location and is part of TODO, which I don't want to change)
While doing all this I also noticed that [these tests](https://github.com/dart-lang/sdk/tree/master/tests/compiler/dart2js_extra ) contain a lot of other inconsistencies in their comments and the location of the import-statements (I only fixed one which was not link-related), could be target of another PR.
Closes #36927
https://github.com/dart-lang/sdk/pull/36927
GitOrigin-RevId: 71d05d0b52d8ec5b92d077a070e066d1fdd4bbfa
Change-Id: Ide4b2424fccad8ae2e06c788efd4443dc0de997b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/102222
Reviewed-by: Michael Thomsen <mit@google.com >
Commit-Queue: Michael Thomsen <mit@google.com >
2019-07-01 16:21:41 +00:00
b8ab793a1b
Reapply 38999. Third time's the charm! The issue was supportsTransitions was a
...
static method,and with my change I was calling an instance method. I've tested
all of the other html tests (before I was just testing on Dartium).
BUG=
R=leafp@google.com
Review URL: https://codereview.chromium.org//445733003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39003 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-07 18:36:23 +00:00
c8d48f89a9
t cl dcommi# Enter a description of the change.
...
"Reverting 38998"
TBR
BUG=
Review URL: https://codereview.chromium.org//449033004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38999 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-07 17:50:26 +00:00
c7dd285314
Reapplication of revision 38996 (dart side edits to make CSS Properties
...
accessible with and without prefixes), with the addition of CSSPropertyNames.in
which will be deleted once https://codereview.chromium.org/444453006/
is committed.
BUG=
Review URL: https://codereview.chromium.org//452493004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38998 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-07 17:21:06 +00:00
Riley Porter
