Commit Graph

5131 Commits

Author SHA1 Message Date
Terry Lucas 581c512345 Fixed DOMRectList not having a prototype field.
TBR=vsm@google.com

Change-Id: I6cbc38bbb2123b914d5b5511774425c403e614ed
Reviewed-on: https://dart-review.googlesource.com/47183
Reviewed-by: Terry Lucas <terry@google.com>
Commit-Queue: Terry Lucas <terry@google.com>
2018-03-20 01:08:47 +00:00
William Hesse d9c022184c Pass enable-asserts flag from test.py to VM runtime.
Change-Id: I84223c57dcbc74d9e5ba7d2d977fe9d5f6d686dc
Reviewed-on: https://dart-review.googlesource.com/46900
Reviewed-by: Erik Ernst <eernst@google.com>
Commit-Queue: William Hesse <whesse@google.com>
2018-03-19 10:38:05 +00:00
Terry Lucas 60469482f1 Move ClientRect members to DOMRect.
TBR=sigmund@google.com,sra@google.com

Change-Id: I424b087830954329f4399f6b169f572196a4f658
Reviewed-on: https://dart-review.googlesource.com/46948
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Terry Lucas <terry@google.com>
2018-03-18 13:27:46 +00:00
Terry Lucas ef6273cba0 Dart Web Libraries re-generated based on Chrome 63 WebIDLs.
This is a migration of 13 Chrome release about 1.5 years of Chrome releases.
Update PYTHON scripts for cleaner and easier rolling.

Here's a doc on the changes that might affect Dart users:
https://docs.google.com/document/d/1Kj0nk3SueO3JKub8im7z3znu9j5oiI7vf49ejZrMxuE/edit#

Change-Id: I768fbd09b04fe6884af36ac102d5813f67bae426
Reviewed-on: https://dart-review.googlesource.com/24501
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Terry Lucas <terry@google.com>
2018-03-18 09:41:04 +00:00
William Hesse bc3b0540f7 Add hash for downloading Linux Chrome to tools/bots/browsers.
Change-Id: Iafacb0d2f1753019878927462e2edd8dfc18b6fe
Reviewed-on: https://dart-review.googlesource.com/45780
Reviewed-by: Alexander Thomas <athom@google.com>
2018-03-16 10:35:11 +00:00
Alexander Thomas c8d044e27d [infra] Remove non-strong mode vm kernel tests steps from test matrix
https://github.com/dart-lang/sdk/issues/32499

TBR=whesse@google.com

Change-Id: I161b13bff4d6b4464d83eb39da9cb8e6d4051374
Reviewed-on: https://dart-review.googlesource.com/46142
Reviewed-by: Alexander Thomas <athom@google.com>
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
2018-03-15 16:53:06 +00:00
Alexander Thomas d7ec39dda7 [infra] Enable vm-kernel-legacy builder on the CQ
https://github.com/dart-lang/sdk/issues/32499

TBR=whesse@google.com

Change-Id: I330824c1ea23b8a0b34d2f5e83874ef67c0994f9
Reviewed-on: https://dart-review.googlesource.com/46802
Reviewed-by: Alexander Thomas <athom@google.com>
2018-03-15 16:26:31 +00:00
Alexander Thomas 56e697e728 [infra] Add experimental vm-kernel-legacy builder to the CQ
https://github.com/dart-lang/sdk/issues/32499

TBR=whesse@google.com

Change-Id: Ie861164cb8e36541691ecb7992c8bdd25f8a531c
Reviewed-on: https://dart-review.googlesource.com/46800
Reviewed-by: Alexander Thomas <athom@google.com>
2018-03-15 16:01:51 +00:00
Alexander Thomas 5c90b1fd98 [infra] Add vm-kernel-legacy builder to the test matrix
https://github.com/dart-lang/sdk/issues/32499

TBR=whesse@google.com

Change-Id: Ia9829fc106162b161e9e31bc918feebc691b3621
Reviewed-on: https://dart-review.googlesource.com/46742
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
2018-03-15 14:31:13 +00:00
Peter von der Ahé 4f2bdff90b Rename Program to Component
Change-Id: I1a3cc03fba9783807fa637a9d42fdbad68ee7686
Reviewed-on: https://dart-review.googlesource.com/31040
Commit-Queue: Peter von der Ahé <ahe@google.com>
Reviewed-by: Kevin Millikin <kmillikin@google.com>
2018-03-15 12:22:23 +00:00
Martin Kustermann 52c884dc6a Add ExtraSlow status file marker
This is used (at least temporarily) for unblocking other P0 changes.

Change-Id: I002af7cfe6384f8813646d5c488a2cf2e58673a5
Reviewed-on: https://dart-review.googlesource.com/46541
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
2018-03-14 15:49:09 +00:00
Sigmund Cherem c438f8b3f4 Dart2js defaults to the new common front-end
Change-Id: Id0f69d258b010a746b56e259335185bcca7dafec
Reviewed-on: https://dart-review.googlesource.com/45143
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
2018-03-13 19:25:59 +00:00
Alexander Thomas 019dae1904 [infra] Remove front end unit tests from other builders
The new front end builders will continue to run them.

Change-Id: Iffd5af76bd3a082256ea4fb146981737462938f9
Reviewed-on: https://dart-review.googlesource.com/46042
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: William Hesse <whesse@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
2018-03-13 12:40:39 +00:00
Peter von der Ahé b0a2e6b9c9 [test.py] Handle Windows file names correctly.
Change-Id: I1b4707826c00144da3190e75e19870b7e39acbf3
Reviewed-on: https://dart-review.googlesource.com/46065
Commit-Queue: Peter von der Ahé <ahe@google.com>
Reviewed-by: William Hesse <whesse@google.com>
2018-03-13 09:16:18 +00:00
Alexander Markov d58887eaf6 [vm/kernel/aot, test tool] Enable global type flow analysis
Issue: https://github.com/dart-lang/sdk/issues/30480
Change-Id: I984869a8cdd9c52cab677cab64b562d002cde490
Reviewed-on: https://dart-review.googlesource.com/46122
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
2018-03-12 22:45:39 +00:00
Alexander Markov ef80524b4f [benchmarks trybot] Add precompiler_entry_points.json
Change-Id: I3edbf7b20f3ab7afce89d7adabd537a6e47133d0
Reviewed-on: https://dart-review.googlesource.com/46005
Reviewed-by: Zach Anderson <zra@google.com>
Reviewed-by: Jonas Termansen <sortie@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
2018-03-12 22:11:10 +00:00
Jonas Termansen e067f7fdfa The dart-dfe target is no longer being benchmarked.
Change-Id: I9188362c0f62e4df50a0b8262d03a183c615eedb
Reviewed-on: https://dart-review.googlesource.com/45703
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Commit-Queue: Jonas Termansen <sortie@google.com>
2018-03-09 13:31:08 +00:00
Zach Anderson d2b7787186 [infra] Use downloaded sysroots by default
Change-Id: I6bd6e369775182acb4aa5933360282af47024018
Reviewed-on: https://dart-review.googlesource.com/45762
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
2018-03-09 09:02:05 +00:00
Zach Anderson 8240134d66 [infra] Roll boringssl forward. Use clang for arm on Linux.
fixes: #32363
Change-Id: I68c3ea314b320e51e0dcbdc98b71cf3150800837
Reviewed-on: https://dart-review.googlesource.com/45742
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Commit-Queue: Zach Anderson <zra@google.com>
2018-03-08 18:09:28 +00:00
Sigmund Cherem d059e97974 Add platform.dill files to the hostchecked try bots.
This change is needed before we turn on the CFE by default in dart2js.

R=whesse@google.com,athom@google.com

Change-Id: I2868d2dcef82d95456a56e809fe90e28dc698437
Reviewed-on: https://dart-review.googlesource.com/45640
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
2018-03-08 17:29:47 +00:00
Jens Johansen ef5909b986 Remove now unused dartk_wrappers
Change-Id: I7c9a91c829c2f8cc748fa38c8affca678e888706
Reviewed-on: https://dart-review.googlesource.com/45506
Reviewed-by: Kevin Millikin <kmillikin@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
2018-03-08 08:01:06 +00:00
Alexander Thomas 55f7687908 [infra] Enable front end CQ builder
Change-Id: Ife7d8b714eeb68a186f5e8bda23fb6be1836a01f
Reviewed-on: https://dart-review.googlesource.com/45508
Reviewed-by: Peter von der Ahé <ahe@google.com>
2018-03-07 19:09:44 +00:00
Paul Berry 440b58d644 Start running analyzer tests with --preview-dart-2.
The changes to the CQ bot should take effect immediately.  The changes
to the other bots will take effect once those bots are switched over
to use the test matrix.

Change-Id: Ibfe59817a11f730fd1847cdc60b3244b4a71a480
Reviewed-on: https://dart-review.googlesource.com/45300
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
2018-03-07 15:04:33 +00:00
William Hesse 3f71dc5dd2 Add preview_dart_2 to supported set of status file variables
R: paulberry@google.com
Change-Id: I9d77800f7db42207c5e730706b02b38080e85299
Reviewed-on: https://dart-review.googlesource.com/45322
Reviewed-by: Paul Berry <paulberry@google.com>
2018-03-06 14:46:44 +00:00
Sigmund Cherem 2448814e83 Also exclude 'Ok' as a valid status to ignore when checking for runtime errors
in Runtime.none

R=rnystrom@google.com,whesse@google.com

Change-Id: I10c9c686d92ab646eebc7bc03a8abdedda66aa92
Reviewed-on: https://dart-review.googlesource.com/45122
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
2018-03-05 22:19:40 +00:00
Alexander Thomas d0eb2d63e8 [infra] Add front-end builder to test matrix
#32123

Change-Id: I996ed57edc78f46aac6fa65a45e07500ad3758a0
Reviewed-on: https://dart-review.googlesource.com/44160
Reviewed-by: Peter von der Ahé <ahe@google.com>
2018-03-05 14:53:03 +00:00
Stephen Adams 109316c484 Force inlining to match AST version
These are a couple of cases where inlining differs from the previous
version and makes a difference in angular code.

Change-Id: Ibc8ba0d720b8bb49481c41e1332fc6a4a0292d9d
Reviewed-on: https://dart-review.googlesource.com/44701
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Stephen Adams <sra@google.com>
2018-03-02 20:10:49 +00:00
Zach Anderson 7a084ee150 [infra] Don't try to download buildtools binaries on arm
Change-Id: Ieea8c822a00ef36b0e457e363973dba00c5b9bc4
Reviewed-on: https://dart-review.googlesource.com/44602
Reviewed-by: Zach Anderson <zra@google.com>
Commit-Queue: Zach Anderson <zra@google.com>
2018-03-01 22:12:29 +00:00
Zach Anderson 6810d4604b [infra] Roll toolchain.
related #32364, #32363, #32362

Change-Id: Ia8ac3af0317fc67efb2a38e506b2924780473b8f
Reviewed-on: https://dart-review.googlesource.com/44400
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Zach Anderson <zra@google.com>
2018-03-01 20:09:29 +00:00
Tom Sullivan ded230959d Fix Homebrew undent warning
Update the generated `dart.rb` formula file to fix:

```
Warning: Calling <<-EOS.undent is deprecated!
Use <<~EOS instead.
/usr/local/Homebrew/Library/Taps/dart-lang/homebrew-dart/dart.rb:72:in `caveats'
Please report this to the dart-lang/dart tap!
```

being reported by `brew`.

Fixes https://github.com/dart-lang/homebrew-dart/issues/48

Credit for original patch to @fsouza:

https://github.com/fsouza/homebrew-dart/commit/06b76e0935a0c74e8f10d32b81e1b72358a661b4

Closes #32346
https://github.com/dart-lang/sdk/pull/32346

GitOrigin-RevId: 938a696caea21eda193375ad4cce5aab0e7b5e71
Change-Id: I757647a7ef0a373cb0258f0fcf03f89849aeba5e
Reviewed-on: https://dart-review.googlesource.com/44100
Reviewed-by: Kevin Moore <kevmoo@google.com>
Reviewed-by: William Hesse <whesse@google.com>
2018-03-01 13:50:38 +00:00
Alexander Thomas 926ef7d742 [infra] Remove dart2js jsshell builder from the test matrix
Change-Id: I850f0d1d75e030da71593e56292fe986e15cc846
Reviewed-on: https://dart-review.googlesource.com/44461
Reviewed-by: William Hesse <whesse@google.com>
2018-03-01 11:56:39 +00:00
Alexander Thomas 990fbea399 [infra] Update analyzer builders in the test matrix
Change-Id: I6a1b9533700646c0ab9b264063e31d6fd671dee7
Reviewed-on: https://dart-review.googlesource.com/44241
Reviewed-by: Paul Berry <paulberry@google.com>
2018-03-01 09:58:24 +00:00
Siva Chandra d45d5a72d2 Pass --preview-dart-2 to dart_bootstrap and dart_precompiled in dartkp config.
Change-Id: I728d085b6433d7ad35fb389ce61b4959311a9b4a
Reviewed-on: https://dart-review.googlesource.com/44383
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Siva Chandra <sivachandra@google.com>
2018-02-28 23:49:05 +00:00
Sigmund Cherem 21c9372d8d Add dart2js-old-frontend option to test.py
Change-Id: I4e762bd5e50b2ff8a91b29e8067e47351ace94f7
Reviewed-on: https://dart-review.googlesource.com/44380
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
2018-02-28 23:21:24 +00:00
Jens Johansen 32efcbfde3 [test.py] Make test.py quickly skip tests that it isn't going to run
The current behavior is to - for instance - create all multitests in a
suite (e.g. language_2) up front, despite having a test-selector that
restricts it a lot.

This CL skips tests faster (i.e. before creating multitests).

Example:

Now:

$ time tools/test.py -m release -a x64 -c dartk --strong language_2/lalala
Test configuration: dartk_vm_release_x64_strong


real    0m0.598s
user    0m0.760s
sys     0m0.116s

Before:

$ time tools/test.py -m release -a x64 -c dartk --strong language_2/lalala
Test configuration: dartk_vm_release_x64_strong


real    0m1.796s
user    0m2.156s
sys     0m0.344s

Change-Id: Ib3c254d4e18c8ed4e6c66f7e25f384ce6b652f02
Reviewed-on: https://dart-review.googlesource.com/44061
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
2018-02-28 13:29:34 +00:00
Jenny Messerly 8bce74bc05 Remove dart:html import of dart:isolate
dart:isolate was used for the `Future<Isolate>` return type of
spawnDomUri, which is an unimplemented experimental method. This method
now returns `Future`.

This change helps dart4web disable support for dart:isolate (#30538)

Change-Id: Ida87c2a27ac33d1b9a14feb7dd6d306a546a0aaf
Reviewed-on: https://dart-review.googlesource.com/43860
Reviewed-by: Terry Lucas <terry@google.com>
2018-02-28 07:25:00 +00:00
Siva Chandra 27d28702a6 Update status files after 4f5ad1918c
Change-Id: I96c56728521a507fe9870fa3f53060d594fa8a78
Reviewed-on: https://dart-review.googlesource.com/44023
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Siva Chandra <sivachandra@google.com>
2018-02-28 02:06:36 +00:00
Siva Chandra 4f5ad1918c Make strong mode the default under --preview-dart-2.
Change-Id: Ic1637d65a34f6b0310439293f7d83cb351f2c89c
Reviewed-on: https://dart-review.googlesource.com/43200
Commit-Queue: Siva Chandra <sivachandra@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
2018-02-27 22:16:07 +00:00
Vyacheslav Egorov 0b5c52456a [testing] Make dartkp configuration work on Windows
Change-Id: I4a09994a1b79a7d857a854e3dcc1fe24068ffdec
Reviewed-on: https://dart-review.googlesource.com/43671
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
Reviewed-by: William Hesse <whesse@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
2018-02-26 17:31:48 +00:00
Sigmund Cherem 735ff83d82 Make the dart2js-d8-kernel try bot no longer experimental
It has been running as expected this week. It has been red, but normally because
of actual breakages that will be prevented once this is on by default.

R=efortuna@google.com
CC=​athom@google.com,whesse@google.com

Change-Id: I85a406d30b9c65274104e4a1b33f9af6a18b3616
Reviewed-on: https://dart-review.googlesource.com/43493
Reviewed-by: Emily Fortuna <efortuna@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
2018-02-23 22:39:19 +00:00
Terry Lucas 9f09ef0af3 - Fixed callback signatures with indexed_db open method to expose VersionChangeEvent and
Event type parameters instead of dynamic.
- Fixed missing interceptor in dart2js for MutationEvent (even though its deprecated
and should not be used).  The MutationEvent is created when a node is deleted. Enabled
Dart MutationEvent class generation.
- Fixed/re-enabled all indexed_db tests to run and pass successfully.

Stephen please take a look - target in VersionChangeEvent is a final field, per your suggestion,
instead of a getter.  The MutationEvent is returned in the browser and without the MutationEvent
Dart class the error:

     Uncaught TypeError: t1.get$target is not a function


R=vsm@google.com,gabrielchow@google.com,sra@google.com

Change-Id: Ic36aea8c33b4263a32ff9d047ba3e6b979e03b10
Reviewed-on: https://dart-review.googlesource.com/41569
Reviewed-by: Stephen Adams <sra@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>
Commit-Queue: Terry Lucas <terry@google.com>
2018-02-23 14:29:45 +00:00
William Hesse 9119148f9c Update checked-in SDK version to 2.0.0-dev.30.0
This updates the checked-in dartfmt to use dart_style 1.0.10.

Change-Id: I2c8ec63bd6634e3cb1b220078ccbca4a1e85d7c6
Reviewed-on: https://dart-review.googlesource.com/43344
Reviewed-by: Jonas Termansen <sortie@google.com>
Commit-Queue: William Hesse <whesse@google.com>
2018-02-23 10:34:43 +00:00
Erik Ernst 4676ba866f Updated data for bot.dart command find-shard.
Change-Id: I5ef8018c477c581647efa8c6b3ea95702abe337c
Reviewed-on: https://dart-review.googlesource.com/42747
Reviewed-by: Erik Ernst <eernst@google.com>
2018-02-21 15:18:43 +00:00
Siva Chandra 6214cedaf5 Create isolate from the platform kernel when running VM tests under dartk.
This is take 2 with appropriate status files updates or fixes to the
tests.

This reverts commit 4925ed38ac.

Change-Id: I133b9ae307f0feed1b72ec5a0131facdc51ad4e9
Reviewed-on: https://dart-review.googlesource.com/41600
Commit-Queue: Siva Chandra <sivachandra@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
2018-02-20 22:08:25 +00:00
Zach Anderson 0b4f01f759 [infra] Fixes to custom version string
related https://github.com/flutter/flutter/issues/14751

Change-Id: Id11048777e9e27fc63b94bc49c45e575b4333d24
Reviewed-on: https://dart-review.googlesource.com/42460
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Zach Anderson <zra@google.com>
2018-02-20 17:53:06 +00:00
William Hesse 862ff2aeb3 Update checked-in SDK to version 2.0.0-dev.28.0
R=sortie@google.com

Change-Id: I5eac0a32c49009dfd5b591b267ef938aaac7bfb4
Reviewed-on: https://dart-review.googlesource.com/42402
Reviewed-by: Jonas Termansen <sortie@google.com>
Commit-Queue: William Hesse <whesse@google.com>
2018-02-20 12:56:02 +00:00
Bob Nystrom fd84e9d4cc Refactor FastaCompilerConfiguration.
Change-Id: I9fa54be97024ec006c1be73b1283067fb24e92de
Reviewed-on: https://dart-review.googlesource.com/42107
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
2018-02-17 01:15:53 +00:00
Sigmund Cherem d0c3e48a5f Add dart2js-with-kernel to the CQ
This is blocked on first landing the change to the dart2js_swarming recipe.

R=whesse@google.com,athom@google.com

Change-Id: Id7c26499cbb3d5337d6c72c10a688dd22d60dd78
Reviewed-on: https://dart-review.googlesource.com/41580
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: William Hesse <whesse@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
2018-02-16 23:46:57 +00:00
Zach Anderson 0d5cf900b0 [infra,flutter] Adds semantically meaningful custom version strings
See https://github.com/flutter/flutter/issues/14751

Change-Id: I3b35c2a32c0dd1301e92abe23b1c6fe2c2e04a6c
Reviewed-on: https://dart-review.googlesource.com/42026
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Zach Anderson <zra@google.com>
2018-02-16 20:44:48 +00:00
Alexander Thomas 7488718131 Revert "[infra] Temporarily mark CQ Windows SDK builder as experimental"
This reverts commit 3493aae512.

Reason for revert: The Windows bots have access to the VS toolchain again.
https://bugs.chromium.org/p/chromium/issues/detail?id=812927

Original change's description:
> [infra] Temporarily mark CQ Windows SDK builder as experimental
> 
> TBR=whesse@google.com
> 
> Change-Id: I95042b0ec8cb056ef2a825ba81c5258c0789df7c
> Reviewed-on: https://dart-review.googlesource.com/41821
> Reviewed-by: Alexander Thomas <athom@google.com>

TBR=whesse@google.com,athom@google.com

Change-Id: I2f064b40536fd771d0b87aa4756f9596ccaace76
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/41980
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
2018-02-16 07:57:41 +00:00