dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
54,652 Commits 2 Branches 0 Tags
38dc57504b8665ca54eeb3a752a5de9355a56901
Commit Graph

54652 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Zach Anderson 38dc57504b [status] Update corelib_2 status for bigint test 
related #32619

Change-Id: Iee23ea5d80f398e7a25b4c77164f327c4cf064ab
Reviewed-on: https://dart-review.googlesource.com/47401
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Zach Anderson <zra@google.com>
 2018-03-20 23:53:39 +00:00
Konstantin Shcheglov 6469f4c78a Support for extracting widget from a function. 
R=brianwilkerson@google.com

Change-Id: I2775ac681f14d26d96a872aae98c473062d47305
Reviewed-on: https://dart-review.googlesource.com/47380
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-03-20 23:29:19 +00:00
Ryan Macnak 00ec3b0867 [vm] Fix several kernel-specific memory leaks. 
Bug: https://github.com/dart-lang/sdk/issues/32615
Change-Id: Ic969915c6084b9deef0d86c8f8a0e9aa4f4640e5
Reviewed-on: https://dart-review.googlesource.com/47321
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Alexander Aprelev <aam@google.com>
 2018-03-20 23:23:49 +00:00
Alexander Markov b7c3c32f63 [vm] Do not assign type to phi if it was loaded from a different local 
During SSA construction in strong mode, types of local variables are
propagated (assigned) to phis which are 'loaded' from slots corresponding
to those local variables.

It is incorrect if phi was stored in a different local variable with a more
specific type and then reloaded.

After this change, type is propagated from local variable to phis only if
phi was created for this local.

Fixes https://github.com/dart-lang/sdk/issues/32597

Change-Id: I7d86c2ef79d14895c9b4c3651d0234b3f9c66173
Reviewed-on: https://dart-review.googlesource.com/47200
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
 2018-03-20 23:08:49 +00:00
Dan Rubel d26c310a27 Rework parsing of local const declarations 
Similar to earlier work that reworked parsing of variable declarations,
this CL reworks parsing of local constant declarations to use
TypeInfo rather than parseType. This simplifies and improves recovery,
and reduces the number of error messages in some recovery situations.

Change-Id: I32705bdba20a0cb7aee41c64510c4c2896a5ae68
Reviewed-on: https://dart-review.googlesource.com/47241
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2018-03-20 22:50:20 +00:00
Ben Konyi 06638dd17f [ VM / Dart 2 ] Removed DartAPI_NativeFieldAccess and DartAPI_InjectNativeFields1 as they were using Dart_CreateNativeWrapper which doesn't make sense in the context of Dart 2. Also did some status file cleanup and reorganization. 
Change-Id: I8e8b309ba7aa453e85f6e68d96bb8b4702ff7bb4
Reviewed-on: https://dart-review.googlesource.com/47322
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Zach Anderson <zra@google.com>
 2018-03-20 22:43:09 +00:00
Sigmund Cherem a5966ad988 Fix dart2js libraries.yaml 
Long ago I accidentally only made the change to _cfe.dart in the .json file and
not in the .yaml file (which is technically the source of truth).

Change-Id: I0e8abdc84b9b0f20019c712246493979debaf1cd
Reviewed-on: https://dart-review.googlesource.com/47323
Reviewed-by: Emily Fortuna <efortuna@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
 2018-03-20 22:29:19 +00:00
Ben Konyi ec65830504 [ VM / Dart 2 ] Fixed DartAPI_LookupLibrary test which was treating the script in Dart_LoadScript as kernel instead of source. 
Change-Id: I979ddd774904d4a3058ff92d93ddf9c2efe14673
Reviewed-on: https://dart-review.googlesource.com/47320
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2018-03-20 21:50:19 +00:00
Konstantin Shcheglov 8abeb56ebb Basic 'Extract Widget' refactoring. 
Only a widget creation expression can be extracted.

Not exposed through Analysis Server API.

R=brianwilkerson@google.com, devoncarew@google.com

Change-Id: I6a47cc1851d69b54a2812bd6a5320c287d5b9eae
Reviewed-on: https://dart-review.googlesource.com/47360
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-03-20 21:24:56 +00:00
Sigmund Cherem 996277d427 Entity-fy the non-frequence minifier so it can be supported under the CFE. 
This minifier is used only when passing --no-frequency-based-minification.

Closes #32600

Bug: https://github.com/dart-lang/sdk/issues/32600
Change-Id: I91ae293c78f4cfe3dd0421493162d9e5744a9217
Reviewed-on: https://dart-review.googlesource.com/47303
Reviewed-by: Emily Fortuna <efortuna@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
 2018-03-20 20:28:53 +00:00
Brian Wilkerson 0e764393f3 A few more Dart2 related fixes 
Change-Id: If2503b93e11f0831787dfa21e5ae0abb74e9162f
Reviewed-on: https://dart-review.googlesource.com/47302
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-03-20 20:17:59 +00:00
Konstantin Shcheglov 965cb81c0f Add AnalysisSessionHelper and move getClass() into it. 
R=brianwilkerson@google.com

Change-Id: I5d1f121ff86d1eea75d6f79663394bb79305c4ca
Reviewed-on: https://dart-review.googlesource.com/47187
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-03-20 19:05:24 +00:00
pq 1c5d2e9016 Bump linter to 0.1.45 
* fix for `invariant_booleans` when analyzing for loops with no condition
* new `avoid_types_as_parameter_names` lint
* new `avoid_renaming_method_parameters` lint

Change-Id: Iaafceba24f1b049a132464b78588d57e621c85d4
Reviewed-on: https://dart-review.googlesource.com/47300
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-03-20 18:40:12 +00:00
Terry Lucas 86b1646475 webSQL is not suported by Firefox fixed test supported should of true should not be expected. 
TBR=alanknight@google.com

Change-Id: Ie6fc9e2db90994ac866637dc12ac5d496f6a627a
Reviewed-on: https://dart-review.googlesource.com/47280
Reviewed-by: Terry Lucas <terry@google.com>
 2018-03-20 17:06:25 +00:00
Terry Lucas 3d34f4d4fe Updated CHANGELOG with Chrome 63 roll changes and fixed status file test now passes. 
TBR=whesse@google.com

Change-Id: Ie48a6023cc3c0abecb8347b1a2f3ce774d42681a
Reviewed-on: https://dart-review.googlesource.com/47243
Reviewed-by: Terry Lucas <terry@google.com>
 2018-03-20 15:14:38 +00:00
danrubel 08d305bbd7 Inline modifiers into endTopLevelFields and endFields events 
Change-Id: I9681e22ae96c43626558ff567cbf4a12117095fa
Reviewed-on: https://dart-review.googlesource.com/47240
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2018-03-20 15:00:35 +00:00
Brian Wilkerson efab00ce5c Fix type issues caused by running with --preview-dart-2 
Change-Id: I99758d562e0140095d8f539419da9a98a55e6132
Reviewed-on: https://dart-review.googlesource.com/46941
Reviewed-by: Peter von der Ahé <ahe@google.com>
Reviewed-by: Dan Rubel <danrubel@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-03-20 13:36:17 +00:00
Dan Rubel adb9f8cc0b Inline modifiers into beginClassDeclaration and beginNamedMixinApplication 
Change-Id: I0d95029c203a77d4a9e9dc2d8f1b40bced7535c5
Reviewed-on: https://dart-review.googlesource.com/47186
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2018-03-20 13:28:17 +00:00
Johnni Winther b75fb574ee Fix async_compiler_input_provider_test for Windows 
Change-Id: Iac926078023a5b94623dc6427a3ca6d5a495b661
Reviewed-on: https://dart-review.googlesource.com/47041
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2018-03-20 12:16:36 +00:00
Dan Rubel fd005e17bc Rework parsing of local function declarations 
This CL reworks parsing local variable and local function
declarations to improve recovery and error messages.
In addition, the fasta parser properly parses metadata
before a local function declaration.

Change-Id: Ia43c8bab3f3ce3b824390a4aa36d50b85f1ea9af
Reviewed-on: https://dart-review.googlesource.com/46952
Commit-Queue: Dan Rubel <danrubel@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-03-20 12:01:26 +00:00
Johnni Winther 8eb749e032 Fix sourcemaps/name_test for kernel 
Change-Id: I77e60ae236cf8a17edc3854496fc900d67915bd0
Reviewed-on: https://dart-review.googlesource.com/47040
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2018-03-20 11:35:49 +00:00
Terry Lucas 581c512345 Fixed DOMRectList not having a prototype field. 
TBR=vsm@google.com

Change-Id: I6cbc38bbb2123b914d5b5511774425c403e614ed
Reviewed-on: https://dart-review.googlesource.com/47183
Reviewed-by: Terry Lucas <terry@google.com>
Commit-Queue: Terry Lucas <terry@google.com>
 2018-03-20 01:08:47 +00:00
Sigmund Cherem 031ef989ac Provide better error message when a linked dependency doesn't exist 
This comes up for dart2js when the location for dart2js_platform.dill is invalid
or when the file was not provided. Today dart2js produces a bad crash message in
that scenario, instead of a readable error.

I wanted to provide a better message, but I'm not sure I can. For example, I
wanted to say "SDK Platform file not found", but I can't because linked
dependencies can be used for other puposes.

Change-Id: I1739ec36dab16b2fd72552e5e7716cd573a8ebd0
Reviewed-on: https://dart-review.googlesource.com/46943
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
 2018-03-20 01:03:37 +00:00
Jenny Messerly d9878ae0da fix regression in DDC handling of top-level field named 'name' 
Also refactors the code to make this sort of issue less likely.

Change-Id: Iff72e53720ba78e84c3d219e69ccd0d6a47c09a0
Reviewed-on: https://dart-review.googlesource.com/47188
Commit-Queue: Jenny Messerly <jmesserly@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>
 2018-03-20 00:49:58 +00:00
Konstantin Shcheglov ac322d0fb4 Move LibraryElement caching to AnalysisSession. 
I need something similar for Extract Widget refactoring - get references
to some Flutter types, which are probably already available from the
resolved unit.

R=brianwilkerson@google.com

Change-Id: I8d9a9e6c35c9fe7ef8fba6547c560642f650d018
Reviewed-on: https://dart-review.googlesource.com/47184
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-03-19 22:26:47 +00:00
Brian Wilkerson 2047d44631 Handle the case where there is no selection(issue 32563) 
Change-Id: I5f1981a89a5af438ccc0e0b4395083ed04cda180
Reviewed-on: https://dart-review.googlesource.com/47185
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-03-19 22:06:37 +00:00
Dan Rubel 06949dc985 Inline modifiers into beginFactoryMethod event 
Change-Id: Ibc1053126b020577625279f4fab0bcff71aa5d15
Reviewed-on: https://dart-review.googlesource.com/47182
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2018-03-19 22:04:37 +00:00
Konstantin Shcheglov 8eb9f3db80 Create new AnalysisSession instance on changes. 
R=brianwilkerson@google.com

Change-Id: I98ec3e28eadc20076a22ae9ac5d872557e73c9ef
Reviewed-on: https://dart-review.googlesource.com/47181
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-03-19 21:01:38 +00:00
Brian Wilkerson 9df1d66b57 Flip analyzer and server to preview-dart-2 by default 
Change-Id: I5d009debf962ba49ae715a87aa117538f552fbdb
Reviewed-on: https://dart-review.googlesource.com/47122
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2018-03-19 20:57:17 +00:00
Dan Rubel 8fde515354 Inline modifiers into beginTopLevelMethod event 
Change-Id: I40423fcd53dc6a374a1c5be280d1806c31f34a6d
Reviewed-on: https://dart-review.googlesource.com/47120
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2018-03-19 20:20:37 +00:00
Konstantin Shcheglov 1d184ace7b Fixes for packages:args deprecated uses. 
Mostly addOption() -> addMultiOption().

Change-Id: Iab40059aab45a371e0def89fbdfcd08bd1487d47
Reviewed-on: https://dart-review.googlesource.com/47121
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-03-19 20:15:37 +00:00
Sigmund Cherem 0c75857ad8 Fix old2new API conversion to use utf8.encode 
Pub still uses the old API to provide inputs. Source files are provided as
String, which were were incorrectly provided as codeunits. The FE expected the
binary input to be utf8 encoded.

As a separate follow up, I can update pub to provide binary data directly, or
even move it to use the new API instead so we can delete the old API soon.
Because pub-build is being replaced, I'm inclined to only do a small fix there.
Closes #32561

Bug= dartbug.com/32561
R=johnniwinther@google.com

Change-Id: I69d9ac896d534427a918ded721ee946aa5c0fc34
Reviewed-on: https://dart-review.googlesource.com/46945
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
 2018-03-19 19:55:16 +00:00
Terry Lucas 2c902f359f Not quite the full test name. 
TBR=whesse@google.com

Change-Id: Idf5568b9c9504ffcf082e7df1d7bd37bd314504f
Reviewed-on: https://dart-review.googlesource.com/47140
Reviewed-by: Terry Lucas <terry@google.com>
 2018-03-19 18:25:14 +00:00
Brian Wilkerson 6856e70b2f Disable unused tests 
Change-Id: Ib5c50063215e282c2b28b2b2fc207a3d63f81413
Reviewed-on: https://dart-review.googlesource.com/47100
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-03-19 18:00:26 +00:00
Ryan Macnak 3989d09c95 [vm] Move writing snapshot magic value from embedder to VM. 
Add Dart_IsSnapshot and Dart_IsKernel to the embedding API.

Change-Id: I7d4e1d145557e8f11dbc3c143767ad38b3615a4a
Reviewed-on: https://dart-review.googlesource.com/46360
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
 2018-03-19 17:47:55 +00:00
Lasse Reichstein Holst Nielsen a81bc639b5 Fix bug in BigInt.from with certain double values. 
Add test.

Change-Id: I385f7237e1b3d004b4401e18a82919b15d097181
Reviewed-on: https://dart-review.googlesource.com/46460
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Florian Loitsch <floitsch@google.com>
 2018-03-19 17:46:35 +00:00
Konstantin Shcheglov 538dbb62d6 Don't expect type arguments for class type parameters of static methods. 
R=brianwilkerson@google.com

Bug: https://github.com/dart-lang/sdk/issues/32396
Change-Id: I4b6b6804cfced4c6628198a7e99e0123f77c2108
Reviewed-on: https://dart-review.googlesource.com/46940
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-03-19 17:03:15 +00:00
Terry Lucas 1b5b2225f0 Few more to mark off. 
TBR=whesse@google.com

Change-Id: I4381b766757d1d365378f1aefa9875d6a55fb726
Reviewed-on: https://dart-review.googlesource.com/47101
Reviewed-by: Terry Lucas <terry@google.com>
 2018-03-19 16:41:52 +00:00
Brian Wilkerson 209809eee0 Changes to AST impl classes 
Change-Id: I2889157892e4a9666d15c5346d0ea24fe8d9d7a0
Reviewed-on: https://dart-review.googlesource.com/47062
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-03-19 16:19:56 +00:00
Terry Lucas afa27982e4 Marked the failing tests in the right status file. 
TBR=whesse@google.com

Change-Id: I7eda272cc69e2be8784c85b0045c0d04197924f8
Reviewed-on: https://dart-review.googlesource.com/47063
Reviewed-by: Terry Lucas <terry@google.com>
 2018-03-19 15:53:00 +00:00
Vyacheslav Egorov d41794ee11 [vm/compiler] Fix UB in ToIntegerConstant helper 
Change-Id: I5ffbebb12bd84eacca33fb81b3df51ba4ca291a8
Reviewed-on: https://dart-review.googlesource.com/46722
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
 2018-03-19 14:12:15 +00:00
Alexey Knyazev 4f1f5f8167 Reland "Do not return this on RandomAccessFile.close" 
This is a reland of 44aa9a17fd

Original change's description:
> Do not return this on RandomAccessFile.close
> 
> Bug: 32015
> Change-Id: I98508bdad569201afeed91f1287f061b5bb39a31
> Reviewed-on: https://dart-review.googlesource.com/44060
> Reviewed-by: Sigmund Cherem <sigmund@google.com>
> Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
> Commit-Queue: Vyacheslav Egorov <vegorov@google.com>

Bug: 32015
Change-Id: I96d870e083d7862cf0f6ad664364cf7ddef0f598
Reviewed-on: https://dart-review.googlesource.com/46780
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
 2018-03-19 13:45:25 +00:00
Brian Wilkerson 1560f19844 Fixes to make analyzer preview-dart-2 safe, part 1 of many 
Change-Id: I8f88168a1fab61b3d0d808b5d9e09e6391325302
Reviewed-on: https://dart-review.googlesource.com/46953
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-03-19 13:15:46 +00:00
Terry Lucas c51db0d213 Revert "Fix status file for few broken tests." 
This reverts commit 52d2813dfd.

TBR=sigmund@google.com

Change-Id: If84e54b755c0d690fa4fbde163b374e0ab1e8cd6
Reviewed-on: https://dart-review.googlesource.com/47061
Reviewed-by: Terry Lucas <terry@google.com>
 2018-03-19 12:29:48 +00:00
Johnni Winther c3f177b8cc Add FutureOr to dart2js static type system 
Change-Id: I0e26c82fffaa41d2e3fc02ba4d2b253c3673ce1a
Reviewed-on: https://dart-review.googlesource.com/46260
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2018-03-19 11:50:55 +00:00
Lasse Reichstein Holst Nielsen c43b1d66b5 Fix typo in map.update. 
Add tests.

Change-Id: If27b6c987c944ebb84d43acde012f5b44730c4e7
Reviewed-on: https://dart-review.googlesource.com/45501
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
 2018-03-19 10:54:15 +00:00
William Hesse d9c022184c Pass enable-asserts flag from test.py to VM runtime. 
Change-Id: I84223c57dcbc74d9e5ba7d2d977fe9d5f6d686dc
Reviewed-on: https://dart-review.googlesource.com/46900
Reviewed-by: Erik Ernst <eernst@google.com>
Commit-Queue: William Hesse <whesse@google.com>
 2018-03-19 10:38:05 +00:00
Terry Lucas 52d2813dfd Fix status file for few broken tests. 
TBR=sigmund@google.com

Change-Id: I2f9104be404771cfb6685ff2dbfd18591e947b73
Reviewed-on: https://dart-review.googlesource.com/46960
Reviewed-by: Terry Lucas <terry@google.com>
 2018-03-19 04:07:33 +00:00
Terry Lucas 666172ded2 Revert "Corrected for safari only" 
This reverts commit 3612130281.

TBR=sigmund@google.com

Change-Id: Idd49c929a1245e9e6bf3fd4798c478e8f08c9bdf
Reviewed-on: https://dart-review.googlesource.com/46956
Reviewed-by: Terry Lucas <terry@google.com>
 2018-03-19 03:55:06 +00:00
Terry Lucas 3612130281 Corrected for safari only 
TBR=sigmund@google.com

Change-Id: I01d64bb823f566e5d55e14110508ab5f36b08f53
Reviewed-on: https://dart-review.googlesource.com/46955
Reviewed-by: Terry Lucas <terry@google.com>
 2018-03-19 02:41:02 +00:00