dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
54,652 Commits 2 Branches 0 Tags
38dc57504b8665ca54eeb3a752a5de9355a56901
Commit Graph

17334 Commits

Author SHA1 Message Date
Zach Anderson 38dc57504b [status] Update corelib_2 status for bigint test 
related #32619

Change-Id: Iee23ea5d80f398e7a25b4c77164f327c4cf064ab
Reviewed-on: https://dart-review.googlesource.com/47401
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Zach Anderson <zra@google.com>
 2018-03-20 23:53:39 +00:00
Terry Lucas 86b1646475 webSQL is not suported by Firefox fixed test supported should of true should not be expected. 
TBR=alanknight@google.com

Change-Id: Ie6fc9e2db90994ac866637dc12ac5d496f6a627a
Reviewed-on: https://dart-review.googlesource.com/47280
Reviewed-by: Terry Lucas <terry@google.com>
 2018-03-20 17:06:25 +00:00
Terry Lucas 3d34f4d4fe Updated CHANGELOG with Chrome 63 roll changes and fixed status file test now passes. 
TBR=whesse@google.com

Change-Id: Ie48a6023cc3c0abecb8347b1a2f3ce774d42681a
Reviewed-on: https://dart-review.googlesource.com/47243
Reviewed-by: Terry Lucas <terry@google.com>
 2018-03-20 15:14:38 +00:00
Johnni Winther b75fb574ee Fix async_compiler_input_provider_test for Windows 
Change-Id: Iac926078023a5b94623dc6427a3ca6d5a495b661
Reviewed-on: https://dart-review.googlesource.com/47041
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2018-03-20 12:16:36 +00:00
Johnni Winther 8eb749e032 Fix sourcemaps/name_test for kernel 
Change-Id: I77e60ae236cf8a17edc3854496fc900d67915bd0
Reviewed-on: https://dart-review.googlesource.com/47040
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2018-03-20 11:35:49 +00:00
Terry Lucas 581c512345 Fixed DOMRectList not having a prototype field. 
TBR=vsm@google.com

Change-Id: I6cbc38bbb2123b914d5b5511774425c403e614ed
Reviewed-on: https://dart-review.googlesource.com/47183
Reviewed-by: Terry Lucas <terry@google.com>
Commit-Queue: Terry Lucas <terry@google.com>
 2018-03-20 01:08:47 +00:00
Jenny Messerly d9878ae0da fix regression in DDC handling of top-level field named 'name' 
Also refactors the code to make this sort of issue less likely.

Change-Id: Iff72e53720ba78e84c3d219e69ccd0d6a47c09a0
Reviewed-on: https://dart-review.googlesource.com/47188
Commit-Queue: Jenny Messerly <jmesserly@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>
 2018-03-20 00:49:58 +00:00
Terry Lucas 2c902f359f Not quite the full test name. 
TBR=whesse@google.com

Change-Id: Idf5568b9c9504ffcf082e7df1d7bd37bd314504f
Reviewed-on: https://dart-review.googlesource.com/47140
Reviewed-by: Terry Lucas <terry@google.com>
 2018-03-19 18:25:14 +00:00
Lasse Reichstein Holst Nielsen a81bc639b5 Fix bug in BigInt.from with certain double values. 
Add test.

Change-Id: I385f7237e1b3d004b4401e18a82919b15d097181
Reviewed-on: https://dart-review.googlesource.com/46460
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Florian Loitsch <floitsch@google.com>
 2018-03-19 17:46:35 +00:00
Terry Lucas 1b5b2225f0 Few more to mark off. 
TBR=whesse@google.com

Change-Id: I4381b766757d1d365378f1aefa9875d6a55fb726
Reviewed-on: https://dart-review.googlesource.com/47101
Reviewed-by: Terry Lucas <terry@google.com>
 2018-03-19 16:41:52 +00:00
Terry Lucas afa27982e4 Marked the failing tests in the right status file. 
TBR=whesse@google.com

Change-Id: I7eda272cc69e2be8784c85b0045c0d04197924f8
Reviewed-on: https://dart-review.googlesource.com/47063
Reviewed-by: Terry Lucas <terry@google.com>
 2018-03-19 15:53:00 +00:00
Alexey Knyazev 4f1f5f8167 Reland "Do not return this on RandomAccessFile.close" 
This is a reland of 44aa9a17fd

Original change's description:
> Do not return this on RandomAccessFile.close
> 
> Bug: 32015
> Change-Id: I98508bdad569201afeed91f1287f061b5bb39a31
> Reviewed-on: https://dart-review.googlesource.com/44060
> Reviewed-by: Sigmund Cherem <sigmund@google.com>
> Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
> Commit-Queue: Vyacheslav Egorov <vegorov@google.com>

Bug: 32015
Change-Id: I96d870e083d7862cf0f6ad664364cf7ddef0f598
Reviewed-on: https://dart-review.googlesource.com/46780
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
 2018-03-19 13:45:25 +00:00
Terry Lucas c51db0d213 Revert "Fix status file for few broken tests." 
This reverts commit 52d2813dfd.

TBR=sigmund@google.com

Change-Id: If84e54b755c0d690fa4fbde163b374e0ab1e8cd6
Reviewed-on: https://dart-review.googlesource.com/47061
Reviewed-by: Terry Lucas <terry@google.com>
 2018-03-19 12:29:48 +00:00
Johnni Winther c3f177b8cc Add FutureOr to dart2js static type system 
Change-Id: I0e26c82fffaa41d2e3fc02ba4d2b253c3673ce1a
Reviewed-on: https://dart-review.googlesource.com/46260
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2018-03-19 11:50:55 +00:00
Lasse Reichstein Holst Nielsen c43b1d66b5 Fix typo in map.update. 
Add tests.

Change-Id: If27b6c987c944ebb84d43acde012f5b44730c4e7
Reviewed-on: https://dart-review.googlesource.com/45501
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
 2018-03-19 10:54:15 +00:00
Terry Lucas 52d2813dfd Fix status file for few broken tests. 
TBR=sigmund@google.com

Change-Id: I2f9104be404771cfb6685ff2dbfd18591e947b73
Reviewed-on: https://dart-review.googlesource.com/46960
Reviewed-by: Terry Lucas <terry@google.com>
 2018-03-19 04:07:33 +00:00
Terry Lucas 666172ded2 Revert "Corrected for safari only" 
This reverts commit 3612130281.

TBR=sigmund@google.com

Change-Id: Idd49c929a1245e9e6bf3fd4798c478e8f08c9bdf
Reviewed-on: https://dart-review.googlesource.com/46956
Reviewed-by: Terry Lucas <terry@google.com>
 2018-03-19 03:55:06 +00:00
Terry Lucas 3612130281 Corrected for safari only 
TBR=sigmund@google.com

Change-Id: I01d64bb823f566e5d55e14110508ab5f36b08f53
Reviewed-on: https://dart-review.googlesource.com/46955
Reviewed-by: Terry Lucas <terry@google.com>
 2018-03-19 02:41:02 +00:00
Terry Lucas ef292c678e Updated for Chrome 63 Roll 
TBR=sigmund@google.com

Change-Id: Iba8e73a1db3f898babdca7aaa08d34790000cf51
Reviewed-on: https://dart-review.googlesource.com/46954
Reviewed-by: Terry Lucas <terry@google.com>
Commit-Queue: Terry Lucas <terry@google.com>
 2018-03-19 01:57:50 +00:00
Terry Lucas ea392fee27 TouchEvents now supported on Safari 
TBR=sigmund@google.com

Change-Id: If485b39afeb0ce389c98d90ebe8a7ea6359e0fba
Reviewed-on: https://dart-review.googlesource.com/46950
Reviewed-by: Terry Lucas <terry@google.com>
 2018-03-18 14:40:03 +00:00
Terry Lucas 9c0ba9992d Aded expected failure to status file. 
TBR=sigmund@google.com

Change-Id: I4e7ede394441038deee6eb973a4b3d7ba1e4623d
Reviewed-on: https://dart-review.googlesource.com/46949
Reviewed-by: Terry Lucas <terry@google.com>
 2018-03-18 14:28:38 +00:00
Terry Lucas 60469482f1 Move ClientRect members to DOMRect. 
TBR=sigmund@google.com,sra@google.com

Change-Id: I424b087830954329f4399f6b169f572196a4f658
Reviewed-on: https://dart-review.googlesource.com/46948
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Terry Lucas <terry@google.com>
 2018-03-18 13:27:46 +00:00
Terry Lucas 148a642aa1 Fixed typo. 
TBR=sigmund@google.com

Change-Id: I7b898c6c77615d9790a72dcb0b5622af0cc4a9e5
Reviewed-on: https://dart-review.googlesource.com/46947
Reviewed-by: Terry Lucas <terry@google.com>
 2018-03-18 11:29:05 +00:00
Terry Lucas b4e0c342c5 Updated html tests to match new/changed Chrome 63 APIs. 
TBR=sigmund@google.com

Change-Id: I831a37c29ed1b82ac5336a017c54486ea75bb889
Reviewed-on: https://dart-review.googlesource.com/46946
Reviewed-by: Terry Lucas <terry@google.com>
 2018-03-18 10:55:05 +00:00
Terry Lucas ef6273cba0 Dart Web Libraries re-generated based on Chrome 63 WebIDLs. 
This is a migration of 13 Chrome release about 1.5 years of Chrome releases.
Update PYTHON scripts for cleaner and easier rolling.

Here's a doc on the changes that might affect Dart users:
https://docs.google.com/document/d/1Kj0nk3SueO3JKub8im7z3znu9j5oiI7vf49ejZrMxuE/edit#

Change-Id: I768fbd09b04fe6884af36ac102d5813f67bae426
Reviewed-on: https://dart-review.googlesource.com/24501
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Terry Lucas <terry@google.com>
 2018-03-18 09:41:04 +00:00
Emily Fortuna db21add40c Adding test for async closures with type variables, and fixing how we emit stubs 
with type parameters in the meanwhile.

Change-Id: I5fe1e94e7423af30adf4020b46269b8ea81ac07f
Reviewed-on: https://dart-review.googlesource.com/46700
Commit-Queue: Emily Fortuna <efortuna@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2018-03-16 17:46:18 +00:00
Kevin Millikin 8108ad9e0e Make the Kernel serializer implement, not extend, Visitor 
Extending visitor makes it impossible to get a static error when new
syntax is added to Kernel.  Also, add @override annotations so we can
get a hint when syntax is removed from Kernel.

Change-Id: I9f3111e406e9994e76a637d2782e24cde264fd31
Reviewed-on: https://dart-review.googlesource.com/46721
Commit-Queue: Kevin Millikin <kmillikin@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2018-03-16 11:03:57 +00:00
Peter von der Ahé 4f2bdff90b Rename Program to Component 
Change-Id: I1a3cc03fba9783807fa637a9d42fdbad68ee7686
Reviewed-on: https://dart-review.googlesource.com/31040
Commit-Queue: Peter von der Ahé <ahe@google.com>
Reviewed-by: Kevin Millikin <kmillikin@google.com>
 2018-03-15 12:22:23 +00:00
Karl Klose a461573294 Remove test expectations for a test that actually passes 
R=kmillikin@google.com

Change-Id: I02b4f4231e7d9c775153d265beb96b3565a651ee
Reviewed-on: https://dart-review.googlesource.com/46724
Reviewed-by: Kevin Millikin <kmillikin@google.com>
Commit-Queue: Karl Klose <karlklose@google.com>
 2018-03-15 12:18:28 +00:00
Dan Rubel 71e16622cd Improve for statement errors and recovery 
This CL updates fasta parsing of `for` statements
to detect additional errors and improve recovery.

The parser originally called parseType when parsing `for` statements
which committed the parser down a particular path
and limited the ability of the caller to gracefully recovery.
Now the parser calls computeType, which parses and caches
the type information, so that the caller has more opportunity
to recover gracefully.

Change-Id: I6296ffb1f75e77a87a7533bfca77dae18cfcf60d
Reviewed-on: https://dart-review.googlesource.com/46383
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2018-03-15 11:43:13 +00:00
Kevin Millikin 65b19ffa3c Translate asserts in the VM-specific async translation 
Translate assert statements in async functions.  The translation of
the condition subexpression can produce a sequence of statements that
have been hoisted out of it.  These need to be guarded so they are
executed only when asserts are enabled.

For this purpose, we introduce an AssertBlock.  The semantics of the
assert block:

assert { s0; ...; sn; }

is the same as:

if (assertsEnabled) { s0; ...; sn; }

where assertsEnabled is a more primitive nullary expression that is
true iff. assertions are enabled.  We chose not to encode this using a
construct like assertsEnabled because (1) we would have to support it
appearing as an arbitrary expression which we don't currently need
and (2) it requires deeper pattern matching to detect and skip the
guarded code when desired.

The translation is more complicated because if there is a message
subexpression in an assert, it is conditionally evaluated only if the
assert's condition is false.

Fixes https://github.com/dart-lang/sdk/issues/28498

Change-Id: I0912a57104ede3160533e49f65b6fb79b76f1500
Reviewed-on: https://dart-review.googlesource.com/46442
Commit-Queue: Kevin Millikin <kmillikin@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
 2018-03-14 19:41:09 +00:00
Sigmund Cherem d6294bc6b5 Round 6 of status updates: remaining issues in d8, safari, ie11, ff (hopefully) 
TBR=efortuna@google.com

Change-Id: Id84ed1a13646a27015d3aa20ad0d3c0c7d08522c
Reviewed-on: https://dart-review.googlesource.com/46564
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Emily Fortuna <efortuna@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
 2018-03-14 19:25:29 +00:00
William Hesse 0bd1aa01f2 Update status for dart2js unit test that times out 
Change-Id: I591aa0f9ea3692f5e586e87829f6a7530ce36d36
Reviewed-on: https://dart-review.googlesource.com/46580
Reviewed-by: Erik Ernst <eernst@google.com>
 2018-03-14 17:20:42 +00:00
Sigmund Cherem af1f26fd48 Status fixes round 5: chrome mac & windows 
TBR=efortuna@google.com

Change-Id: I69db60955cd22aca48981bb84a2637a28c385cc4
Reviewed-on: https://dart-review.googlesource.com/46422
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
 2018-03-14 16:16:34 +00:00
Sigmund Cherem 1bad507517 Status fixes round 4: minified+checked d8, and chrome csp 
TBR=efortuna@google.com

Change-Id: I98fd69ca11b962a9eb665c0de9d5ecb49626a891
Reviewed-on: https://dart-review.googlesource.com/46421
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
 2018-03-14 07:11:29 +00:00
Sigmund Cherem 9c9497bda0 Status updates round 3: chrome-faststarup, ff, ff-faststartup 
TBR=efortuna@google.com

Change-Id: I06b535f7273c3ac85173bf4f0286e02d09897c8e
Reviewed-on: https://dart-review.googlesource.com/46420
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2018-03-14 06:16:19 +00:00
Sigmund Cherem 537057cd2d Round 2: fast-startup minified 
TBR=efortuna@google.com

Change-Id: Id8d74e93304ed92fd50afbb1820d9ad05e3abf02
Reviewed-on: https://dart-review.googlesource.com/46402
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
 2018-03-14 05:17:49 +00:00
Sigmund Cherem 1b13c73062 Round 1 of .status fixes: to cover d8 bots 
TBR=efortuna@google.com

Change-Id: I93e86104760e6e41ea32fbae311535a46a72e4c8
Reviewed-on: https://dart-review.googlesource.com/46386
Reviewed-by: Emily Fortuna <efortuna@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
 2018-03-14 01:53:58 +00:00
Sigmund Cherem c438f8b3f4 Dart2js defaults to the new common front-end 
Change-Id: Id0f69d258b010a746b56e259335185bcca7dafec
Reviewed-on: https://dart-review.googlesource.com/45143
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2018-03-13 19:25:59 +00:00
Alexander Markov 881c0196aa [vm] Fix type test '_Closure class IS FunctionType' in strong mode 
Closes https://github.com/dart-lang/sdk/issues/32508

Change-Id: Ib3455edd393d0ce5ccd5fe315f8d54f14606cc25
Reviewed-on: https://dart-review.googlesource.com/46201
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
 2018-03-13 19:08:56 +00:00
Dmitry Stefantsov f8995da6aa Report a compile-time error on magic const 
When inferring const or new for expressions that aren't required to be const,
Fasta always choses new. That's not correct, and this is a short-term work
around to avoid introducing a breaking change in the future. The plan is to
implement this feature correctly, but that will require more time than we have
right now.

Originally submitted by ahe@google.com.  Added: status file fixes.

Change-Id: I2d70bd2488de6b69fcd5546c1f4654dfbbb30b7f
Reviewed-on: https://dart-review.googlesource.com/46340
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
 2018-03-13 19:07:12 +00:00
Alexander Markov 38f598bf80 [Gardening] Mark timed-out test as Slow 
The test language_2/vm/precompiled_static_initializer_test times out
on kernel/precompiler/debug bots. This test enables uncontrollable inlining
which results in a huge amount of code to precompile. Most probably,
it started to time-out because type flow analysis, which was enabled in
https://github.com/dart-lang/sdk/commit/d58887eaf6cb8460e2283d8531bbd8c0611a146d,
does more devirtualization and provides more opportunities for inlining.

Change-Id: I915132f81529cc967f62f9546d16a60cb4e8aed7
Reviewed-on: https://dart-review.googlesource.com/46303
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
 2018-03-13 17:32:09 +00:00
Lasse R.H. Nielsen 6f13072739 Add toString to MapEntry. 
Fixes #32464

BUG: http://dartbug.com/32464

Change-Id: I1462452c3f6a7838aeaaa84e3fb0e092a3f85338
Reviewed-on: https://dart-review.googlesource.com/45704
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2018-03-13 13:57:59 +00:00
Martin Kustermann 8dadc89bfb [VM] Disallow ConstructorInvocation/ListLiteral/MapLiteral in constant evaluator 
Change-Id: I4ef12bd25974bba9aa69127630b05f2e4fd46657
Reviewed-on: https://dart-review.googlesource.com/46241
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
 2018-03-13 12:59:09 +00:00
Lasse R.H. Nielsen 00dae36b47 Add of constructors to collections. 
Change-Id: Ic9a180cbb758cf8fe51369d904fa4b51fd1b8e27
Reviewed-on: https://dart-review.googlesource.com/44480
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Kevin Moore <kevmoo@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
 2018-03-13 12:57:49 +00:00
William Hesse dfbd8f044b Update status for analyzer on Windows after test.py fixes 
R: ahe@google.com
Change-Id: I46b43bfefcdfce05408cefc5a82071f061e6a9eb
Reviewed-on: https://dart-review.googlesource.com/46246
Reviewed-by: Peter von der Ahé <ahe@google.com>
 2018-03-13 12:25:24 +00:00
Johnni Winther f58659399d More status fixes 
Change-Id: Ib43800c9fe0da786a154d7b42f9784e45c690a77
Reviewed-on: https://dart-review.googlesource.com/46245
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2018-03-13 12:12:17 +00:00
Johnni Winther 85720e4eb3 Fix status of dart2js-with-kernel tests 
Change-Id: I2f5a1589b800fc1d453f5dd6f941f77c42250acc
Reviewed-on: https://dart-review.googlesource.com/46242
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2018-03-13 11:22:44 +00:00
Johnni Winther b08bedee7e Update RuntimeTypesNeed to disable rti optimization 
- for local signatures in strong mode.

Change-Id: I0cafead24b24a534813449b6bf710eeafcb569bd
Reviewed-on: https://dart-review.googlesource.com/46064
Reviewed-by: Emily Fortuna <efortuna@google.com>
 2018-03-13 10:09:26 +00:00
Johnni Winther 42e7598f5d Don't emit function signatures for non-closure classes in Dart 2 
Change-Id: I144ddd60abebe41549c1f5304d73cb56042c7289
Reviewed-on: https://dart-review.googlesource.com/46043
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2018-03-13 09:50:39 +00:00