dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity
54,652 Commits 2 Branches 0 Tags
38dc57504b8665ca54eeb3a752a5de9355a56901
Commit Graph

1337 Commits

Author SHA1 Message Date
Sigmund Cherem d6294bc6b5 Round 6 of status updates: remaining issues in d8, safari, ie11, ff (hopefully) 
TBR=efortuna@google.com

Change-Id: Id84ed1a13646a27015d3aa20ad0d3c0c7d08522c
Reviewed-on: https://dart-review.googlesource.com/46564
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Emily Fortuna <efortuna@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
 2018-03-14 19:25:29 +00:00
Martin Kustermann 846d18414c Use platform.dill for more fasta tests, skip shaker test 
Issue https://github.com/dart-lang/sdk/issues/32530
Issue https://github.com/dart-lang/sdk/issues/32531

Change-Id: Ie31a9e4d82fb942e48aa9a9c89c45eefb132702f
Reviewed-on: https://dart-review.googlesource.com/46520
Reviewed-by: Peter von der Ahé <ahe@google.com>
 2018-03-14 16:27:37 +00:00
Sigmund Cherem af1f26fd48 Status fixes round 5: chrome mac & windows 
TBR=efortuna@google.com

Change-Id: I69db60955cd22aca48981bb84a2637a28c385cc4
Reviewed-on: https://dart-review.googlesource.com/46422
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
 2018-03-14 16:16:34 +00:00
Sigmund Cherem 9c9497bda0 Status updates round 3: chrome-faststarup, ff, ff-faststartup 
TBR=efortuna@google.com

Change-Id: I06b535f7273c3ac85173bf4f0286e02d09897c8e
Reviewed-on: https://dart-review.googlesource.com/46420
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2018-03-14 06:16:19 +00:00
Peter von der Ahé 8a9956d4a7 [dart2js] Handle Windows file names correctly. 
Closes https://github.com/dart-lang/sdk/issues/31899

Change-Id: I0577e9cd5bab7083df53ccbee7ffb2258f08a442
Reviewed-on: https://dart-review.googlesource.com/46080
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Peter von der Ahé <ahe@google.com>
 2018-03-13 09:15:48 +00:00
Sigmund Cherem 932a99a731 Prepare pkg.status to enable dart2js CFE by default 
TBR=sra@google.com

Change-Id: I041af103a50c534ba278a61c1eefb689e5f58d6f
Reviewed-on: https://dart-review.googlesource.com/45366
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2018-03-07 01:30:21 +00:00
Peter von der Ahé 9f56e28372 Mixin Applications with a Vengeance 
Change-Id: I213f99234f29abd7e2ec03dc8451ed6dd16f3d03
Reviewed-on: https://dart-review.googlesource.com/45021
Reviewed-by: Kevin Millikin <kmillikin@google.com>
 2018-03-06 15:15:57 +00:00
Jens Johansen 2f10ab76f7 Mark incremental_load_from_dill_test slow on Windows 
incremental_load_from_dill_test is sometimes slow on Windows. Mark it as such.

Change-Id: I11bf1bac275829f5bb612ab6f8b80d646cc31a3e
Reviewed-on: https://dart-review.googlesource.com/44780
Reviewed-by: Peter von der Ahé <ahe@google.com>
Commit-Queue: Peter von der Ahé <ahe@google.com>
 2018-03-02 14:49:40 +00:00
Danny Tuppeny 0e48dce272 Mark integration tests as skip on Windows due to timeouts 
Bug: https://github.com/dart-lang/sdk/issues/32356
Change-Id: I78613615c2de2869535810536464d3dc04f1f45b
Reviewed-on: https://dart-review.googlesource.com/44542
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-03-01 16:36:16 +00:00
Danny Tuppeny a3b2c5addb Update status for analysis server tests on Windows 
Various tests are currently flaky so marked with Pass, Slow/RuntimeError.

Bug: https://github.com/dart-lang/sdk/issues/32355
Bug: https://github.com/dart-lang/sdk/issues/32356
Change-Id: I86755a5eeb72ad92eaa22f950306e745c14e67fc
Reviewed-on: https://dart-review.googlesource.com/44260
Reviewed-by: William Hesse <whesse@google.com>
 2018-03-01 13:52:32 +00:00
William Hesse d002e2f6f3 Update status for 3 analysis server unit tests on Windows 
Bug: https://github.com/dart-lang/sdk/issues/32355
Change-Id: Ide2a8e5051e42b529c5b302978f28246ce087cf4
R: athom@google.com
Reviewed-on: https://dart-review.googlesource.com/44203
Reviewed-by: Danny Tuppeny <danny@tuppeny.com>
 2018-02-28 15:51:17 +00:00
Danny Tuppeny 6eeac05d48 Unskip analysis server tests on windows 
All path issues have been fixed and pass locally.

Bug: https://github.com/dart-lang/sdk/issues/32226
Change-Id: I782bd0a661a10f78cb672e79a000f637aa9e46a6
Reviewed-on: https://dart-review.googlesource.com/44063
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Danny Tuppeny <danny@tuppeny.com>
 2018-02-28 14:18:55 +00:00
Konstantin Shcheglov fae3a83629 Remove typed_mock 
Bug: https://github.com/dart-lang/sdk/issues/32271
Change-Id: I32d7708f269b9618f6a031f0323f5cea646066f3
Reviewed-on: https://dart-review.googlesource.com/42862
Reviewed-by: Kevin Moore <kevmoo@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-02-21 22:22:32 +00:00
Paul Berry 6539760609 Fix analyzer bots 
Change-Id: I4a0ed3b51854442994ca45235050434249b73299
Reviewed-on: https://dart-review.googlesource.com/40241
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2018-02-09 09:25:08 +00:00
Paul Berry cca7b4419d Replace $builder_tag == strong with $strong in status files 
The `$builder_tag == strong` annotations were added before test.py
supported `$strong`.  Now that `$strong` is supported, it's better to
use it directly to avoid confusion.

Change-Id: I715edecaee1e36ab8a26dbc96a6aa056e1be018f
Reviewed-on: https://dart-review.googlesource.com/39600
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2018-02-07 11:50:10 +00:00
Peter von der Ahé 861550a28c Read patch files in strong mode 
Closes https://github.com/dart-lang/sdk/issues/28822

Change-Id: I05e1d9885a39efca131d78d06cfd8a0e84276bb9
Reviewed-on: https://dart-review.googlesource.com/36641
Commit-Queue: Peter von der Ahé <ahe@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Zach Anderson <zra@google.com>
 2018-02-05 14:35:36 +00:00
Jens Johansen c3b992dcd8 [fasta] incremental compiler can initialize from dill 
As requested in #31691 the incremental compiler should be able to
initialize its state from a previously generated dill file.

This CL introduces that functionally.
It is tested, but actual usage (e.g. proper invalidation of old files)
should live outside of the front-end (i.e. it's the callers responsibility).
One option would be for the caller to load the dill file and use the
included sources to invalidate changed files.

On my machine a from-scratch compile of dart2js takes ~5 seconds,
one initialized from such an output and with a single file invalidated
(though it actually hasn't changed) it takes ~1 second and the resulting
dill file is bit-perfect compared to the from-scratch compiled one.

Closes #31691.

Change-Id: I07f5efca5f2684d73f6c252f2dbc2ad04e9b5cd0
Reviewed-on: https://dart-review.googlesource.com/37260
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Kevin Millikin <kmillikin@google.com>
 2018-02-01 14:57:07 +00:00
Alexander Thomas 676c7dbd85 Revert "[Gardening] Marked pkg/front_end/test/fasta/compile_test.dart as 'Timeout' in pkg.status" 
This reverts commit a6e59cc351.

Reason for revert: Timeout for these tests was increased in the recipes instead. We do want all of these tests to run.

Original change's description:
> [Gardening] Marked pkg/front_end/test/fasta/compile_test.dart as 'Timeout' in pkg.status
> 
> Change-Id: Ibf91848efef99159bb93b7ad46da91d4de9763ed
> Reviewed-on: https://dart-review.googlesource.com/37922
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
> Commit-Queue: Ben Konyi <bkonyi@google.com>

TBR=brianwilkerson@google.com,bkonyi@google.com

Change-Id: Id7dbb5241505c97c55b4469357d070e76bd42270
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/37662
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
 2018-02-01 10:15:18 +00:00
Ben Konyi a6e59cc351 [Gardening] Marked pkg/front_end/test/fasta/compile_test.dart as 'Timeout' in pkg.status 
Change-Id: Ibf91848efef99159bb93b7ad46da91d4de9763ed
Reviewed-on: https://dart-review.googlesource.com/37922
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2018-02-01 01:23:41 +00:00
Jens Johansen 29c76d7604 [kernel] Update Windows status files take #5 
Change-Id: Ia3bc3affba3100453846678b03d2a83402187418
Reviewed-on: https://dart-review.googlesource.com/36881
Reviewed-by: Jens Johansen <jensj@google.com>
 2018-01-26 08:46:23 +00:00
Konstantin Shcheglov 79868e3b22 Reenable analyzer/test/generated/non_error_resolver_kernel_test. 
I don't see that the test is slow, at least anymore.
It takes 9 and 14 seconds in unchecked and checked modes on my Mac.

R=brianwilkerson@google.com

Bug: https://github.com/dart-lang/sdk/issues/30796
Change-Id: I6a0453393660fac750a305cb26f837a3354a9cad
Reviewed-on: https://dart-review.googlesource.com/36280
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-01-22 16:21:48 +00:00
Alexander Markov bcdb32bc1a [vm/kernel] Unit tests for type flow analysis 
Issue: https://github.com/dart-lang/sdk/issues/30480
Change-Id: If6cf8c7dfb59703b00f5432ce803f81e1bf90232
Reviewed-on: https://dart-review.googlesource.com/34301
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
 2018-01-19 00:55:34 +00:00
Peter von der Ahé 3974d1fd50 Fix typo in status file 
Change-Id: I3c6a49bee6e3c8b63ec63ffdce3fab6c7bdecb55
Reviewed-on: https://dart-review.googlesource.com/35401
Reviewed-by: Peter von der Ahé <ahe@google.com>
Commit-Queue: Peter von der Ahé <ahe@google.com>
 2018-01-17 18:44:12 +00:00
Peter von der Ahé d0057bb039 Skip two front_end tests that fail on Windows. 
Change-Id: Ie099856787bced6a2d9e8d30540ee0854abc7d71
Reviewed-on: https://dart-review.googlesource.com/35400
Reviewed-by: Peter von der Ahé <ahe@google.com>
Commit-Queue: Peter von der Ahé <ahe@google.com>
 2018-01-17 18:29:55 +00:00
William Hesse d29f574518 Update status for two front-end unit tests failing on windows paths 
BUG=https://github.com/dart-lang/sdk/issues/31902
R=athom@google.com

Change-Id: If64467e9076d2c4f3c4cf67dfcd8dbe75f40415a
Reviewed-on: https://dart-review.googlesource.com/35340
Reviewed-by: Alexander Thomas <athom@google.com>
 2018-01-17 17:43:02 +00:00
Peter von der Ahé beda5c3e62 This CL supposedly broke the analyzer, but that isn't true. It broke a single front_end test, and if that was causing you trouble, you could have marked it as failing. 
Revert "Revert "Don't skip front-end tests""

This reverts commit b4556e646e.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Revert "Don't skip front-end tests"
> 
> This reverts commit 62d2255719.
> 
> Reason for revert: Broke analyzer bots
> 
> Original change's description:
> > Don't skip front-end tests
> > 
> > Change-Id: Ibbd0d63e8c23d045a898e52185fe55e5c53dd6b3
> > Reviewed-on: https://dart-review.googlesource.com/34621
> > Reviewed-by: Jens Johansen <jensj@google.com>
> 
> TBR=ahe@google.com,jensj@google.com
> 
> Change-Id: I6519e0c551dd79d3bd98345925c2db888e892123
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://dart-review.googlesource.com/35020
> Reviewed-by: Paul Berry <paulberry@google.com>
> Commit-Queue: Paul Berry <paulberry@google.com>

TBR=paulberry@google.com,ahe@google.com,jensj@google.com

Change-Id: I7ff6fd587912fd8a2aba113eb7c765c7b16c5eda
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/35120
Reviewed-by: Peter von der Ahé <ahe@google.com>
Commit-Queue: Peter von der Ahé <ahe@google.com>
 2018-01-17 06:03:59 +00:00
Paul Berry b4556e646e Revert "Don't skip front-end tests" 
This reverts commit 62d2255719.

Reason for revert: Broke analyzer bots

Original change's description:
> Don't skip front-end tests
> 
> Change-Id: Ibbd0d63e8c23d045a898e52185fe55e5c53dd6b3
> Reviewed-on: https://dart-review.googlesource.com/34621
> Reviewed-by: Jens Johansen <jensj@google.com>

TBR=ahe@google.com,jensj@google.com

Change-Id: I6519e0c551dd79d3bd98345925c2db888e892123
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/35020
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2018-01-16 22:44:33 +00:00
William Hesse 2d406b654e Skip front_end hot_reload_e2e test while it is broken 
BUG=31901

Change-Id: I16b195f67bb8eaeb992498acefcd82e2805c42bd
Reviewed-on: https://dart-review.googlesource.com/34840
Reviewed-by: Alexander Thomas <athom@google.com>
 2018-01-16 12:58:39 +00:00
Peter von der Ahé 62d2255719 Don't skip front-end tests 
Change-Id: Ibbd0d63e8c23d045a898e52185fe55e5c53dd6b3
Reviewed-on: https://dart-review.googlesource.com/34621
Reviewed-by: Jens Johansen <jensj@google.com>
 2018-01-16 12:00:28 +00:00
Peter von der Ahé 06040f73f2 Skip hot_reload_e2e_test on Windows. 
Change-Id: I7a379c2520be98d447a6c4e12875b74c5af29518
Reviewed-on: https://dart-review.googlesource.com/34720
Reviewed-by: Peter von der Ahé <ahe@google.com>
 2018-01-16 06:29:57 +00:00
Peter von der Ahé 2cc21f515e Remove original and minimal IKG 
Change-Id: Id845a025ae9823fd3e53aaac7b5a95aa9e2ad767
Reviewed-on: https://dart-review.googlesource.com/34380
Commit-Queue: Peter von der Ahé <ahe@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
 2018-01-15 15:02:20 +00:00
Alexander Thomas 813be084dd [infra] Normalize pkg.status 
Change-Id: I656880ceb89bfe3e5588d035d2c1a452580c2e95
Reviewed-on: https://dart-review.googlesource.com/34104
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: William Hesse <whesse@google.com>
 2018-01-11 14:33:48 +00:00
Alexander Thomas db99248e77 [infra] Normalize comments in pkg.status 
Change-Id: Ia90ecd801c4d63c434c3b3fa220f59ff8c054e08
Reviewed-on: https://dart-review.googlesource.com/33886
Commit-Queue: William Hesse <whesse@google.com>
Reviewed-by: William Hesse <whesse@google.com>
 2018-01-11 12:13:15 +00:00
Aske Simon Christensen 9bdcc40f69 Rename PhysicalFileSystem to StandardFileSystem. 
Preparation for data URI support. For clarity, this is just a rename.

Change-Id: Ibbd8da05d1a7106b5ec7c0ea9c1e13a95a89d1bd
Reviewed-on: https://dart-review.googlesource.com/33460
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2018-01-11 11:23:25 +00:00
Jens Johansen 5e5550422f [kernel] Remove unnecessary "skip" of perf_test 
Issue 28698 updated 3 status file entries. 2 entries are now gone,
and the last one doesn't seem to be current anymore.
This CL removes the remaining - unnecessary - entry.

Bug:
Change-Id: I38c8339e83c00d4be33ce84abc1c12f0b5ebe181
Reviewed-on: https://dart-review.googlesource.com/32771
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2018-01-11 08:17:47 +00:00
Vijay Menon 3a4a0fae4f test.py support for tests under pkg/dev_compiler 
Change-Id: Ic68359907d3c58bbebe7e368a6e4ad24017c6504
Reviewed-on: https://dart-review.googlesource.com/33620
Commit-Queue: Vijay Menon <vsm@google.com>
Reviewed-by: Jenny Messerly <jmesserly@google.com>
 2018-01-10 23:31:18 +00:00
Konstantin Shcheglov 2ba489c65a Fix resynthesize tests for Windows. 
Fixes #31832

R=brianwilkerson@google.com, paulberry@google.com

Bug: https://github.com/dart-lang/sdk/issues/31832
Change-Id: Ie0b1dd9742415fe9cf97b3d3843eeaf3af878308
Reviewed-on: https://dart-review.googlesource.com/33982
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-01-10 20:24:39 +00:00
Dmitry Stefantsov 613c248a6d Skip resynthesize_kernel_test for now, until the timeout issue is solved 
TBR=athom@google.com,jensj@google.com

Bug: http://dartbug.com/31832
Change-Id: I675be8bd7432f598d80ac79126f53ddfad318e42
Reviewed-on: https://dart-review.googlesource.com/33740
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
 2018-01-10 08:30:18 +00:00
Alexander Thomas 89bd41d19a [infra] Simplify vm-kernel configurations in test matrix 
This also adds the missing vm-kernel opt-counter builder.

Bug: https://github.com/dart-lang/sdk/issues/31753
Change-Id: I0199218f83d227cfc52505c213d7b689acd9c43e
Reviewed-on: https://dart-review.googlesource.com/31984
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: William Hesse <whesse@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
 2018-01-09 20:59:49 +00:00
Alexander Thomas c637a34a5a [gardening] Mark timing out test as "Slow" 
TBR=whesse@google.com

Change-Id: I080c700e6c7e76aad0a70419e21021d92c295f3f
Reviewed-on: https://dart-review.googlesource.com/33464
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
 2018-01-09 20:26:58 +00:00
Jens Johansen 426d94785d [gardening] Mark timing out tests as slow 
It seems that f99d3628d1
(CL https://dart-review.googlesource.com/33144)
caused these 5 tests to time out on the pkg builder as well as the try
bots.
Locally the tests take ~40 seconds, so giving it a bit more time (i.e.
marking them as slow) seems likely to turn things green again.

Bug:
Change-Id: I90526b1d7060309d8f1cf902bd9d52c71927f1ed
Reviewed-on: https://dart-review.googlesource.com/33340
Reviewed-by: Jens Johansen <jensj@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2018-01-09 12:57:28 +00:00
Jens Johansen 923386490a [pkg/kernel] Remove status entries for non-existing tests 
Bug:
Change-Id: I07e51f6fe958f6c37761a97002bab2fe15251a3d
Reviewed-on: https://dart-review.googlesource.com/32241
Reviewed-by: Kevin Millikin <kmillikin@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2018-01-05 07:50:33 +00:00
Jenny Messerly 0b4d7a7d7b address #30245 for DDC codegen_test 
Change-Id: I34bfc4a4c3a47dfc8352fcd3ccbd0e3fce63a5d1
Reviewed-on: https://dart-review.googlesource.com/32501
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Jenny Messerly <jmesserly@google.com>
 2018-01-05 01:03:37 +00:00
Florian Loitsch c0e4c30adb Mark minimal_incremental_kernel_generator_test as slow. 
Change-Id: I3f32dc82c146071ff14ba3345f4ba733b46bc56d
Reviewed-on: https://dart-review.googlesource.com/30220
Reviewed-by: Florian Loitsch <floitsch@google.com>
 2017-12-18 13:54:55 +00:00
Devon Carew 3ac5200e3a Add --preview-dart-2 integration tests for the search domain. 
Bug:
Change-Id: Ib062b45936463c2e3564195bc3ffd69e031ddf17
Reviewed-on: https://dart-review.googlesource.com/27464
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2017-12-09 04:57:26 +00:00
Devon Carew e38c1a98e4 Add --preview-dart-2 integration tests for the edit domain. 
Bug:
Change-Id: Ie63cd20cad7d27cb380db1cdefd7a5d4f7254a2a
Reviewed-on: https://dart-review.googlesource.com/27461
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2017-12-08 04:26:10 +00:00
Martin Kustermann d82cdcc66e [Gardening] Mark analyzer/test/src/dart/analysis/driver_kernel_test as Slow 
Change-Id: I690971ee5acc072e2ab51c26dfe538e860277641
Reviewed-on: https://dart-review.googlesource.com/26181
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
 2017-12-05 10:04:31 +00:00
Martin Kustermann d354a28cb2 [kernel] Add kernel2kernel constant evaluation, binary format as well as vm support 
The introduced "constants" transformation can evaluate constant expressions.  The
original use-sites of constant expressions are replaced by a new [ConstantExpression]
node, which points to a subclass of a new [Constant] class hierarchy.  Constant
[Field]s and [VariableDeclarations]s will be removed, since all use-sites are
re-written.

The [Constant] class hierarchy is, similarly to the [DartType] class hierarchy, not
part of the AST tree (also has no parent pointer).  The constants form a
DAG (directed acyclic graph).

There is no canonicalization requirement of the [Constant] objects referenced by the
AST (via [ConstantExpression]).  Although it is beneficial to canonicalize them during
construction, since it reduces time spent in operator==/hashCode.

This CL furthermore adds support for a constant table in the binary format.  Similarly
to [String]s, we canonicalize the constants before writing the table to the binary.
The constant table entries in the binary are written in a post-order way, to ensure
easy construction on the backend side.

The text format will be augmented with a "constants { ... }" section at the end,
which lists the constants in the same order as in the binary format.

The transformation can be used by those backends who choose to do so.  It is not
enabled by default atm.  It should therefore not affect analyzer, fasta or other
components.

Change-Id: I57cd9624fedcf537ab6870db76246149647bed21
Reviewed-on: https://dart-review.googlesource.com/14382
Commit-Queue: Martin Kustermann <kustermann@google.com>
Reviewed-by: Kevin Millikin <kmillikin@google.com>
 2017-11-16 11:08:02 +00:00
Peter von der Ahé 8bc6f7761f Add strong version of compile_platform_test. 
Change-Id: I18795293ca353a265b76f472ba2b567ab2b1ebbf
Reviewed-on: https://dart-review.googlesource.com/18540
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Peter von der Ahé <ahe@google.com>
 2017-11-03 13:17:39 +00:00
Brian Wilkerson c0f81029a3 Extract error translation and re-enable completeness test 
Change-Id: Ic78139f46a56f5b37d5569af712071ee8ae5fed9
Reviewed-on: https://dart-review.googlesource.com/18148
Reviewed-by: Dan Rubel <danrubel@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2017-11-02 16:34:09 +00:00