Commit Graph

53 Commits

Author SHA1 Message Date
ricow@google.com 7ff576944f Don't try to get chrome version on windows.
We still make sure that the binary is valid.

Enable the browser controller on windows again

R=kustermann@google.com

Review URL: https://codereview.chromium.org//23815007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27333 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-10 12:29:43 +00:00
kustermann@google.com 1e32f03118 Disable new browser controller on win-chrome
test.dart is not able to determine the version of chrome when running
'chrome.exe --version'. This causes an open browser window to hang and
makes the bot timeout.

TBR=ricow@google.com

Review URL: https://codereview.chromium.org//23561005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27245 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-06 12:22:32 +00:00
kustermann@google.com 58b33d70e9 test.py: Bugfix in browser_controller. Make sure we always complete even in case of errors
TBR=ricow@google.com

Review URL: https://codereview.chromium.org//24033002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27242 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-06 11:32:34 +00:00
ricow@google.com b4b435faab Add support for chrome on windows to the new browser controller
R=kustermann@google.com

Review URL: https://codereview.chromium.org//23625008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27239 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-06 09:45:52 +00:00
ricow@google.com 175c3f58e1 Add support for firefox on windows to the browser controller
R=kustermann@google.com

Review URL: https://codereview.chromium.org//23679006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27235 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-06 08:52:43 +00:00
ricow@google.com ec88776e9a Add div displaying the currently executing test.
This can be useful if the window freezes up with a busy loop

R=kustermann@google.com

Review URL: https://codereview.chromium.org//23506023

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27027 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-03 08:04:26 +00:00
kustermann@google.com 59c486d34c Fixed type error in browser_controller: DebugLogger.error() takes a string
TBR=ricow@google.com

Review URL: https://codereview.chromium.org//23618020

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26936 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-30 19:15:03 +00:00
kustermann@google.com 4d7311f14b Remove Timeout entries in status files for ie9/ie10
After reducing the load on our IE builders, we hopefully no longer see these
random timeouts.

R=ahe@google.com

Review URL: https://codereview.chromium.org//23604010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26912 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-30 13:39:05 +00:00
kustermann@google.com 7ddb5bb8ad test.py: Report info about how long it took until a browser tests started if it times out
R=ahe@google.com

Review URL: https://codereview.chromium.org//23522009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26910 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-30 12:55:27 +00:00
kustermann@google.com 45c42e08f2 Update checked-in binary to 0.6.21.3_r26639 (M6)
R=ricow@google.com

Review URL: https://codereview.chromium.org//23568002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26704 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-27 11:16:37 +00:00
ricow@google.com fbe8335669 Catch race condition where we are shutting down a browser and that browser is sending back results.
R=kustermann@google.com

Review URL: https://codereview.chromium.org//23005022

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26532 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-22 16:30:56 +00:00
ricow@google.com 73826dc6bf Add support for ie in the browser controller
Also, add no caching headers (since IE will cache the task that it gets)

R=kustermann@google.com

Review URL: https://codereview.chromium.org//22420002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26112 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-14 11:30:48 +00:00
kustermann@google.com 76ce98c89b Disable javascript time limit on firefox
This is an attempt to disable the script time limit on firefox, since some tests
are timing out.

TBR=ricow@google.com

Review URL: https://codereview.chromium.org//21091002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25569 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-29 16:06:17 +00:00
ricow@google.com af21d74d2d Fix safari browser to use Future.value
Also correct type errors found by the analyzer.

R=kustermann@google.com

Review URL: https://codereview.chromium.org//18089005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24532 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-27 17:07:17 +00:00
ricow@google.com 545f6e1341 Update checked in binary to version 0.5.19.0
This is a reland of r24086 with a fix catching errors in the websocket server in tools/testing/dart/http_server.dart.

R=kustermann@google.com

Review URL: https://codereview.chromium.org//18065003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24520 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-27 16:10:59 +00:00
ricow@google.com ee35be8712 Simplify close functionality in the browser controller.
Add a done future that can be used by users to determine if a browser crashes.

This future is the same we return from the close call.

R=kustermann@google.com

Review URL: https://codereview.chromium.org//17633008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24395 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-25 11:35:24 +00:00
ricow@google.com 302fbd5174 Add two additional directories to safari cache clearing.
R=kustermann@google.com

Review URL: https://codereview.chromium.org//17592003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24317 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-24 09:47:37 +00:00
ricow@google.com 568e86f4a1 Also remove Library/Safari from users home dir if --clear_safari_cache is set
Additionally, actually handle errors on deletion correctly by checking for existense first and actually failing if we fail to delete the directory.

R=kustermann@google.com

Review URL: https://codereview.chromium.org//17450017

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24238 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-20 16:01:41 +00:00
ricow@google.com ecb4dea649 Add safari cache clearing browser functionality to the safari browser.
Also, add flag to test.dart to enable this feature.

R=kustermann@google.com

Review URL: https://codereview.chromium.org//17489002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24215 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-20 10:30:04 +00:00
ricow@google.com 4c5b2ac2ab Revert 24086 Update checked in binary to version 0.5.19.0
This is causing crashes in http server.

R=kustermann@google.com

Review URL: https://codereview.chromium.org//17274002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24096 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-17 13:22:15 +00:00
ricow@google.com 1970fc7afb Update checked in binary to version 0.5.19.0
R=kustermann@google.com

Review URL: https://codereview.chromium.org//17078007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24086 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-17 10:47:02 +00:00
ricow@google.com 62f8da0bdf More debug info on the browser controller.
Add timing info on actual requests to the http server.

Review URL: https://codereview.chromium.org//16848019

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24017 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-14 06:22:07 +00:00
ricow@google.com a3902a74f4 Add debug info for how long it takes to handle the output from the browser.
Review URL: https://codereview.chromium.org//16881006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23998 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-13 17:15:54 +00:00
ricow@google.com 4eff75f62d Write browser timings on the debug log
R=kustermann@google.com

Review URL: https://codereview.chromium.org//16848011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23984 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-13 14:30:35 +00:00
ricow@google.com 5c08a32f86 Use request.response.done instead of getting future from close()
The checked in binary does not return a future on close()

R=kustermann@google.com

Review URL: https://codereview.chromium.org//16844010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23980 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-13 14:01:37 +00:00
ricow@google.com 786b0b7f1c Fix error handling on errorReportingServer
R=kustermann@google.com

Review URL: https://codereview.chromium.org//16946005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23978 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-13 13:53:25 +00:00
ricow@google.com e97215e045 Add error reporting server to the browser controller
This is used to send back errors from the browsers if we see any issues with getting resources.

R=kustermann@google.com

Review URL: https://codereview.chromium.org//16900003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23973 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-13 12:40:37 +00:00
kustermann@google.com 4efd9609a5 Moving timing info to utils.dart:DebugLogger
R=ricow@google.com

Review URL: https://codereview.chromium.org//16958003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23967 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-13 11:20:21 +00:00
ricow@google.com c0c48e23ef Add correct timing collection for new browser controller
R=kustermann@google.com

Review URL: https://codereview.chromium.org//16948002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23957 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-13 09:14:39 +00:00
ricow@google.com 0e1472b570 Fix id in browser testing status map
This was wrongly set to the old id.

R=kustermann@google.com

Review URL: https://codereview.chromium.org//16922003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23952 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-13 08:20:55 +00:00
kustermann@google.com 73b8c4adc6 Fixed bug in browser_controller.dart
If a browser crashed on it's own, then the driving page running in it will not
post a result. So the test will eventually time out. The testing server will
then call 'browser.close()' and after the browser was closed, it will start a
new one.

Previously the 'browser.close()' future did not complete in this scenario, since
the '_browserClosed' callback was not set.

Note that with the new browser controller, browser crashes will currently be
reported as timeouts.

R=ricow@google.com

Review URL: https://codereview.chromium.org//16836009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23951 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-13 08:08:34 +00:00
ricow@google.com 96272613d5 Add timing information to browser controller logging.
Review URL: https://codereview.chromium.org//16843009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23950 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-13 06:59:58 +00:00
ricow@google.com ee8ddfd2d4 Add debugging info to browser controller.
R=kustermann@google.com

Review URL: https://codereview.chromium.org//16365017

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23903 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-12 12:54:39 +00:00
ricow@google.com 57838491b2 Remove leftover static varibles for old kill functionality in the browser controller.
R=kustermann@google.com

Review URL: https://codereview.chromium.org//16280010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23898 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-12 09:10:04 +00:00
kustermann@google.com 096eb7ada9 Simplified the killing mechanism in browser_controller.dart
R=ricow@google.com

Review URL: https://codereview.chromium.org//15649021

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23674 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-06 11:12:59 +00:00
kustermann@google.com eda01014b4 Support for running tests in an iframe
R=ricow@google.com

Review URL: https://codereview.chromium.org//16050006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23400 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-30 12:16:22 +00:00
ricow@google.com 88679922c3 Change firefox initialization name
R=kustermann@google.com

Review URL: https://codereview.chromium.org//15963012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23347 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-29 12:33:26 +00:00
ricow@google.com 0b2f1c89f4 Fix comment style to unbreak build
Review URL: https://codereview.chromium.org//16032014

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23345 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-29 12:14:03 +00:00
ricow@google.com 874e82fb90 Add factory constructor to browser controller.
Additionally, fix explicit number of browsers hack.

R=kustermann@google.com

Review URL: https://codereview.chromium.org//15904008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23344 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-29 12:10:50 +00:00
kustermann@google.com 0897a8608a Remove hack for android resources.
We got a v8 mirror in golo now, so we can remove this hack.

R=ricow@google.com

Review URL: https://codereview.chromium.org//16168005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23339 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-29 10:19:15 +00:00
ricow@google.com 13a3ba87c4 Use the Debug log for messages from the browser controller
R=kustermann@google.com

Review URL: https://codereview.chromium.org//15825004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23325 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-29 08:03:07 +00:00
ricow@google.com 21a51ebac2 Fix accidentially added dot in safari web driver
R=kustermann@google.com

Review URL: https://codereview.chromium.org//16026007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23290 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-28 15:54:45 +00:00
ricow@google.com 8d21a80c9d Allow safari to do pop ups on startup
R=kustermann@google.com

Review URL: https://codereview.chromium.org//15782006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23287 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-28 15:37:48 +00:00
ricow@google.com 46f9be8751 Add safari browser controller.
Additionally, fix some bugs in the browser controller discovered while enabling safari.

R=kustermann@google.com

Review URL: https://codereview.chromium.org//16094004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23240 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-28 08:41:09 +00:00
ricow@google.com 0c99661d51 Disable default browser check on firefox.
R=kustermann@google.com

Review URL: https://codereview.chromium.org//15873003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23067 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-23 13:25:30 +00:00
kustermann@google.com 1ac6e80e89 Search for android testing resources in third_party and /tmp
We need this temporary hack until we get a v8 mirror in golo.

R=ricow@google.com

Review URL: https://codereview.chromium.org//15862002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23060 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-23 11:42:02 +00:00
ricow@google.com b01abf0301 Update browser controller and unittest lib to use start marker to figure out when to start new tests (and send back the correct id)
R=kustermann@google.com

Review URL: https://codereview.chromium.org//15742006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23059 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-23 11:06:46 +00:00
kustermann@google.com 2a49e58294 Added support for running dart2js tests on android devices
R=ricow@google.com

Review URL: https://codereview.chromium.org//15567002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23022 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-22 15:34:32 +00:00
ricow@google.com adcf26fcab Add --no-first-run to chrome browser controller
This will disable the pop-up that asks if you want to be default browser

R=kustermann@google.com

Review URL: https://codereview.chromium.org//14629027

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22777 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-16 08:15:50 +00:00
ricow@google.com f175c670d8 Don't check for default browser when starting up chrome in the new browser controller
On a fresh install this is needed to avoid a blocking pop up

Review URL: https://codereview.chromium.org//14643021

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22768 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-16 06:04:40 +00:00