Commit Graph

18116 Commits

Author SHA1 Message Date
kathyw@google.com 2ff7bb2447 One-liners for unittest and matcher.
Also had to give a one-liner to stack_trace, to work around a doc generation issue (dartbug.com/13246).

R=gram@google.com

Review URL: https://codereview.chromium.org//23828006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27398 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-11 19:28:17 +00:00
scheglov@google.com 1d5cdc7941 Triage co19 tests.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//23461046

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27396 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-11 18:32:44 +00:00
mlippautz@google.com 94502c10ea Checks CObject lengths in native API.
Also converts the API to use intptr_t instead of a mixture of int64_t and int. Internally all variable length objects have lengths and maximum values represented as intptr_t (actually Smi ranges). In order to check for these maximum lengths we need to have a common type for 32 and 64 bit platforms.

Helping constructs like IOBuffer can still use 64bit lengths, but have to check that there values are actually in the domain of intptr_t as soon as internal objects are created.

Addresses issue 4314.

BUG=
R=asiva@google.com, sgjesse@google.com

Review URL: https://codereview.chromium.org//23532048

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27395 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-11 16:56:12 +00:00
floitsch@google.com d687d1f410 Add more filters to gitignore.
R=ricow@google.com

Review URL: https://codereview.chromium.org//23658024

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27394 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-11 16:50:19 +00:00
hausner@google.com 43d319c105 Update unresolved name handling with library prefixes
Fixes issue 12913

R=iposva@google.com

Review URL: https://codereview.chromium.org//23480064

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27393 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-11 16:21:25 +00:00
lrn@google.com 18362b2cf4 Revert "Convert HashSet, LinkedHashSet to factory methods and custom implementations."
Triggers an error in html tests on dartium.

Review URL: https://codereview.chromium.org//23451045

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27392 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-11 16:19:45 +00:00
blois@google.com 02852e6fed Removing dart2js main execution warning message
This was a temporary warning to ease migration to the new main() execution time, the transition should be complete now.

BUG=12281
R=ahe@google.com

Review URL: https://codereview.chromium.org//23480066

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27391 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-11 16:18:56 +00:00
mlippautz@google.com 1cf1806f29 Remove unreachable code in mirrors.
The only case where we do not set the name in the constructor is for anonymous
mixin applications.

BUG=
R=asiva@google.com, rmacnak@google.com

Review URL: https://codereview.chromium.org//23531037

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27390 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-11 16:10:43 +00:00
kathyw@google.com bc2a4fae5b Copyedit pass over args library description; fixed some example code
R=mcampione@google.com, rnystrom@google.com

Review URL: https://codereview.chromium.org//23603002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27388 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-11 15:35:01 +00:00
ajohnsen@google.com c6ef82b5c9 Polish the EventHandler cleanup in r26517.
BUG=
R=iposva@google.com, sgjesse@google.com

Review URL: https://codereview.chromium.org//22918023

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27386 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-11 15:31:44 +00:00
ajohnsen@google.com b5e8a83a28 Fix comment for Uri encodeComponent.
BUG=https://code.google.com/p/dart/issues/detail?id=13127
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//24096011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27385 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-11 15:30:19 +00:00
ajohnsen@google.com 1cd800214f Always wait for child processes when forked, even if the process failed.
BUG=
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//23494048

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27384 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-11 14:29:23 +00:00
floitsch@google.com 68a9727c52 Rewrite Futures.
R=lrn@google.com

Committed: https://code.google.com/p/dart/source/detail?r=27375
Reverted: https://code.google.com/p/dart/source/detail?r=27376

Review URL: https://codereview.chromium.org//23926011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27383 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-11 14:00:20 +00:00
ngeoffray@google.com 03b948e409 Re-apply: "Fix http://code.google.com/p/dart/issues/detail?id=13007 by introducing a new Marker value in the SsaValueRangeAnalyzer."
R=kasperl@google.com

Review URL: https://codereview.chromium.org//23669006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27382 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-11 13:33:49 +00:00
ajohnsen@google.com 071c5a1ee8 Accept IPv6 addresses in Uri.http and Uri.https, and correctly nest IPv6 addresses in '[' and ']'.
BUG= http://dartbug.com/13130
BUG= http://dartbug.com/13131
BUG= http://dartbug.com/13132
R=floitsch@google.com, sgjesse@google.com

Review URL: https://codereview.chromium.org//23904004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27381 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-11 13:22:31 +00:00
ajohnsen@google.com 6949a7bd08 Simplify process exit-code handling on Posix, take 2.
As in https://codereview.chromium.org/24024007, except the monitor->Wait
is now called in a loop with a guard, to ensure we actually do get notified.

Also, now correctly exiting the thread if we have no more child
processes, using the initialize/terminate mutex as guard.

BUG=
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//23717038

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27380 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-11 13:05:13 +00:00
johnniwinther@google.com effefe0e10 Create type masks lazily.
R=ngeoffray@google.com

Review URL: https://codereview.chromium.org//23819039

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27379 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-11 12:48:39 +00:00
lrn@google.com c5bb6f7b15 Convert HashSet, LinkedHashSet to factory methods and custom implementations.
R=floitsch@google.com

Review URL: https://codereview.chromium.org//23859008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27378 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-11 12:35:57 +00:00
kmillikin@google.com 94ca56a774 Fix a bug in block reordering/block compaction.
The compiler assumes (a) the graph entry is followed in the block order by
its normal entry, and (b) the normal entry block is non-empty.  There is not
necessarily true, so stop assuming it.

BUG=https://code.google.com/p/dart/issues/detail?id=13101
R=fschneider@google.com

Review URL: https://codereview.chromium.org//23766021

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27377 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-11 12:32:58 +00:00
floitsch@google.com d035cbd825 Revert "Rewrite Futures."
This reverts commit r27375.

Review URL: https://codereview.chromium.org//23967011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27376 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-11 12:16:41 +00:00
floitsch@google.com 42e3d1db85 Rewrite Futures.
R=lrn@google.com

Review URL: https://codereview.chromium.org//23926011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27375 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-11 12:02:37 +00:00
johnmccutchan@google.com bc987abea7 Revert type hierarchy changes
Review URL: https://codereview.chromium.org//23533046

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27374 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-11 11:05:10 +00:00
ricow@google.com 1d61244f5c Also mark worker_api_test as Skip
This is flaking now

R=kustermann@google.com

Review URL: https://codereview.chromium.org//23814009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27373 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-11 10:59:08 +00:00
kustermann@google.com aa3bbdfb09 Fixed status file entry in co19-runtime.status
TBR=ricow@google.com

Review URL: https://codereview.chromium.org//23454025

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27372 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-11 10:38:04 +00:00
johnmccutchan@google.com 4913d3803b Actually disable typed_data_hierarchy_test for dart2js chrome and safari
Review URL: https://codereview.chromium.org//24081003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27371 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-11 09:36:50 +00:00
johnmccutchan@google.com a3409e951b Disable typed_data_hierarchy_test for dart2js chrome and safari
Review URL: https://codereview.chromium.org//23754008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27370 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-11 09:21:56 +00:00
ricow@google.com 0032257d32 Mark standalone/io/file_system_watcher_test as flaky timing out
Filed issue 13228

Review URL: https://codereview.chromium.org//23931003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27369 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-11 09:02:47 +00:00
ricow@google.com 04eaac5e0f Mark notifications_test/supported as flaky on safari
This fails on 10.8, but pass on 10.7.

Filed issue 13210

Review URL: https://codereview.chromium.org//23451043

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27368 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-11 08:25:08 +00:00
ricow@google.com 6671a88835 Mark html/work_test and html/worker_api_test as skip
These tests are leaving stuff that makes the other test fail.

I filed issue 13221 to track this.

R=kustermann@google.com

Review URL: https://codereview.chromium.org//24104002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27367 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-11 08:19:01 +00:00
johnmccutchan@google.com a2c4cf0896 Uint8ClampedList no longer inherits from Uint8List
Review URL: https://codereview.chromium.org//23464052

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27366 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-11 08:06:22 +00:00
aprelev@gmail.com 0bd09c308a Fix dart2js decimal number tokenization. Remove support for 'd'-suffixed double format.
BUG=dartbug.com/13070
R=ahe@google.com

Review URL: https://codereview.chromium.org//23583038

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27364 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-11 01:58:07 +00:00
regis@google.com 6c92ec5439 Simplify VM internal representation of a mixin application clause (MixinAppType
object) by removing some redundant field and type arguments.
Tolerate mixins with wrong number of type arguments and update tests.
Note: this is a first cleanup step in preparation of more mixin bug fixes.

R=hausner@google.com

Review URL: https://codereview.chromium.org//23619026

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27363 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-11 00:41:07 +00:00
zra@google.com e65e9e1564 Better handling of zero in compare and branch for MIPS.
R=regis@google.com

Review URL: https://codereview.chromium.org//23537030

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27362 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-10 23:46:09 +00:00
jmesserly@google.com 68a3655f3e add timeout as an option for polymer/example IE tests
Review URL: https://codereview.chromium.org//24097004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27361 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-10 23:03:10 +00:00
jmesserly@google.com 58700e061f fix pkg.status file for polymer/example/component/news test
Review URL: https://codereview.chromium.org//23903039

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27360 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-10 22:33:52 +00:00
jmesserly@google.com 00c31d8951 mark polymer test failing on safari, ie
BUG=

Review URL: https://codereview.chromium.org//23531038

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27358 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-10 22:08:58 +00:00
nweiz@google.com d62561a2ab Detect transformer dependency cycles in packages using barback transformers.
R=rnystrom@google.com
BUG=

Review URL: https://codereview.chromium.org//23924006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27355 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-10 21:46:21 +00:00
jmesserly@google.com 05705dad2f fix polymer tests -- replace run.sh and run tests using bots
BUG=
R=sigmund@google.com

Review URL: https://codereview.chromium.org//24077003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27353 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-10 21:21:55 +00:00
pquitslund@google.com 07e4dfdb43 Ensure formatted CUs end with a newline (dartbug.com/13188).
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//23458038

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27352 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-10 21:17:21 +00:00
pquitslund@google.com 79f133550d Optional trailing comma support for list and map literals.
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//23451037

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27350 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-10 18:34:05 +00:00
pquitslund@google.com 1d8cee96ee Fix to NOT traverse linked directories when formatting (dartbug.com/13187).
We *may* allow support for this in the future but either way the default (as set here) should be false.

R=brianwilkerson@google.com, kevmoo@j832.com

Review URL: https://codereview.chromium.org//23461044

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27349 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-10 18:32:21 +00:00
iposva@google.com 09a1a3824b - Add missing AddProperty function, which was lost during reformatting.
- Reenable vmservice tests.

Review URL: https://codereview.chromium.org//23781005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27348 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-10 18:11:29 +00:00
iposva@google.com 3d5e47acfc - Disable vmservice/ tests temporarily.
Review URL: https://codereview.chromium.org//23983022

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27347 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-10 17:57:28 +00:00
iposva@google.com 52a736ee38 - Disallow copy constructors.
Review URL: https://codereview.chromium.org//23903034

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27346 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-10 17:47:55 +00:00
iposva@google.com 336183cf6b - Add missing explicit in constructor.
Review URL: https://codereview.chromium.org//24088007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27345 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-10 17:31:37 +00:00
iposva@google.com 74b2a34d5b - Base JSON stream printing on stack objects.
- Simplify creation of a JSONStream.

- Add experimental coverage output to the VM.

R=asiva@google.com, johnmccutchan@google.com

Review URL: https://codereview.chromium.org//23875015

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27344 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-10 17:21:59 +00:00
pquitslund@google.com 8c13dc887a Formatter sanity-checking (via token stream verification).
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//23480055

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27343 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-10 17:10:41 +00:00
kustermann@google.com 5bb79cdda5 Followup CL after co19-roll to r576
TBR=ricow@google.com

Review URL: https://codereview.chromium.org//23515008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27340 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-10 15:55:07 +00:00
hausner@google.com fe9e202f8b Fix debugger expression evaluation for top-level functions
The temporary class that holds the expression to be evaluated
must be marked as finalized.

Added Jacob's closure tests.

Fixes issue 13192.

R=jacobr@google.com

Review URL: https://codereview.chromium.org//23825006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27338 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-10 15:30:52 +00:00
kustermann@google.com 34a42d9c35 Followup CL after co19-roll to r576
R=ricow@google.com

Review URL: https://codereview.chromium.org//24066005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27336 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-10 13:15:00 +00:00