7ff576944f
Don't try to get chrome version on windows.
...
We still make sure that the binary is valid.
Enable the browser controller on windows again
R=kustermann@google.com
Review URL: https://codereview.chromium.org//23815007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27333 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-10 12:29:43 +00:00
1e32f03118
Disable new browser controller on win-chrome
...
test.dart is not able to determine the version of chrome when running
'chrome.exe --version'. This causes an open browser window to hang and
makes the bot timeout.
TBR=ricow@google.com
Review URL: https://codereview.chromium.org//23561005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27245 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-06 12:22:32 +00:00
58b33d70e9
test.py: Bugfix in browser_controller. Make sure we always complete even in case of errors
...
TBR=ricow@google.com
Review URL: https://codereview.chromium.org//24033002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27242 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-06 11:32:34 +00:00
b4b435faab
Add support for chrome on windows to the new browser controller
...
R=kustermann@google.com
Review URL: https://codereview.chromium.org//23625008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27239 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-06 09:45:52 +00:00
175c3f58e1
Add support for firefox on windows to the browser controller
...
R=kustermann@google.com
Review URL: https://codereview.chromium.org//23679006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27235 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-06 08:52:43 +00:00
337880c0d4
fixed TodoMVC tests to include deploying to JS
...
R=kustermann@google.com , sigmund@google.com
Review URL: https://codereview.chromium.org//23678009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27222 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-05 23:00:41 +00:00
f4691ff4fe
Consider tests as flaky if it contains more than one marker (which can occur when running the test)
...
R=ricow@google.com
Review URL: https://codereview.chromium.org//23441045
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27116 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-04 12:03:10 +00:00
ec88776e9a
Add div displaying the currently executing test.
...
This can be useful if the window freezes up with a busy loop
R=kustermann@google.com
Review URL: https://codereview.chromium.org//23506023
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27027 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-03 08:04:26 +00:00
71f3a4df75
Shard based on relative originTestPath
...
R=ricow@google.com
Review URL: https://codereview.chromium.org//23431015
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27017 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-02 17:51:32 +00:00
c0ab51e4d6
Seems like cc/ TestCases don't have a TestInformation object attached
...
R=ricow@google.com
Review URL: https://codereview.chromium.org//23475015
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27015 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-02 14:19:40 +00:00
f6ab02857e
test.py: Fixed incorrect handling of multitest in status files, status file cleanups.
...
R=ricow@google.com
Review URL: https://codereview.chromium.org//23721006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27013 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-02 14:04:59 +00:00
b0889233cd
test.py: Print the warning about left-over dirs only for directories created using Directory.createTemp()
...
R=ricow@google.com
Review URL: https://codereview.chromium.org//23714002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27003 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-02 09:29:12 +00:00
7a091dcfca
Turn on Polymer TodoMVC tests on Dart buildbots
...
The biggest changes are to the examples, but there's a small tweak to test_suite.dart as well, so it can load the HTML files.
For now, we only test the development loop (content_shell+Dart VM). I'm working on changes to enable us to test the deploy story with dart2js.
R=kustermann@google.com , sigmund@google.com
Review URL: https://codereview.chromium.org//23539003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26943 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-30 21:09:06 +00:00
59c486d34c
Fixed type error in browser_controller: DebugLogger.error() takes a string
...
TBR=ricow@google.com
Review URL: https://codereview.chromium.org//23618020
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26936 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-30 19:15:03 +00:00
4d7311f14b
Remove Timeout entries in status files for ie9/ie10
...
After reducing the load on our IE builders, we hopefully no longer see these
random timeouts.
R=ahe@google.com
Review URL: https://codereview.chromium.org//23604010
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26912 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-30 13:39:05 +00:00
7ddb5bb8ad
test.py: Report info about how long it took until a browser tests started if it times out
...
R=ahe@google.com
Review URL: https://codereview.chromium.org//23522009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26910 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-30 12:55:27 +00:00
1887b5ca49
Some more removals of dart:utf.
...
R=jmesserly@google.com , lrn@google.com , nweiz@google.com
Review URL: https://codereview.chromium.org//22909059
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26712 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-27 13:18:34 +00:00
45c42e08f2
Update checked-in binary to 0.6.21.3_r26639 (M6)
...
R=ricow@google.com
Review URL: https://codereview.chromium.org//23568002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26704 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-27 11:16:37 +00:00
013ac3b1d1
Reland "Enable running multitests in browsers""
...
R=ricow@google.com
Review URL: https://codereview.chromium.org//23545003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26695 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-27 09:12:05 +00:00
807685dcaa
Revert "Enable running multitests in browsers"
...
R=ricow@google.com
Review URL: https://codereview.chromium.org//23201019
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26648 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-26 14:20:57 +00:00
6844e23211
Enable running multitests in browsers
...
R=ricow@google.com
Review URL: https://codereview.chromium.org//23427002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26641 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-26 12:12:41 +00:00
5afecf5f67
Changes to how we handle fancy stacks:
...
- in the base config they are disabled
- in htmnl config they are enabled unless a certain meta tag is present in the
page.
- in vm config they are enabled unless a --no-fancy-stacks flag is in the
Options.
The test runner adds a fancy_stacks flag that can be used to control this
behavior, but by default turns off fancy stacks for all tests.
There were a couple of test runner tests that were affected and have kludgy
fixes where I strip out the new argument from Options first.
This has passed a baseline set of tests; I'm still running a more comprehensive
set.
R=kustermann@google.com , nweiz@google.com
Review URL: https://codereview.chromium.org//22859009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26560 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-22 21:47:51 +00:00
fbe8335669
Catch race condition where we are shutting down a browser and that browser is sending back results.
...
R=kustermann@google.com
Review URL: https://codereview.chromium.org//23005022
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26532 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-22 16:30:56 +00:00
db24c54987
Cleanup of isolate.status (first step)
...
R=ricow@google.com
BUG=
Review URL: https://codereview.chromium.org//23368003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26506 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-22 07:35:25 +00:00
13f0f94448
Find issue number from comment in status file.
...
R=kustermann@google.com
BUG=
Review URL: https://codereview.chromium.org//23172010
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26360 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-20 15:01:00 +00:00
f9df206e2e
Report compile-time errors for conflicting overrides as specified by latest
...
language spec (fix issue 12342).
Add override conflict tests.
Update status files.
Add support for 'ok' status in multi-tests.
R=hausner@google.com
Review URL: https://codereview.chromium.org//22999022
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26302 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-16 23:39:41 +00:00
3d0ace5885
Re-try of Tightening up dart2js load timing.
...
This is a fixup of https://codereview.chromium.org/22488002/ , first patch is the original, subsequent the fixes.
BUG=
R=ahe@google.com , vsm@google.com
Review URL: https://codereview.chromium.org//23121004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26244 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-15 23:57:07 +00:00
653c15bf55
Revert revision 26149.
...
This is causing IE bots to fail
R=ahe@google.com , kustermann@google.com
Review URL: https://codereview.chromium.org//23201005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26186 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-15 11:19:11 +00:00
daf090e7b3
Tightening up dart2js load timing.
...
The timing of main() execution in dart2js currently occurs after 'loaded' which is quite late in the page load phase (after all images) and is inconsistent with Dartium.
In order to get the timing more consistent with Dartium and more consistent in general this CL makes a couple of changes:
- dart2js generated code is now executed synchronously- this gives end developers more control over timing of main().
- A warning is generated if main() is executed during document parse time- this is primarily to ease the transition and let users know what needs to be done to more closely match Dartium behavior.
- dart.js bootstrapper no longer waits for DOMContentLoaded- the modified script tags will be executed after parse phase, the additional delay should not be necessary.
Breaking changes:
- dart2js main() execution in standard project templates now occurs after document parse but before all assets have been loaded
- Script tags directly referencing dart.js files will now execute synchronously. It's recommended that defer tags be added to these, or that they be moved to the end of the body tag.
- dart.js bootstrapper will now only auto-load script tags which occur before it on the page.
BUG=4718
R=sra@google.com , vsm@google.com
Review URL: https://codereview.chromium.org//22488002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26149 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-14 20:51:45 +00:00
73826dc6bf
Add support for ie in the browser controller
...
Also, add no caching headers (since IE will cache the task that it gets)
R=kustermann@google.com
Review URL: https://codereview.chromium.org//22420002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26112 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-14 11:30:48 +00:00
8ffef7528d
Bug fix and status file updates for MIPS HW.
...
R=regis@google.com
Review URL: https://codereview.chromium.org//22828004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26037 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-12 21:45:41 +00:00
e2dbbb540a
test.py: Reduce the number of times we retry commands before showing them as failed.
...
R=ricow@google.com
Review URL: https://codereview.chromium.org//22817002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25997 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-12 10:57:07 +00:00
0328d6686f
test.py In case we don't have any TestCases, don't block
...
R=ricow@google.com
Review URL: https://codereview.chromium.org//22322007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25921 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-08 11:17:54 +00:00
4b509345a5
Fix exitcode handling from analyzer running in nobatch mode.
...
R=kustermann@google.com
Review URL: https://codereview.chromium.org//22574002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25871 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-07 12:28:54 +00:00
5d2f423339
test.py: Fix in CommandQueue to make sure we finish up correctly if an intermediate command failed
...
R=ricow@google.com
Review URL: https://codereview.chromium.org//22326004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25870 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-07 12:20:35 +00:00
70a1cbf5c9
test.py: Use different path to dartanalyzer on windows
...
R=ricow@google.com
Review URL: https://codereview.chromium.org//22303003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25869 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-07 11:12:33 +00:00
25041cc9f8
Add dependent commands at the front of the run queue to make the progress indicator more linear.
...
We currently add everything at the end of the queue, i.e., we will run all compilation comands before we run them on the browser/d8.
R=kustermann@google.com
Review URL: https://codereview.chromium.org//22387002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25808 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-06 08:34:25 +00:00
34c06045eb
Do not rely on the exit code of browser to determine if the *command* was successful
...
R=ricow@google.com
Review URL: https://codereview.chromium.org//22174002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25764 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-05 10:30:04 +00:00
8cecc4b627
Check if we're done after the dependency graph was sealed
...
R=ricow@google.com
Review URL: https://codereview.chromium.org//22160002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25763 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-05 09:17:12 +00:00
92303dffda
test.py: First step towards support of caching dart2js compilations across runtimes
...
This CL changes the way we run tests completely: When enqueueing TestCases we
build up a dependency graph of Commands. This has the advantage that if more
TestCases share common commands, we only execute it once.
R=ricow@google.com
Review URL: https://codereview.chromium.org//21001003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25760 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-05 07:54:17 +00:00
cb18d8ba87
Removed compiler/ directory from repository
...
R=ricow@google.com
Review URL: https://codereview.chromium.org//20722006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25728 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-02 08:31:15 +00:00
76ce98c89b
Disable javascript time limit on firefox
...
This is an attempt to disable the script time limit on firefox, since some tests
are timing out.
TBR=ricow@google.com
Review URL: https://codereview.chromium.org//21091002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25569 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-29 16:06:17 +00:00
7861a23db8
Add support for passing in vm options to the testing script.
...
R=kustermann@google.com
Review URL: https://codereview.chromium.org//19483008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25407 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-24 12:23:06 +00:00
4fd637523f
test.py: Add 'Cache-Control' header to http responses: enable browsers to cache resources
...
BUG=http://dartbug.com/10697
R=ahe@google.com
Review URL: https://codereview.chromium.org//19486005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25265 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-22 11:52:50 +00:00
a5cd38ed41
Bugfix in multitest.dart: Make sure we copy imported files to the generated_tests directory
...
The regular expression was no longer valid after import statements have changed.
Furthermore the guard against cyclic imports was not working because of missing
hashCode/operator== on the Path class.
R=ricow@google.com
Review URL: https://codereview.chromium.org//19774003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25155 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-18 17:11:37 +00:00
03f7b209b2
test.py: Report timings by adding up the time of all commands
...
BUT=http://dartbug.com/11847
R=ahe@google.com
Review URL: https://codereview.chromium.org//19388002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25096 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-17 13:15:22 +00:00
41d8e6ee39
Test running changes.
...
1. Change in the test runner to consider any warning as warning.
After this following was required:
2. Triage language tests.
3. Triage co19 tests.
R=brianwilkerson@google.com , kustermann@google.com
BUG=
Review URL: https://codereview.chromium.org//18174010
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25069 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-16 20:35:51 +00:00
e7de55b945
Revert "When using content_shell to run tests, run them with '--single-process'"
...
This reverts r24840.
r24840 revealed quite a few issues. Unfortunatly it seems like we cannot run all
tests in single-process mode. In particular indexeddb tests are timing out. The
issue seems to be this chromium bug:
https://code.google.com/p/chromium/issues/detail?id=229684
Review URL: https://codereview.chromium.org//18104008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24846 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-09 15:34:59 +00:00
1a0def6a46
When using content_shell to run tests, run them with '--single-process'
...
It seems that the exit code of the renderer process is not correctly propagated
to content_shell (at least on windows). By passing the '--single-process' flag
to content_shell, we ensure that we can detect renderer crashes.
R=whesse@google.com
Review URL: https://codereview.chromium.org//18826010
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24840 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-09 12:33:03 +00:00
58c6fd4e23
Allow re-running of failing tests on drt-windows
...
Our windows dartium builders are currently flaky. The reasons seems to be that
content_shell.exe is sometimes not able to fetch resources from the HttpServer.
This CL makes sure we try to re-run failing tests on drt-windows. This will
hopefully make the builder less flaky and will buy us some time to figure out
what the exact issue is.
The default number of retries before we give up is 2.
TBR=ricow@google.com
Review URL: https://codereview.chromium.org//18144012
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24785 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-05 13:05:19 +00:00
ricow@google.com