9dd81d94a7
Fixing up DOM constructors.
...
This is a continuation of https://codereview.chromium.org/17063007/
Basically I changed it so factory constructors are only added if the class derives from a native type. Otherwise the native type now extends Interceptor.
BUG=
R=sra@google.com
Review URL: https://codereview.chromium.org//18054021
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24619 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-29 00:14:23 +00:00
6b44f65407
Revert "Making all DOM types abstract and removing superfluous Dartium constructors."
...
This reverts commit http://code.google.com/p/dart/source/detail?r=24241 .
Compiler error, not sure of best fix.
BUG=
Review URL: https://codereview.chromium.org//17508002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24245 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-20 19:37:47 +00:00
c3547d4e9b
Making all DOM types abstract and removing superfluous Dartium constructors.
...
Adding factory constructors to all classes to suppress missing generative constructor warnings.
Adding a throw to Dartium's base DOM class to prevent construction of native objects.
This also includes the changes necessary to make all DOM types abstract, but I'm running into a dart2js issue which is preventing that.
BUG=
R=vsm@google.com
Review URL: https://codereview.chromium.org//17063007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24241 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-20 17:31:36 +00:00
797769e39f
Fixing SelectElement.options, adding support for optgroup.
...
BUG=8115
R=efortuna@google.com
Review URL: https://codereview.chromium.org//16409002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23652 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-05 19:45:36 +00:00
59c2920a7f
This is a resubmit of:
...
https://codereview.chromium.org/13852008/
There were some type issues in Dartium checked mode on collections which caused problems. Basically just tweaked the generic arguments on some collections.
BUG=
R=sra@google.com
Review URL: https://codereview.chromium.org//13963020
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22087 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-26 21:10:49 +00:00
349cd9eae0
Add unmodifiable list view.
...
Avoid using list.take(list.length), which no longer gives a list.
Review URL: https://codereview.chromium.org//12259045
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18572 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-15 12:42:27 +00:00
de9fbf0e90
Renaming dart:html library from 'html' to 'dart.html'
...
This should be invisible to end users, but basically brings dart:html in-line with the core libraries.
BUG=
Review URL: https://codereview.chromium.org//12061008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17929 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-31 17:25:55 +00:00
383dce1b4e
Remove collection-dev from the html and js-helper library.
...
Review URL: https://codereview.chromium.org//11859037
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17358 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-21 14:41:30 +00:00
049efc4fe8
Fixing cleanup of dart:html annotation generation.
...
This is an update of https://codereview.chromium.org/11968047/
BUG=
Review URL: https://codereview.chromium.org//12024002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17323 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-18 22:11:21 +00:00
bda6df30df
Revert "Fixing formatting of dart:html's dart2js annotations."
...
This reverts commit 11508.
BUG=
Review URL: https://codereview.chromium.org//11962049
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17239 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-17 22:16:31 +00:00
b6f3ecaa2c
Fixing formatting of dart:html's dart2js annotations.
...
Also unifying formatting of attributes.
BUG=7808
Review URL: https://codereview.chromium.org//11968047
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17238 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-17 22:12:36 +00:00
038af964dc
Changed @domName annotation in comment to full fledge @DomName annotation.
...
Review URL: https://codereview.chromium.org//11887006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17154 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-16 19:01:07 +00:00
a014168309
Type check fixes for Dartium tests.
...
Note: I'm seeing the following in checked mode:
FAIL Expectation: queryAll-where. Caught type 'WhereIterable<Element>' is not a subtype of type 'Iterable<CanvasElement>' of 'canvases'.
I only fixed what's necessary to get the tests green (I hope), but
perhaps other allocation sites should be fixed to remove the generic.
Review URL: https://codereview.chromium.org//11788023
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16773 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-08 00:40:18 +00:00
247816a253
Fixing SelectElement.options to return a read-only list.
...
This got lost in the new collections change.
BUG=
Review URL: https://codereview.chromium.org//11783017
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16753 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-07 21:45:01 +00:00
4a7dfd2da3
Big merge from experimental to bleeding edge.
...
Review URL: https://codereview.chromium.org//11783009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16687 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-07 11:23:16 +00:00
01fb2bbc86
Moved most of html lib generating scripts into tools.
...
BUG=
Review URL: https://codereview.chromium.org//11691009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16557 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-28 22:26:48 +00:00
blois@google.com