b904bf81ba
Revert "Revert "Tag extensions""
...
Original CL is the first patch, changes follow. Includes fixes for Chrome test failures and Firefox type check issues.
BUG=
R=jmesserly@google.com
Review URL: https://codereview.chromium.org//23442011
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27313 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-09 22:03:43 +00:00
dbf675d60d
Adding conversion support for JSON XHR requests.
...
This has been a half-supported feature for Chrome for a while, but popular elsewhere. Appears that recent Dartium behavior broke, so adding a test, but still need to fix Dartium.
BUG=13069
R=efortuna@google.com
Review URL: https://codereview.chromium.org//23454012
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27215 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-05 22:02:22 +00:00
9f52a2969c
Added back childNodes and getAttribute and setAttribute.
...
This is a quick check to verify that it was this CL:
https://codereview.chromium.org/23189014/ was the cause of the performance
regression. If it is, I have some ideas of potential performance improvements
going forward that we should investigate, and I'll also investigate why I wasn't
getting this performance behavior on my machine locally. Either way, expect at
least one additional change on these APIs going forward.
BUG=
R=blois@google.com
Review URL: https://codereview.chromium.org//23808005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27139 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-04 19:34:39 +00:00
013e3bb062
Dart binding changes to along with Blink merge 155942-156717
...
BUG=
R=blois@google.com
Review URL: https://codereview.chromium.org//23829002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26948 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-30 21:24:02 +00:00
6570db562c
Revert "Basic functionality is working with JS native support and polyfill, still some issues with dart2js typechecking."
...
This reverts commit r26935. Failing in FF checked on type extension and IE9 on synchronous constructor upgrading, need to investigate.
TBR
BUG=
Review URL: https://codereview.chromium.org//23567006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26938 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-30 19:37:23 +00:00
5607d75eca
Basic functionality is working with JS native support and polyfill, still some issues with dart2js typechecking.
...
BUG=
R=jmesserly@google.com
Review URL: https://codereview.chromium.org//23190026
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26935 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-30 19:08:19 +00:00
47dcd084f3
Removing more dom_ methods (dom_getAttribute and dom_setAttribute.).
...
BUG=
R=blois@google.com
Review URL: https://codereview.chromium.org//23189014
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26928 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-30 17:18:40 +00:00
205058d856
Adding an easy way to allow inline style attributes through sanitization
...
BUG=
R=sigmund@google.com
Review URL: https://codereview.chromium.org//23793004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26899 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-30 01:05:30 +00:00
694f960486
Adding warning message when HTML contents get sanitized away.
...
BUG=
R=jmesserly@google.com
Review URL: https://codereview.chromium.org//23511007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26807 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-28 18:05:18 +00:00
74da0c7286
Remove usage of dart:json.
...
R=jmesserly@google.com , lrn@google.com , nweiz@google.com , rnystrom@google.com
Review URL: https://codereview.chromium.org//23596007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26789 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-28 14:05:11 +00:00
b576296c39
Fix for IE9 html/htmlcollection test with Safe HTML
...
Issue is that IE9 uses uppercase attribute name when it's a boolean attribute, so was getting stripped.
BUG=
Review URL: https://codereview.chromium.org//23661002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26759 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-28 01:33:57 +00:00
93c361dd36
This is an updated version of https://codereview.chromium.org/16374007/
...
Original submission is the first patch, fixes are the second.
There were two issues with the original-
- Issue with URI sanitization where relative URIs on IE were being dropped.
- Analyzer issue on missing members for CustomElement.
BUG=
R=jmesserly@google.com
Review URL: https://codereview.chromium.org//23525003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26757 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-28 01:03:01 +00:00
a85f2a8d4c
Changing onCreated callback to created.
...
Brings it in-line with the browser's createdCallback and Polymer's created. Avoid conflict with event names.
Dartium changes are https://codereview.chromium.org/23494005
BUG=
R=jacobr@google.com
Review URL: https://codereview.chromium.org//23451006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26754 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-27 23:51:42 +00:00
24e9f22c90
Revert "First rev of Safe DOM"
...
This reverts commit 26681.
Some IE issues with URL validation that I need to investigate further.
BUG=
Review URL: https://codereview.chromium.org//23523002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26682 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-27 02:18:48 +00:00
63ecf1a3fd
First rev of Safe DOM
...
BUG=
R=jacobr@google.com , jmesserly@google.com
Review URL: https://codereview.chromium.org//16374007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26681 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-27 01:48:13 +00:00
90873051ad
Making almost all dom_ methods private. Exceptions will be addressed in a later CL.
...
Current ones that still remain to be made private include createElement(NS),
createRange, all the Element properties, and childNodes.
BUG=
R=blois@google.com
Review URL: https://codereview.chromium.org//23055008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26605 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-23 18:25:40 +00:00
f1f2431bef
Platform.upgradeCustomElements for Dartium
...
Using this as a workaround for 12642.
R=blois@google.com
Review URL: https://codereview.chromium.org//22891020
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26602 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-23 16:12:08 +00:00
89b8d13fb6
Support for type extensions in Dartium (part 1)
...
R=blois@google.com
Review URL: https://codereview.chromium.org//22859033
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26458 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-21 19:30:28 +00:00
ec11e52f62
Revert "Revert "Adding polyfill support for custom elements.""
...
This fixes the issues in the custom elements polyfills.
R=jmesserly@google.com
Review URL: https://codereview.chromium.org//23301012
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26412 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-21 00:08:46 +00:00
508affefed
Revert "Adding polyfill support for custom elements."
...
Caused issues with DocumentFragment and some lingering changes from the blink roll.
BUG=
Review URL: https://codereview.chromium.org//22957010
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26410 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-20 23:28:22 +00:00
72651260aa
Adding polyfill support for custom elements.
...
BUG=
R=jmesserly@google.com
Review URL: https://codereview.chromium.org//22967006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26405 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-20 22:56:08 +00:00
178afc3105
because Kasper cares
...
R=kasperl@google.com
Review URL: https://codereview.chromium.org//22904004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26286 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-16 18:04:48 +00:00
3a17d47e58
Modify custom elements to inherit from HtmlElement
...
R=blois@google.com
Review URL: https://codereview.chromium.org//23189009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26275 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-16 15:24:32 +00:00
5aa944301a
Update dart:chrome to include fileSystem, and update summary docs.
...
The dart:chrome library already includes the file system module but
this wasn't included properly at the top level of the API object,
making it unavailable.
The documentation from the generator included in the API has also
been updated.
BUG=None
R=blois@google.com , kathyw@google.com
Review URL: https://codereview.chromium.org//23202004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26241 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-15 23:27:37 +00:00
1ffafc705d
Additional code to https://codereview.chromium.org/15026006
...
to enable user classes extending DOM classes to be registered.
Review URL: https://codereview.chromium.org//22642002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26221 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-15 21:18:07 +00:00
4d51b41ff8
Initial Dartium custom element support
...
This will need to be rebased with Stephen's CL or vice versa. The test mod is taken from his CL.
R=blois@google.com
Review URL: https://codereview.chromium.org//22912004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26141 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-14 19:47:07 +00:00
1685a782e5
Fix KeyEvent keyIdentifier is unsupported error message.
...
BUG=
R=blois@google.com
Review URL: https://codereview.chromium.org//22766002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25989 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-09 23:25:48 +00:00
3304c64b52
Make includeAncestors match a separate method.
...
BUG=
R=blois@google.com
Review URL: https://codereview.chromium.org//22305005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25979 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-09 20:41:48 +00:00
8963a49505
Event delegation
...
Fix for https://code.google.com/p/dart/issues/detail?id=6270
BUG=
R=blois@google.com , jmesserly@google.com
Review URL: https://codereview.chromium.org//21607003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25969 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-09 17:37:32 +00:00
0da2ef2fe9
Add method to html_dartium utils to check for NSM errors
...
BUG=
R=vsm@google.com
Review URL: https://codereview.chromium.org//21676003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25741 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-02 20:06:58 +00:00
b10d8f0736
Add magnitude getter to Point.
...
BUG=
R=blois@google.com
Review URL: https://codereview.chromium.org//21619004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25724 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-01 22:48:19 +00:00
992776552a
Fixes for Blink roll.
...
TBR=jacobr@google.com ,asiva@google.com
Review URL: https://codereview.chromium.org//19820007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25395 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-24 04:46:29 +00:00
ffd476be53
Reapply Box Model convenience classes
...
BUG=
R=jmesserly@google.com
Review URL: https://codereview.chromium.org//19786005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25235 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-19 19:46:36 +00:00
73429941fe
Reverting 25196, 25195, 25192.
...
BUG=
Review URL: https://codereview.chromium.org//19520019
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25197 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-19 02:02:06 +00:00
6d09432cb6
Added part of to Dimension class.
...
BUG=
Review URL: https://codereview.chromium.org//19713009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25195 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-19 01:08:28 +00:00
ef1cb88f26
Provide cross-browser Rects for box model dimensions for Elements.
...
Also added Dimensions class to reduce dealing with Strings for CSS.
BUG=
R=jmesserly@google.com
Review URL: https://codereview.chromium.org//15507007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25192 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-19 00:40:52 +00:00
1fdd1a34b2
Utility methods used for dartium debugger integration.
...
In addition, added back two DOM methods required by the chrome dev tools that had been removed from dart:html
I'm not thrilled about adding back className but the devtools use className in 495 places so figuring out which places are actually talking about classNames of inspected objects and which ones are just internal uses of className inside the devtools would be a pain.
As the browser has a String "class" attribute I do think it is natural to provide at least a read only className in addition to classes.
This changes goes along with the larger CL
https://codereview.chromium.org/18169002/
which I will be sending out for general review in a little bit.
BUG=
R=blois@google.com
Review URL: https://codereview.chromium.org//18125007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25032 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-15 22:57:04 +00:00
4fe143407c
Update dart:chrome APIs and include chrome.fileSystem
...
chrome.fileSystem is needed to do integration testing.
BUG=None
R=blois@google.com
Review URL: https://codereview.chromium.org//19090002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24988 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-15 01:09:52 +00:00
7c20ac6514
Added boolean to toggle.
...
BUG=
R=blois@google.com
Review URL: https://codereview.chromium.org//18583004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24938 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-12 02:00:38 +00:00
1315656027
Make asBroadcastStream take two callbacks.
...
These callbacks will be called when the broadcast stream no longer
has any listeners, or when it gets a listener after having none.
The callback is provided with a StreamSubscription-like object where
it can pause/resume/cancel the underlying subscription on the original
stream.
BUG=http://dartbug.com/11289
R=floitsch@google.com
Review URL: https://codereview.chromium.org//17490002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24776 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-04 13:02:02 +00:00
b515c8e2aa
Fix error.
...
Review URL: https://codereview.chromium.org//18528002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24682 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-02 12:45:49 +00:00
93f70b1125
correct syntax error.
...
Review URL: https://codereview.chromium.org//18526002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24679 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-02 12:20:46 +00:00
01251efd5e
Add isActive field on Timer.
...
BUG= http://dartbug.com/10010
R=floitsch@google.com
Review URL: https://codereview.chromium.org//18325006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24678 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-02 12:01:11 +00:00
7c12f9ea0f
Fixing analyzer warnings on overloading == but not get hashCode.
...
BUG=11613
R=sra@google.com
Review URL: https://codereview.chromium.org//18034021
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24614 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-28 22:36:50 +00:00
f191d0d4de
Fixing DateTime values in serialized script values.
...
This allows Dart's DateTime objects to be passed as serialized script values. Especially useful for DB values.
BUG=11449
R=sra@google.com
Review URL: https://codereview.chromium.org//17574008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24608 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-28 20:55:23 +00:00
d6b9207588
Reorganize mdv and observe functionality
...
* keep correct dart:html APIs
* move implementation into package:mdv and package:observe
* remove dart:mdv_observe_impl
* remove getValueWorkaround/setValueWorkaround from package:observe
R=blois@google.com , floitsch@google.com , justinfagnani@google.com
Review URL: https://codereview.chromium.org//17552019
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24498 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-26 23:25:47 +00:00
edf30f6b20
Exposing Node.firstChild and Node.lastChild.
...
These are the most efficient way access children and are very commonly used.
BUG=
R=jmesserly@google.com
Review URL: https://codereview.chromium.org//17909002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24476 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-26 16:53:50 +00:00
48b1656690
Allow Object when doing lookups.
...
According to our typing rules a Set<Apple> is a Set<Fruit>. However, before this change, we couldn't use it as a Set<Fruit>:
===
bool foo(Set<Fruit> fruits) {
// Would yield a type-error since we actually got a Set<Apple>.
return fruits.contains(new Banana());
}
foo(new Set<Apple>());
===
R=ajohnsen@google.com , blois@google.com , lrn@google.com
Review URL: https://codereview.chromium.org//14246008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24326 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-24 12:45:10 +00:00
66398e12b5
Move PathObserver to mdv_observe package
...
(Since it doesn't actually depend on dart:html, didn't seem the right place for it)
R=blois@google.com
Review URL: https://codereview.chromium.org//17434008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24166 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-19 02:21:54 +00:00
6632a3d8ed
Fixed an incorrect doc reference.
...
R=efortuna@google.com
Review URL: https://codereview.chromium.org//15995029
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23767 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-07 19:51:53 +00:00
blois@google.com