Commit Graph

378 Commits

Author SHA1 Message Date
blois@google.com 647d73af0f Fix for CSS URIs not parsing correctly with innerHTML
Chrome has a bug (https://code.google.com/p/chromium/issues/detail?id=229142) where CSS URIs are not converting correctly when an element is parsed in one document then moved to another document. This uses a base element to set the baseURI of the parse document so it doesn't need to be converted on clone.

BUG=13147
R=jmesserly@google.com

Review URL: https://codereview.chromium.org//23903020

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27305 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-09 19:06:27 +00:00
asiva@google.com 4d8651f8af 1. Make direct calls to _nativeIndexedGetter in "get last" "get first" "get single" instead of calling the "[]" operator. This avoids one additional native call to the length method for each call to "last" "first" or "single"
2. Fix templateloader to deal with nested 'if' conditions

R=vsm@google.com

Review URL: https://codereview.chromium.org//23534050

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27270 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-06 23:22:31 +00:00
blois@google.com dbf675d60d Adding conversion support for JSON XHR requests.
This has been a half-supported feature for Chrome for a while, but popular elsewhere. Appears that recent Dartium behavior broke, so adding a test, but still need to fix Dartium.

BUG=13069
R=efortuna@google.com

Review URL: https://codereview.chromium.org//23454012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27215 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-05 22:02:22 +00:00
blois@google.com 871fbc9189 Fixing Element.shadowRoot to work with webkitShadowRoot
Chrome 31 changed it to shadowRoot, need to support the prefixed version as well.

BUG=13061
R=jacobr@google.com

Review URL: https://codereview.chromium.org//23576013

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27203 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-05 17:47:37 +00:00
blois@google.com afd3921b76 Fixing JS size regression from Blink roll.
BUG=
R=jacobr@google.com, sra@google.com

Review URL: https://codereview.chromium.org//23481010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27163 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-04 22:37:48 +00:00
efortuna@google.com 9f52a2969c Added back childNodes and getAttribute and setAttribute.
This is a quick check to verify that it was this CL:
https://codereview.chromium.org/23189014/ was the cause of the performance
regression. If it is, I have some ideas of potential performance improvements
going forward that we should investigate, and I'll also investigate why I wasn't
getting this performance behavior on my machine locally. Either way, expect at
least one additional change on these APIs going forward.

BUG=
R=blois@google.com

Review URL: https://codereview.chromium.org//23808005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27139 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-04 19:34:39 +00:00
blois@google.com b14e379d94 Cleaning up a bunch of DOM generation tables
Many unused keys and missing events, etc.

BUG=
R=efortuna@google.com, jacobr@google.com

Review URL: https://codereview.chromium.org//23889005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27137 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-04 18:30:54 +00:00
jacobr@google.com 013e3bb062 Dart binding changes to along with Blink merge 155942-156717
BUG=
R=blois@google.com

Review URL: https://codereview.chromium.org//23829002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26948 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-30 21:24:02 +00:00
blois@google.com 8fe0dd796d Fixing mouse clicks on IE11 Preview
The previous fix works for RTM but not the current version.

TBR
BUG=

Review URL: https://codereview.chromium.org//23483025

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26937 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-30 19:27:38 +00:00
efortuna@google.com 47dcd084f3 Removing more dom_ methods (dom_getAttribute and dom_setAttribute.).
BUG=
R=blois@google.com

Review URL: https://codereview.chromium.org//23189014

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26928 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-30 17:18:40 +00:00
ngeoffray@google.com 944aca6de7 HTML types that don't have [] do not implement JavaScriptIndexingBehavior, that is, the items cannot be accessed through [] in JavaScript.
R=kustermann@google.com

Review URL: https://codereview.chromium.org//23499007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26911 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-30 13:27:27 +00:00
blois@google.com 5eade2a0e6 Fixing mouse events on IE11.
IE11 is passing PointerEvents in place of MouseEvents.

BUG=12744
R=sra@google.com

Review URL: https://codereview.chromium.org//23479008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26890 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-29 19:52:21 +00:00
blois@google.com 87e39090a1 Exposing native doubles as doubles when they are read-only or method return values.
This keeps num for parameters of operations and fields which are settable. Requested because some DOM APIs (such as Performance.now) don't really make sense returning ints.

BUG=11133
R=vsm@google.com

Review URL: https://codereview.chromium.org//21555003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26817 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-28 21:07:13 +00:00
blois@google.com 93c361dd36 This is an updated version of https://codereview.chromium.org/16374007/
Original submission is the first patch, fixes are the second.

There were two issues with the original-
  - Issue with URI sanitization where relative URIs on IE were being dropped.
  - Analyzer issue on missing members for CustomElement.

BUG=
R=jmesserly@google.com

Review URL: https://codereview.chromium.org//23525003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26757 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-28 01:03:01 +00:00
blois@google.com 24e9f22c90 Revert "First rev of Safe DOM"
This reverts commit 26681.

Some IE issues with URL validation that I need to investigate further.

BUG=

Review URL: https://codereview.chromium.org//23523002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26682 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-27 02:18:48 +00:00
blois@google.com 63ecf1a3fd First rev of Safe DOM
BUG=
R=jacobr@google.com, jmesserly@google.com

Review URL: https://codereview.chromium.org//16374007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26681 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-27 01:48:13 +00:00
efortuna@google.com 90873051ad Making almost all dom_ methods private. Exceptions will be addressed in a later CL.
Current ones that still remain to be made private include createElement(NS),
createRange, all the Element properties, and childNodes.

BUG=
R=blois@google.com

Review URL: https://codereview.chromium.org//23055008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26605 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-23 18:25:40 +00:00
asiva@google.com 4f6536ba66 Use new Dart API functions
Dart_GetNativeIntegerArgument
Dart_GetNativeBooleanArgument
Dart_GetNativeDoubleArgument

R=vsm@google.com

Review URL: https://codereview.chromium.org//22859038

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26500 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-22 01:15:58 +00:00
blois@google.com 0820807ae6 Fixing dart2js codesize regression from blink roll.
New ErrorEvent.error was pulling in everything.

BUG=
R=sra@google.com

Review URL: https://codereview.chromium.org//22986022

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26468 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-21 20:27:54 +00:00
blois@google.com ec11e52f62 Revert "Revert "Adding polyfill support for custom elements.""
This fixes the issues in the custom elements polyfills.

R=jmesserly@google.com

Review URL: https://codereview.chromium.org//23301012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26412 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-21 00:08:46 +00:00
blois@google.com 508affefed Revert "Adding polyfill support for custom elements."
Caused issues with DocumentFragment and some lingering changes from the blink roll.

BUG=

Review URL: https://codereview.chromium.org//22957010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26410 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-20 23:28:22 +00:00
blois@google.com 72651260aa Adding polyfill support for custom elements.
BUG=
R=jmesserly@google.com

Review URL: https://codereview.chromium.org//22967006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26405 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-20 22:56:08 +00:00
vsm@google.com 69bea8b4e8 Suppress getPresentationAttribute
Should fix analyzer bot.

TBR=jacobr@google.com,blois@google.com

Review URL: https://codereview.chromium.org//23004006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26364 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-20 16:19:05 +00:00
jacobr@google.com 339b0bdd70 Attempt to land Dartium roll a second time.
BUG=

Review URL: https://codereview.chromium.org//23064024

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26363 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-20 15:54:49 +00:00
jacobr@google.com c6ebe4e4e0 rollback problem blink merge cl
Review URL: https://codereview.chromium.org//23163010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26339 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-20 06:22:24 +00:00
jacobr@google.com 785c8416bc Changes required for Dartium roll
Merge checkpoint. Everything compiles.

BUG=

Review URL: https://codereview.chromium.org//22886009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26335 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-20 01:50:17 +00:00
asiva@google.com 24c3ca0b47 Fix for issue 12489.
R=vsm@google.com

Review URL: https://codereview.chromium.org//23295016

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26327 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-19 20:44:33 +00:00
vsm@google.com 7c85f03cc9 Move _HTMLElement to HtmlElement
The old HtmlElement is now HtmlHtmlElement.  The custom tests don't break for now.  I'll modify them in a separate CL to inherit from HtmlElement instead.

R=blois@google.com

Review URL: https://codereview.chromium.org//23151005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26248 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-16 00:46:10 +00:00
benwells@google.com 5aa944301a Update dart:chrome to include fileSystem, and update summary docs.
The dart:chrome library already includes the file system module but
this wasn't included properly at the top level of the API object,
making it unavailable.

The documentation from the generator included in the API has also
been updated.

BUG=None
R=blois@google.com, kathyw@google.com

Review URL: https://codereview.chromium.org//23202004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26241 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-15 23:27:37 +00:00
asiva@google.com f010ffa98d - Add a new toNative which accepts Dart_NativeArguments as a parameter.
Currently it is implemented as two calls to the API to get at the native
  wrapper (will be made one call in another CL).
- Use the new API call Dart_SetWeakHandleReturnValue to return a string
  from the cache directly without having to call Dart_NewHandle(...)

R=vsm@google.com

Review URL: https://codereview.chromium.org//22694004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26148 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-14 20:45:40 +00:00
blois@google.com affaf4c2df Renaming Crypto's new horribly generic class 'Key' to CryptoKey.
BUG=
R=vsm@google.com

Review URL: https://codereview.chromium.org//21929004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26142 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-14 19:54:44 +00:00
vsm@google.com 4d51b41ff8 Initial Dartium custom element support
This will need to be rebased with Stephen's CL or vice versa.  The test mod is taken from his CL.

R=blois@google.com

Review URL: https://codereview.chromium.org//22912004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26141 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-14 19:47:07 +00:00
blois@google.com 59c29150b4 Removing overloaded operations in dart2js.
BUG=
R=sra@google.com

Review URL: https://codereview.chromium.org//22933003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26041 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-12 22:23:42 +00:00
efortuna@google.com 3304c64b52 Make includeAncestors match a separate method.
BUG=
R=blois@google.com

Review URL: https://codereview.chromium.org//22305005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25979 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-09 20:41:48 +00:00
efortuna@google.com 9fdbcf176c Add includeAncestors to dartium matches call.
BUG=

Review URL: https://codereview.chromium.org//22529004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25975 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-09 20:21:50 +00:00
efortuna@google.com 8963a49505 Event delegation
Fix for https://code.google.com/p/dart/issues/detail?id=6270

BUG=
R=blois@google.com, jmesserly@google.com

Review URL: https://codereview.chromium.org//21607003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25969 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-09 17:37:32 +00:00
vsm@google.com cd7a678e83 Use DartExceptionState
R=blois@google.com

Review URL: https://codereview.chromium.org//22605010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25953 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-08 22:56:57 +00:00
vsm@google.com f58ea07d46 EventTargets should be EventTargets
systemnative.py keys off the ext_attr.  Recent IDL changes removed the EventTarget attribute however.

Types marked with isEventTarget are handled specially during GC.

R=jacobr@google.com

Review URL: https://codereview.chromium.org//22507005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25947 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-08 21:18:13 +00:00
vsm@google.com 68b7394e53 Treat EventTarget as a secondary superclass
This matches the C++.  It's brittle, but it's not clear how to get
this out of idl right now.

R=blois@google.com

Review URL: https://codereview.chromium.org//22594012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25906 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-07 22:15:10 +00:00
blois@google.com 2b37129071 Fixing polyfill for Element.createShadowRoot.
Chrome roll changed it from webkitCreateShadowRoot to createShadowRoot, polyfills need to be updated. This change should probably be reverted once everyone adapts to the new API.

TBR
BUG=

Review URL: https://codereview.chromium.org//22513002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25851 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-07 01:32:58 +00:00
blois@google.com 0094164ae8 Regenerating DOM types from IDL roll.
TBR=vsm
BUG=

Review URL: https://codereview.chromium.org//22352004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25849 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-07 00:57:08 +00:00
asiva@google.com abb3ca866b Do not generate calls to Dart_EnterScope/Dart_ExitScope around native
callbacks as an ApiLocalScope is auto created by the VM when making
external native calls.

R=vsm@google.com

Review URL: https://codereview.chromium.org//22392006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25846 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-06 23:57:50 +00:00
vsm@google.com c5dd3d3ba7 MERGE: 152953-155080
TBR=jacobr@google.com,blois@google.com

Review URL: https://codereview.chromium.org//22357003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25832 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-06 21:17:56 +00:00
asiva@google.com 7376bf6cf2 Alter the native code generator to directly use
Dart_SetBooleanReturnValue
 Dart_SetIntReturnValue
 Dart_SetDoubleReturnValue

instead of 
 Dart_Handle retval = toDart(...); // Calls Dart_Boolean, Dart_NewInteger,
                                   // Dart_Double.
 Dart_SetReturnValue(args, retval);

R=vsm@google.com

Review URL: https://codereview.chromium.org//21156011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25698 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-01 00:58:22 +00:00
blois@google.com 1311f1d755 Fixing WebGLLoseContext on Firefox.
BUG=11874
R=efortuna@google.com

Review URL: https://codereview.chromium.org//21287002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25697 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-01 00:35:25 +00:00
blois@google.com 651836e67b Fixing some SVG collections not working on Dartium.
Issue was that we were generating code calling native methods which were not present for these SVG collections.

BUG=11204
R=vsm@google.com

Review URL: https://codereview.chromium.org//21085008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25682 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-31 20:18:42 +00:00
blois@google.com 59a514b316 Moving AngleInstancedArrays from dart:html to dart:web_gl.
It's a new type which for some reason was added to Canvas rather than with the rest of the WebGL stuff.

BUG=11357
R=efortuna@google.com

Review URL: https://codereview.chromium.org//21297002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25649 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-30 22:26:34 +00:00
efortuna@google.com c75ffac982 Added shim for scrollX and scrollY for IE 9.
BUG=
R=blois@google.com

Review URL: https://codereview.chromium.org//20385002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25529 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-26 18:09:13 +00:00
vsm@google.com 9f8be9f84a Fix Dartium test break
I had to revert this line - it's breaking a test on Dartium.

TBR=efortuna@google.com

Review URL: https://codereview.chromium.org//20174003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25460 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-25 01:50:42 +00:00
vsm@google.com a439ba51c0 Fix dartium build breakage
TBR=efortuna@google.com

Review URL: https://codereview.chromium.org//20214002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25458 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-25 00:47:17 +00:00