68a9727c52
Rewrite Futures.
...
R=lrn@google.com
Committed: https://code.google.com/p/dart/source/detail?r=27375
Reverted: https://code.google.com/p/dart/source/detail?r=27376
Review URL: https://codereview.chromium.org//23926011
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27383 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-11 14:00:20 +00:00
d035cbd825
Revert "Rewrite Futures."
...
This reverts commit r27375.
Review URL: https://codereview.chromium.org//23967011
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27376 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-11 12:16:41 +00:00
42e3d1db85
Rewrite Futures.
...
R=lrn@google.com
Review URL: https://codereview.chromium.org//23926011
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27375 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-11 12:02:37 +00:00
7cf1fa8d26
Don't wait for asynchronous error handlers.
...
R=lrn@google.com
Review URL: https://codereview.chromium.org//23534043
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27182 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-05 09:25:32 +00:00
113c812877
Replace ReceivePorts with asyncStart|End in some tests.
...
R=kustermann@google.com
Review URL: https://codereview.chromium.org//23522012
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26996 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-02 08:23:21 +00:00
89373813f9
Make async stream test less flaky.
...
R=kustermann@google.com
Review URL: https://codereview.chromium.org//23444026
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26923 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-30 15:53:23 +00:00
8e7d24a2c5
Fix run_zoned6 and run_zoned9 test.
...
Review URL: https://codereview.chromium.org//23450011
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26787 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-28 13:43:45 +00:00
003cfdc910
Fix run_zoned6|9_test.
...
BUG= http://dartbug.com/12817
R=kustermann@google.com
Review URL: https://codereview.chromium.org//23694002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26784 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-28 12:20:34 +00:00
a9cefff022
elementAt throws a RangeError not StateError.
...
Review URL: https://codereview.chromium.org//23429002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26651 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-26 14:56:26 +00:00
76d4625ccd
Fixed bug in _ControllerStream.operator==.
...
Make _BroacastStream extends _ControllerStream to get same
equality behavior.
Add regression tests.
BUG= http://dartbug.com/11904
R=floitsch@google.com
Review URL: https://codereview.chromium.org//19775015
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25205 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-19 11:58:08 +00:00
0f8d8f3028
Don't assume that I can use package:-url in test.
...
Review URL: https://codereview.chromium.org//18271016
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24839 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-09 11:25:22 +00:00
91aa700848
Add Stream.join
...
BUG= http://dartbug.com/11652
R=floitsch@google.com
Review URL: https://codereview.chromium.org//18271015
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24838 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-09 10:55:13 +00:00
50d6b9811a
Dart2js bug only applies to unchecked mode.
...
Remove an unncessary trace in event_state_test.
Review URL: https://codereview.chromium.org//18853002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24797 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-08 14:52:38 +00:00
57291fed77
Address more bot-redness.
...
Review URL: https://codereview.chromium.org//18841002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24794 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-08 12:24:31 +00:00
d02d106430
Make StreamController be a StreamSink, not just an EventSink.
...
Reverts r24590
Review URL: https://codereview.chromium.org//18080019
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24791 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-08 08:27:27 +00:00
d573bfb5f6
Fix pub errorgroup and analyzer errors.
...
Errorgroup now works as it used to, using an old-style asBroadcastStream
instead of a proper broadcast controller, because that's what the tests
are testing for.
Analyzer was complaining about code that should have been deleted.
Now it is.
Review URL: https://codereview.chromium.org//18428003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24778 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-04 14:13:30 +00:00
1315656027
Make asBroadcastStream take two callbacks.
...
These callbacks will be called when the broadcast stream no longer
has any listeners, or when it gets a listener after having none.
The callback is provided with a StreamSubscription-like object where
it can pause/resume/cancel the underlying subscription on the original
stream.
BUG=http://dartbug.com/11289
R=floitsch@google.com
Review URL: https://codereview.chromium.org//17490002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24776 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-04 13:02:02 +00:00
01251efd5e
Add isActive field on Timer.
...
BUG= http://dartbug.com/10010
R=floitsch@google.com
Review URL: https://codereview.chromium.org//18325006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24678 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-02 12:01:11 +00:00
df2bcb893f
Revert "Make StreamController be a StreamSink, not just an EventSink."
...
Revert "Remove type variable to work around dart2js bug."
This reverts commit r24587.
This reverts commit r24588.
Review URL: https://codereview.chromium.org//18080015
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24590 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-28 15:07:09 +00:00
a15e02cc6a
Make StreamController be a StreamSink, not just an EventSink.
...
BUG=http://dartbug.com/10677
R=floitsch@google.com
Review URL: https://codereview.chromium.org//16240008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24587 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-28 12:56:29 +00:00
60e5ca3727
Add runAsync interceptor.
...
BUG= http://dartbug.com/11279
R=lrn@google.com
Review URL: https://codereview.chromium.org//17672002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24470 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-26 14:41:03 +00:00
48b1656690
Allow Object when doing lookups.
...
According to our typing rules a Set<Apple> is a Set<Fruit>. However, before this change, we couldn't use it as a Set<Fruit>:
===
bool foo(Set<Fruit> fruits) {
// Would yield a type-error since we actually got a Set<Apple>.
return fruits.contains(new Banana());
}
foo(new Set<Apple>());
===
R=ajohnsen@google.com , blois@google.com , lrn@google.com
Review URL: https://codereview.chromium.org//14246008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24326 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-24 12:45:10 +00:00
2ae198d527
Reapply "Zone support for Futures, Timer, Streams."
...
This reapplies commit r24034.
This reapplies commit r24035.
This reapplies commit r24036.
This reapplies commit r24037.
+ some status file updates and fixes.
Review URL: https://codereview.chromium.org//17098007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24064 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-15 11:28:38 +00:00
bcba9d5c8c
Revert "Zone support for Futures."
...
Revert "Add Zone support for Timers."
Revert "Add zone support to streams."
Revert "catchErrors and waitForCompletion now based on runZonedExperimental."
This reverts commit r24034.
This reverts commit r24035.
This reverts commit r24036.
This reverts commit r24037.
Review URL: https://codereview.chromium.org//17064008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24042 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-14 17:17:16 +00:00
9485a093ae
catchErrors and waitForCompletion now based on runZonedExperimental.
...
R=lrn@google.com
Review URL: https://codereview.chromium.org//16801008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24037 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-14 16:29:32 +00:00
496f6dca97
Add zone support to streams.
...
R=lrn@google.com
Review URL: https://codereview.chromium.org//15864007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24036 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-14 16:28:32 +00:00
96c6330215
Add Zone support for Timers.
...
R=lrn@google.com
Review URL: https://codereview.chromium.org//15764003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24035 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-14 16:27:35 +00:00
40216008f2
Zone support for Futures.
...
R=lrn@google.com
Review URL: https://codereview.chromium.org//14973006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24034 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-14 16:26:45 +00:00
df6b4b13f8
Make _FutureImpl._chain do path shortening on listeners.
...
A chained future is one that will give exactly the same result as another
future. It is used to handle, e.g., futures returned by .then handlers.
Currently we chaing futures by simply making the future itself a listener
on the future it is chained to.
This change makes the future move all its listeners to the future it is
chained to, and forward future listeners as well. It avoids long chains of
futures depending on each other.
Effectively, chained futures form equivalence classes. This makes the
equivalence classess all be represented by the future that every other element
depends on, and it applies path shortening to make the dependency graph as
flat as possible.
R=floitsch@google.com
Review URL: https://codereview.chromium.org//15942010
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23807 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-10 12:27:46 +00:00
ae1393fcdc
Revert "Try out 15 ms safety margin."
...
TBR=floitsch@google.com , iposva@google.com
Review URL: https://codereview.chromium.org//16310006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23732 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-07 08:38:09 +00:00
5d90793a87
Try out 15 ms safety margin.
...
If tests start to pass on Windows, it might be a notable clue
that Stopwatch implementation on this platform is not precise
enough.
R=floitsch@google.com
BUG=10982
Review URL: https://codereview.chromium.org//16568002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23696 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-06 16:43:16 +00:00
662c2a8262
Rename RuntimeError to CyclicIntializationError, as per spec.
...
The RuntimeError has been used to report cyclic initialization errors in
dart2js.
It has also been used for other, unrelated, uses, where it makes
little to no sense.
The RuntimeError type has been removed, but added in js_helper.dart,
where dart2js uses it.
Uses of new RuntimeError("some message") have been converted to
other errors (Argument/State/Unsupported). In some cases, just
throwing a String might have been just as good.
BUG=http://dartbug.com/11040
R=johnniwinther@google.com
Review URL: https://codereview.chromium.org//16154017
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23584 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-04 10:33:11 +00:00
faa7227cec
Make new StreamController be async by default.
...
Change all instances, except some tests, to be sync still.
Rename Multiplex to Broadcast everywhere.
R=floitsch@google.com
Review URL: https://codereview.chromium.org//16125005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23453 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-31 06:07:39 +00:00
79a0a652d0
Implement asBroadcast using a _MultiplexStreamController.
...
R=floitsch@google.com
Review URL: https://codereview.chromium.org//15673006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23342 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-29 10:39:35 +00:00
5adef4e9bd
Fix bug in VM timer implementation.
...
Timers stop working after exception in callback.
R=floitsch@google.com , sgjesse@google.com
Review URL: https://codereview.chromium.org//15823008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23271 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-28 13:54:10 +00:00
5982226109
Revert "Mark periodic4-test as flaky and add debug information."
...
This reverts commit 20868.
BUG= http://dartbug.com/9619
R=lrn@google.com
Review URL: https://codereview.chromium.org//15665005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23262 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-28 13:01:13 +00:00
37b1cd3b3f
Optimize internals of multiplex-streams.
...
Make the multiplex streams broadcast streams.
This allows you to listen twice on the same stream, instead of having to get
a new stream each time.
R=floitsch@google.com
Review URL: https://codereview.chromium.org//16007003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23256 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-28 12:06:34 +00:00
781e84284f
Reapply "Active stream subscriptions".
...
Makes subscriptions the active part of a stream, with the stream
itself being just an inert creator of subscriptions.
This changes the behavior of a "single subscription" stream to match
the documentation: After the subscription is canceled, you can't
resubscribe to the stream. Previously, you could do that, but it was
never documented or intended.
This also makes the stream of a StreamController not be paused while
before it's subscribed - it is always the subscription that is paused
or not, and while there is no subscription, the stream cannot be
paused. Previously the stream was set to paused until the first
subscription in order to prevent events from being lost. That is
handled independently of pauses now.
Adds StreamController.multiplex constructor. This name is tentative,
and likely to change. Its behavior may change as well. It currently
provides a new single-subscription stream each time its "stream"
getter is read, and you can subscribe to these.
Adds StreamIterator class that allows iterating over a stream's data
events using (async) "moveNext()" and "current", like a direct style
Iterator (sorry, it won't work in a for-in loop).
Review URL: https://codereview.chromium.org//16131003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23237 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-28 07:28:36 +00:00
cc0d9d57af
Revert until Windows crash is debugged.
...
Reverts r23218, r23217, r23208, r23207, r23206, r23205, r23204.
r23218 | Path observer is listened more than once, so make it multiplex.
r23217 | Add StreamController.multiplex constructor.
r23208 | Fix bug in streamimpl
r23207 | Fix bug in stream iterator.
r23206 | Change expectations for http_parser_test.
r23205 | Fix bug in stream-impl.
r23204 | Make StreamSubscription be the active part of a string.
Review URL: https://codereview.chromium.org//15989006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23221 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-27 13:03:03 +00:00
23162a3847
Add StreamController.multiplex constructor.
...
The "multiplex" stream controller will generate a new stream every
time .stream is read on the controller, and it will send events to
any stream that currently has a listener.
The streams handle their own buffering. Events added before the listen
are ignored.
R=floitsch@google.com
Review URL: https://codereview.chromium.org//16003002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23217 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-27 12:27:20 +00:00
ee1c11a2a6
Make StreamSubscription be the active part of a string.
...
It is the one keeping the buffer of events, not the stream.
R=ajohnsen@google.com , floitsch@google.com , jmesserly@google.com
Review URL: https://codereview.chromium.org//14753009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23204 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-27 08:34:20 +00:00
f2f0261bf5
Add Stream.drain() method.
...
This method will discard all data on the stream and return a Future to
mark the end of the stream.
BUG=
R=floitsch@google.com , sgjesse@google.com
Review URL: https://codereview.chromium.org//15999002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23140 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-24 12:45:42 +00:00
968ebcff5a
Make Completers asynchronous.
...
BUG= http://dartbug.com/9990
R=ajohnsen@google.com , lrn@google.com
Review URL: https://codereview.chromium.org//14690009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22417 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-06 15:15:15 +00:00
80aad7930f
Fix skipWhile.
...
BUG= http://dartbug.com/9480
Review URL: https://codereview.chromium.org//14242008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21623 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-17 15:39:42 +00:00
084cc64ce1
Add Stream.forEach
...
Review URL: https://codereview.chromium.org//14312010
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21608 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-17 09:13:16 +00:00
466d6670c1
Refactor Future constructors.
...
BUG=
Review URL: https://codereview.chromium.org//14070010
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21517 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-15 21:24:27 +00:00
62d413ec91
Remove StreamController.broadcast.
...
Review URL: https://codereview.chromium.org//14136004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21499 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-15 19:08:17 +00:00
5431a5af54
Remove AsyncError with Expando.
...
Review URL: https://codereview.chromium.org//14251006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21498 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-15 18:58:32 +00:00
f553392322
Change StreamController constructor.
...
Review URL: https://codereview.chromium.org//14196003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21472 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-15 16:34:26 +00:00
e2ee353940
Rename unsubscribeOnError to cancelOnError.
...
Review URL: https://codereview.chromium.org//14251013
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21469 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-15 16:07:36 +00:00
floitsch@google.com