18362b2cf4
Revert "Convert HashSet, LinkedHashSet to factory methods and custom implementations."
...
Triggers an error in html tests on dartium.
Review URL: https://codereview.chromium.org//23451045
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27392 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-11 16:19:45 +00:00
c5bb6f7b15
Convert HashSet, LinkedHashSet to factory methods and custom implementations.
...
R=floitsch@google.com
Review URL: https://codereview.chromium.org//23859008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27378 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-11 12:35:57 +00:00
0bd09c308a
Fix dart2js decimal number tokenization. Remove support for 'd'-suffixed double format.
...
BUG=dartbug.com/13070
R=ahe@google.com
Review URL: https://codereview.chromium.org//23583038
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27364 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-11 01:58:07 +00:00
6c92ec5439
Simplify VM internal representation of a mixin application clause (MixinAppType
...
object) by removing some redundant field and type arguments.
Tolerate mixins with wrong number of type arguments and update tests.
Note: this is a first cleanup step in preparation of more mixin bug fixes.
R=hausner@google.com
Review URL: https://codereview.chromium.org//23619026
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27363 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-11 00:41:07 +00:00
42378cd781
Reapply r27285: "Support dynamic as type literal."
...
Reviewed as: https://codereview.chromium.org//23978010
BUG=dartbug.com/12398
R=ngeoffray@google.com
Review URL: https://codereview.chromium.org//23825007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27325 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-10 09:12:55 +00:00
cbd5db9e60
Emit error on default values in typedefs.
...
BUG=dartbug.com/12801,dartbug.com/12802
R=johnniwinther@google.com
Review URL: https://codereview.chromium.org//24073002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27324 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-10 08:42:24 +00:00
99b8252f45
Revert "Support dynamic as type literal."
...
This reverts commit 27285.
R=ngeoffray@google.com
Review URL: https://codereview.chromium.org//23600017
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27294 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-09 15:03:00 +00:00
7544fcae38
Fix bug in inferrer: a super constructor call goes through the visitSuperSend in the resolved visitor.
...
R=karlklose@google.com
Review URL: https://codereview.chromium.org//23680015
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27289 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-09 13:27:41 +00:00
7fd9c10112
Support dynamic as type literal.
...
BUG=dartbug.com/12398
R=ngeoffray@google.com
Review URL: https://codereview.chromium.org//23978010
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27285 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-09 11:02:11 +00:00
0f1e912d9d
Reapply "Make LinkedHashMap also have a factory constructor and be customizable""
...
The change was reverted due to failing Dartium tests that were not easily handelable on a Friday afternoon.
Review URL: https://codereview.chromium.org//23872008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27284 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-09 10:49:32 +00:00
c2a6029d5c
Mark no_such_method tests as flaky.
...
The buildbot marks them as succeeding.
Review URL: https://codereview.chromium.org//23618037
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27276 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-07 16:42:56 +00:00
761f55b1b9
Revert "Make LinkedHashMap also have a factory constructor and be customizable"
...
Dartium expectations expects "LinkedHashMap" and gets "_LinkedHashMap".
Review URL: https://codereview.chromium.org//23890008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27250 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-06 14:29:04 +00:00
64359158ab
Make LinkedHashMap also have a factory constructor and be customizable
...
R=floitsch@google.com
Review URL: https://codereview.chromium.org//23494027
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27246 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-06 13:01:54 +00:00
ce6008eaa8
Update status.
...
BUG=
Review URL: https://codereview.chromium.org//23712003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27228 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-06 06:30:45 +00:00
89707c39c9
Check for non-final field in the face of const constructors.
...
BUG=http://dartbug.com/12900,http://dartbug.com/12901
R=karlklose@google.com
Review URL: https://codereview.chromium.org//23533040
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27227 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-06 06:19:38 +00:00
77a766e06b
Add a test for a generic mixin as mixin.
...
Update test status files.
R=hausner@google.com
Review URL: https://codereview.chromium.org//23444040
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27221 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-05 22:51:31 +00:00
5c0b92e347
Fix number scanning
...
Removing an old, Dash-era hack that makes 2is a faulty number
literal rather than the number 2 followed by the identifier or
keyword "is".
Also fix number_identifier_test.dart which contains an access
to a non-existent getter "memberName" of class NoSuchMethodError.
Review URL: https://codereview.chromium.org//23711004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27216 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-05 22:11:50 +00:00
06762131cc
Update language.status with more issue numbers
...
R=kustermann@google.com
Update language.status
Add some more issue numbers. Rewrite some tests
BUG=
Review URL: https://codereview.chromium.org//23503036
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27195 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-05 13:54:39 +00:00
6d54786025
Emit a compile-time error on const constructors with a body.
...
BUG=dartbug.com/13028
R=johnniwinther@google.com
Review URL: https://codereview.chromium.org//23503035
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27194 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-05 12:45:32 +00:00
a2865875f2
Update language.status
...
Add some more issue numbers. Rewrite some tests
R=kustermann@google.com
BUG=
Review URL: https://codereview.chromium.org//23621022
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27193 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-05 12:37:31 +00:00
0b6479cdaf
Change language/number_identifier_test to be correct.
...
Also make it more comprehensive.
BUG: http://dartbug.com/13014 http://dartbug.com/13015
R=ahe@google.com
Review URL: https://codereview.chromium.org//23868006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27187 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-05 10:28:29 +00:00
51d68152ca
Fix inferrer bug in the presence of compound assignments and unresolved fields in a generative constructor.
...
R=johnniwinther@google.com
Review URL: https://codereview.chromium.org//23526020
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27185 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-05 09:51:39 +00:00
a2e4c994d5
Change test language/const_factory_negative_test.dart into a multi-test
...
R=kustermann@google.com
BUG=
Review URL: https://codereview.chromium.org//23519005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27174 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-05 07:01:34 +00:00
7df443f834
Make showHide combinators work with getter/setter names
...
Adding test language/import_show_test.dart
Fixes issue 9535
R=regis@google.com
Review URL: https://codereview.chromium.org//23810003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27136 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-04 18:00:02 +00:00
3c3e2f959a
Emit a compile-time error when returning a value from a constructor.
...
BUG=dartbug.com/12937, dartbug.com/12938
R=ngeoffray@google.com
Review URL: https://codereview.chromium.org//23583035
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27129 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-04 13:45:44 +00:00
1f2051f88a
Merge two static_final_field tests and rewrite a negative test to a multi-test
...
Removed negative static_final_field_negative_test.dart and created a
multi-test in static_final_field2_test.dart.
Changed throw7_negative_test.dart into a multi-test throw7_test.dart
More Expect.equals cleanup in scope_variable_test.dart.
Add more issue numbers as well.
R=kustermann@google.com
BUG=
Review URL: https://codereview.chromium.org//23638006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27123 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-04 13:26:32 +00:00
0c6d6fb90e
Update the tests testing the use of built in identifiers
...
Updated the actual list of built in identifiers as of the current spec (0.51).
Changed the names of the tests from pseudo_kw_* to built_in_identifier_*
Try to track the actual identifiers which are not working in dart2js.
R=ahe@google.com , kustermann@google.com
BUG=
Review URL: https://codereview.chromium.org//23716002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27117 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-04 12:09:32 +00:00
6a02eca2d3
Merge two language/scope_ tests
...
R=kustermann@google.com
BUG=
Review URL: https://codereview.chromium.org//23944004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27108 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-04 10:17:01 +00:00
4155070fe0
Rewrite negative test number_identifier_negative_test.dart to multi-test
...
R=kustermann@google.com
BUG=
Review URL: https://codereview.chromium.org//23461024
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27105 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-04 09:39:49 +00:00
fcc7862611
A typed selector needs no such method handling if at least one of its implemented subtype (in case it's not exact) does not implement the selector name.
...
R=johnniwinther@google.com
Review URL: https://codereview.chromium.org//23447011
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27100 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-04 08:36:56 +00:00
c8f4cbb263
Support symbol literals.
...
BUG=
R=ahe@google.com
Review URL: https://codereview.chromium.org//21511003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27095 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-04 06:32:44 +00:00
c099eb8d2a
Do not export library prefix names used in a library
...
The spec is unclear whether library prefix names are part of
the export namespace of a library or whether they are private
to that library. The latter makes more sense and is what dart2js
implements, so here's a VM change that implements the same
behavior. Spec will be clarified.
Fixes issue 12713.
R=iposva@google.com
Review URL: https://codereview.chromium.org//23613006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27079 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-03 22:19:27 +00:00
3306b4ac10
Update language.status and rewrite some tests
...
Changed a number of negative tests to multi-tests
R=kustermann@google.com
BUG=
Review URL: https://codereview.chromium.org//23691029
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27062 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-03 14:54:12 +00:00
eaf1021a87
Make HashMap constructor a factory.
...
Add optional parameters that aren't supported yet.
R=floitsch@google.com
Review URL: https://codereview.chromium.org//23513010
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27044 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-03 11:45:12 +00:00
e174a4c18e
Fix a compiler bug caused by Utils::IsPowerOfTwo treating zero as a power of two.
...
The IsPowerOfTwo function is used together with ShiftForPowerOfTwo. Both function
do not work with zero. This caused the optimizing compiler to generate invalid code
for the expression
x ? 0 : 0
where it assumed that if one of the constants is a power-of-two, it can
be computed by (1 << n). We check for 0 in a number of places, but instead
I decided to fix Utils::IsPowerOfTwo itself and remove unnecessary checks
for the zero case.
TEST=tests/language/vm/if_conversion_vm_test.dart, runtime/vm/utils_test.cc
R=kmillikin@google.com
Review URL: https://codereview.chromium.org//23604024
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27033 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-03 09:28:34 +00:00
5f27a4f4ad
java2dart improvements and new analyzer_experimental snapshot.
...
1. All enums extend Enum class.
2. Remove more unneeded parentheses.
3. Remove type arugments for types with all wildcards.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//23852002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27020 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-02 19:01:22 +00:00
7222569e4f
Fix various parser bugs related to modifiers of top-level and class members.
...
BUG=http://dartbug.com/5852
BUG=http://dartbug.com/12805
BUG=http://dartbug.com/12887
BUG=http://dartbug.com/12898
R=johnniwinther@google.com
Review URL: https://codereview.chromium.org//23606010
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27016 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-02 17:50:42 +00:00
f6ab02857e
test.py: Fixed incorrect handling of multitest in status files, status file cleanups.
...
R=ricow@google.com
Review URL: https://codereview.chromium.org//23721006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27013 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-02 14:04:59 +00:00
7a36e5d865
Checked mode throws a TypeError.
...
Review URL: https://codereview.chromium.org//23868002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27011 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-02 11:58:05 +00:00
3fad273e9e
Fix inferrer bug in the presence of synthesized constructors: we should always notify a call to the super constructor to know what are the types of the optional parameters.
...
R=ahe@google.com
Review URL: https://codereview.chromium.org//23449018
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27010 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-02 11:00:26 +00:00
92e97e5d1a
Fix bug with reflection on VM-internal native methods.
...
My previous approach was not enough, since methods can
be invoked via reflection before they are parsed/compiled.
This CL fixes the problem at hand, but I'd like a more general
approach to mark those methods. Maybe an annotation at the declaration
would be better.
I also refactored the test case as suggested in the previous code review.
R=srdjan@google.com
Review URL: https://codereview.chromium.org//23458008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27009 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-02 10:43:59 +00:00
55bf6d834e
Fix typo
...
R=srdjan@google.com
Review URL: https://codereview.chromium.org//23806004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26986 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-02 06:54:22 +00:00
53dc9ba034
Change the field and constructor parameter types of NoSuchMethodError to Symbol.
...
The NSME uses strings for names. It should use symbols.
This change modifies the VM libraries only enough to make the signature change
not crash. It will probably need cleanup to ensure that symbols are passed
to the internal constructor directly, instead of strings that have to be
converted.
(Also fixes a type error in Map.fromIterable that was hit by the code).
BUG= http://dartbug.com/11190
R=ahe@google.com , regis@google.com
Review URL: https://codereview.chromium.org//23486007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26985 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-02 05:57:49 +00:00
3723a7e4bd
@proxy support the Analysis Engine.
...
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//23495020
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26981 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-31 20:18:50 +00:00
0a80cb84b2
Spell minified correctly
...
Review URL: https://codereview.chromium.org//23843002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26970 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-31 09:02:49 +00:00
33d5c11f09
Update status of stack_trace_test for IE9 and dart2js minified
...
Review URL: https://codereview.chromium.org//23493016
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26967 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-31 08:42:44 +00:00
c191eb248a
Update status file for dart2dart
...
Review URL: https://codereview.chromium.org//23530012
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26966 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-31 08:29:25 +00:00
97891ce193
If a rethrow is encountered in the catch block, then its handler must be marked that it needs stacktrace. Fix issue r12584.
...
R=iposva@google.com
Review URL: https://codereview.chromium.org//23691024
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26963 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-31 00:26:47 +00:00
03d1af54b0
Fix crash with cyclic exports
...
Issue 6060, 6595
R=srdjan@google.com
Review URL: https://codereview.chromium.org//23658007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26957 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-30 23:09:35 +00:00
fede338905
Update language.status and rewrite two tests
...
Added issue numbers
Changed two negative tests into mulit-tests.
R=kustermann@google.com
BUG=
Review URL: https://codereview.chromium.org//23761003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26914 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-30 13:44:48 +00:00
lrn@google.com