Commit Graph

228 Commits

Author SHA1 Message Date
sra@google.com ce4b15c0e9 Esoteric bit operations.
- bit length
- truncate to signed fixed width integer
- truncate to unsigned fixed width integer

This change is motivated by a program that spends 20-30% of its time here:
    // TODO(5828): Replace this with a bit-length method on int when available.
    int n_bitLength = this.n.toRadixString(2).length;

See Also
https://code.google.com/p/dart/issues/detail?id=5828#c3
https://code.google.com/p/dart/issues/detail?id=6486#c2
https://code.google.com/p/dart/issues/detail?id=5798#c5
https://code.google.com/p/dart/issues/detail?id=12008

R=lrn@google.com, srdjan@google.com

Review URL: https://codereview.chromium.org//23645003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27269 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-06 22:22:26 +00:00
kustermann@google.com f6ab02857e test.py: Fixed incorrect handling of multitest in status files, status file cleanups.
R=ricow@google.com

Review URL: https://codereview.chromium.org//23721006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27013 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-02 14:04:59 +00:00
kustermann@google.com 7c2d27bb13 Add again the *necessary* timeout markers for tests running on ie9/ie10
R=ahe@google.com

Review URL: https://codereview.chromium.org//23830002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26930 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-30 17:32:42 +00:00
kustermann@google.com 4d7311f14b Remove Timeout entries in status files for ie9/ie10
After reducing the load on our IE builders, we hopefully no longer see these
random timeouts.

R=ahe@google.com

Review URL: https://codereview.chromium.org//23604010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26912 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-30 13:39:05 +00:00
ricow@google.com bc8ad29953 Add timeout suppression for corelib/collection_length_test on IE
Filed issue 12844

R=kustermann@google.com, ngeoffray@google.com

Review URL: https://codereview.chromium.org//23572009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26779 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-28 11:12:26 +00:00
sgjesse@google.com e95bb89f6d Remove some bogus rules from the staus files
R=kustermann@google.com
BUG=

Review URL: https://codereview.chromium.org//22854029

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26357 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-20 14:19:51 +00:00
sgjesse@google.com 6b514b1a0c Remove all remaining references to dartc
R=ricow@google.com
BUG=

Review URL: https://codereview.chromium.org//23301004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26338 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-20 06:17:03 +00:00
ricow@google.com 649079a711 Remove flaky marker for csslib/test/declaration_test
This has been fixed in V8 and we rolled in a new version

R=kustermann@google.com

Review URL: https://codereview.chromium.org//22891007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26313 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-19 13:22:38 +00:00
asiva@google.com 84d93c0b09 Fix status file to account for dart2dart minified mode failure
(error_stack_trace1_test.dart depends on method names)

R=ahe@google.com

Review URL: https://codereview.chromium.org//22865010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26082 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-13 20:21:36 +00:00
asiva@google.com dbd0e8c285 Fix the stack trace when there are C++ frames in between dart frames.
R=iposva@google.com

Review URL: https://codereview.chromium.org//22938002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26044 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-13 00:16:16 +00:00
zra@google.com 8ffef7528d Bug fix and status file updates for MIPS HW.
R=regis@google.com

Review URL: https://codereview.chromium.org//22828004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26037 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-12 21:45:41 +00:00
asiva@google.com 33a46a45c6 Fix minor bug which was causing throw of Null to not be recognized properly.
R=iposva@google.com

Review URL: https://codereview.chromium.org//22889002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26024 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-12 19:50:28 +00:00
ahe@google.com 4d4fa32377 Implement Error.stackTrace.
BUG=http://dartbug.com/11681
R=bak@google.com

Review URL: https://codereview.chromium.org//22798006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26004 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-12 14:42:02 +00:00
kustermann@google.com b497bd0a4b Status file update for tests failing on dart2js-drt after chrome roll
R=ricow@google.com

Review URL: https://codereview.chromium.org//22576004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25874 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-07 14:00:56 +00:00
zra@google.com dad3270d95 Implements far branch targets for MIPS.
This change adds a flag --mips-far-branches, which when set causes
relative branches to be converted to absolute branches by determining
the PC, adding the branch offset to it, and using the jr or jalr
instruction to jump if the branch test passes.

This procedure clobbers the assembler temporary TMP, so TMP can no
longer be used in a branch test or in the branch delay slot of a
relative branch. Because TMP can't be used in a branch test, a
new temporary is introduced CMPRES2. This change replaces TMP with
CMPRES1 or another register where TMP can no longer be used.

Tests that were failing due to a too-far relative have the
--mips-far-branches flag set.

R=regis@google.com

Review URL: https://codereview.chromium.org//20369003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25543 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-26 23:30:32 +00:00
fschneider@google.com 082e80d514 Temporarily mark list_test as crashing on MIPS.
BUG=https://code.google.com/p/dart/issues/detail?id=11851
TBR=zra@google.com

Review URL: https://codereview.chromium.org//19373004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25060 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-16 17:38:00 +00:00
scheglov@google.com cdfb38b317 New analyzer_experimental snapshot.
The biggest change is in formatting long list literals.
It looks now better and also does not turn Editor into text mode for couple files.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//18612009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24903 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-11 01:51:53 +00:00
zra@google.com e21da288c2 Fixes status file.
R=asiva@google.com

Review URL: https://codereview.chromium.org//18811009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24899 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-11 00:30:47 +00:00
scheglov@google.com 58e638766c Report CTEC.ARGUMENT_TYPE_NOT_ASSIGNABLE and extra/not-enough arguments as errors.
R=brianwilkerson@google.com, jwren@google.com
BUG=

Review URL: https://codereview.chromium.org//18690009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24790 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-07 18:11:36 +00:00
karlklose@google.com cf5be8e52c Fix dart2dart test expectations.
R=johnniwinther@google.com

Review URL: https://codereview.chromium.org//18757002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24781 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-05 08:09:04 +00:00
hausner@google.com 98883150d6 Partial solution to analyze potentially constant expressions
This change adds code that detects if an expression can definitively
never be constant. We use this to analyze the initializer expressions
in const constructors. This check is not entirely water tight, but
together with the checks in canonicalization code catches most
illegal initializer expressions.

The const constructor of class Symbol turns out to be illegal. The
name verification check can't be part of the constructor code.

R=iposva@google.com

Review URL: https://codereview.chromium.org//18649003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24749 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-03 20:47:14 +00:00
scheglov@google.com 6c6b88967f Remove dartc status sections.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//18566003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24735 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-03 17:50:34 +00:00
floitsch@google.com 5e207df6a4 Revert "Relax method override restrictions."
Revert "Update status file."

This reverts commit r24731.
This reverts commit r24732.

Review URL: https://codereview.chromium.org//18652002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24733 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-03 16:39:51 +00:00
floitsch@google.com 96a6e8d252 Update status file.
Review URL: https://codereview.chromium.org//18345017

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24732 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-03 16:37:17 +00:00
floitsch@google.com 77034fe249 Relax method override restrictions.
This implements part of issue 11495.

BUG= http://dartbug.com/11495
R=regis@google.com

Review URL: https://codereview.chromium.org//18600007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24731 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-03 16:20:05 +00:00
floitsch@google.com cd01e5c5f8 Update status file.
Review URL: https://codereview.chromium.org//18348014

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24730 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-03 16:18:00 +00:00
floitsch@google.com b6d62603e7 Correct status file.
Review URL: https://codereview.chromium.org//18259008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24729 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-03 15:36:16 +00:00
floitsch@google.com 438767ca3a Add stackTrace to Error object.
BUG=
R=lrn@google.com

Review URL: https://codereview.chromium.org//18529003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24726 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-03 14:51:30 +00:00
zra@google.com e730b67b10 Fixes bug in mips left shift.
R=regis@google.com

Review URL: https://codereview.chromium.org//18053013

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24561 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-27 23:11:13 +00:00
iposva@google.com ca6b378934 - Update status file for dart2js. Tests have been updated to not
use ? operator and thus now "Pass" instead of "Fail,OK".

Review URL: https://codereview.chromium.org//18117003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24542 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-27 19:22:21 +00:00
zra@google.com bc703b348f Updates co19 status file for simarm and simmips.
Also marks corelib/collection_to_string_test as
Pass, Crash for arm hardware, as it crashes
occasionally.

R=regis@google.com

Review URL: https://codereview.chromium.org//17932003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24489 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-26 20:54:17 +00:00
kasperl@google.com 1e6c3a1998 Remove support for 'argument definitions test' from dart2js.
R=ngeoffray@google.com
BUG=

Review URL: https://codereview.chromium.org//17825002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24455 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-26 08:02:25 +00:00
iposva@google.com 11632110c6 - Revert r24441 until issues found have been addressed.
Review URL: https://codereview.chromium.org//17769004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24443 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-25 23:38:45 +00:00
iposva@google.com ddc3e13f8a - Trial balloon for removal of argument definition test.
This change removes the support for the ? operator.

R=asiva@google.com, hausner@google.com

Review URL: https://codereview.chromium.org//17765003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24441 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-25 23:04:19 +00:00
zra@google.com 8edda78ccc Enables more tests for SIMMIPS.
. Fixes register allocation bugs
. Implements float <-> double conversion in assembler and simulator.
. Fixes floating point argument passing for simarm and simmips,
  and floating point return for simarm, and adjusts tests to match.

R=regis@google.com

Review URL: https://codereview.chromium.org//17502002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24365 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-24 20:16:16 +00:00
floitsch@google.com b1800554d7 Test started working. Marking as flaky.
Review URL: https://codereview.chromium.org//17154002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24067 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-15 12:25:13 +00:00
sgjesse@google.com da6dd8e33d Update status file
The crash no longer happens after the code was refactored.

TBR=vegorov@google.com
BUG=

Review URL: https://codereview.chromium.org//16961005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23976 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-13 13:03:38 +00:00
kustermann@google.com 8ea94854e3 Second round of status file updates for simarm/arm
TBR=zra

Review URL: https://codereview.chromium.org//16802005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23915 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-12 16:04:39 +00:00
ngeoffray@google.com 98b8521dcc Test does not crash on mac, and is flaky on windows.
Review URL: https://codereview.chromium.org//16520011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23913 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-12 15:53:25 +00:00
ngeoffray@google.com 71cbc38e4f VM crashes when running dart2js on this test case.
R=vegorov@google.com

Review URL: https://codereview.chromium.org//15679023

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23909 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-12 15:08:48 +00:00
kustermann@google.com f73188d127 Use gnueabihf for ARM + enabled corelib/isolate/lib/standalone tests on ARM again
R=regis@google.com

Review URL: https://codereview.chromium.org//16638009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23854 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-11 14:21:28 +00:00
scheglov@google.com 80fea8fd8e More fixes for java2dart and status files.
Now DDA passes/fails the same tests as Java version.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//15675016

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23705 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-06 18:13:44 +00:00
antonm@google.com 3264ecdd1b Cleanup suppressions.
TBR=vsm@google.com

Review URL: https://codereview.chromium.org//15969012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23548 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-03 15:44:39 +00:00
vsm@google.com d5da0f0c0d Adjusted expectations from last Blink roll
TBR=antonm, blois

Review URL: https://codereview.chromium.org//15795004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23513 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-02 20:30:14 +00:00
regis@google.com b7eb5aedbe Cleanup various test status files.
R=zra@google.com

Review URL: https://codereview.chromium.org//16232012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23450 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-31 00:39:37 +00:00
lrn@google.com 6f6ed505a3 Fix bug in list test.
The test assumed that the return of a typeddata-list's toList method
did not have a generic type parameter, as it should have.

BUG=http://dartbug.com/10708
R=floitsch@google.com

Review URL: https://codereview.chromium.org//15952006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23382 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-30 07:03:54 +00:00
kustermann@google.com a8857ed49c Status file updates for arm -> remove Skip markers
R=ricow@google.com

Review URL: https://codereview.chromium.org//15956005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23242 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-28 09:09:38 +00:00
karlklose@google.com 35da54ead7 Reapply "Enable full type-checks in checked mode."
R=ngeoffray@google.com

Review URL: https://codereview.chromium.org//15299002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22846 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-17 11:46:39 +00:00
scheglov@google.com 2214a97df7 Update status files for 'dartanalyer'.
Small tweak for the Java command line analyzer to actually support --package-root option in batch.

R=devoncarew@google.com
BUG=

Review URL: https://codereview.chromium.org//14786020

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22480 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-07 21:45:20 +00:00
lrn@google.com 4214819184 Mark list_test as failing on browsers.
Seems to be failing in UInt8List.operator[] with invalid argument.

BUG=http://dartbug.com/10174

Review URL: https://codereview.chromium.org//14178017

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21945 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-24 12:58:01 +00:00