18362b2cf4
Revert "Convert HashSet, LinkedHashSet to factory methods and custom implementations."
...
Triggers an error in html tests on dartium.
Review URL: https://codereview.chromium.org//23451045
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27392 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-11 16:19:45 +00:00
071c5a1ee8
Accept IPv6 addresses in Uri.http and Uri.https, and correctly nest IPv6 addresses in '[' and ']'.
...
BUG= http://dartbug.com/13130
BUG= http://dartbug.com/13131
BUG= http://dartbug.com/13132
R=floitsch@google.com , sgjesse@google.com
Review URL: https://codereview.chromium.org//23904004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27381 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-11 13:22:31 +00:00
c5bb6f7b15
Convert HashSet, LinkedHashSet to factory methods and custom implementations.
...
R=floitsch@google.com
Review URL: https://codereview.chromium.org//23859008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27378 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-11 12:35:57 +00:00
0f1e912d9d
Reapply "Make LinkedHashMap also have a factory constructor and be customizable""
...
The change was reverted due to failing Dartium tests that were not easily handelable on a Friday afternoon.
Review URL: https://codereview.chromium.org//23872008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27284 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-09 10:49:32 +00:00
ce4b15c0e9
Esoteric bit operations.
...
- bit length
- truncate to signed fixed width integer
- truncate to unsigned fixed width integer
This change is motivated by a program that spends 20-30% of its time here:
// TODO(5828): Replace this with a bit-length method on int when available.
int n_bitLength = this.n.toRadixString(2).length;
See Also
https://code.google.com/p/dart/issues/detail?id=5828#c3
https://code.google.com/p/dart/issues/detail?id=6486#c2
https://code.google.com/p/dart/issues/detail?id=5798#c5
https://code.google.com/p/dart/issues/detail?id=12008
R=lrn@google.com , srdjan@google.com
Review URL: https://codereview.chromium.org//23645003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27269 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-06 22:22:26 +00:00
761f55b1b9
Revert "Make LinkedHashMap also have a factory constructor and be customizable"
...
Dartium expectations expects "LinkedHashMap" and gets "_LinkedHashMap".
Review URL: https://codereview.chromium.org//23890008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27250 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-06 14:29:04 +00:00
64359158ab
Make LinkedHashMap also have a factory constructor and be customizable
...
R=floitsch@google.com
Review URL: https://codereview.chromium.org//23494027
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27246 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-06 13:01:54 +00:00
5d8f2cad4e
Reapply "Add custom equals and hashCode for HashMap implementation."
...
Review URL: https://codereview.chromium.org//23493017
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27179 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-05 08:29:26 +00:00
c288d7c951
Revert "Add custom equals and hashCode for HashMap implementation."
...
Review URL: https://codereview.chromium.org//23883003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27111 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-04 11:17:15 +00:00
76c0e79ff6
Add custom equals and hashCode for HashMap implementation.
...
R=floitsch@google.com
Review URL: https://codereview.chromium.org//23893002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27106 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-04 09:42:21 +00:00
f6ab02857e
test.py: Fixed incorrect handling of multitest in status files, status file cleanups.
...
R=ricow@google.com
Review URL: https://codereview.chromium.org//23721006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27013 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-02 14:04:59 +00:00
53dc9ba034
Change the field and constructor parameter types of NoSuchMethodError to Symbol.
...
The NSME uses strings for names. It should use symbols.
This change modifies the VM libraries only enough to make the signature change
not crash. It will probably need cleanup to ensure that symbols are passed
to the internal constructor directly, instead of strings that have to be
converted.
(Also fixes a type error in Map.fromIterable that was hit by the code).
BUG= http://dartbug.com/11190
R=ahe@google.com , regis@google.com
Review URL: https://codereview.chromium.org//23486007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26985 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-02 05:57:49 +00:00
39f1574318
Fix for Issue 12833
...
Eliminate limit on size for bignum multiply by storing extra overflow bits for column sums.
R=floitsch@google.com , iposva@google.com
Review URL: https://codereview.chromium.org//23455014
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26962 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-31 00:14:53 +00:00
7c2d27bb13
Add again the *necessary* timeout markers for tests running on ie9/ie10
...
R=ahe@google.com
Review URL: https://codereview.chromium.org//23830002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26930 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-30 17:32:42 +00:00
4d7311f14b
Remove Timeout entries in status files for ie9/ie10
...
After reducing the load on our IE builders, we hopefully no longer see these
random timeouts.
R=ahe@google.com
Review URL: https://codereview.chromium.org//23604010
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26912 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-30 13:39:05 +00:00
788c569e9c
Convert HashMap and LinkedHashMap to closed addressing hash tables.
...
R=regis@google.com , sgjesse@google.com
Review URL: https://codereview.chromium.org//23056002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26863 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-29 12:13:32 +00:00
74da0c7286
Remove usage of dart:json.
...
R=jmesserly@google.com , lrn@google.com , nweiz@google.com , rnystrom@google.com
Review URL: https://codereview.chromium.org//23596007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26789 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-28 14:05:11 +00:00
bc8ad29953
Add timeout suppression for corelib/collection_length_test on IE
...
Filed issue 12844
R=kustermann@google.com , ngeoffray@google.com
Review URL: https://codereview.chromium.org//23572009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26779 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-28 11:12:26 +00:00
1887b5ca49
Some more removals of dart:utf.
...
R=jmesserly@google.com , lrn@google.com , nweiz@google.com
Review URL: https://codereview.chromium.org//22909059
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26712 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-27 13:18:34 +00:00
0fa1bbdf15
Reapply "Make Map constructors return LinkedHashMap."
...
Updated tests assuming a specific ordering of an unlinked hash map
to not be daft.
R=floitsch@google.com , jmesserly@google.com
Review URL: https://codereview.chromium.org//22859069
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26693 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-27 08:43:46 +00:00
cda03252f6
Change the type of the pathSegments argument to the Uri constructor from List to Iterable
...
R=lrn@google.com
BUG=http://dartbug/11342
Review URL: https://codereview.chromium.org//22918029
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26649 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-26 14:25:25 +00:00
4983d492d3
Revert "Make Map constructors return LinkedHashMap."
...
Some tests are making assumptions that are not warranted.
Review URL: https://codereview.chromium.org//22966015
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26624 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-26 09:12:48 +00:00
011f1ee4b8
Make Map constructors return LinkedHashMap.
...
BUG= http://dartbug.com/5803
R=floitsch@google.com
Review URL: https://codereview.chromium.org//23190040
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26622 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-26 08:08:06 +00:00
e95bb89f6d
Remove some bogus rules from the staus files
...
R=kustermann@google.com
BUG=
Review URL: https://codereview.chromium.org//22854029
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26357 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-20 14:19:51 +00:00
6b514b1a0c
Remove all remaining references to dartc
...
R=ricow@google.com
BUG=
Review URL: https://codereview.chromium.org//23301004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26338 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-20 06:17:03 +00:00
649079a711
Remove flaky marker for csslib/test/declaration_test
...
This has been fixed in V8 and we rolled in a new version
R=kustermann@google.com
Review URL: https://codereview.chromium.org//22891007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26313 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-19 13:22:38 +00:00
7866ff39e5
Make Error.safeToString convert control codes in strings to escapes.
...
Converts values in the range 0x00 to 0x1f to escapes.
Escapes are either \xhh for most values, or \n, \r and \t for
NL, CR and TAB.
BUG= http://dartbug.com/11250
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//23116007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26269 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-16 11:35:52 +00:00
84d93c0b09
Fix status file to account for dart2dart minified mode failure
...
(error_stack_trace1_test.dart depends on method names)
R=ahe@google.com
Review URL: https://codereview.chromium.org//22865010
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26082 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-13 20:21:36 +00:00
dbd0e8c285
Fix the stack trace when there are C++ frames in between dart frames.
...
R=iposva@google.com
Review URL: https://codereview.chromium.org//22938002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26044 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-13 00:16:16 +00:00
8ffef7528d
Bug fix and status file updates for MIPS HW.
...
R=regis@google.com
Review URL: https://codereview.chromium.org//22828004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26037 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-12 21:45:41 +00:00
33a46a45c6
Fix minor bug which was causing throw of Null to not be recognized properly.
...
R=iposva@google.com
Review URL: https://codereview.chromium.org//22889002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26024 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-12 19:50:28 +00:00
4d4fa32377
Implement Error.stackTrace.
...
BUG=http://dartbug.com/11681
R=bak@google.com
Review URL: https://codereview.chromium.org//22798006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26004 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-12 14:42:02 +00:00
b497bd0a4b
Status file update for tests failing on dart2js-drt after chrome roll
...
R=ricow@google.com
Review URL: https://codereview.chromium.org//22576004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25874 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-07 14:00:56 +00:00
cfba41b714
Add support for file URIs and extracting the file path from file URIs
...
A file URI can now be created directly using the constructor Uri.file.
The file path for a file URI can now be extracted using the toFilePath() method.
The path strings involved use either Windows or non-Windows
semantics. Both the Uri.file constructor and the toFilePath()
method have optional anamed arguments for specifying the
semantics. The default semantic is determined from the platform
Dart is running on.
R=ahe@google.com , whesse@google.com
BUG=
Review URL: https://codereview.chromium.org//21039005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25872 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-07 12:55:09 +00:00
fa2ad38a31
Enables per-function far-branches for ARM and MIPS.
...
R=regis@google.com , srdjan@google.com
Review URL: https://codereview.chromium.org//21363003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25723 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-01 20:51:46 +00:00
dad3270d95
Implements far branch targets for MIPS.
...
This change adds a flag --mips-far-branches, which when set causes
relative branches to be converted to absolute branches by determining
the PC, adding the branch offset to it, and using the jr or jalr
instruction to jump if the branch test passes.
This procedure clobbers the assembler temporary TMP, so TMP can no
longer be used in a branch test or in the branch delay slot of a
relative branch. Because TMP can't be used in a branch test, a
new temporary is introduced CMPRES2. This change replaces TMP with
CMPRES1 or another register where TMP can no longer be used.
Tests that were failing due to a too-far relative have the
--mips-far-branches flag set.
R=regis@google.com
Review URL: https://codereview.chromium.org//20369003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25543 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-26 23:30:32 +00:00
082e80d514
Temporarily mark list_test as crashing on MIPS.
...
BUG=https://code.google.com/p/dart/issues/detail?id=11851
TBR=zra@google.com
Review URL: https://codereview.chromium.org//19373004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25060 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-16 17:38:00 +00:00
3b2c97ae08
Fix issue 11705: deal with user-defined Function classes that override noSuchMethod, and are being called with apply.
...
R=ahe@google.com
Review URL: https://codereview.chromium.org//19101002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24950 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-12 15:16:52 +00:00
93bcd6baf7
Move toString() to collection classes.
...
R=floitsch@google.com
Committed: https://code.google.com/p/dart/source/detail?r=24836
Review URL: https://codereview.chromium.org//18837002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24913 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-11 12:59:12 +00:00
cdfb38b317
New analyzer_experimental snapshot.
...
The biggest change is in formatting long list literals.
It looks now better and also does not turn Editor into text mode for couple files.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//18612009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24903 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-11 01:51:53 +00:00
e21da288c2
Fixes status file.
...
R=asiva@google.com
Review URL: https://codereview.chromium.org//18811009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24899 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-11 00:30:47 +00:00
a0c76e6d43
Revert "Move toString() to collection classes."
...
This reverts commit 24836
Review URL: https://codereview.chromium.org//18282008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24837 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-09 09:36:47 +00:00
8ed47ae514
Move toString() to collection classes.
...
R=floitsch@google.com
Review URL: https://codereview.chromium.org//18837002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24836 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-09 08:35:54 +00:00
58e638766c
Report CTEC.ARGUMENT_TYPE_NOT_ASSIGNABLE and extra/not-enough arguments as errors.
...
R=brianwilkerson@google.com , jwren@google.com
BUG=
Review URL: https://codereview.chromium.org//18690009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24790 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-07 18:11:36 +00:00
cf5be8e52c
Fix dart2dart test expectations.
...
R=johnniwinther@google.com
Review URL: https://codereview.chromium.org//18757002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24781 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-05 08:09:04 +00:00
58e3227700
Remove incorrect comment.
...
Review URL: https://codereview.chromium.org//18466003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24770 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-04 11:44:55 +00:00
98883150d6
Partial solution to analyze potentially constant expressions
...
This change adds code that detects if an expression can definitively
never be constant. We use this to analyze the initializer expressions
in const constructors. This check is not entirely water tight, but
together with the checks in canonicalization code catches most
illegal initializer expressions.
The const constructor of class Symbol turns out to be illegal. The
name verification check can't be part of the constructor code.
R=iposva@google.com
Review URL: https://codereview.chromium.org//18649003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24749 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-03 20:47:14 +00:00
6c6b88967f
Remove dartc status sections.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//18566003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24735 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-03 17:50:34 +00:00
5e207df6a4
Revert "Relax method override restrictions."
...
Revert "Update status file."
This reverts commit r24731.
This reverts commit r24732.
Review URL: https://codereview.chromium.org//18652002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24733 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-03 16:39:51 +00:00
96a6e8d252
Update status file.
...
Review URL: https://codereview.chromium.org//18345017
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24732 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-03 16:37:17 +00:00
lrn@google.com