Commit Graph

155 Commits

Author SHA1 Message Date
kevmoo@j832.com 85e045313e adding HtmlEscape to dart:convert
BUG=https://code.google.com/p/dart/issues/detail?id=1657
R=blois@google.com, floitsch@google.com, rnystrom@google.com

Review URL: https://codereview.chromium.org//23492002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27211 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-05 20:30:56 +00:00
alanknight@google.com 47b25f4236 Fix off-by-one error in computing the quarter in date formatting
R=efortuna@google.com

Review URL: https://codereview.chromium.org//23494030

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27202 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-05 17:41:38 +00:00
alanknight@google.com e0234b8da6 Allow creating VariableSubstitution by name or by index
R=efortuna@google.com

Review URL: https://codereview.chromium.org//23449021

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27077 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-03 21:46:41 +00:00
alanknight@google.com 1e6838f8f4 Re-arrange tests to allow testing generated messages code in dart2js
R=efortuna@google.com

Review URL: https://codereview.chromium.org//23484010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26927 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-30 17:03:39 +00:00
alanknight@google.com a74007e83b Documents the exception on DateFormat.parse
R=efortuna@google.com

Review URL: https://codereview.chromium.org//23623011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26894 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-29 22:28:13 +00:00
alanknight@google.com c2d9d8cd2e Disable Intl deferred loading until it works in dart2js
R=efortuna@google.com

Review URL: https://codereview.chromium.org//23598003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26803 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-28 17:33:10 +00:00
floitsch@google.com 74da0c7286 Remove usage of dart:json.
R=jmesserly@google.com, lrn@google.com, nweiz@google.com, rnystrom@google.com

Review URL: https://codereview.chromium.org//23596007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26789 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-28 14:05:11 +00:00
alanknight@google.com 5a965b5a45 Resume testing message extraction on Windows after dart:io fix
R=efortuna@google.com

Review URL: https://codereview.chromium.org//23630002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26744 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-27 20:50:55 +00:00
alanknight@google.com 8da15c52f0 Remove hack for finding package-root in tests, now available in Platform
R=efortuna@google.com

Review URL: https://codereview.chromium.org//23446002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26721 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-27 16:55:31 +00:00
alanknight@google.com 7602371022 Verify the locale when initializing dates over http
BUG=dartbug.com/11093
R=efortuna@google.com

Review URL: https://codereview.chromium.org//23090005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26613 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-23 21:04:51 +00:00
alanknight@google.com 551f37ed99 Put the @lazy directive on a separate line from the import to avoid confusing naive parsers (e.g. dwc)
R=sigmund@google.com

Review URL: https://codereview.chromium.org//22793016

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26559 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-22 21:46:54 +00:00
alanknight@google.com 5038d3b5e7 Make defaultLocale public
R=efortuna@google.com

Review URL: https://codereview.chromium.org//23033028

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26557 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-22 21:35:40 +00:00
alanknight@google.com f95ea62a8a Simplify the generated code for a message.
R=efortuna@google.com

Review URL: https://codereview.chromium.org//23060025

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26548 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-22 19:23:35 +00:00
alanknight@google.com d632beeaa4 Add a null check to avoid trying to load libraries that don't exist.
R=efortuna@google.com, sigmund@google.com

Review URL: https://codereview.chromium.org//22986014

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26377 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-20 18:22:42 +00:00
alanknight@google.com 3d80dba138 If you have something that recursively looks for messages in dependencies, it can end up parsing intl.dart and giving warnings that there are invalid messages in its internals. Change the calls to invoke the static messages without a prefix so that this won't complain.
R=efortuna@google.com

Review URL: https://codereview.chromium.org//23241004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26233 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-15 22:27:48 +00:00
alanknight@google.com b136efff1c Use deferred loading for message libraries.
R=efortuna@google.com

Review URL: https://codereview.chromium.org//22828006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26199 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-15 16:50:41 +00:00
alanknight@google.com e8dd115eb6 Relax verification checks. The locale doesn't have to be constant, print
the node in the error message without making assumptions about its
type, and do not require the name parameter to match the function name.

R=efortuna@google.com

Review URL: https://codereview.chromium.org//23212003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26154 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-14 21:06:54 +00:00
efortuna@google.com 5504f5a970 Fix message_extraction test.
BUG=

Review URL: https://codereview.chromium.org//22928010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26103 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-14 00:45:48 +00:00
efortuna@google.com 6970ef4c98 Rename CompositeMessage's named parent constructor.
BUG=
R=alanknight@google.com

Review URL: https://codereview.chromium.org//23140003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26101 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-14 00:33:14 +00:00
alanknight@google.com 9f565af534 Workaround for bug 11834 with Chrome XHR
R=efortuna@google.com

Review URL: https://codereview.chromium.org//22877005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26028 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-12 20:33:04 +00:00
alanknight@google.com 31ab754cbf Add support for Intl.select
Moves some of the validation logic into the appropriate objects, so we can more easily deal with Select, which takes its arguments in a Map, versus Plural/Gender which expect named arguments.

R=efortuna@google.com

Review URL: https://codereview.chromium.org//22286013

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25965 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-09 17:08:03 +00:00
kevmoo@j832.com 18d38085ab pkg: analysis aided cleanup
Removed a lot of warnings and hints when opening many pkg projects in the editor

R=gram@google.com

Review URL: https://codereview.chromium.org//22284003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25831 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-06 20:42:04 +00:00
alanknight@google.com 12ee5f7c61 Improvements to warnings on message extraction.
Add warning for message names that don't match the function name, and
a warnings-are-errors command-line option.

R=efortuna@google.com

Review URL: https://codereview.chromium.org//22392004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25829 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-06 20:01:13 +00:00
alanknight@google.com 899a8d27a0 Allow Intl.plural/gender as the top-level, omitting the Intl.message wrapper and the first layer of interpolation.
R=efortuna@google.com

Review URL: https://codereview.chromium.org//20072002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25435 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-24 20:01:59 +00:00
alanknight@google.com 816b24e8ff Make _shortLocale public
R=efortuna@google.com

Review URL: https://codereview.chromium.org//20071003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25423 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-24 17:12:54 +00:00
rnystrom@google.com a9d24edd0f Rename "pathos" package to "path".
R=ajohnsen@google.com

Review URL: https://codereview.chromium.org//18356011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24964 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-12 17:54:48 +00:00
alanknight@google.com bea11dee93 Plurals and Genders
R=efortuna@google.com

Review URL: https://codereview.chromium.org//18543009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24746 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-03 20:23:27 +00:00
sgjesse@google.com 887c8e7596 Move getters from Options to Platform
The getters for executable, script and version are now statics on
Platform. I kept them on Options for now, but updated most tests to
use Platform.

R=ajohnsen@google.com, floitsch@google.com, iposva@google.com
BUG=

Review URL: https://codereview.chromium.org//17406010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24401 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-25 12:56:23 +00:00
kustermann@google.com 8356c667db Added async_helper and fixed broken asynchronous test.
R=ahe@google.com, efortuna@google.com, floitsch@google.com

Review URL: https://codereview.chromium.org//16958006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24339 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-24 15:47:00 +00:00
alanknight@google.com 0ec6fe103b Allow translated messages that have no matching original message. Also clean up help text and get rid of type error for types whose name is no longer easily visible from analyzer.
R=efortuna@google.com

Review URL: https://codereview.chromium.org//17113002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24240 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-20 17:01:13 +00:00
sgjesse@google.com 9d6a64e81b Merge the dart:uri library into dart:core and update the Uri class
This merges the dart:uri library into dart:core removing the dart:uri library. Besides moving the library the Url class has been changed.

* Removed existing Uri constructor as it was equivalent with Uri.parse
* Remamed constructor Uri.fromComponents to Uri
* Moved toplevel function encodeUriComponent to static method Uri.encodeComponent
* Moved toplevel function decodeUriComponent to static method Uri.decodeComponent
* Moved toplevel function encodeUri to static method Uri.encodeFull
* Moved toplevel function decodeUri to static method Uri.decodeFull
* Rename domain to host
* Added static methods Uri.encodeQueryComponent and Uri.decodeQueryComponent
* Added support for path generation and splitting
* Added support for query generation and splitting
* Added some level of normalization

R=floitsch@google.com, lrn@google.com, nweiz@google.com, scheglov@google.com
BUG=

Review URL: https://codereview.chromium.org//16019002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23266 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-28 13:35:01 +00:00
ajohnsen@google.com 06091dd24c Remove (unused) ProcessOptions in test.
BUG=

Review URL: https://codereview.chromium.org//15670004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23132 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-24 11:16:00 +00:00
alanknight@google.com f61dd39e24 Add a dateSymbols getter to DateFormat, useful to get e.g. the list of weekday names
R=efortuna@google.com

Review URL: https://codereview.chromium.org//14604009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22749 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-15 17:54:43 +00:00
alanknight@google.com 805def3f49 Change DateFormat doc examples to not show padding of months/days in the default locale
R=efortuna@google.com

Review URL: https://codereview.chromium.org//14835008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22688 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-14 16:36:04 +00:00
nweiz@google.com 5f3be4f352 Add some user-friendly utility functions to pkg/analyzer_experimental.
R=alanknight@google.com, amouravski@google.com, brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//14998006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22567 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-09 21:05:44 +00:00
alanknight@google.com a6b47e0fad Fix some doc formatting problems, stop using "set" methods for NumberFormat
R=amouravski@google.com, sethladd@google.com

Review URL: https://codereview.chromium.org//14544009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22148 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-29 20:32:04 +00:00
alanknight@google.com c9f0368d7d Allow suppressing message extraction warnings, providing a prefix for generated files, and format warnings better.
Review URL: https://codereview.chromium.org//13898014

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21959 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-24 17:03:36 +00:00
alanknight@google.com 0c2102f7e8 Explain better than the en_US locale is always available, fix other doc glitches.
Review URL: https://codereview.chromium.org//14270009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21910 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-23 22:32:00 +00:00
sethladd@google.com 8fd2c2e5ea add installation instructions to pkg packages
BUG=

Review URL: https://codereview.chromium.org//14188048

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21770 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-19 20:51:10 +00:00
nweiz@google.com 89cb31e4c4 Fix some warnings in pub and pkg packages.
Review URL: https://codereview.chromium.org//13817008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21701 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-18 20:24:47 +00:00
floitsch@google.com 466d6670c1 Refactor Future constructors.
BUG=

Review URL: https://codereview.chromium.org//14070010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21517 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-15 21:24:27 +00:00
alanknight@google.com 664fe171c6 Make use of the patterns in Intl number formatting
This adds code to parse and use the information from the pattern
string used to create a NumberFormat. It adds tests taken
from the Closure tests and also tests comparing a simple
format to the ICU output for a large set of locales.

In addition it has changes to
 - part number_format.dart in intl.dart rather than having it as a
separate library
 - Update the algorithm to incorporate some additions in Closure
 - Allow setting a few of the internal parameters, which the
Closure tests wanted to use
 - Add named constructors for the standard formats, e.g. DECIMAL_FORMAT
 - Access _defaultLocale consistently via the getCurrentLocale() method
rather than directly, so it can never be uninitialized.
 - Regenerated the locale data

Review URL: https://codereview.chromium.org//13814018

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21166 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-09 19:58:42 +00:00
kevmoo@j832.com 755c71f1fc pkg/intl test cleanup
pkg/unittest has evolved a lot. Helping intl use some of the new features and
avoid some problems. I think I fixed some issues in the process

BUG=https://code.google.com/p/dart/issues/detail?id=9342

Review URL: https://codereview.chromium.org//13684003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20993 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-05 18:24:14 +00:00
kevmoo@j832.com 1a6983771c pkg/intl: cleanup after message extraction test
call deleteGeneratedFiles after test
update deleteGeneratedFiles to cover all generated files

Review URL: https://codereview.chromium.org//12827019

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20391 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-22 17:13:05 +00:00
kevmoo@j832.com 1d9013517e Moved pkg pubspecs to use dev_dependencies where appropriate
BUG=https://code.google.com/p/dart/issues/detail?id=9309

Review URL: https://codereview.chromium.org//12962003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20285 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-20 19:41:10 +00:00
alanknight@google.com d98dc62e7d Parameterize the import directories, fix test to behave correctly on an error
Review URL: https://codereview.chromium.org//12478010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20241 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-19 20:53:26 +00:00
alanknight@google.com 6bda92055d Update Intl's json data file generation to current APIs
Review URL: https://codereview.chromium.org//12918018

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20182 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-18 22:47:42 +00:00
iposva@google.com cdcb3e5b09 - Make test code fail when run from unexpected location.
Review URL: https://codereview.chromium.org//12787011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20122 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-15 23:14:07 +00:00
lrn@google.com 844cd39fad Change getRange to sublist. Make getRange deprecated.
This changes the exception behavior of getRange. It used to accept
a length of zero, no matter what start value. Now the start value
must be a valid list index.

Review URL: https://codereview.chromium.org//12817003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20064 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-15 09:15:39 +00:00
alanknight@google.com ab0ead6b50 Intl test spawning processes must specify the encoding for stdout
Review URL: https://codereview.chromium.org//12645010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20055 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-14 22:17:24 +00:00