07e4dfdb43
Ensure formatted CUs end with a newline (dartbug.com/13188).
...
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//23458038
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27352 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-10 21:17:21 +00:00
79f133550d
Optional trailing comma support for list and map literals.
...
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//23451037
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27350 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-10 18:34:05 +00:00
8c13dc887a
Formatter sanity-checking (via token stream verification).
...
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//23480055
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27343 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-10 17:10:41 +00:00
e6ce94adab
java2dart improvement - use field if getter/setter are trivial.
...
Also analyzer_experimental snapshot.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//23769004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27138 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-04 19:17:38 +00:00
e8f8262517
New analyzer_experimental snapshot.
...
And java2dart improvements for better inner classes support.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//23461019
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27078 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-03 21:46:33 +00:00
f8c8395201
Formatter comment-handling improvements.
...
A bit messy but ready to checkpoint. Should handle the major cases.
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//23589005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27074 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-03 19:21:14 +00:00
5f27a4f4ad
java2dart improvements and new analyzer_experimental snapshot.
...
1. All enums extend Enum class.
2. Remove more unneeded parentheses.
3. Remove type arugments for types with all wildcards.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//23852002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27020 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-02 19:01:22 +00:00
0b6ae2575c
Fix analyzer_experimental hints: remove unused imports.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//23496027
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26944 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-30 21:11:46 +00:00
663530693f
New analysis_experimental snapshot.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//23080005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26876 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-29 16:30:24 +00:00
2a88e8858b
Improved comment handling (and misc. formatter fixes).
...
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//23440011
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26746 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-27 21:55:58 +00:00
e84b9dba61
Add a parseDartString method to pkg/analyzer.
...
R=brianwilkerson@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//22865035
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26673 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-26 22:06:55 +00:00
4502a116e9
Minor formatter tweaks and a few more tests.
...
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//23121006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26655 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-26 16:38:04 +00:00
faac3d0e06
Formatter checkpoint.
...
Some fixes and a progress towards the elimination of references to String literals in visit methods.
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//23301021
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26608 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-23 20:17:01 +00:00
0ba745e63d
Formatter fixes and tweaks.
...
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//22928013
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26462 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-21 19:40:53 +00:00
8951d19925
Formatter checkpoint.
...
Largely cleanup in a move from string literals to accessing the corresponding node tokens.
I'm also trying on an approach to tracking the need for preceding (and trailing) newlines. In general I don't love state flags where I can avoid them but the alternatives were even more ungainly to my eye.
Thoughts, of course, are most welcome!
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//23308004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26370 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-20 16:50:03 +00:00
6b3d069dd2
Formatter cleanup.
...
Migration to emitToken begins...
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//23044004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26079 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-13 20:08:41 +00:00
88e634dba0
Formatter token emission baby-steps.
...
Still playing around with emitToken(..) as a general strategy. Next step will likely be to migrate all appropriate print(..) calls to it. (Along the way a great rename will happen too.)
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//22937006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26064 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-13 17:06:23 +00:00
47e8d45430
analyzer_exp fixes
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//22542003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25946 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-08 21:07:01 +00:00
f6b9baced7
Formatter checkpoint.
...
Review URL: https://codereview.chromium.org//22403004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25941 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-08 19:51:32 +00:00
0039dfca51
Remove dart:io dependency from scanner/ast/parser tests.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//22325013
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25935 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-08 17:46:50 +00:00
c52c1736ee
New analyzer_experimental snapshot.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//22285004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25902 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-07 21:15:25 +00:00
a5ed18ebdb
Formatter check-point (blank-space preservation experiment).
...
Possibly not the long-term approach but an early checkpoint of one approach to preserving user defined blank spaces (between members).
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//19668003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25125 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-17 21:44:28 +00:00
4ac2a1452c
New analyzer_experimental snapshot.
...
FYI bot is red, as I can see this is caused by VM crashes.
https://code.google.com/p/dart/issues/detail?id=11873
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//19590006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25121 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-17 19:32:30 +00:00
a9d24edd0f
Rename "pathos" package to "path".
...
R=ajohnsen@google.com
Review URL: https://codereview.chromium.org//18356011
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24964 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-12 17:54:48 +00:00
cdfb38b317
New analyzer_experimental snapshot.
...
The biggest change is in formatting long list literals.
It looks now better and also does not turn Editor into text mode for couple files.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//18612009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24903 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-11 01:51:53 +00:00
319f5b5425
Initial indent fix and a few more tests.
...
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//18487005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24825 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-08 21:58:55 +00:00
00845ce4c6
Formatter re-think/updates.
...
A redesign striving for simplicity and a riff on ToSourceASTVisitor. Some shuffling and renaming still to come. Line and Token abstractions are also quite likely to change. Consider this a baby-step.
R=brianwilkerson@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//18346013
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24758 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-03 22:22:20 +00:00
532aa2fab4
New analyzer_experimental snapshot.
...
Fixes also compilation problem in java2dart translator.
R=pquitslund@google.com
BUG=
Review URL: https://codereview.chromium.org//18325018
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24744 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-03 19:47:59 +00:00
69eaca5ebd
Simplify constructors translation, improve code style.
...
This CL stops generating and using "_impl" methods with constructor implementation.
This is actually required only locally, when there are other statements aside of redirecting constructor invocation.
So, this may be done later, during constructors optimizing in ConstructorSemanticProcessor.
For now we just transform placeholder of redirecting constructor invocation into the actual initializer.
Also, this CL adds more optimizations into ConstructorSemanticProcessor, such as:
1. removing empty constructor body;
2. enum constructor tweaks.
Plus new snapshot of analyzer_experimental with these changes in translation applied.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//18129004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24701 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-02 17:45:11 +00:00
8b0684be54
New analyzer_experimental snapshot.
...
R=brianwilkerson@google.com , devoncarew@google.com
BUG=
Review URL: https://codereview.chromium.org//17932005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24613 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-28 22:34:01 +00:00
4d097b2712
Dart formatter checkpoint.
...
More babysteps. Note: some of the style is tentative (e.g., still trying on cascades).
Comments welcome.
R=brianwilkerson@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//17470004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24255 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-20 22:35:48 +00:00
2329919e5e
Fix build after analyzer_experimental changes
...
TBR
We have to disable converting to properties for some Parser methods, which are used via reflection.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//16983008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24118 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-18 00:05:00 +00:00
fd7dde1aef
Code coverage, something is working now.
...
For now only 'statement' level coverage.
Review this, please.
Any comments about Dart code style, using libraries, etc will be helpful!
There are some Dart VM changes, which I'm _not_ going to commit.
I'm waiting for https://codereview.chromium.org/16368002/
So, ignore them.
R=pquitslund@google.com
BUG=
Review URL: https://codereview.chromium.org//16964008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24116 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-17 23:24:18 +00:00
36ace54ada
Convert isX() methods to isX getter.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//17317002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24115 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-17 23:02:36 +00:00
4d79a15ce3
New analyzer_experimental snapshot.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//17249003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24109 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-17 21:04:45 +00:00
b9950462a2
New analyzer_experimental snapshot.
...
Includes recent disambiguation and fixes.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//16774005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23878 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-11 20:08:54 +00:00
0049091064
Clean up analyzer_experimental after Annotation disambiguation.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//16663003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23836 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-10 23:55:54 +00:00
bb87681f61
Fixing build.
...
TBR
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//15944013
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23796 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-10 04:58:59 +00:00
20a078aefb
Improve java2dart code style - relax 'don't reference variable name in its initializer'.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//16611004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23795 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-10 04:05:50 +00:00
9b27cae892
New analyzer_experimental snapshot.
...
Mainly to fix missing import in html.dart
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//16702002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23792 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-09 19:13:20 +00:00
7ee54e63c1
Removing accidental symlink in quest for build greenness [TBR].
...
Review URL: https://codereview.chromium.org//16668002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23770 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-07 20:12:27 +00:00
8fe83e6d51
Dart formatter babysteps.
...
Largely scaffolding and basic datastructures. Very much subject to change.
Dart style pointers greatly appreciated! :)
R=brianwilkerson@google.com , messick@google.com , rnystrom@google.com
Review URL: https://codereview.chromium.org//16562012
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23769 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-07 19:53:40 +00:00
c7eeff273b
Quick check for self in InterfaceTypeImpl.getLeastUpperBound()
...
This reduces co19 time from 60 to 45 seconds for DDA.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//16381003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23714 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-06 19:29:22 +00:00
80fea8fd8e
More fixes for java2dart and status files.
...
Now DDA passes/fails the same tests as Java version.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//15675016
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23705 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-06 18:13:44 +00:00
d775a9cef3
Fixes for translator and DDA status files.
...
Almost everything is again translated automatically.
There are three fragments which we have to replace to source level.
One for performance reasons; two others - to avoid using IO.
Now we are green for co19 tests, execute 4034 of them in 2:07, 132 failures.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//16103010
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23624 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-05 00:59:32 +00:00
b80f5b1e6d
Remove trailing spaces in analyzer_experimental
...
Otherwise Editor does this on the first save and creates unmanagable CL.
R=jwren@google.com
BUG=
Review URL: https://codereview.chromium.org//16256021
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23570 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-03 21:33:08 +00:00
7e96d2372f
analyzer_experimental snapshot
...
R=brianwilkerson@google.com , messick@google.com
BUG=
Review URL: https://codereview.chromium.org//16302002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23515 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-02 22:00:29 +00:00
9d6a64e81b
Merge the dart:uri library into dart:core and update the Uri class
...
This merges the dart:uri library into dart:core removing the dart:uri library. Besides moving the library the Url class has been changed.
* Removed existing Uri constructor as it was equivalent with Uri.parse
* Remamed constructor Uri.fromComponents to Uri
* Moved toplevel function encodeUriComponent to static method Uri.encodeComponent
* Moved toplevel function decodeUriComponent to static method Uri.decodeComponent
* Moved toplevel function encodeUri to static method Uri.encodeFull
* Moved toplevel function decodeUri to static method Uri.decodeFull
* Rename domain to host
* Added static methods Uri.encodeQueryComponent and Uri.decodeQueryComponent
* Added support for path generation and splitting
* Added support for query generation and splitting
* Added some level of normalization
R=floitsch@google.com , lrn@google.com , nweiz@google.com , scheglov@google.com
BUG=
Review URL: https://codereview.chromium.org//16019002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23266 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-28 13:35:01 +00:00
cb3bbdc62d
Manual fixes for Dart^2 analyzer
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//16059002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23195 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-25 19:09:39 +00:00
15d6f64ab1
Fix a RegExp in analyzer_experimental/test/utils for Windows.
...
TBR
Review URL: https://codereview.chromium.org//14865015
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22571 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-09 21:45:13 +00:00
pquitslund@google.com