2deae5a599
[analysis_Server] Sync with latest published LSP (TS) spec
...
Change-Id: If5003354491047bf18538c6c097ea21a34e44843
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/247222
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2022-06-06 14:11:13 +00:00
09967d8c25
Use textual state dumps for Cider tests.
...
This allows us to see which files were read, unlinked summary created,
how many many references to data we have, how we discard data from the
byte store, how we discard libraries from LinkedElementFactory,
and linked summaries from the byte store, etc.
Change-Id: I4eb57d96db8e1f816e7b932b727a6a92e6b07248
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/247244
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2022-06-05 03:11:37 +00:00
84402e7824
Capture analytics about notifications
...
Let me know if there's other information you think we should be
reporting or if this won't accurately capture the time it takes to
handle notifications.
Change-Id: I7c57316ad37bd6bb9add9ab6d27e6f3428f4b491
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/247241
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Danny Tuppeny <danny@tuppeny.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2022-06-03 19:51:12 +00:00
fad5a668a9
Use a JSON encoding for percentile data being sent to analytics
...
Change-Id: Ie96f81e9cdc7585a5027db7b44f7f39cb7e763b8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/247240
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2022-06-03 16:38:21 +00:00
42778832a1
allow rename on extension via fix_data.yaml
...
Closes https://github.com/dart-lang/sdk/pull/49164
GitOrigin-RevId: 3bc7a3de9781d0005c041145affe6c0ed3ae744b
Change-Id: I7e0357cd928636d0556d3dea2aac083529d089c7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/246983
Reviewed-by: Keerti Parthasarathy <keertip@google.com >
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2022-06-03 00:39:55 +00:00
30d0fd72cd
Use initialized 'late final' in GoogleAnalyticsManagerTest.
...
Change-Id: I2d9775cf5f53e060162e0dd59f0fecc1a38f59fb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/246991
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2022-06-02 21:52:35 +00:00
f9acb37545
Add some tests of analytics
...
Change-Id: Icd4b86346d199649b156776df9835414a1ad41cd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/246980
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2022-06-02 19:39:55 +00:00
be13f8b89a
Add a fix to remove print expression statements for avoid_print.
...
Bug: https://github.com/dart-lang/sdk/issues/45921
Change-Id: I9dc1726e19fdd592d42bc3d7eb6aa6a1b1944279
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/246051
Commit-Queue: Janice Collins <jcollins@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2022-06-02 18:30:57 +00:00
15a40305c3
Report plugin performance in analytics
...
Change-Id: I22e37031330e2d65aa1317965d1536932f5e6cc2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/246764
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2022-06-01 20:36:16 +00:00
e51af7cd0c
[analysis_server] Improve failure messages if LSP JSON deserialisation tests fail
...
+ add test for fields declared as doubles where the client may pass numbers without decimals.
Change-Id: I6b709a4620a2688d948faae1103193ab6ff5ceea
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/246647
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2022-06-01 16:48:34 +00:00
7c652aff38
Change FileResolver() constructor to named parameters.
...
Change-Id: I9040d4947ce431002ef9469244aa582e3dd2de2d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/246760
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Keerti Parthasarathy <keertip@google.com >
2022-06-01 16:46:56 +00:00
75d622a25d
[analysis_server] Prevent failed LSP requests when refactors fail validation
...
Change-Id: I302492939b89f3c4d5fe6ef66ee2366a08dc7764
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/246645
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2022-06-01 15:50:34 +00:00
45ceaff1a1
Gather analytics for plugin usage
...
We also plan to gather some data about performance, but that will be in
follow-on CLs.
Change-Id: I97410d601eaeb87dfe027855a730d85feaeb3d7d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/246661
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2022-05-31 20:42:03 +00:00
8cc19f912c
[analysis_server] Don't use 0 for LSP choice placeholders
...
See https://github.com/Dart-Code/Dart-Code/issues/3996 .
Change-Id: If718b23ca4e5216dc7f635a679a38bef91d1056e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/246448
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2022-05-31 15:38:33 +00:00
4d26011910
Remove broken git submodule link from analysis server
...
This git submodule link was added in a rebase of CL
https://dart-review.googlesource.com/c/sdk/+/243647/4..5
This seems to be an erroneous commit of some work in progress.
Removing just that submodule link at pkg/analysis_server/native/cJSON.
Bug: https://github.com/dart-lang/sdk/issues/49124
Change-Id: I068db76c0afeb2f0eb4bac1ce23867d777c5f3bc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/246440
Reviewed-by: Alexander Thomas <athom@google.com >
Commit-Queue: William Hesse <whesse@google.com >
2022-05-30 09:50:12 +00:00
3e1bad6e7a
Record startup information for analytics
...
In order to avoid passing several pieces of data through several layers
of the API, this change passes the analytics manager down. This means
that we're creating the manager earlier, but I think it keeps the code
cleaner.
Change-Id: I096e416c1aa445f5f7382ae666b3d02d0abf0a0f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/246320
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2022-05-27 19:29:20 +00:00
20b7de7b57
[analysis_server] Provide UseCurlyBraces as a fix for always_put_control_body_on_new_line
...
Fixes https://github.com/Dart-Code/Dart-Code/issues/3981 .
Change-Id: I3fc5579e2150c8e0faa5f7692b837a27c9ce732d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/246120
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2022-05-27 17:55:30 +00:00
26985e3978
Update the fix status for a few diagnostics
...
Change-Id: Ie26fe0ff3a8085b37a5382323fa29b6c4fc157f2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/246260
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2022-05-27 16:23:10 +00:00
f7c46f145c
[pkg] prefer 'any' deps for package dev dependencies
...
Tested: CI validation
Change-Id: If65cc156130a65ffe00c6f1660ac320e2921afae
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/246053
Commit-Queue: Devon Carew <devoncarew@google.com >
Reviewed-by: Nate Bosch <nbosch@google.com >
2022-05-27 01:34:59 +00:00
b253c4a004
Suggest static fields/getters.
...
Change-Id: Ibf422215f1f1a6ddb062302a6c3e7b831b176468
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/229324
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2022-05-26 16:44:31 +00:00
c202252876
[analysis_server] remove two lint ignores for generated LSP spec files
...
Fixes #49059
`prefer_is_not_operator`
`unnecessary_parenthesis`
Change-Id: I79d3e1b6ed89d138a2bb6eab79fa8dcdc9a23080
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/245541
Reviewed-by: Danny Tuppeny <danny@tuppeny.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2022-05-26 06:00:59 +00:00
366042a0dd
[analysis_server] satisfy annotate_overrides in generated LSP spec files
...
Part of #49059
Change-Id: Ifb97985907757f53548764fc64a46094650efd4c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/245544
Reviewed-by: Danny Tuppeny <danny@tuppeny.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2022-05-26 04:37:59 +00:00
4cf8091c8d
Remove PartWithoutLibraryResult, consider a part to be a library instead.
...
Bug: https://github.com/dart-lang/sdk/issues/49046
Change-Id: I20413cd2b2ff284d2e4b92949f057c97b98fb49b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/246042
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2022-05-25 20:51:04 +00:00
fa8a33f60e
[analysis_server] Set Container() as final tabstop/selection in Flutter snippets
...
Change-Id: I0f1fd31a051440ccc119188cccdb3168c9e58e20
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/245988
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2022-05-25 18:57:28 +00:00
33b6483ad1
Support for AugmentationFileStateKind.
...
Change-Id: Ib32b7b56739d89118c9a497087dc5066bab177dd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/245680
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2022-05-25 16:54:38 +00:00
b292488a8d
Deprecate Element.isAccessibleIn(), use isAccessibleIn2(LibraryElement) instead.
...
Change-Id: Ic018a8ff19454a5645336d23b3e8a72c706608ca
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/245910
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2022-05-25 16:52:13 +00:00
cd4d9c6f2f
[analysis_server] Include placeholder Container() in Flutter snippet build methods
...
Fixes https://github.com/Dart-Code/Dart-Code/issues/3975 .
Change-Id: I388f22fefed048dabd200070482a2a2915c5b971
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/245840
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2022-05-25 14:49:28 +00:00
4b08b7de8b
Issue 49054. Use prefix filter for UriBasedDirective, use MatchStyle.FILENAME
...
Bug: https://github.com/dart-lang/sdk/issues/49054
Change-Id: I127944d9eca20f0d8a57e26b3050fcfcb381d2b1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/245623
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2022-05-24 19:43:05 +00:00
e66540d8a3
[analysis_server] Update to latest published 3.17 (TS) spec
...
Some minor tweaks + fix for `NotebookDocumentSyncOptions` since the original publish.
Change-Id: I3962222a984e2617ebcb023453a16580cd787b7b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/245700
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2022-05-24 16:49:15 +00:00
c954d80f18
[analysis_server] Fix LSP class name generation for nested inline types + minor renames
...
Change-Id: Ia8321eedeb783ffe5e91a508e258a87aa9efcf31
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/245372
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2022-05-24 16:36:55 +00:00
2591ed885b
[analysis_server] Handle navigation for "part of"s using URIs
...
Fixes https://github.com/Dart-Code/Dart-Code/issues/3970 .
Change-Id: I972f8811f0819d3018f36cb36ed796b8dafc1b3b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/245701
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2022-05-24 16:23:47 +00:00
a6fcb56901
Fix typos
...
Fixes #49094
TEST=ci
Change-Id: I23cdcb5ad2fc83e5e91d80e34b66af186c0cb923
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/245820
Reviewed-by: Jens Johansen <jensj@google.com >
Commit-Queue: Slava Egorov <vegorov@google.com >
Reviewed-by: Slava Egorov <vegorov@google.com >
2022-05-24 09:10:51 +00:00
19d0d888f5
Add support for import rename
...
Change-Id: I7358e697d022302f060eb751415c28087c9642a4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/245741
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Keerti Parthasarathy <keertip@google.com >
2022-05-23 23:17:30 +00:00
0340696b02
[pkg/analysis_server] remove code referencing itsallwidgets.com
...
Change-Id: Ic7b93eaaef6cb35395d47af5603e095250048d77
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/245740
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Commit-Queue: Devon Carew <devoncarew@google.com >
2022-05-23 20:54:00 +00:00
f397ecb588
Satisfy library_private_types_in_public_api in analyzer
...
This involves changes of a few flavors:
* Make classes private which were unnecessarily public.
* Make class elements private which were unnecessarily public.
* Comment in places where a "public" API contains a private type,
but this is because of the signature of a super-member. I think
these are generally quite safe.
Change-Id: Ied1864202cc256205a3b421ddec5513f0a22a608
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/243647
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2022-05-22 01:45:33 +00:00
1827c4caf4
Fix an exception in sort_constructors_first
...
Change-Id: I08f4f626e948240e4a6e6faba190714f3c22d155
Fixes: https://github.com/dart-lang/sdk/issues/48966
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/245622
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Auto-Submit: Brian Wilkerson <brianwilkerson@google.com >
2022-05-22 01:08:36 +00:00
e1a73506d9
[analysis_server] Always show TODOs via LSP if configured as warning/error
...
See https://github.com/dart-lang/sdk/issues/49061 .
Change-Id: I6113acf9712502669b199ab1269f39ea7a1d2df4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/245543
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2022-05-21 17:50:23 +00:00
77da5016fe
[analysis_server] remove ignore of no_leading_underscores_for_local_identifiers in generated file
...
Part of #49059
Change-Id: I9d8771e71ca505d61442bc04b9f71fd02f1c7d5e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/245380
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Danny Tuppeny <danny@tuppeny.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2022-05-20 15:54:53 +00:00
3fa01b2b9b
[analysis_server] Remove ignoring avoid_renaming_method_parameters
...
Bug: #48785
Change-Id: I089dd5a76bf5c5c5d4e57ecc8ddaabda04866621
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/245361
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Danny Tuppeny <danny@tuppeny.com >
2022-05-20 14:55:12 +00:00
c038e3b3c1
Clean up in analytics
...
This
- converts PercentileCalculator to sort entries, as previously suggested,
- adds the number of values to the dump of a PercentileCalculator, and
- fixes the name of a class to conform to conventions.
Change-Id: Icb25a3adfc922b6d5b394883853eeeff968e4b89
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/245460
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2022-05-19 21:53:01 +00:00
2bb220a95d
[analyzer] CreateConstructor to handle undefined enum constructor
...
Fixes #48481
Change-Id: I237bcbf1cb3202435c9bda31467a76f27e3dc896
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/245169
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2022-05-19 20:52:21 +00:00
aae961063f
[analysis_server] Move LSP JSON-RPC types to custom generation
...
Change-Id: Ie84f7aa099bdeeb1be2a565faf1ffa0bb3ef4b21
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/245365
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2022-05-19 18:18:01 +00:00
b088f98e05
Add the hooks to capture analytics for requests and responses
...
In the process of testing this I found (and fixed) a couple of bugs
introduced in the recent conversion of the legacy code to handler
classes. I wanted to validate that I'd added hooks in all the right
places, so I wrote an AnalysisManager to keep track of request/response
pairs. It showed that some extra responses were being generated. I'm
still debating how best to add this to the normal tests to prevent
regressions, so you'll probably see it in another CL at some point.
Change-Id: Ib203c02ef27b6efb53a41a48696a3a39e61ed800
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/245260
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Danny Tuppeny <danny@tuppeny.com >
2022-05-19 13:24:40 +00:00
466202bb34
[analyzer] remove lints ignore in generated files
...
Fixes #49039
Change-Id: I14e98fc5ab9c1f7b7e69f99dc1c97178b56c624d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/245020
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2022-05-19 05:17:00 +00:00
5ee3a6f07a
bump to linter 1.24.0
...
(I did a `find_violations` run internally against cl/449544481 and all clear 🟢 .)
Change-Id: I2375a42244902ee2da515417cb463f74d9949387
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/245224
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Phil Quitslund <pquitslund@google.com >
2022-05-19 00:20:30 +00:00
b9c077b435
[analysis_server] Fix type aliases with multiple literal types in LSP TypeScript spec
...
Change-Id: I82a8344b5e4858355757b8d4d167a305f74f3ec4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/245172
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2022-05-18 18:46:23 +00:00
e28972166c
Return PartWithoutLibraryResult when a part without its library.
...
Change-Id: I5eb384d77c263b489b10e112a79115bf028e79af
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/245081
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2022-05-18 16:45:53 +00:00
a5e40e4916
Apply the changes from the previous CL
...
I forgot to upload these before I clicked submit.
Change-Id: I112eb9a1c3bd1ce8980f87dc92b8ebb39b72d075
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/245080
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2022-05-17 22:12:17 +00:00
d4c4408f10
Add initial support for gathering analytics in the analysis server
...
I'm primarily interested in feedback on the general approach, which is
to have a single object to which all significant events are reported and
which is responsible for reporting or aggregating the data as
appropriate.
I removed a getter from AnalysisServer that should no longer be used,
though I haven't changed the code that directly references the
underlying analytics object so that existing code won't be impacted.
I also added a couple of references to the new class, but because we're
always creating a noop version there won't be any impact on users at
this point.
Once the overall approach has landed I'll start wiring up the existing
methods and adding new methods as appropriate.
Change-Id: I419f409c9df82fdc62a14128bb1f67723e9cf55f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/244983
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2022-05-17 20:46:16 +00:00
a34deb2587
[analysis_server] Move super.dispose() to end of stanim snippet's dispose method
...
Equiv change for extension-shipped snippet in https://github.com/Dart-Code/Dart-Code/pull/3965 .
Change-Id: Ief61a7d11f19edac6f4f4a14f311d7789add8d80
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/245003
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2022-05-17 14:55:40 +00:00
Danny Tuppeny