2837647bea
[wiki] move the https://github.com/dart-lang/sdk/wiki to the docs/ dir
...
Change-Id: I28db796fadcc111d97d3589bf3988ea0bbb8e18a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/366682
Reviewed-by: Alexander Thomas <athom@google.com >
Commit-Queue: Devon Carew <devoncarew@google.com >
2024-05-16 18:19:40 +00:00
3bdc1f9c59
[wildcards] UNUSED_CATCH_CLAUSE tests
...
Fixes: https://github.com/dart-lang/sdk/issues/55721
Change-Id: I5e675c61a7d1eb0f6192f98146fd2dbd5dd0e2e5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/366407
Commit-Queue: Phil Quitslund <pquitslund@google.com >
Reviewed-by: Kallen Tu <kallentu@google.com >
2024-05-16 17:31:30 +00:00
b6207ebdb4
[deps] Roll dart-lang/native
...
Adds the missing argument to `link`.
Change-Id: I8a9d167b046ac301e5274a5062e30d6c186ac257
Cq-Include-Trybots: luci.dart.try:pkg-linux-debug-try,pkg-linux-release-arm64-try,pkg-linux-release-try,pkg-mac-release-arm64-try,pkg-mac-release-try,pkg-win-release-arm64-try,pkg-win-release-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/366381
Reviewed-by: Hossein Yousefi <yousefi@google.com >
Commit-Queue: Hossein Yousefi <yousefi@google.com >
Auto-Submit: Daco Harkes <dacoharkes@google.com >
Commit-Queue: Daco Harkes <dacoharkes@google.com >
2024-05-16 17:12:17 +00:00
73bdc86dd5
Macro. Issue 55746. Fix for using re-exported macros.
...
Bug: https://github.com/dart-lang/sdk/issues/55746
Change-Id: Ib18b60467ce946346072c04b1df7b36d12e4cab1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/366901
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2024-05-16 17:03:01 +00:00
c734d583c1
Prevent .call tearoff on expressions whose type is a nullable type variable.
...
Note that this is not a breaking change, since the CFE already
correctly flags the error condition.
Fixes #55734 .
Bug: https://github.com/dart-lang/sdk/issues/55734
Change-Id: I5570e0840ce20c2a761d88f698b9876f7543bd8e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/366680
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2024-05-16 16:44:29 +00:00
b3287af10e
[vm] Remove MSAN_UNPOISONs around print and sort functions.
...
This was probably fixed by ddc11f8084https://dart-review.googlesource.com/c/sdk/+/366683
Reviewed-by: Alexander Aprelev <aam@google.com >
Commit-Queue: Ryan Macnak <rmacnak@google.com >
2024-05-16 16:33:52 +00:00
8b5b1571ae
dds/dap] Fix evaluation tests for new exceptions wrapping failed responses
...
In a recent change I wrapped these exceptions to provide better failure messages in tests, but I missed updating these tests that had matchers against them.
For reasons I don't yet understand, the trybots that ran on that change didn't include these tests so didn't catch this.
Change-Id: I5227842d2317bbe33186670141586c315f98a5c9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/366665
Reviewed-by: Helin Shiah <helinx@google.com >
Reviewed-by: Ben Konyi <bkonyi@google.com >
Commit-Queue: Helin Shiah <helinx@google.com >
2024-05-16 15:51:10 +00:00
762ca98456
[corelib] Update date_time_far_away_dates_test
...
Bug: #37442
Change-Id: I0c04136bc4fdbf2908154a608f09311c5c511da5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/366720
Commit-Queue: Stephen Adams <sra@google.com >
Reviewed-by: Lasse Nielsen <lrn@google.com >
2024-05-16 14:19:18 +00:00
eb413f21fe
[cfe] Remove unused messages
...
Change-Id: I97542c9558b19d634ac562fdde1cb833f0c22d16
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/366666
Reviewed-by: Chloe Stefantsova <cstefantsova@google.com >
Commit-Queue: Johnni Winther <johnniwinther@google.com >
2024-05-16 12:37:49 +00:00
e7dde8377e
[dart2wasm] Port VM fix for #52083 (sync*)
...
dart2wasm's sync* runtime library was mostly copied from VM, but we
didn't get the fix for #52083 in 9cf26fchttps://dart-review.googlesource.com/c/sdk/+/366663 .
Change-Id: I9d82d1bbb4c96ccb9bf411a385f4b7ff395a1c19
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/366671
Reviewed-by: Martin Kustermann <kustermann@google.com >
Commit-Queue: Ömer Ağacan <omersa@google.com >
2024-05-16 11:53:25 +00:00
4ab652b38f
[CFE] Coverage on try bot
...
This runs the strong suite, does coverage, and compares the coverage
(percentage) to the (hardcoded) expected percentage.
Change-Id: I2e7511d7841b19c15139a7c84bf0861b56b81ccc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/366340
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Reviewed-by: Alexander Thomas <athom@google.com >
Commit-Queue: Jens Johansen <jensj@google.com >
2024-05-16 11:48:12 +00:00
8b8ec2aa3d
[gardening] Fix TrySwitchInstanceCall for --no-lazy-dispatchers.
...
TEST=Manual run of the following command line found by the dart
fuzzer:
out/DebugX64/dart --profiler --max_profile_depth=189 \
--sample_buffer_duration=51 --marker_tasks=2 \
--optimization_counter_threshold=31050 --no_load_cse \
--no_lazy_dispatchers pkg/compiler/lib/src/dart2js.dart \
--invoker=test --platform-binaries=out/ReleaseX64 \
--out=out/dartfuzz/5.js --no-source-maps \
pkg/compiler/lib/src/util/memory_compiler.dart
Change-Id: If7620b7b7bb76d28f66ffde01af52a62392302c2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/366780
Commit-Queue: Tess Strickland <sstrickl@google.com >
Reviewed-by: Martin Kustermann <kustermann@google.com >
2024-05-16 10:33:58 +00:00
a9d8cd598a
[cfe] Change incremental suite to default to strong mode
...
Change-Id: I551cdc70e07f033a73c9941c307fa68ad3f78a01
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/366761
Reviewed-by: Jens Johansen <jensj@google.com >
Commit-Queue: Johnni Winther <johnniwinther@google.com >
2024-05-16 09:45:39 +00:00
05df51c962
[vm] Use newer language version in package:vm which removes some unnecessary casts
...
TEST=ci
Change-Id: Ic1218bddf1879054f1d35ac550224a294d03cda8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/366664
Commit-Queue: Martin Kustermann <kustermann@google.com >
Reviewed-by: Slava Egorov <vegorov@google.com >
2024-05-16 08:57:40 +00:00
d8e6d26159
[cfe] Remove isNonNullableByDefault from various functions
...
Change-Id: I757b3be578f5ce6489482cdcaae45480ed20ce68
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/366660
Commit-Queue: Johnni Winther <johnniwinther@google.com >
Reviewed-by: Chloe Stefantsova <cstefantsova@google.com >
2024-05-16 08:20:28 +00:00
eccaf152ee
[cfe] Change more nnbd default modes to strong
...
Change-Id: Iab51c30024764ebd1c82991ad8687e7accf999f9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/366661
Reviewed-by: Jens Johansen <jensj@google.com >
Commit-Queue: Johnni Winther <johnniwinther@google.com >
2024-05-16 07:44:10 +00:00
5a6b2421bf
[dds/dap] Improve reporting of failed requests in DAP tests
...
This improves the failure messages that will show in tests if a DAP request unexpectedly fails.
Before:
```
Instance of 'Response'
```
After:
```
Request "evaluate" failed:
{
"seq": 17,
"type": "response",
"body": {
"error": {
"format": "{message}",
"id": 1,
"showUser": true,
"variables": {
"message": "This is a test failure",
"stack": "#0 DartDebugAdapter.evaluateRequest (package:dds/src/dap/adapters/dart.dart:1046:5)\n#1 (SNIP)\n"
}
}
},
"command": "evaluate",
"message": "This is a test failure",
"request_seq": 8,
"success": false
}
```
Might help diagnose https://github.com/dart-lang/sdk/issues/55705 .
Change-Id: If9edad16090a8bd09e22dd9b772401763d281f8b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/366640
Commit-Queue: Helin Shiah <helinx@google.com >
Reviewed-by: Ben Konyi <bkonyi@google.com >
Reviewed-by: Helin Shiah <helinx@google.com >
2024-05-15 22:17:18 +00:00
38d7d5d663
[vm, compiler] Account for IndirectGotoInstr with 1 successor in register allocation.
...
TEST=dartfuzz
Bug: https://github.com/dart-lang/sdk/issues/55686
Change-Id: I58f772d80063c0b44613224bf4eb3980d2d9e2b4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/366067
Commit-Queue: Ryan Macnak <rmacnak@google.com >
Reviewed-by: Alexander Markov <alexmarkov@google.com >
2024-05-15 16:53:58 +00:00
e8abe2711c
analyzer: Remove NodeLintRuleWithContext
...
Cq-Include-Trybots: luci.dart.try:flutter-analyze-try,analyzer-win-release-try,pkg-win-release-try
Change-Id: I9b80e132906890b29a7cd939334829350756b423
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/366504
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2024-05-15 16:36:08 +00:00
5c9c98c3ef
[deps] Roll dart-lang/native
...
Closes: https://github.com/dart-lang/sdk/issues/55712
Change-Id: Ibc5bd26b063444205005ba3b2f612c010bd977a5
Cq-Include-Trybots: luci.dart.try:pkg-win-release-try,pkg-win-release-arm64-try,pkg-mac-release-try,pkg-mac-release-arm64-try,pkg-linux-release-try,pkg-linux-release-arm64-try,pkg-linux-debug-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/366622
Reviewed-by: Hossein Yousefi <yousefi@google.com >
Auto-Submit: Daco Harkes <dacoharkes@google.com >
Commit-Queue: Daco Harkes <dacoharkes@google.com >
2024-05-15 12:03:15 +00:00
30e4861d9b
[cfe] Run weak suite only on dart2js
...
Change-Id: I96aa868dd9ac5cf8c7c5592607c0d87e3f2d9bc7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/366620
Reviewed-by: Jens Johansen <jensj@google.com >
Commit-Queue: Johnni Winther <johnniwinther@google.com >
2024-05-15 11:33:06 +00:00
10429f4e89
[dart2wasm] Add a bit more documentation to pkg/dart2wasm/doc/*
...
Adds some more documentation about
* using `wami` to dump section stats / wasm code
* building & testing dart2wasm
...
Change-Id: I439daf04d8f4599e817577c3b4cb58053a836b47
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/365806
Commit-Queue: Martin Kustermann <kustermann@google.com >
Reviewed-by: Ömer Ağacan <omersa@google.com >
2024-05-15 11:11:27 +00:00
1e6c9b026f
[vm/libs] Improve JsonUtf8Decoder performance.
...
This CL focuses on improving parsing of white space (between
JSON tokens) and simple strings which don't contain escape
sequences inside.
Improvements are achieved by changing the code to
table driven implementation instead of if-cascade: we
have a 256 element table which stores attributes for characters
(e.g. whether it is a white space or a terminal token for
a simple string) and use this table to make decisions
on whether to advance through characters or stop a loop and
do something else.
We also suppress bounds checks and interrupt checks in tight
loops - in tight loops like this a bound checks can cost
30% in overhead.
This CL brings 28% geomean improvement on benchmarks from the linked issue. (All measurements are done in X64 Product AOT)
Individual measurements are:
| Input JSON | ms/iter | vs HEAD | vs V8 |
| ---------- | ------- | ------- | ----- |
| apache_builds.json | 0.44 | 61.06% | 136.86% |
| canada.json | 31.04 | 96.54% | 187.15% |
| citm_catalog.json | 6.43 | 64.44% | 93.94% |
| github_events.json | 0.23 | 59.02% | 128.86% |
| google_maps_api_compact_response.json | 0.10 | 82.12% | 133.83% |
| google_maps_api_response.json | 0.12 | 68.79% | 140.07% |
| gsoc-2018.json | 9.25 | 44.89% | 147.43% |
| instruments.json | 1.08 | 70.18% | 167.38% |
| marine_ik.json | 21.07 | 88.25% | 142.58% |
| mesh.json | 4.51 | 94.56% | 136.57% |
| mesh.pretty.json | 9.97 | 83.76% | 193.79% |
| numbers.json | 0.57 | 91.88% | 83.37% |
| random.json | 3.79 | 78.32% | 107.18% |
| repeat.json | 0.06 | 71.51% | 118.47% |
| semanticscholar-corpus.json | 37.65 | 54.82% | 57.81% |
| tree-pretty.json | 0.17 | 68.68% | 162.33% |
| twitter_api_compact_response.json | 0.06 | 75.23% | 126.11% |
| twitter_api_response.json | 0.08 | 70.64% | 123.60% |
| twitterescaped.json | 3.88 | 84.66% | 177.94% |
| twitter.json | 3.54 | 73.01% | 105.33% |
| twitter_timeline.json | 0.37 | 81.52% | 271.37% |
| update-center.json | 2.85 | 66.75% | 89.01% |
vs HEAD (geomean): 72.94%
vs V8 (geomean): 130.99%
HEAD vs V8 (geomean): 179.59%
Issue https://github.com/dart-lang/sdk/issues/55522
TEST=covered by co19
Change-Id: Id673118c19250ab7781cc98c7656b972debc60ff
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/365803
Reviewed-by: Alexander Markov <alexmarkov@google.com >
Commit-Queue: Slava Egorov <vegorov@google.com >
2024-05-15 09:56:20 +00:00
da4bf60a09
[wasm_builder] Update incorrect docs, some minor refactoring
...
- Imported things (modules, globals, tables, functions) don't need to
declared before defining things, as we don't assign indices to things
before finalizing the IR, and when finalizing we assign ids to
imported things before defined things, in
`finalizeImportsAndBuilders`.
Remove documentation saying imports should be declared before
definitions.
`FunctionsBuilder._functions` list was used in the name section, and
required imports to come before definitions. This list is now removed,
instead we pass `[...imported, ...defined]` to the names section.
- Stop upcasting imported things to `Import` before we need to upcast.
- Fix global lists passed to `NameSection`.
These lists need to include imports as well (even though we never name
them, wasm_builder doesn't allow naming them yet) otherwise the
indices in the name section will be incorrect.
wasm_builder doesn't allow importing types yet, so we don't need to do
the same for the types list.
Change-Id: Id05632c3af7937bd66d7581d89d538137020f6e6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/366601
Commit-Queue: Ömer Ağacan <omersa@google.com >
Reviewed-by: Martin Kustermann <kustermann@google.com >
2024-05-15 09:49:02 +00:00
0299c05481
[dart2wasm] Roll back binaryen version to one commit before optimization bug
...
Issue https://github.com/WebAssembly/binaryen/issues/6593
Change-Id: If7dc1fe279b0d8be8e4e84d243b5e96c31e5eef9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/366621
Reviewed-by: Ömer Ağacan <omersa@google.com >
Commit-Queue: Martin Kustermann <kustermann@google.com >
2024-05-15 09:48:16 +00:00
ae03b57cbb
[cfe] Remove .isNonNullableByDefault from package:kernel
...
This removes the .isNonNullableByDefault properties and similar from
the AST nodes in package:kernel. NNBD is now always enabled so these
properties are trivial.
TEST=existing
Change-Id: I75ca0551ac4b5910ea63530dd0c9c2e68bd01aff
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/366320
Commit-Queue: Johnni Winther <johnniwinther@google.com >
Reviewed-by: Chloe Stefantsova <cstefantsova@google.com >
Reviewed-by: Alexander Markov <alexmarkov@google.com >
Reviewed-by: Sigmund Cherem <sigmund@google.com >
2024-05-15 08:31:38 +00:00
4bf22f41f3
[cfe] Use sound null safety for outline and modular suites
...
Change-Id: Ideee9917b2e5b819672c7e441d051f9bc57c86c6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/366342
Reviewed-by: Jens Johansen <jensj@google.com >
Commit-Queue: Johnni Winther <johnniwinther@google.com >
2024-05-15 08:27:25 +00:00
732d95288a
Update OWNERS to avoid incorrect reviewer assignments
...
This helps to make "suggest owners" more accurate.
Change-Id: Iea61eb8a1307bf88bffaf0c1c86dddf4bdcfd597
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/366600
Reviewed-by: Slava Egorov <vegorov@google.com >
2024-05-15 08:27:20 +00:00
3afb61aa7a
[vm] Use Hash as TypeArguments canonicalization hash
...
Fixes https://github.com/dart-lang/sdk/issues/55666
TEST=ci
Change-Id: Ib7d53e14f5be0f56851576dec2e6a3f136b41e44
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/366301
Commit-Queue: Slava Egorov <vegorov@google.com >
Reviewed-by: Ryan Macnak <rmacnak@google.com >
2024-05-15 08:06:29 +00:00
0307423810
[wasm_builder] Remove array.new_data handling in global sections
...
As of 2025/05/14, `array.new_data` is not a constant instruction, so
can't be used in a global initializer.
Also, data count section needs to appear right before the code section.
Without `array.new_data` we don't need to generate it before the global
section.
Remove the code related to handling `array.new_data` in global sections.
When `array.new_data` becomes constant, we can generate the data count
section in its new place always, without having to specially handle it
when it's used in a global section.
Change-Id: If11824e171d7f21848e82c102f0a4e8257f02c6f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/366341
Reviewed-by: Martin Kustermann <kustermann@google.com >
Commit-Queue: Ömer Ağacan <omersa@google.com >
2024-05-15 07:55:13 +00:00
de68b22e84
Bump actions/checkout from 4.1.4 to 4.1.5
...
Closes https://github.com/dart-lang/sdk/pull/55699
GitOrigin-RevId: f1980c676eb2c4da6f92288859422618ed721d78
Change-Id: I2e77c75c0941f2418f94ef9e7283e10fa6680b5a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/366083
Reviewed-by: Alexander Thomas <athom@google.com >
2024-05-15 05:39:03 +00:00
54fc1b1c72
linter: Remove deprecated NodeLintRegistry.addOnClause
...
Cq-Include-Trybots: luci.dart.try:flutter-analyze-try,analyzer-win-release-try,pkg-win-release-try
Change-Id: I3c1b1ee14591b21c9ea718178e0650a84bf51d95
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/366404
Auto-Submit: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Commit-Queue: Phil Quitslund <pquitslund@google.com >
2024-05-14 23:36:05 +00:00
3f53542c5a
[wildcards] update UNUSED_LOCAL_VARIABLE for wildcards
...
Updates `UNUSED_LOCAL_VARIABLE` to flag `__`s when the wildcard variables feature is enabled.
Fixes: https://github.com/dart-lang/sdk/issues/55719
The implementation is quick so I'm very open to feedback.
Also, I'm not sure how exhaustively we want/need to test. Coverage is incomplete and I'm not sure it needs to be *but* for sure if there are interesting cases missed, please do let me know!
Change-Id: I4d95d5b94141fa033b3c426ac4b5a721a12fc107
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/366403
Reviewed-by: Kallen Tu <kallentu@google.com >
Commit-Queue: Phil Quitslund <pquitslund@google.com >
2024-05-14 23:11:28 +00:00
88f5c43c0c
Update DevTools rev to e2a7208bb8eed852b1f9dedabf423f187e947a7d
...
Change-Id: Ic0adaf47ec1d8499a6b31f3fb0851b86b4feff7d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/366223
Reviewed-by: Ben Konyi <bkonyi@google.com >
Commit-Queue: Kenzie Davisson <kenzieschmoll@google.com >
2024-05-14 22:22:27 +00:00
261e1181be
Stop creating synthetic identifiers to use as error nodes.
...
By changing the type of error nodes to SyntacticEntity, we can use
Token objects directly as error nodes, rather than having to wrap them
in synthetic identifiers.
Change-Id: I29c2fec7007766b8bc6103da835093ea326e939b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/366420
Commit-Queue: Paul Berry <paulberry@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2024-05-14 21:01:11 +00:00
7c5437b8bf
linter: Avoid infinite loop in avoid_redundant_argument_values
...
Fixes https://github.com/dart-lang/linter/issues/4970
Change-Id: I75e6fd554f12038acbd7604f52b2fe50d11a682d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/366500
Auto-Submit: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Phil Quitslund <pquitslund@google.com >
Reviewed-by: Phil Quitslund <pquitslund@google.com >
2024-05-14 20:59:48 +00:00
480e631727
[io/ssl] Avoid reinitiating racing handshake request.
...
When other side closes their write socket during us running handhsake, don't repeat handshake. Repeated handshake call results in boringssl secure filter data race between ongoing encryption/decryption sequence and this new handshake call, running concurrently.
Fixes https://github.com/dart-lang/sdk/issues/53136
TEST=secure_session_resume_test on TSAN
CoreLibraryReviewExempt:no user-visible changes to io functionality
Change-Id: I7540b41b15b3a7487a237b6957314e38b078a774
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/366401
Reviewed-by: Ryan Macnak <rmacnak@google.com >
Commit-Queue: Alexander Aprelev <aam@google.com >
2024-05-14 20:50:33 +00:00
595fcd6d80
Enable SocketOptions.tcpNoDelay in the kernel compilation service.
...
This makes compilation of the JSON macro about twice as fast.
Change-Id: I8ba5e1791a2b99d0c3804145ba178d6d0acb750e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/366520
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Jake Macdonald <jakemac@google.com >
Auto-Submit: Jake Macdonald <jakemac@google.com >
2024-05-14 20:14:07 +00:00
771ef3dd8e
Bump ossf/scorecard-action from 2.3.1 to 2.3.3
...
Closes https://github.com/dart-lang/sdk/pull/55700
GitOrigin-RevId: 1201687058814015a4771089080d0eaa16cbe18e
Change-Id: Idccd954825450ba0c96f5fbdf13dbfc864ae6f82
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/366082
Reviewed-by: Alexander Thomas <athom@google.com >
2024-05-14 19:53:06 +00:00
9b9e8ed991
[deps] rev ecosystem, http, source_map_stack_trace, source_maps, source_span, sse, stack_trace, stream_channel, string_scanner, term_glyph, tools, typed_data, watcher, web, web_socket_channel, webdev, yaml, yaml_edit
...
Revisions updated by `dart tools/rev_sdk_deps.dart`.
ecosystem (https://github.com/dart-lang/ecosystem/compare/5890417..ad9da15 ):
ad9da15 2024-05-13 Devon Carew add 'unnecessary_library_name' to package:dart_flutter_team_lints (dart-lang/ecosystem#252 )
http (https://github.com/dart-lang/http/compare/fdb0d36..4722e03 ):
4722e03 2024-05-14 Brian Quinlan Prepare http_profile for publish (dart-lang/http#1197 )
source_map_stack_trace (https://github.com/dart-lang/source_map_stack_trace/compare/4671c20..6834af5 ):
6834af5 2024-05-13 dependabot[bot] Bump actions/checkout from 4.1.4 to 4.1.5 in the github-actions group (dart-lang/source_map_stack_trace#54 )
f356e62 2024-05-13 Devon Carew blast_repo fixes (dart-lang/source_map_stack_trace#53 )
source_maps (https://github.com/dart-lang/source_maps/compare/c4dc7d0..181a41c ):
181a41c 2024-05-13 dependabot[bot] Bump actions/checkout from 4.1.4 to 4.1.5 in the github-actions group (dart-lang/source_maps#93 )
a3d7c5c 2024-05-13 Devon Carew blast_repo fixes (dart-lang/source_maps#92 )
source_span (https://github.com/dart-lang/source_span/compare/1695904..e80cb44 ):
e80cb44 2024-05-13 dependabot[bot] Bump actions/checkout from 4.1.4 to 4.1.5 in the github-actions group (dart-lang/source_span#112 )
c2743b4 2024-05-13 Devon Carew blast_repo fixes (dart-lang/source_span#111 )
sse (https://github.com/dart-lang/sse/compare/f5ed4d6..1bb0a98 ):
1bb0a98 2024-05-13 dependabot[bot] Bump actions/checkout from 4.1.4 to 4.1.5 in the github-actions group (dart-lang/sse#110 )
184d72e 2024-05-13 Devon Carew blast_repo fixes (dart-lang/sse#109 )
stack_trace (https://github.com/dart-lang/stack_trace/compare/54c7b9d..4d346f7 ):
4d346f7 2024-05-13 dependabot[bot] Bump actions/checkout from 4.1.4 to 4.1.5 in the github-actions group (dart-lang/stack_trace#154 )
2b053bf 2024-05-13 Devon Carew blast_repo fixes (dart-lang/stack_trace#153 )
stream_channel (https://github.com/dart-lang/stream_channel/compare/ba35137..61ad872 ):
61ad872 2024-05-13 dependabot[bot] Bump actions/checkout from 4.1.4 to 4.1.5 in the github-actions group (dart-lang/stream_channel#106 )
73746a0 2024-05-13 Devon Carew blast_repo fixes (dart-lang/stream_channel#105 )
string_scanner (https://github.com/dart-lang/string_scanner/compare/6e893af..32468bd ):
32468bd 2024-05-13 dependabot[bot] Bump actions/checkout from 4.1.4 to 4.1.5 in the github-actions group (dart-lang/string_scanner#74 )
395dc7e 2024-05-13 Devon Carew blast_repo fixes (dart-lang/string_scanner#73 )
term_glyph (https://github.com/dart-lang/term_glyph/compare/c3e323b..a46b48b ):
a46b48b 2024-05-13 dependabot[bot] Bump actions/checkout from 4.1.4 to 4.1.5 in the github-actions group (dart-lang/term_glyph#52 )
cc75160 2024-05-13 Devon Carew blast_repo fixes (dart-lang/term_glyph#51 )
tools (https://github.com/dart-lang/tools/compare/d35d633..86b3661 ):
86b3661 2024-05-13 dependabot[bot] Bump the github-actions group with 2 updates (dart-lang/tools#270 )
760015a 2024-05-13 Devon Carew blast_repo fixes (dart-lang/tools#269 )
typed_data (https://github.com/dart-lang/typed_data/compare/5b3708e..fb1958c ):
fb1958c 2024-05-13 dependabot[bot] Bump actions/checkout from 4.1.4 to 4.1.5 in the github-actions group (dart-lang/typed_data#87 )
9c4cb6f 2024-05-13 Devon Carew blast_repo fixes (dart-lang/typed_data#86 )
watcher (https://github.com/dart-lang/watcher/compare/42308ea..c182cd3 ):
c182cd3 2024-05-13 dependabot[bot] Bump actions/checkout from 4.1.4 to 4.1.5 in the github-actions group (dart-lang/watcher#167 )
c7e8d2c 2024-05-13 Devon Carew blast_repo fixes (dart-lang/watcher#166 )
web (https://github.com/dart-lang/web/compare/c36d962..d776645 ):
d776645 2024-05-13 dependabot[bot] Bump actions/checkout from 4.1.4 to 4.1.5 in the github-actions group (dart-lang/web#238 )
a59e8b4 2024-05-13 Devon Carew blast_repo fixes (dart-lang/web#237 )
web_socket_channel (https://github.com/dart-lang/web_socket_channel/compare/5f65bae..8c77d6f ):
8c77d6f 2024-05-13 dependabot[bot] Bump actions/checkout from 4.1.4 to 4.1.5 in the github-actions group (dart-lang/web_socket_channel#360 )
758148c 2024-05-13 Devon Carew blast_repo fixes (dart-lang/web_socket_channel#359 )
webdev (https://github.com/dart-lang/webdev/compare/9108903..d46cf50 ):
d46cf50e 2024-05-13 dependabot[bot] Bump actions/checkout from 4.1.4 to 4.1.5 in the github-actions group (dart-lang/webdev#2434 )
86a8502e 2024-05-13 Devon Carew blast_repo fixes (dart-lang/webdev#2433 )
yaml (https://github.com/dart-lang/yaml/compare/022ea64..8fb8147 ):
8fb8147 2024-05-13 dependabot[bot] Bump actions/checkout from 4.1.4 to 4.1.5 in the github-actions group (dart-lang/yaml#164 )
620e34b 2024-05-13 Devon Carew blast_repo fixes (dart-lang/yaml#163 )
yaml_edit (https://github.com/dart-lang/yaml_edit/compare/c4629ad..3191934 ):
3191934 2024-05-13 dependabot[bot] Bump the github-actions group with 2 updates (dart-lang/yaml_edit#79 )
7dbc61d 2024-05-13 Devon Carew blast_repo fixes (dart-lang/yaml_edit#78 )
Change-Id: I20a413371e3adc9a53e27e1308eac04753a434f9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/366440
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Devon Carew <devoncarew@google.com >
2024-05-14 17:53:47 +00:00
3db9fd328b
Macro. Pass 'packagesFileUri' when compiling using KernelCompilationService.
...
Change-Id: I2cdb9864a2c824ca568ded1a8b7c2c7b0d74de5d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/366402
Reviewed-by: Morgan :) <davidmorgan@google.com >
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Reviewed-by: Jake Macdonald <jakemac@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2024-05-14 17:52:29 +00:00
d45304cd6f
[vm] Add support for the Zalasr extension.
...
TEST=ci
Change-Id: Ic1a98751ac6b46310e420b44f487720f0dc237c8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/366162
Commit-Queue: Ryan Macnak <rmacnak@google.com >
Reviewed-by: Alexander Aprelev <aam@google.com >
2024-05-14 16:40:59 +00:00
d73f534cd9
[macros] quick fix for EXTENSION_AUGMENTATION_HAS_ON_CLAUSE
...
Change-Id: I4521f742bfb60d7ff03dc76fe3ac6ea2810bb84f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/366400
Commit-Queue: Phil Quitslund <pquitslund@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2024-05-14 16:18:30 +00:00
c37ccccae4
Fixed _writeSuperMemberInvocation in DartEditBuilderImpl to properly suggest completions when super member has named parameters
...
Closes https://github.com/dart-lang/sdk/pull/55697
GitOrigin-RevId: 8a43d8595921a271eb54e7c8aa9966fe559e1fd4
Change-Id: I393b17fc26eda821615f2d2d29cb386ab5f98406
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/366081
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2024-05-14 16:01:33 +00:00
b06a34fc5a
Don't allow completing a _Future with itself.
...
This never worked. It was silently accepted, at least if the future had no listeners, then any later attempt to use the future would cause a stack overflow or other impossible results.
Moves some `_Future._complete` call out of try-catch.
The `_complete` shouldn't throw (but before this fix it could).
Moving them out of the `try`/`catch` makes such errors be reported
as unhandled, instead of catching them and trying to complete the same
future again with an error, when it's possibly in an inconsistent state.
Fixes #43662 .
Based on https://github.com/dart-lang/sdk/issues/43662#issuecomment-2058870247
CoreLibraryReviewExempt: No response.
Bug: http://dartbug.com/43662
Change-Id: I96a4f01bcd5b6cee93bba267299852569a9b905c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/363060
Commit-Queue: Lasse Nielsen <lrn@google.com >
Reviewed-by: Nate Bosch <nbosch@google.com >
Reviewed-by: Martin Kustermann <kustermann@google.com >
2024-05-14 15:44:07 +00:00
e4c1985c79
[macros] Copy macros and _macros into package:json as a workaround.
...
Change-Id: I3e9ce2c21b55661eb25f6523e1912fba6d364a4b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/366380
Commit-Queue: Morgan :) <davidmorgan@google.com >
Reviewed-by: Jake Macdonald <jakemac@google.com >
2024-05-14 15:42:45 +00:00
6824371d2f
analyzer: simplify _computeLints
...
It doesn't need an `analysisOptions` parameter, as that is an instance
variable.
It doesn't need the LinterContextUnit, as that is fetched from the
UnitAnalysis object.
Cq-Include-Trybots: luci.dart.try:flutter-analyze-try,analyzer-win-release-try,pkg-win-release-try
Change-Id: Id375ea5c727617cd6dc806bc2885da389aa9e691
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/366222
Commit-Queue: Phil Quitslund <pquitslund@google.com >
Auto-Submit: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Phil Quitslund <pquitslund@google.com >
2024-05-14 15:23:08 +00:00
9f94984af2
[kernel] Clarify what TreeNode.fileOffset indexes, some rephrasing
...
- Rephrase AssertStatement offset documentations to be consistent with
the TreeNode.fileOffset documentation.
- Use a noun phrase in `TreeNode.fileOffsetsIfMultiple`, as per
Effective Dart recommendation.
Change-Id: If3f8acb47a96effbda2526819badb943b6e6062f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/366360
Reviewed-by: Jens Johansen <jensj@google.com >
Commit-Queue: Ömer Ağacan <omersa@google.com >
2024-05-14 15:06:25 +00:00
f774ec53e7
[CFE] Shard strong suite in unit_test_suites more
...
Before this CL the weak suite had 10 shards but the strong suite only
had 2 shards.
This CL makes the strong suite have 10 shards as well.
Change-Id: Ia1b228ed7159b7b2ca04d2ea12abe57f2b1a2658
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/365828
Commit-Queue: Jens Johansen <jensj@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
2024-05-14 09:56:09 +00:00
310775bd43
[cfe] Remove isNonNullableByDefault argument from messages
...
Legacy libraries are no longer supported so nullabilities are always
shown in messages.
TEST=existing
Change-Id: Ic1a444c3f5d98baff70a60a2ad0d316d487ea250
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/365824
Commit-Queue: Johnni Winther <johnniwinther@google.com >
Reviewed-by: Chloe Stefantsova <cstefantsova@google.com >
Reviewed-by: Srujan Gaddam <srujzs@google.com >
Reviewed-by: Alexander Markov <alexmarkov@google.com >
2024-05-14 09:32:01 +00:00
Devon Carew