dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
105,778 Commits 2 Branches 0 Tags
25bd38bbe287c78e77dbcde795458f032dbd95ae
Commit Graph

505 Commits

Author SHA1 Message Date
Danny Tuppeny 4be9188379 [analysis_server] Support occurrences (Document Highlights) with different lengths 
+ split unnamed constructors from classes

Fixes https://github.com/Dart-Code/Dart-Code/issues/4454

Change-Id: I42e7346b7c22348cf6424d15c5c35a24e31c85b3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/406822
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2025-02-03 12:05:53 -08:00
Konstantin Shcheglov 6e17841614 Macro. Remove tests from analyzer/ and analysis_server/. 
Change-Id: Iabe04d7ff8fe0cc9b605d0c18fd47591fd02d6bd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/406681
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2025-01-29 14:58:19 -08:00
Danny Tuppeny 154b473cdb [analysis_server] Fix missing dartdoc references in Library comments 
Fixes https://github.com/dart-lang/sdk/issues/59946

Change-Id: I3b8558f72b6cc932f2c87ee4f2e993c5584907a7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/405361
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2025-01-22 13:00:30 -08:00
FMorschel 667730a0b5 [DAS] Fixes import prefix highlighting 
R=scheglov@google.com

Fixes: https://github.com/dart-lang/sdk/issues/59942
Change-Id: Id5c971f040dc2dcdddde6e36055e9045eb4b2aef
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/404925
Auto-Submit: Felipe Morschel <git@fmorschel.dev>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
 2025-01-20 10:11:52 -08:00
Konstantin Shcheglov a5468363c6 CQ. Remove unnecessary 'async' where no 'await'. 
Change-Id: I58f56c098c9cec753325ab56d0aad37e1fde0ec6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/403082
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2025-01-07 10:08:11 -08:00
Brian Wilkerson c02b3a4ea8 [Migration] occurrences_dart.dart 
Change-Id: I55f821655ed5f2430e752748231bdf1a1c0279e0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/402840
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2025-01-03 09:09:59 -08:00
Danny Tuppeny 922ad1b95e [analyzer/analysis_server] Migrate navigation to new element model 
Change-Id: I5cb132de15e103c5fdba22e7033317ee2013f886
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/399106
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Ivan Inozemtsev <iinozemtsev@google.com>
 2024-12-19 04:55:11 -08:00
Chloe Stefantsova 0b5e5c6b66 [analyzer] Add tests for null-aware elements and navigation to type 
Part of https://github.com/dart-lang/sdk/issues/56989

Change-Id: I162272e95f0b843b176d3a1708311991cea6017a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/398882
Reviewed-by: Keerti Parthasarathy <keertip@google.com>
Commit-Queue: Chloe Stefantsova <cstefantsova@google.com>
 2024-12-05 07:00:02 +00:00
Chloe Stefantsova d2135e7880 [analyzer] Add tests for null-aware elements and navigation to definition 
Part of https://github.com/dart-lang/sdk/issues/56989

Change-Id: I0249fb24540736934ebf4e536f5424b8b1e14ded
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/398880
Commit-Queue: Chloe Stefantsova <cstefantsova@google.com>
Reviewed-by: Keerti Parthasarathy <keertip@google.com>
 2024-12-05 06:59:21 +00:00
Chloe Stefantsova 630dcee666 [analyzer] Add tests for null-aware elements in hover info 
Part of https://github.com/dart-lang/sdk/issues/56989

Change-Id: I94eddeb84705ee11d9976442feb7772c864c74b8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/398061
Reviewed-by: Keerti Parthasarathy <keertip@google.com>
Commit-Queue: Chloe Stefantsova <cstefantsova@google.com>
 2024-12-03 08:26:22 +00:00
Danny Tuppeny 526c575fef [analysis_server] Exclude parameter information when hovering over binary operator RHS argument 
Similar to the previous Hover change that excluded parameter for expressions passed to setters, this does the same for binary operators (where hovering the expression on the right side would also show the parameter info).

Change-Id: I6a2eb0d60ddcc64912b09e7c69bfc44cc700c619
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/392940
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2024-11-12 18:26:13 +00:00
Danny Tuppeny 5fcbb32060 [analysis_server] Migrate hovers to new element model 
(also fixes https://github.com/dart-lang/sdk/issues/56933)

Change-Id: I0ae66313d9c11012f42093631158c2f2df00d938
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/391644
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2024-11-12 17:47:13 +00:00
Sam Rawlins 73443c8603 DAS: Generated protocol 'enums' can be real enums 
File sizes are reduced:

```
analysis_server_client's protocol_common.dart    - 132k -> 102k (-23%)
analysis_server_client's protocol_generated.dart - 453k -> 433k (- 4%)
analysis_server's        protocol_generated.dart - 528k -> 509k (- 3%)
analyzer_plugin's        protocol_common.dart    - 139k -> 108k (-22%)
```

Change-Id: I8018f1d09e053c9d3df340ba31cdb07cbd29acf7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/392842
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2024-11-07 17:27:18 +00:00
Sam Rawlins fbf331e0dd DAS: reformat source code with tall-style 
Change-Id: I42b4a44fd6a2197e499e8623274b3cd1a4b5556f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/394003
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2024-11-06 23:04:00 +00:00
Danny Tuppeny 56fc83656a [analysis_server] Fix occurrences highlighting for prefixed identifiers 
Fixes https://github.com/dart-lang/sdk/issues/56981

Change-Id: I817625962b5a4975ec5f597ab147fe7312cdf06f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/392580
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2024-10-30 15:27:39 +00:00
Danny Tuppeny 40b9153fab [analysis_server] Fix semantic tokens/highlights skipping annotations on super parameters 
+ treat super parameters that reference field formals as field references, the same as field formals themselves.

Fixes https://github.com/Dart-Code/Dart-Code/issues/5247

Change-Id: I5ea841a32445a141a3cf46d8662154f2e9950ebe
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/383580
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2024-09-06 14:34:59 +00:00
Konstantin Shcheglov 67c21f7b67 Migrate from 'import augment' to 'part' in analysis_server/. 
Change-Id: Iac57024ab48ed389b4578bc0fb2a2e620533812b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/383420
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Keerti Parthasarathy <keertip@google.com>
 2024-09-03 19:45:55 +00:00
pq c371785d42 [wildcards] legacy navigation tests 
See: https://github.com/dart-lang/sdk/issues/56567

Change-Id: I0abf861903e440f3bc6162e671c71d134786e8d4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/382280
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2024-08-26 23:05:57 +00:00
pq a4a146d3c4 [wildcards] legacy occurrences tests 
See: https://github.com/dart-lang/sdk/issues/55681

Change-Id: I5426ef22d56f6c2ab92a2028969cebd867a676ce
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/382242
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2024-08-26 22:59:09 +00:00
Sam Rawlins f60b5bd855 DAS: Add digit separator tests for highlighting 
Work towards https://github.com/dart-lang/sdk/issues/56188

Cq-Include-Trybots: luci.dart.try:flutter-analyze-try,analyzer-win-release-try,pkg-win-release-try
Change-Id: I852c9fe2301c297b8e5ae5b3157153774eaca740
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/380640
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2024-08-15 01:00:16 +00:00
pq 10cbc8f9b3 [wildcards] ensure signatures with wildcard params have types 
See: https://github.com/dart-lang/sdk/issues/55681

Change-Id: Ibbb2771cea0311a6bf2145f663efff07f2f97d31
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/378340
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2024-07-31 21:16:49 +00:00
Danny Tuppeny 916272331b [analysis_server] Remove the singleton uriConverter and pass explicitly to all toJson/fromJson methods 
This avoids accidentally using the converter when talking to plugins, (at least for now) URIs are never expected, and file paths should always be used regardless of which mode the server is in.

This unfortunately touches a _lot_ of code, so I've pushed in many separate patch sets to Gerrit.

Fixes https://github.com/Dart-Code/Dart-Code/issues/5156

Change-Id: I312c3e2cbc35a05a078aaa0138aec7288b3c7dd6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/373745
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2024-07-02 14:15:11 +00:00
Danny Tuppeny d328e9c06a [analysis_server] Add highlights/semantic tokens for augmented() 
+ tests for fetching semantic tokens for macro-generated sources.

Change-Id: I1811e5fd3eb3f5564a1d6f21348f9650e30eb536
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/368421
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
 2024-05-28 19:39:16 +00:00
Sam Rawlins ee5eb9fedc Remove unnecessary Linter parent class, rename linterRegistry 
Linter was in between LintRule and NodeLintRule, but the only subtype
was LintRule so the abstraction was unnecessary. There are lots of
small, nice follow-on effects across the codebase.

Also rename the top-level `lintRegistry` variable to be
`lintRuleTimers` as it is just a mapping of lint rule timers. (I was
confused about what this was because `Analyzer.registeredRules` is the
more general "registry of rules."

Also remove the deprecated, unused `getVisitor` API.

Also remove the unused top-level `linterVersion` string.

Cq-Include-Trybots: luci.dart.try:flutter-analyze-try,analyzer-win-release-try,pkg-win-release-try
Change-Id: Icf75db7786fc2022e271ec6f32fd3aa00b2b4084
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/366840
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
 2024-05-17 03:25:49 +00:00
Konstantin Shcheglov 5c07c89a35 Enable 'unnecessary_final' in analysis_server/. 
Change-Id: I71ee934b915d4aff924cf5925f87bcc9adc6c015
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/362901
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2024-04-16 20:04:15 +00:00
Konstantin Shcheglov d0e4ef7e6c Parse 'augment library' instead of 'library augment'. 
Bug: https://github.com/dart-lang/sdk/issues/55374

Change-Id: I856c21f4b102fa589f5a14c3d28daf64e4112099
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/361286
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Jake Macdonald <jakemac@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2024-04-08 20:34:30 +00:00
Konstantin Shcheglov c5f876b7aa Augment. Use ExtensionOnClause in ExtensionDeclaration, make it optional. 
Change-Id: I696ffd0b8e8f3bf9017b583d480313ec7c7753f7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/360561
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2024-04-02 16:12:00 +00:00
Danny Tuppeny 046f3117b6 [analysis_server] Fix navigation on augmentation directives 
Change-Id: I0972d6c9aa93f1bac180504da96e63ed9f04e63e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/360260
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2024-04-02 16:09:26 +00:00
Konstantin Shcheglov aced0523a4 Augment. Fixes for navigation for constructor annotations. 
...and for import prefixes in augmentations.

Change-Id: I4c2f358d5bd1819c8691990a0b86a37d04449213
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/360505
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2024-04-01 23:06:19 +00:00
Konstantin Shcheglov e7865021fc Augment. Fix semantic highlighting for functions / getters / setters. 
Change-Id: I2f42d10e0d4b6a994e11ef40120a7e7fac91a15b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/355506
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2024-03-05 17:05:50 +00:00
Konstantin Shcheglov 2bdd4c5076 Augment. Support for top-level augmented getter / setter / variable. 
Change-Id: Ie4f59e623ba572092a98e240d34c2eba936e3ea3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/355201
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Keerti Parthasarathy <keertip@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2024-02-29 19:13:10 +00:00
Konstantin Shcheglov 8968e5500a CQ. Enable avoid_redundant_argument_values in analysis_server/ 
Change-Id: If9c09f81bdbac890553573a8491ca27cb4f22dd7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/353805
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2024-02-26 19:51:41 +00:00
Brian Wilkerson cc711c3839 Add support for macros in implements information 
Change-Id: I0406d928625adc5c7e34635d0a89592ec4cafa34
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/353808
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Keerti Parthasarathy <keertip@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2024-02-23 17:50:20 +00:00
Brian Wilkerson 5eeaf42939 Add support for macros in override information 
Change-Id: I308fd21becac53a6ad535b508749a119f8816709
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/353781
Reviewed-by: Keerti Parthasarathy <keertip@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2024-02-22 19:04:51 +00:00
Danny Tuppeny cb578498f7 [analysis_server] Fix some additional tests failing on Windows 
Change-Id: I4f03ecb28f4e440faecc75bc5a99d8fedd0dc402
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/352865
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Keerti Parthasarathy <keertip@google.com>
Commit-Queue: Keerti Parthasarathy <keertip@google.com>
 2024-02-16 17:32:34 +00:00
Keerti Parthasarathy 5394052641 Use the test file to check for navigation results. 
Had added the ability to check navigation for a second file, but tests that use that are timing out on the windows bot. This is an attempt to fix it.

Change-Id: I5b9bbe81edb675442b7d58aa04df335284073fd3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/352981
Commit-Queue: Keerti Parthasarathy <keertip@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2024-02-16 04:04:57 +00:00
Keerti Parthasarathy 974dfa3071 Finally fix the windows bot failure 
Change-Id: I731da6529aebd0679402fa4832ad001b0c1c242e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/352720
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2024-02-14 22:37:59 +00:00
Keerti Parthasarathy 4ef3c33932 Fix navigation test on windows 
Change-Id: I4689e92cc32ca24c3204270bf378ec35d707d4bb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/352480
Commit-Queue: Keerti Parthasarathy <keertip@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2024-02-14 15:48:39 +00:00
Konstantin Shcheglov de6d8cb813 Use File instead of String path in AnalysisHoverTest. 
Change-Id: I945aef29b2f4284ba47597c13a718ea998f535c3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/352381
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Keerti Parthasarathy <keertip@google.com>
 2024-02-13 19:44:20 +00:00
Brian Wilkerson 2a4d527633 Attempt to fix a failure on the windows bot 
Change-Id: Icd170157c9b9db4965c47f7540ae80535f572c35
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/352400
Auto-Submit: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2024-02-13 18:05:29 +00:00
Brian Wilkerson a2574f28d3 Tests to ensure that hovers work with macro generated code 
Change-Id: I745ae1b61e3baf6343cff3eda31dfb8159f67579
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/351700
Reviewed-by: Keerti Parthasarathy <keertip@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2024-02-12 18:17:57 +00:00
Keerti Parthasarathy dc339962c3 Fix test on windows 
Change-Id: Ie2cdd561636e24bc77a5126a159e6e031db5bed6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/351561
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Keerti Parthasarathy <keertip@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2024-02-09 19:33:32 +00:00
Keerti Parthasarathy 987a3e18c2 Add navigation tests for augmentations 
Change-Id: Ia5232beb1c1a4f7f730d0601962d38d24905e813
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/351300
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Keerti Parthasarathy <keertip@google.com>
 2024-02-09 00:43:49 +00:00
Danny Tuppeny 581686b8fb [analysis_server] Consolidate some more writePackageConfig() methods 
+ tidy up some redundant package versions that are inherited from the ConfigurationFiles mixin.

Change-Id: I93329cbf65af3a68ed27284903e7becac01cf5ea
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/349380
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2024-02-01 19:11:27 +00:00
Brian Wilkerson 394538ebf1 Enhance semantic highlighting for macros 
Change-Id: I1d2e26e25f69971ea9a7979290d26c8f63208923
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/349363
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Keerti Parthasarathy <keertip@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2024-02-01 17:10:36 +00:00
Danny Tuppeny 6872a0bb77 [analysis_server] Combine writePackageConfig helpers from LSP and legacy server tests 
Both LSP and legacy server tests had their own implementation of writing package_config files. This combines them by moving the LSP `ConfigurationFilesMixin` mixin to its own file and updating the legacy test classes to use it.

This removes a little duplication and avoids adding more for the temporary packages required for Macros that's currently only in the LSP version (but required for some upcoming LSP-over-Legacy tests).

Change-Id: Iaa4055c544df4cdd5a0f140b0c6171ff1a406946
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/347081
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2024-01-29 21:57:13 +00:00
Danny Tuppeny 0d6dd73877 [analysis_server] Add syntax highlighting to record fields 
Fixes https://github.com/Dart-Code/Dart-Code/issues/4908

Change-Id: I8c425d75ad163a5968f4ce318ef6dc0601978a42
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/345502
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2024-01-10 16:52:25 +00:00
Konstantin Shcheglov 40dfd1befe Report HighlightRegionType.IMPORT_PREFIX for import prefix in NamedType. 
Change-Id: I05ce7fb0010dafe69c6b5926a368350a3486332e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/343541
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2023-12-25 20:29:03 +00:00
Danny Tuppeny b1620d1ba0 [analyzer] Drop return type from element display for setters 
Change-Id: Id580f2c5796b3024b127464ffffdb420511a5632
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/339540
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2023-12-04 06:16:26 +00:00
Danny Tuppeny 7f9099e75a [analysis_server] Fix static type on hovers for non-synthetic getters/setters 
Fixes https://github.com/Dart-Code/Dart-Code/issues/4863

Change-Id: Ie4272b77e81fcee282e22002a8cc3f58611af969
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/338821
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2023-11-29 23:18:09 +00:00