25bd38bbe2
[dds/dap] Enable verbose logging for debug_test
...
I'm struggling to reproduce the flakes noted in https://github.com/dart-lang/sdk/issues/60187 so hopefully verbose logs will help understand what's wrong.
Change-Id: Id76b30b4efc9fb63cfacd01d2df6dc5a8ea4c7eb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/411681
Commit-Queue: Derek Xu <derekx@google.com >
Reviewed-by: Derek Xu <derekx@google.com >
Reviewed-by: Jessy Yameogo <yjessy@google.com >
2025-02-24 09:19:29 -08:00
617e0e1815
Elements. Migrate ResolverVisitor.
...
Use the return type of the method element, not a fragment, as a result
report BODY_MIGHT_COMPLETE_NORMALLY in invalid fragments.
Change-Id: I5a07fcc21695695cf9aeacaf6d35949c69b4c817
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/411480
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2025-02-24 08:54:20 -08:00
d070ea7181
Elements. Fix a TypeImpl cast in BinaryExpressionResolver.
...
Change-Id: I2618b45d89aec3962afef17a5db9c7e387bd56d3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/411500
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2025-02-24 08:32:34 -08:00
efd357fdff
Elements. Return XyzImpl from 'declaration'.
...
Change-Id: I29ae5383aa583f18d31eabb827e6b1aedd43b430
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/411520
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
2025-02-24 07:35:09 -08:00
62dd31e8af
[analyzer] Allow developer experience team to approve message-only CLs.
...
Change-Id: Icb52e0f35f92ff36734917a4693fffe5e811e8e7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/410941
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2025-02-24 06:08:05 -08:00
7d954e54f7
[CFE] Weekly leak tester should accept first compile too
...
This should fix the leak found by the weekly bot.
https://dart-review.googlesource.com/c/sdk/+/411580 should fix the leak
too, but we really should always have run accept here.
Change-Id: I223e03e3ddf90b0c8f08e77da17000ecec60f173
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/411601
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Commit-Queue: Jens Johansen <jensj@google.com >
2025-02-24 06:00:19 -08:00
4e76761147
Bump ossf/scorecard-action from 2.4.0 to 2.4.1
...
Closes https://github.com/dart-lang/sdk/pull/60197
GitOrigin-RevId: 90a3403079028a7abfb0640a514a1e83c1520b50
Change-Id: I1035a72f89b96dd2689b7a1dfa2dc9c42303c2aa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/411561
Reviewed-by: Alexander Thomas <athom@google.com >
2025-02-24 03:53:08 -08:00
01dacf5884
Bump actions/upload-artifact from 4.6.0 to 4.6.1
...
Closes https://github.com/dart-lang/sdk/pull/60196
GitOrigin-RevId: c0c3c7346f1fc0ed346d1675adddb7d030949924
Change-Id: I8c9b00e3073ed9f48ca669d2960a461de8c63c76
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/411560
Reviewed-by: Alexander Thomas <athom@google.com >
2025-02-24 03:52:36 -08:00
1a3f7fadcd
Bump github/codeql-action from 3.28.9 to 3.28.10
...
Closes https://github.com/dart-lang/sdk/pull/60195
GitOrigin-RevId: be05dcace976dd3e3c1d659fc0d53ad53af80b76
Change-Id: Id21ee043f84f7542466c377af7c19033600a9334
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/411521
Reviewed-by: Alexander Thomas <athom@google.com >
2025-02-24 03:52:08 -08:00
9475d56e17
[infra] Support Mac in pkg/dart2wasm/tool/run_benchmark
...
R=kustermann@google.com
Change-Id: I4f0604468402437a3361269a244f9b32dd8969f2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/411302
Reviewed-by: Martin Kustermann <kustermann@google.com >
Commit-Queue: Slava Egorov <vegorov@google.com >
2025-02-24 02:12:01 -08:00
b69cc05249
[infra] Remove .packages and pubspec from js_runtime
...
Change-Id: I8382da009d20200a26f4499c00b736a7240109ec
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/411303
Reviewed-by: Nate Biggs <natebiggs@google.com >
Commit-Queue: Slava Egorov <vegorov@google.com >
2025-02-24 01:31:59 -08:00
7a672b40f4
[analyzer] Sort input for analysis_options signature calculation
...
This, too, would have fixed the issue fixed in
https://dart-review.googlesource.com/c/sdk/+/410700 .
This CL furthermore means that changing the order of the "analyzer:
errors:" entries (or "plugins:" entries) doesn't change the signature.
Change-Id: I6439f985260545dfc2c7e0a75b353b5324ef8f88
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/411040
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Jens Johansen <jensj@google.com >
2025-02-24 00:58:48 -08:00
3df3d4fab4
[analyzer] Remove unnecessary line in test file introduced in cl/410700
...
Follow up to https://dart-review.googlesource.com/c/sdk/+/410700
Change-Id: Ia284b95615bf001950b1755c81d001b0df6490f5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/411241
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Jens Johansen <jensj@google.com >
2025-02-24 00:23:59 -08:00
0324981ae7
[co19] Roll co19 to d285ef839784162ca988a9d149522249d0c00c5c
...
2025-02-20 sgrekhov22@gmail.com Fixes dart-lang/co19#3084 . Update expected errors positions in member_definition_t10.dart (dart-lang/co19#3085 )
2025-02-19 sgrekhov22@gmail.com dart-lang/co19#3057 . Add tests for logical and, or and null-check operators (dart-lang/co19#3082 )
2025-02-19 sgrekhov22@gmail.com dart-lang/co19#3057 . Add more null-check tests (dart-lang/co19#3081 )
2025-02-17 sgrekhov22@gmail.com dart-lang/co19#3057 . Update operator `==` tests updated and add new ones (dart-lang/co19#3077 )
2025-02-17 sgrekhov22@gmail.com dart-lang/co19#3057 . Add instance check tests (dart-lang/co19#3078 )
2025-02-17 sgrekhov22@gmail.com dart-lang/co19#3057 . Add flow analysis tests for throw expression (dart-lang/co19#3076 )
2025-02-17 sgrekhov22@gmail.com dart-lang/co19#3057 . Add more flow analysis tests for type Never. Part 2. (dart-lang/co19#3071 )
2025-02-17 sgrekhov22@gmail.com Fixes dart-lang/co19#3079 . Fix numerous typos in Parts with imports tests (dart-lang/co19#3080 )
2025-02-17 sgrekhov22@gmail.com dart-lang/co19#3057 . Add more flow analysis tests for type Never (dart-lang/co19#3070 )
Cq-Include-Trybots: luci.dart.try:analyzer-linux-release-try
Change-Id: I3d4450e3687fe542737b397aa097d56211534c9b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/411240
Reviewed-by: Alexander Thomas <athom@google.com >
Reviewed-by: Erik Ernst <eernst@google.com >
Commit-Queue: Alexander Thomas <athom@google.com >
2025-02-24 00:08:28 -08:00
d569aeaad3
Bump github/codeql-action from 3.28.8 to 3.28.9
...
Closes https://github.com/dart-lang/sdk/pull/60084
GitOrigin-RevId: 0a38633381dac820f1179840e9019952114e771e
Change-Id: Icec8cb999a7a937883a4bff19bd6fc391809e51b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/408643
Reviewed-by: Alexander Thomas <athom@google.com >
2025-02-23 23:35:55 -08:00
a004960960
[analyzer] Add occurrences tests for null-aware elements
...
Part of https://github.com/dart-lang/sdk/issues/56989
Change-Id: Ic6e48f1579b60a59ddb17c08202232081cbd3bf2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/411243
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Chloe Stefantsova <cstefantsova@google.com >
2025-02-23 23:09:40 -08:00
e8e56ff2f5
Cleanup declarations in server with trailing digits
...
There are still lots of declarations whose name ends in a trailing
digit, but most of them are unrelated to the migration, and some
are required in order to not break internal code.
I'm happy to break this up into smaller CLs if it's hard to review.
Mostly it's just renaming some declarations, although there are one or
two places where I did a little more clean-up.
Change-Id: I50d32316e82e48c6a5a47aec630b4ffee2ead2c8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/410922
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Phil Quitslund <pquitslund@google.com >
2025-02-23 08:17:36 -08:00
fad65ac3b4
Elements. Migrate NamespaceBuilder.
...
Change-Id: I3f51d6ad88528a7a7251a8c140795a442b04e5a9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/411460
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2025-02-21 16:41:39 -08:00
9c9fe8f102
Roll Fuchsia SDK from 27.20250220.5.1 to 27.20250221.4.1
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-dart-sdk
Please CC fuchsia-3p-engprod@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Fuchsia SDK: https://bugs.fuchsia.dev/p/fuchsia/issues/list
To file a bug in Dart SDK: https://github.com/dart-lang/sdk/issues
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.dart.try:vm-fuchsia-release-x64-try;luci.dart.try:vm-fuchsia-release-arm64-try
Change-Id: I85731ded1d0f154dfb3d9f30f43e16d801832c53
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/411400
Commit-Queue: Brian Quinlan <bquinlan@google.com >
Reviewed-by: Zijie He <zijiehe@google.com >
Reviewed-by: Brian Quinlan <bquinlan@google.com >
2025-02-21 15:06:48 -08:00
2227249c2b
[PE] [linter] don’t report require_trailing_commas if language >=3.7
...
Fixes: https://github.com/dart-lang/sdk/issues/60119
Change-Id: If4821300dcae05cd1283558a87481d2bad7dae9c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/411182
Commit-Queue: Phil Quitslund <pquitslund@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2025-02-21 14:09:47 -08:00
3a8ff1083e
Elements. Migrate LabelScope.
...
Change-Id: I9891142ba33ea4d5bca1842ab8414dd89b4142eb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/411442
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2025-02-21 14:01:40 -08:00
c604aa2e77
Elements. Migrate PatternVariableDeclarationImpl.elements
...
Change-Id: I0b7cafe4d1def187bbebdb6d694fab56a9d24a7d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/411441
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2025-02-21 13:54:21 -08:00
3c792ec8d0
Modify error message for const (ASSIGNMENT_TO_CONST)
...
Closes https://github.com/dart-lang/sdk/pull/56953
GitOrigin-RevId: 5452a16747b9c536ae8dfe6d4a9f6a195d53e3d2
Change-Id: Icc1811b39a10cd0fe5b9155c52ef4f133cfc7f14
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/391489
Reviewed-by: Paul Berry <paulberry@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Phil Quitslund <pquitslund@google.com >
Reviewed-by: Phil Quitslund <pquitslund@google.com >
2025-02-21 13:16:59 -08:00
115dcc9609
[migration] constant/value.dart
...
Change-Id: Id1ed8bd41b8efb34124ddda93f1039215caf0651
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/411362
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2025-02-21 12:48:48 -08:00
b4194ea6fb
Elements. Migrate InvocationInferrer.
...
Change-Id: I55fc394c06669e7d8c0d1ffb1449dd73aa6b4bf2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/411363
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2025-02-21 11:54:08 -08:00
db96984d37
[analyzer] Add correction for removing '?' before elements
...
Part of https://github.com/dart-lang/sdk/issues/56989
Change-Id: I36543863eb76724cb23b4521780eccd130750014
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/410042
Commit-Queue: Phil Quitslund <pquitslund@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Phil Quitslund <pquitslund@google.com >
2025-02-21 11:28:29 -08:00
c04de775f3
Roll Fuchsia SDK from 27.20250215.0.1 to 27.20250220.5.1
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-dart-sdk
Please CC fuchsia-3p-engprod@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Fuchsia SDK: https://bugs.fuchsia.dev/p/fuchsia/issues/list
To file a bug in Dart SDK: https://github.com/dart-lang/sdk/issues
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.dart.try:vm-fuchsia-release-x64-try;luci.dart.try:vm-fuchsia-release-arm64-try
Change-Id: I440419c83e58674409a5d89e30d0bbb1dc095977
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/411120
Commit-Queue: Derek Xu <derekx@google.com >
Reviewed-by: Derek Xu <derekx@google.com >
Reviewed-by: Alexander Markov <alexmarkov@google.com >
2025-02-21 10:51:13 -08:00
f61e253a19
Roll BoringSSL from 2b619cc49cbe to 0c59e9e55bda (5 revisions)
...
https://boringssl.googlesource.com/boringssl.git/+log/2b619cc49cbe..0c59e9e55bda
2025-02-20 cinlin@google.com Clarify bssl-sys build instructions.
2025-02-20 davidben@google.com Support PBES2 schemes in PKCS12_create
2025-02-19 davidben@google.com Fix legacy_version in DTLS 1.3 HelloRetryRequest
2025-02-19 davidben@google.com Remove dependencies between bssl_shim and ssl/internal.h
2025-02-19 stefanoduo@google.com Add a way to prefix Android targets names
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/boringssl-dart-sdk
Please CC dart-engprod@google.com ,dart-vm-gardener@grotations.appspotmail.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in BoringSSL: https://crbug.com/boringssl/new
To file a bug in Dart SDK: https://github.com/dart-lang/sdk/issues
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: dart-vm-gardener@grotations.appspotmail.com
Change-Id: I8e8b636f95f43cc7dbfbbe9b212d58098aec255c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/411340
Reviewed-by: Derek Xu <derekx@google.com >
Commit-Queue: Derek Xu <derekx@google.com >
Reviewed-by: Alexander Markov <alexmarkov@google.com >
2025-02-21 10:51:03 -08:00
c4c805da60
[native assets] Single SoT for package name on Dart build
...
Do not use the folder name as a proxy for the package name.
Cq-Include-Trybots: luci.dart.try:pkg-linux-debug-try,pkg-linux-release-arm64-try,pkg-linux-release-try,pkg-mac-release-arm64-try,pkg-mac-release-try,pkg-win-release-arm64-try,pkg-win-release-try
Change-Id: I17664ea88a4e317d994d93ae84a5584078e5f94d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/410360
Commit-Queue: Moritz Sümmermann <mosum@google.com >
Reviewed-by: Daco Harkes <dacoharkes@google.com >
Auto-Submit: Moritz Sümmermann <mosum@google.com >
2025-02-21 08:30:28 -08:00
1c8007dbcd
Elements. Migrate BlockScope.
...
Change-Id: I5f536b2622ce1a2a300e383c88487bdb527a8b8d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/411088
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2025-02-21 08:09:39 -08:00
0b10797968
Elements. Migrate TypeSystemImpl.
...
Change-Id: Ib76d1de117b717ee434177bc85851d8c05a3f54a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/411180
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2025-02-21 08:08:50 -08:00
bbb4a1b4e7
[DAS] Adds base tests for auto-complete on dart docs
...
R=srawlins@google.com
Bug: https://github.com/dart-lang/sdk/issues/59724
Change-Id: Ia2345c77371a58ad0be402daa93642a3f0e53dc7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/410461
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Auto-Submit: Felipe Morschel <git@fmorschel.dev >
2025-02-21 07:57:09 -08:00
31224db2f6
Roll BoringSSL from 8c6b0c04f19f to 2b619cc49cbe (4 revisions)
...
https://boringssl.googlesource.com/boringssl.git/+log/8c6b0c04f19f..2b619cc49cbe
2025-02-18 davidben@google.com Shave an easy 16 bytes off SSL_SESSION
2025-02-18 davidben@google.com Avoid running the X.509 auto-chaining logic twice in TLS clients
2025-02-18 davidben@google.com Remove now unnecessary <openssl/arm_arch.h> includes from assembly
2025-02-18 davidben@google.com Revert "runner: Switch back to filippo.io/mlkem768 for now"
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/boringssl-dart-sdk
Please CC dart-engprod@google.com ,dart-vm-gardener@grotations.appspotmail.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in BoringSSL: https://crbug.com/boringssl/new
To file a bug in Dart SDK: https://github.com/dart-lang/sdk/issues
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: dart-vm-gardener@grotations.appspotmail.com
Change-Id: I7f0a19611828e33b05a7208fd1c2d2408cfd4dfb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/410680
Reviewed-by: Liam Appelbe <liama@google.com >
Reviewed-by: Derek Xu <derekx@google.com >
Commit-Queue: Derek Xu <derekx@google.com >
2025-02-21 07:45:33 -08:00
2c790d3823
[VM/Service] Fix get_perfetto_cpu_samples_rpc_test
...
My change
https://github.com/dart-lang/sdk/commit/f3536c5c4211479918c9de34c9e74d866dd31c52
has made the test start failing on more configs, because now the `fib`
computation isn't lasting long enough for any samples to get collected.
This change makes the `fib` computation take longer.
Issue: https://github.com/dart-lang/sdk/issues/54401
Change-Id: I0f038df21bb116f97a5093e7d2e58ccda7447977
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/411161
Commit-Queue: Derek Xu <derekx@google.com >
Reviewed-by: Liam Appelbe <liama@google.com >
2025-02-21 07:37:23 -08:00
fb3f2633ba
[linter] lines_longer_than_80_chars and document_ignores shouldn't read files
...
* document_ignores read each file once
* lines_longer_than_80_chars read each file for every line > 80 chars (!).
This follows the approach in
https://dart-review.googlesource.com/c/sdk/+/401424 where the same
pattern was identified as bad.
Before this CL, if a file had, say, 1000 lines > 80 chars (and having
the lint enabled), the lint would read the file - from disk - 1000
times. A somewhat saving grace is that for open files - which I guess is
where it's normally run a lot - it normally reads from an overlay file
and thus not from disk.
Except if you are editing a part in which case the open part is an
overlay, but the "parent" (which is for whatever reason also linted) is
read from file. So if you have 1000 lines > 80 chars in the "parent"
file, and is typing in a part file you're in for a really bad time.
This CL should reduce the number of reads in the lint to 0.
Change-Id: Iac6c78f50add1bc7a411c0c244a181f5ca2ea25b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/411300
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Jens Johansen <jensj@google.com >
2025-02-21 06:40:12 -08:00
f66ceaf292
Update date_time_extremes_test to not make assumptions.
...
The test assumes that seconds, milliseconds and occasionally
microseconds will necessarily be zero, which is to optimistic
in practice.
The changed test will use all the values from a source
`DateTime`, and not stop when it thinks it knows the rest.
(Even for UTC values, where it actually does know.)
Change-Id: Ie88e6c33e721f9c7cfba605f0e2cb5f4d2f72218
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/411021
Reviewed-by: Nicholas Shahan <nshahan@google.com >
Commit-Queue: Lasse Nielsen <lrn@google.com >
2025-02-21 02:45:16 -08:00
57e5b2895f
[analyzer] Handle NullAwareElements in Flutter outlines
...
Part of https://github.com/dart-lang/sdk/issues/56989
Change-Id: I32557d994d16b97b8f3b40bb3d654a657338b83e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/411020
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Chloe Stefantsova <cstefantsova@google.com >
2025-02-20 23:32:01 -08:00
b2c8b31af3
[tests] Fix flaky standalone/io/http_auth_digest_test
...
This test has a few independent calls to asyncExpectThrows which uses
asyncStart/asyncEnd. However, multiple top-level asyncStart/asyncEnd
are not allowed, which causes the following flaky error:
```
Unhandled exception:
Exception: Fatal: asyncStart() was called even though we are done with testing.. This is most likely a bug in your test.
#0 asyncStart (package:expect/async_helper.dart:53)
#1 asyncExpectThrows (package:expect/async_helper.dart:140)
#2 testMalformedAuthenticateHeaderWithAuthHandler.<anonymous closure> (file:///b/s/w/ir/cache/builder/sdk/tests/standalone/io/http_auth_digest_test.dart:345)
#3 Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:951)
#4 Future._propagateToListeners (dart:async/future_impl.dart:980)
#5 Future._completeWithValue (dart:async/future_impl.dart:723)
#6 Future._asyncCompleteWithValue.<anonymous closure> (dart:async/future_impl.dart:807)
#7 _microtaskLoop (dart:async/schedule_microtask.dart:40)
#8 _startMicrotaskLoop (dart:async/schedule_microtask.dart:49)
#9 _runPendingImmediateCallback (dart:isolate-patch/isolate_patch.dart:128)
#10 _RawReceivePort._handleMessage (dart:isolate-patch/isolate_patch.dart:195)
--- Re-run this test:
python3 tools/test.py -n vm-aot-ubsan-linux-release-x64 standalone/io/http_auth_digest_test
```
This change attempts to fix this by adding a top-level asyncStart/asyncEnd
and also asyncStart/asyncEnd to the server start/shutdown to
enclose each test case into asyncStart/asyncEnd and avoid printing
"unittest-suite-success" marker before all test cases are finished.
TEST=standalone/io/http_auth_digest_test
Change-Id: I950e7c6c09f5c2144da874ab3be3cd3a130d3790
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/411086
Commit-Queue: Alexander Markov <alexmarkov@google.com >
Reviewed-by: Alexander Aprelev <aam@google.com >
2025-02-20 20:01:52 -08:00
a647f0eed0
[tests] Porting top level deleted member tests to the hot reload framework
...
Change-Id: Ic3561614b75b63556ea91b5a4dd75421cc5d3d5e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/411084
Reviewed-by: Nate Biggs <natebiggs@google.com >
Commit-Queue: Mark Zhou <markzipan@google.com >
2025-02-20 16:29:25 -08:00
a039f8818f
[migration] diagnostic_factory.dart
...
Change-Id: I45da294d218329f312f3f30bfa64d4089b7017fc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/411181
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2025-02-20 16:14:08 -08:00
7ac018eaf4
[element model] migrate error_verifier (import directives, cleanup)
...
Change-Id: Ie413c7ab0cb9e4fdcdf11cec6e726c376e0701af
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/411085
Commit-Queue: Phil Quitslund <pquitslund@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2025-02-20 15:32:29 -08:00
d82c467851
Elements. Rename to VariableFragment.initializer
...
Change-Id: I00e27d560d2b5aaa87db89626c5679aa04b2065a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/411083
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2025-02-20 15:27:59 -08:00
11ab2dfe2f
Revert "[SDK] Switch dds and dtd to use an AOT snapshot"
...
This reverts commit 6450d76f1fhttps://dart-review.googlesource.com/c/sdk/+/387133
> Reviewed-by: Ben Konyi <bkonyi@google.com >
> Commit-Queue: Siva Annamalai <asiva@google.com >
Change-Id: I9985919063cacfc8673b3e2946eaa163e90c9cc3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/411200
Auto-Submit: Ben Konyi <bkonyi@google.com >
Reviewed-by: Siva Annamalai <asiva@google.com >
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com >
Commit-Queue: Siva Annamalai <asiva@google.com >
2025-02-20 15:17:16 -08:00
bc7feacec6
[analysis_server] Fix missing trailing comma when inserting arguments before solo child/children
...
The logic here was bad, assuming we didn't need a trailing comma when inserting an arg before a solo argument (which can happen for child/children).
Fixes https://github.com/flutter/devtools/issues/8921
Change-Id: I38f9003cdc8b499d6417cac7989c65a4760416a6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/411140
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Elliott Brooks <elliottbrooks@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2025-02-20 15:07:32 -08:00
292e00610f
Elements. Migrate AstRewriter.
...
Change-Id: I111acffc6a74ee72e371bcdad2f0db2f1d4b0d20
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/411100
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2025-02-20 14:49:31 -08:00
c957483693
[ddc] Initialize and link the necessary library in debugger APIs
...
Closes https://github.com/dart-lang/sdk/issues/60109
Both getClassMetadata and getClassesInLibrary can be called before
main is called. In order to support this, libraries should be
initialized so that these debugger APIs can inspect them. Similarly,
SDK libraries that are needed before any code can run should be
initialized. In order to support this, they are initialized on the
first initializeAndLinkLibrary call and reinitialized during a
hotRestart (since the libraries are recreated).
Tests are added to evaluate these methods before main is called.
The debugger test helpers are amended to:
- Support breakpoints within the bootstrap script. This is done by
caching the script and querying to see if it has the breakpoint if
the input sources do not.
- Refactor shared test expectation logic.
- Remove an unused method.
Change-Id: I5534d7008436a51243cf51dba01bb8ad06adca69
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/410602
Reviewed-by: Nicholas Shahan <nshahan@google.com >
Commit-Queue: Srujan Gaddam <srujzs@google.com >
2025-02-20 14:15:06 -08:00
0ebec968c9
[migration] rename.dart
...
This also migrates all of refactoring.dart except for one getter that's used internally.
Change-Id: If11f30d740c02509e3eeeac90268b14540e3e0a2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/411080
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2025-02-20 13:40:40 -08:00
d5981addc0
[linter] Issue 60136: Update strict_top_level_inference to ignore wildcard variables.
...
Avoid linting on wildcard variables. Wildcard variables won't be used, so it's okay that the type will be `dynamic`.
Fixes: https://github.com/dart-lang/sdk/issues/60136
Bug: https://github.com/dart-lang/sdk/issues/60136
Change-Id: I6bc0543bfbd3b8eac09ca934fc5098b6c825e1d6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/410940
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Kallen Tu <kallentu@google.com >
2025-02-20 13:24:39 -08:00
24f13524a1
Roll Fuchsia SDK from 27.20250214.4.1 to 27.20250215.0.1
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-dart-sdk
Please CC fuchsia-3p-engprod@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Fuchsia SDK: https://bugs.fuchsia.dev/p/fuchsia/issues/list
To file a bug in Dart SDK: https://github.com/dart-lang/sdk/issues
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.dart.try:vm-fuchsia-release-x64-try;luci.dart.try:vm-fuchsia-release-arm64-try
Change-Id: Ieb201d3e6ca9174f89428f37c0908037fb9ce241
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/410121
Reviewed-by: Zijie He <zijiehe@google.com >
Commit-Queue: Derek Xu <derekx@google.com >
Reviewed-by: Derek Xu <derekx@google.com >
2025-02-20 13:01:10 -08:00
7ca8660229
[element model] migrate error_verifier (_enclosing{Class,Extension})
...
Change-Id: I36ffcb401da8448f1a1df7791af0a0974a0d0d75
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/411082
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Auto-Submit: Phil Quitslund <pquitslund@google.com >
Commit-Queue: Phil Quitslund <pquitslund@google.com >
2025-02-20 12:50:23 -08:00
Danny Tuppeny