a004960960
[analyzer] Add occurrences tests for null-aware elements
...
Part of https://github.com/dart-lang/sdk/issues/56989
Change-Id: Ic6e48f1579b60a59ddb17c08202232081cbd3bf2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/411243
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Chloe Stefantsova <cstefantsova@google.com >
2025-02-23 23:09:40 -08:00
e8e56ff2f5
Cleanup declarations in server with trailing digits
...
There are still lots of declarations whose name ends in a trailing
digit, but most of them are unrelated to the migration, and some
are required in order to not break internal code.
I'm happy to break this up into smaller CLs if it's hard to review.
Mostly it's just renaming some declarations, although there are one or
two places where I did a little more clean-up.
Change-Id: I50d32316e82e48c6a5a47aec630b4ffee2ead2c8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/410922
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Phil Quitslund <pquitslund@google.com >
2025-02-23 08:17:36 -08:00
2227249c2b
[PE] [linter] don’t report require_trailing_commas if language >=3.7
...
Fixes: https://github.com/dart-lang/sdk/issues/60119
Change-Id: If4821300dcae05cd1283558a87481d2bad7dae9c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/411182
Commit-Queue: Phil Quitslund <pquitslund@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2025-02-21 14:09:47 -08:00
db96984d37
[analyzer] Add correction for removing '?' before elements
...
Part of https://github.com/dart-lang/sdk/issues/56989
Change-Id: I36543863eb76724cb23b4521780eccd130750014
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/410042
Commit-Queue: Phil Quitslund <pquitslund@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Phil Quitslund <pquitslund@google.com >
2025-02-21 11:28:29 -08:00
bbb4a1b4e7
[DAS] Adds base tests for auto-complete on dart docs
...
R=srawlins@google.com
Bug: https://github.com/dart-lang/sdk/issues/59724
Change-Id: Ia2345c77371a58ad0be402daa93642a3f0e53dc7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/410461
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Auto-Submit: Felipe Morschel <git@fmorschel.dev >
2025-02-21 07:57:09 -08:00
57e5b2895f
[analyzer] Handle NullAwareElements in Flutter outlines
...
Part of https://github.com/dart-lang/sdk/issues/56989
Change-Id: I32557d994d16b97b8f3b40bb3d654a657338b83e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/411020
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Chloe Stefantsova <cstefantsova@google.com >
2025-02-20 23:32:01 -08:00
bc7feacec6
[analysis_server] Fix missing trailing comma when inserting arguments before solo child/children
...
The logic here was bad, assuming we didn't need a trailing comma when inserting an arg before a solo argument (which can happen for child/children).
Fixes https://github.com/flutter/devtools/issues/8921
Change-Id: I38f9003cdc8b499d6417cac7989c65a4760416a6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/411140
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Elliott Brooks <elliottbrooks@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2025-02-20 15:07:32 -08:00
0ebec968c9
[migration] rename.dart
...
This also migrates all of refactoring.dart except for one getter that's used internally.
Change-Id: If11f30d740c02509e3eeeac90268b14540e3e0a2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/411080
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2025-02-20 13:40:40 -08:00
a31be9beba
[analysis_server] Provide DocumentLinks for packages in Pubspec.yaml
...
Having quick links to pub.dev in pubspec.yaml is a long-standing request, but all of the API options to implemented it seemed bad.
However I was recently made aware that DocumentLinks (which we use for the Flutter example links) support HTTP links and this turns out to be a perfect fit (credit to https://github.com/orestesgaolin for the idea).
Links are built based on the kind of package, so `git` and `hosted` packages will be built accordingly (I special-cased GitHub SSH links but don't know if this could be generalised for other Git-hosting services). We use PUB_HOSTED_URL as the default base for standard Pub packages.
Packages that don't have URLs (such as `path`, `sdk: x` or other unknown kinds) will not produce links.
Fixes https://github.com/Dart-Code/Dart-Code/issues/2785
Change-Id: I1c9e704f67736bbc451866a9e10f7928e2246c7c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/409660
Commit-Queue: Phil Quitslund <pquitslund@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Phil Quitslund <pquitslund@google.com >
2025-02-20 09:36:01 -08:00
8f79645456
[DAS] Fixes closure cases for inline method refactor
...
R=scheglov@google.com , pquitslund@google.com
Fixes: https://github.com/dart-lang/sdk/issues/60160
Change-Id: Ie6313a92d5e4326b81ad0f277c5a8ff2c264ca39
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/410603
Commit-Queue: Phil Quitslund <pquitslund@google.com >
Auto-Submit: Felipe Morschel <git@fmorschel.dev >
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2025-02-19 10:24:07 -08:00
dd93f6fae0
Fix for create constructor for Widget with private fields.
...
Fixes https://github.com/dart-lang/sdk/issues/56182
Change-Id: I25a94dbb5af5dda4db1fde9494783df215587fd5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/410520
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Keerti Parthasarathy <keertip@google.com >
2025-02-18 21:48:29 -08:00
999f39e908
Elements. Remove FindElement fields where possible.
...
Change-Id: Iea32d103f433d88c70de837bba09435b6f52d11a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/410580
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2025-02-18 14:29:23 -08:00
2048190cb1
[DAS] Makes encapsulate field work with final
...
R=scheglov@google.com
Fixes: https://github.com/dart-lang/sdk/issues/60154
Change-Id: I45c887169672e3cdbce4aea95000996c09e8123b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/410460
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Phil Quitslund <pquitslund@google.com >
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Auto-Submit: Felipe Morschel <git@fmorschel.dev >
2025-02-18 14:02:43 -08:00
c38b8bb007
[migration] abstract_rename.dart
...
Change-Id: I90dc69640a15a8cdf14dc7fa2fb486f30e547445
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/410181
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2025-02-14 14:38:29 -08:00
d18af76865
[migration] analysis_server.dart
...
Change-Id: I111faf848d4243f72fb5e9bf20393784d6ed1fcf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/410180
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2025-02-14 12:15:10 -08:00
0c15648c0b
[migration] search_find_element_references.dart
...
Change-Id: I320e4a92a8c5b5e6cb55347d93272c38a92cc325
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/410100
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2025-02-14 10:48:20 -08:00
b0566a5773
[analysis_server] Remove isDefault and don't set value when there's no argument for EditableArguments API
...
Now that we have `defaultValue` against each argument, there was some redundancy here.
`isDefault` is redundant because if `hasArgument=false` it's always default, and if `hasArgument=true`, then `value` and `defaultValue` can be compared
When `hasArgument=false`, there's no value in duplicating `defaultValue` into `value`
Change-Id: I5cba055e56175565842efef815e08dd46e9ed36a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/406621
Reviewed-by: Elliott Brooks <elliottbrooks@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2025-02-13 09:23:32 -08:00
b732a62fd2
[ analyzer ] Add support for "Wrap FutureBuilder" code assist
...
Fixes https://github.com/dart-lang/sdk/issues/34364
Change-Id: I53b005fdae61fe84ebc7defd54531df6dcd2a351
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/408341
Auto-Submit: Ben Konyi <bkonyi@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2025-02-12 13:12:19 -08:00
1a0b1fe496
[DAS] Fixes renaming closure parameter
...
R=scheglov@google.com
Fixes: https://github.com/dart-lang/sdk/issues/60047
Fixes: https://github.com/dart-lang/sdk/issues/60046
Change-Id: I24b62213c6ef81e76603e7bffabe463c9ca96dcf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/408140
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Auto-Submit: Felipe Morschel <git@fmorschel.dev >
2025-02-12 12:48:28 -08:00
ff93acd624
[analysis_server] Fix "Move to File" for top-level variables with references to their getters
...
There were two issues here:
1. Analyzer's `prefixesUsedInLibrary` search did not handle when an element was not found in the library (for example when looking for a top level variable that doesn't match because it's referenced through a getter)
2. The refactor not looking for prefixes for getters/setters when updating other files
Fixes https://github.com/dart-lang/sdk/issues/59968
Change-Id: Ic560e06c45091937611b247e7fee26b9854873fd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/406844
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2025-02-12 11:41:34 -08:00
e758dffdbb
[analysis_server] Add missing bool completions for strict language options in analysis_options
...
Fixes part of https://github.com/dart-lang/sdk/issues/59827 , but not the main issue.
Change-Id: I7f9d6cfd5163a1bf6c72f9eea4bb71872d3dfa15
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/409140
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
2025-02-11 08:27:51 -08:00
3f71a43464
[DAS] Adds new fix for importing multiple names in combinantors
...
R=srawlins@google.com
Fixes https://github.com/dart-lang/sdk/issues/56608
Change-Id: I3f48517b927aeaa3c410b6f04fcf75b3beead923
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/399021
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Auto-Submit: Felipe Morschel <git@fmorschel.dev >
Commit-Queue: Ivan Inozemtsev <iinozemtsev@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
2025-02-10 23:51:30 -08:00
e6df5493c9
support renamed parameters when adding super calls
...
Bug: https://github.com/dart-lang/sdk/issues/59745
Change-Id: I177e4f748954ddfea1b300085800c8c9a87bed3f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/408840
Auto-Submit: Jake Macdonald <jakemac@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2025-02-10 12:48:10 -08:00
3ded147e2e
[analysis_server] Make format of LSP completion tests more consistent
...
No functional changes here, only formatting/code style:
- Remove additional intending from embedded code in some tests (which didn't match others in this file or the style of other tests in the server)
- Change expression-bodied-tests to block bodies where they're not on a single line
Change-Id: I2c15bbcf7b7accff85f34a4e9ad5afa3e0a0a221
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/408820
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Commit-Queue: Phil Quitslund <pquitslund@google.com >
2025-02-10 10:27:40 -08:00
0246cc613f
[Completion] Show enum constants when completion is in the declaration.
...
Fixes https://github.com/dart-lang/sdk/issues/56971
Change-Id: Ib33a58e774f5540c426f5d5ffb7a387414dcf9f9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/408600
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Keerti Parthasarathy <keertip@google.com >
2025-02-09 22:41:31 -08:00
da2ffedc50
add test for adding super calls with multiple parameters
...
Bug:https://github.com/dart-lang/sdk/issues/59745
Change-Id: Ibaf6321f0ea6cf3046f360e91cf58faba7a16cb3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/408460
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Auto-Submit: Jake Macdonald <jakemac@google.com >
2025-02-07 13:30:01 -08:00
c87b18581a
[CQ] rationalize/unify test lint registration
...
Eliminates duplication and promotes hermetic tests (some were registering and failing to unregister test lints).
Bug: https://github.com/dart-lang/sdk/issues/60036
Change-Id: I9d0fe5fd610b51ce9000decbf75da2338ed87737
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/408320
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Phil Quitslund <pquitslund@google.com >
2025-02-07 13:09:28 -08:00
a78fb5e47a
[analysis_server] Fix semantic tokens for method tear-offs in object patterns
...
Fixes https://github.com/dart-lang/sdk/issues/59976
Change-Id: I75127a59670522ddfc6526d10bfe9844638fdd99
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/408001
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Commit-Queue: Phil Quitslund <pquitslund@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2025-02-07 12:24:25 -08:00
46a739ce20
Add quick assist for Wrap with ValueListenableBuilder
...
Change-Id: If4941d867fbdea687a12a043da240ceb981c758f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/408401
Commit-Queue: Kenzie Davisson <kenzieschmoll@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2025-02-07 10:47:31 -08:00
f4cfbf9cdc
Update create function fix to create an async function for await expressions
...
Bug: https://github.com/dart-lang/sdk/issues/59990
Change-Id: I9e89089ca5c60bea190060bc0c8e869c7e78e32e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/408361
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Auto-Submit: Jake Macdonald <jakemac@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2025-02-06 14:25:39 -08:00
7559108945
[DAS] Tests for parameter highlights
...
R=brianwilkerson@google.com
Bug: https://github.com/dart-lang/sdk/issues/60046
Change-Id: I5b57109e9459a8583fd543031f239174a71472cf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/408040
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Auto-Submit: Felipe Morschel <git@fmorschel.dev >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
2025-02-06 13:08:59 -08:00
07b7cfed07
New assist to add/edit hide at import for ambiguous import
...
Closes https://github.com/dart-lang/sdk/pull/56762
GitOrigin-RevId: af16e245090fa66e6212801cd862d809f5ede640
Change-Id: Ibbc49c36860ba6e58c45dfc40029e2375396c153
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/386020
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
2025-02-05 15:49:35 -08:00
466cc35c7e
[CQ] correct options fix test docs
...
Change-Id: Ib87ca966872e7ea165d866a1c95fd8669b6852c2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/407622
Auto-Submit: Phil Quitslund <pquitslund@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2025-02-04 09:05:03 -08:00
2ac59922d2
DAS plugins: Support fixes to ignore diagnostics
...
Change-Id: I71ae995d1a4a94ecfeafd187c5674c41b6d928d4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/395702
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2025-02-04 08:24:23 -08:00
5454e70ce2
[migration] Rename utilities in protocol_dart.dart
...
Change-Id: I90c06dffcac98bc8ec6bb2a982a6825157eda56d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/407620
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2025-02-03 16:32:40 -08:00
448f0d4080
[migrate] server/protocol_dart.dart
...
I didn't rename all of the functions because I thought it would be easier to review if I did it in two steps.
Change-Id: If765d56300374794dc9964f17002cfbe172e66b7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/407602
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2025-02-03 14:34:21 -08:00
4be9188379
[analysis_server] Support occurrences (Document Highlights) with different lengths
...
+ split unnamed constructors from classes
Fixes https://github.com/Dart-Code/Dart-Code/issues/4454
Change-Id: I42e7346b7c22348cf6424d15c5c35a24e31c85b3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/406822
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
2025-02-03 12:05:53 -08:00
6de0ef3d5f
[DAS] Fix auto-complete update combinators
...
We already have a quick-fix that allows us to use the same existing import by editing the combinators. The auto-completer now should do the same.
Bug: https://github.com/Dart-Code/Dart-Code/issues/5238
Change-Id: I0f3a50299abb9890370a6c8934b49036f7e03196
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/404525
Auto-Submit: Felipe Morschel <git@fmorschel.dev >
Commit-Queue: Phil Quitslund <pquitslund@google.com >
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2025-02-03 11:15:57 -08:00
1372538855
[DAS] Fixes import prefix go to definition (multiple)
...
R=keertip@google.com
Fixes https://github.com/dart-lang/sdk/issues/56931
Change-Id: Ida0cb58cdb4267af31a87a29862a3f4f2e28907f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/405201
Auto-Submit: Felipe Morschel <git@fmorschel.dev >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Keerti Parthasarathy <keertip@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
2025-02-03 09:18:52 -08:00
2946ea71d5
Macro. Remove more from analyzer/ and analysis_seever/.
...
Change-Id: Id5426cce73395d3d95657cf1e0b5f9d85fe3f574
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/406921
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2025-01-31 11:35:10 -08:00
ca31648dbb
Support 'new' analyzer plugins in dart analyze.
...
This change allows the LegacyAnalysisServer to understand when the
plugin isolate (if there is one) is analyzing or not. There are a few
primary concepts:
* The plugin isolate (PluginServer) notifies the analysis server, when
analyzing all files in a context collection, and analyzing changed
files, that it is analyzing, and later that it isn't.
* The NotificationManager tracks whether the plugin isolate is analyzing
or not, based on the last status.
* The PluginManager tracks whether new plugins are initialized or not.
This is determined by the work done by the PluginWatcher. If no
plugins are configured, then plugins are declared to be "initialized".
Otherwise, the AnalysisServer sets their status to be "initialized"
after receiving the first status notification from the plugin isolate.
* The LegacyAnalysisServer now uses the additional "are plugins
analyzing" signal, held in NotificationManager, and the "are plugins
initializing" signal, held in PluginManager, to determine whether to
notify the client that analysis is complete.
Change-Id: Ie2b6a6048f074d7a26d7d5d07622a17c30fcab96
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/405444
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2025-01-31 10:44:36 -08:00
6e17841614
Macro. Remove tests from analyzer/ and analysis_server/.
...
Change-Id: Iabe04d7ff8fe0cc9b605d0c18fd47591fd02d6bd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/406681
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2025-01-29 14:58:19 -08:00
204039cdf2
[analysis_server] Add "defaultValue" to EditableArguments API
...
This adds a new field "defaultValue" to the API response that contains the default value for a parameter.
Change-Id: Ief11da553d57871ad1e3fab54c731cbc98d674a4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/406000
Reviewed-by: Elliott Brooks <elliottbrooks@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2025-01-29 08:00:26 -08:00
11edab5264
[analyzer] Add correction for adding '?' before null-aware elements
...
Part of https://github.com/dart-lang/sdk/issues/56989
Change-Id: I487790e796a37679fd5fe1c9bc1e72ccb6248249
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/405520
Reviewed-by: Keerti Parthasarathy <keertip@google.com >
Commit-Queue: Chloe Stefantsova <cstefantsova@google.com >
2025-01-28 23:06:04 -08:00
ca2119e0a6
[anlaysis_server] Improve the error text/codes for property editor APIs
...
Change-Id: If3ad0fd11cc661e88104444afd14a5d79374cc1c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/406360
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Elliott Brooks <elliottbrooks@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2025-01-28 13:00:18 -08:00
8eb9bcd7f0
[analysis_server] Verify with/without documentChanges for EditArguments tests
...
The tests by default run with documentChanges (set in `setUp`), but it's possible LSP-over-Legacy clients won't support it.
Change-Id: I40c65f05127c88e15a43f16669f64675285955dc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/406002
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2025-01-27 12:54:48 -08:00
1ec4ea79fd
[analysis_server] Include "get" or "set" in LSP override completions to distinguish them
...
Screenshot of how this looks here: https://github.com/dart-lang/sdk/issues/59929#issuecomment-2602188244
Fixes https://github.com/dart-lang/sdk/issues/59929
Change-Id: I220ee8facb96dbf31ee88868c8c44223de5e8406
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/405007
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Keerti Parthasarathy <keertip@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2025-01-27 09:06:38 -08:00
8884a8b4ad
[analysis_server] Make it easier to print protocol messages when running LSP-over-Legacy tests
...
This moves the existing `debugPrintCommunication` flag out of `test/lsp` into `test/` and passes it to the `MockServerChannel` to simplify printing protocol messages for LSP-over-Legacy tests (similar to what MockLspServerChannel already does).
Change-Id: Ic5fa6309e8de01ce0c624584ad6eb653ced90698
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/406021
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
2025-01-27 08:47:42 -08:00
0d90ccc2ec
[analysis_server] Use unique request IDs in tests to avoid flaky tests
...
Some of the LSP-over-Legacy tests were intermittently failing because the test did not correctly wait for the `setClientCapabilities` request to complete.
The reason for this was that it used the ID `0` (from `_newRequestId`) but so did `setAnalysisRoots`. If the timing was right, the second request would appear to complete when the first did (because the response had id=0) and the test would start before the capabilities had actually been set (and since the test reads them directly off the server, they would be incorrect).
This moves the `_nextRequestId` field down into a base class and updates the helpers for requests like `setAnalysisRoots` to use it too.
Change-Id: Ice44191aad39c7ea81c40e501827557fe563e3d5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/405760
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2025-01-24 09:26:38 -08:00
a0db69f182
[DAS] Considers factory keyword on constructors auto-complete
...
R=keertip@google.com
Fixes https://github.com/dart-lang/sdk/issues/59896
Change-Id: I47c51bc521f97398ae19a8d124e836baadfdabd4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/405200
Commit-Queue: Keerti Parthasarathy <keertip@google.com >
Reviewed-by: Keerti Parthasarathy <keertip@google.com >
Auto-Submit: Felipe Morschel <git@fmorschel.dev >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
2025-01-24 08:45:46 -08:00
Chloe Stefantsova