Commit Graph

296 Commits

Author SHA1 Message Date
johnmccutchan@google.com 7f75b32faa Mark Service_Coverage as Skip on SIMMIPS
BUG=

Review URL: https://codereview.chromium.org//140253010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31976 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-22 16:39:22 +00:00
johnmccutchan@google.com c55a51e081 Disable profiler
Review URL: https://codereview.chromium.org//128953002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31618 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-08 18:41:05 +00:00
hausner@google.com c571528323 Make return statements single steppable
Replace the code smashing breakpoints at function returns with a call
to a runtime stub that checks whether the debugger is single stepping.
The call to the stub is only emitted in unoptimized code.

R=srdjan@google.com

Review URL: https://codereview.chromium.org//106053011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31435 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-02 23:31:52 +00:00
hausner@google.com 15e8f121dd Change how debugger handles source breakpoints
- Identify a source breakpoint by a script and a token position
  rather than a function object.
- When a new breakpoint is set, iterate over all compiled functions
  to see whether code breakpoints must be set.

This change fixes issues with functions that get compiled several
times, for example as implicit closures or a copies of mixin
functions or local closures of mixing functions. We did not detect
all duplicates of functions.

Eliminated recently introduced const modifiers in SourceBreakpoint
class. They tend to be in the way because several accessor methods
of SourceBreakpoint compute data lazily and modify the object as a
side effect.

Review URL: https://codereview.chromium.org//117133005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31372 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-26 20:53:58 +00:00
johnmccutchan@google.com 919dc2d6eb * Introduce ThreadInterrupter which calls a TLS set callback when thread is interrupted.
* Threads can only register and unregister themselves with ThreadInterrupter.
* Profiler is no longer involved in interrupting threads. It's just a callback and the buffer.
* Profiler operates lock free using an atomic operation to reserve sample in sample buffer.
* Linux, Mac, and Windows done.

R=asiva@google.com

Review URL: https://codereview.chromium.org//109803002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31170 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-16 18:52:15 +00:00
rmacnak@google.com 5e310f4e31 Update mirror tests for removed API and other analyzer warnings.
BUG=http://dartbug.com/14695
R=gbracha@google.com

Review URL: https://codereview.chromium.org//64793003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30290 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-14 19:55:05 +00:00
iposva@google.com 1cae21b556 - Reverting mirror changes.
Review URL: https://codereview.chromium.org//62373008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30029 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-07 02:07:37 +00:00
iposva@google.com a2d280501e - Reverting mirror changes.
Review URL: https://codereview.chromium.org//63563003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30027 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-07 01:48:45 +00:00
rmacnak@google.com bc897425e1 Cascaded mirror removal revert.
Review URL: https://codereview.chromium.org//63363003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30024 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-07 01:20:51 +00:00
rmacnak@google.com 1caa73df59 Remove implementations of mirror methods not in the API from the VM. Update tests.
R=iposva@google.com

Review URL: https://codereview.chromium.org//63063002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30005 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-06 22:30:45 +00:00
rmacnak@google.com 07c3de9310 Mirror implementation removals: async invoke, mirrorSystemOf(port), Mirror.mirrors.
(API was removed in r29492)

R=ahe@google.com, gbracha@google.com

Review URL: https://codereview.chromium.org//23460050

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29698 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-31 21:01:59 +00:00
rmacnak@google.com 0abc881d9e Mirror API removals: async invocations, mirrorSystemOf(port), Mirror.mirrors.
R=ahe@google.com, gbracha@google.com

Review URL: https://codereview.chromium.org//45293002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29492 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-29 21:14:19 +00:00
kustermann@google.com 94ebff2225 Bugfix in test.dart, adding of specialized test outcomes for analyzer
This CL will:
 - fix a bug in the legacy AnalyzerCommandOutputImpl class (in certain cases
   we did not report that the analyzer was missing a warning).
 - make the outcome of running the analyzer on a test be one of:
   * CompileTimeError
   * MissingCompileTimeError
   * StaticWarning
   * MissingStaticWarning
 - Make status file updates using the new Expectation markers
 - Remove support for '@static-clean':
     Previously running the analyer on a test could either result in
     'Pass' or in 'Fail'. The '@static-clean' annotation has been used
     as a (poor) mechanism to distinguish between errors and warnings.
     Having the 4 markers mentioned above means we can remove '@static-clean'
 - Remove 100 lines of rotted legacy code in our testing scripts.
 - Make a status file entry for every test that has analyzer errors or warnings

R=ricow@google.com

Review URL: https://codereview.chromium.org//46163002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29350 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-28 10:39:38 +00:00
floitsch@google.com 6a72655d1b Very simple version of Isolates.
R=ajohnsen@google.com, iposva@google.com, kasperl@google.com, lrn@google.com

Review URL: https://codereview.chromium.org//27215002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29271 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-25 19:23:00 +00:00
iposva@google.com 6267207e64 - Account for hidden frames when concatenating throw and
catch traces.

R=asiva@google.com

Review URL: https://codereview.chromium.org//41503004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29218 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-24 22:08:33 +00:00
iposva@google.com e8f2abb833 Fix build:
- Dartium is skipping some numbers when creating frames.

Review URL: https://codereview.chromium.org//38833003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29140 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-24 01:16:10 +00:00
iposva@google.com 7fb172b783 - Don't mix the collection of Error.stackTrace with the collection of
the stack trace for try-catch.

R=asiva@google.com

Review URL: https://codereview.chromium.org//38343004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29136 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-24 00:16:55 +00:00
rmacnak@google.com 879539c348 Skip redirection_type_shuffling_test on dart2js.
Review URL: https://codereview.chromium.org//29103011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28968 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-21 23:10:11 +00:00
rmacnak@google.com 7c67d66df1 Skip mirrored_compilation_error_test on dart2js and Dartium.
Review URL: https://codereview.chromium.org//33673002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28951 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-21 21:00:42 +00:00
rmacnak@google.com 6a0920d2a6 isolate_mirror_local_test no longer fails the analyzer.
Review URL: https://codereview.chromium.org//33053004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28948 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-21 20:38:40 +00:00
rmacnak@google.com a5fd049d73 Hide MirroredCompilationErrror behind a flag until post-1.0. Remove VM reference to MirroredUncaughtExceptionError.
R=asiva@google.com, gbracha@google.com

Review URL: https://codereview.chromium.org//28053005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28946 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-21 20:12:49 +00:00
rmacnak@google.com 0d23dbc1e2 Make TypedefMirror a direct descendant of TypeMirror.
BUG=http://dartbug.com/11616
R=ahe@google.com, asiva@google.com

Review URL: https://codereview.chromium.org//24005002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28862 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-18 16:59:55 +00:00
rmacnak@google.com 564fbb68dd Add proper API for creating private symbols wrt a library.
BUG=http://dartbug.com/13355
BUG=http://dartbug.com/12358
R=ahe@google.com, asiva@google.com, gbracha@google.com

Review URL: https://codereview.chromium.org//24631003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28551 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-11 20:56:14 +00:00
rmacnak@google.com 6ed9f2c17f Implement constructor kinds in the VM mirrors.
BUG=http://dartbug.com/13798
R=asiva@google.com, hausner@google.com

Review URL: https://codereview.chromium.org//26436004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28416 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-09 20:40:11 +00:00
vsm@google.com 334fd6bf07 Mark spawnFunction tests as Fail on Dartium
See corresponding Dartium CL:
https://chromiumcodereview.appspot.com/26397003/

This disables spawnFunction on DOM enabled isolate (i.e., where
dart:html is available).  spawnFunction should continue to work on
non-DOM enabled isolated.  spawnUri should be unaffected.

R=asiva@google.com

Review URL: https://codereview.chromium.org//26616002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28406 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-09 16:25:28 +00:00
kustermann@google.com 22d20313b4 Implement testing support for "--compiler=none --runtime=dartium"
This is implemented without the broken unittest-based wrapping of tests.

R=kasperl@google.com

Review URL: https://codereview.chromium.org//25514002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28141 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-02 07:37:50 +00:00
ajohnsen@google.com fac6baef28 Clean up status file.
BUG=
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//24750003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27956 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-26 14:35:18 +00:00
kustermann@google.com dfbf264f40 Automatically converted general Fail status file markers to one of the more specific markers
R=johnniwinther@google.com, ricow@google.com

Review URL: https://codereview.chromium.org//23494066

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27876 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-25 12:47:03 +00:00
ajohnsen@google.com 0cc1e648e2 Re-enable VM isolate tests.
BUG=https://code.google.com/p/dart/issues/detail?id=6890
R=ricow@google.com

Review URL: https://codereview.chromium.org//24542002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27868 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-25 09:20:40 +00:00
zra@google.com 6282267aae Fixes slow object pool search on x64.
Issue 13144.

R=iposva@google.com

Review URL: https://codereview.chromium.org//23723008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27494 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-13 18:10:04 +00:00
zra@google.com eb28abc920 Updates status file for slow test on x64.
Review URL: https://codereview.chromium.org//23654018

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27299 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-09 16:54:03 +00:00
zra@google.com df2054dae7 Sets a register aside on x64 for use as a pool-pointer. It is loaded and restored from the code object on Frame entry and exit. All LoadObject calls that can, and many calls and jumps through ExternalLabels now use the pool-pointer. The --compiler-stats flag when running dart2js indicates that code size is reduced ~13%, and more is probably possible.
R=fschneider@google.com, srdjan@google.com

Review URL: https://codereview.chromium.org//22825023

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27295 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-09 15:39:26 +00:00
ahe@google.com 37a5567eb8 Triage Safari bug 7414.
BUG=http://dartbug.com/7414
R=floitsch@google.com, kustermann@google.com, srdjan@google.com

Review URL: https://codereview.chromium.org//23595002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26726 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-27 17:17:35 +00:00
lrn@google.com f02f2c0a6b Mark CustomIsolates test as potentially crashing.
Review URL: https://codereview.chromium.org//23572002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26702 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-27 10:41:25 +00:00
lrn@google.com 88b242b66a Mark some tests as failing instead of skipping.
R=floitsch@google.com

Review URL: https://codereview.chromium.org//23550002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26698 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-27 09:26:10 +00:00
zra@google.com 8ffef7528d Bug fix and status file updates for MIPS HW.
R=regis@google.com

Review URL: https://codereview.chromium.org//22828004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26037 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-12 21:45:41 +00:00
kustermann@google.com cb18d8ba87 Removed compiler/ directory from repository
R=ricow@google.com

Review URL: https://codereview.chromium.org//20722006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25728 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-02 08:31:15 +00:00
rmacnak@google.com 844a406c8a Implement reflect() with Dart code, InstanceMirror.type and ClosureMirror.function with internal code.
R=asiva@google.com

Review URL: https://codereview.chromium.org//21119002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25594 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-29 23:57:31 +00:00
rmacnak@google.com 6318625f35 Re-enable VM mirror toString tests. Fix some long lines.
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25530 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-26 18:09:33 +00:00
rmacnak@google.com 670a0345ca Wrap lazy compilation errors when parsing metadata. Addresses the poor error reporting in issue 12027.
R=asiva@google.com

Review URL: https://codereview.chromium.org//20458002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25498 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-25 20:49:59 +00:00
rmacnak@google.com 4a98a91696 Change the return value of setField to be in line with non-reflective assignments. Complete unwrapping of exceptions for the InstanceMirror invokes. Resolves issue 11219 and issue 11943.
R=asiva@google.com

Review URL: https://codereview.chromium.org//20066004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25457 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-25 00:18:42 +00:00
rmacnak@google.com 1a0b3c7871 Make reflective invocations raise NoSuchMethodErrors in the cases where non-reflective invocations do so. Resolves issues 11187 and 11957.
R=asiva@google.com

Review URL: https://codereview.chromium.org//19819003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25387 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-24 00:29:17 +00:00
floitsch@google.com 06493c3460 Revert "Introduce StackTraceOnThrowMixin."
This reverts commit r24951.

R=lrn@google.com

Review URL: https://codereview.chromium.org//19579002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25142 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-18 10:39:56 +00:00
rmacnak@google.com 183c94e250 Implement dynamicType and voidType as TypeMirrors not ClassMirrors. Issue 11743.
R=asiva@google.com

Review URL: https://codereview.chromium.org//18343005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25010 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-15 16:32:11 +00:00
floitsch@google.com e5cade9e88 Introduce StackTraceOnThrowMixin.
R=ahe@google.com, lrn@google.com

Review URL: https://codereview.chromium.org//18259021

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24951 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-12 15:30:53 +00:00
zra@google.com c09f0f5697 Fixes status file for arm hardware.
After the bugfix in BitVector.Equals(), these vm tests pass.

R=regis@google.com

Review URL: https://codereview.chromium.org//18917002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24849 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-09 16:30:46 +00:00
zra@google.com 99772465b5 Updates status files for arm hardware
R=regis@google.com

Review URL: https://codereview.chromium.org//17732002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24431 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-25 20:16:02 +00:00
srdjan@google.com ce3c239a89 Reduce time spenty in tests: instead of looping for long, shorten optimizations threshold.
R=zra@google.com

Review URL: https://codereview.chromium.org//17599004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24367 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-24 20:55:54 +00:00
zra@google.com 8edda78ccc Enables more tests for SIMMIPS.
. Fixes register allocation bugs
. Implements float <-> double conversion in assembler and simulator.
. Fixes floating point argument passing for simarm and simmips,
  and floating point return for simarm, and adjusts tests to match.

R=regis@google.com

Review URL: https://codereview.chromium.org//17502002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24365 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-24 20:16:16 +00:00
srdjan@google.com b8531f4f49 Mark test pass, crash for simarm, in order to make bot green.
Review URL: https://codereview.chromium.org//17585007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24357 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-24 18:29:18 +00:00