dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
21,645 Commits 2 Branches 0 Tags
23c2fcd6482ce052d334d1c93385c2f8a0e70cdd
Commit Graph

75 Commits

Author SHA1 Message Date
pquitslund@google.com 5c26be4b49 Indent fix for trailing comments (dartbug.com/16383). 
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//153203002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32287 260f80e4-7a28-3924-810f-c04153c831b5
 2014-02-04 20:50:12 +00:00
pquitslund@google.com 07888b2f25 Indent fix for switch statement defaults (dartbug.com/16406). 
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//150533003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32174 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-30 21:39:28 +00:00
pquitslund@google.com 18ad816d5f Max line length test fix (dartbug.com/16405). 
The rub: two off by ones! --- Proof that two wrongs don't make a right! :)

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//149913002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32166 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-30 18:35:17 +00:00
pquitslund@google.com 9d5f39180c Empty map formatting fix (dartbug.com/16382). 
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//149793003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32143 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-29 22:02:26 +00:00
pquitslund@google.com 4260d5a585 Fix to allow single method cascades to fit on one line (dartbug.com/16384). 
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//149743002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32138 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-29 20:57:44 +00:00
scheglov@google.com becf22691a New analyzer snapshot. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//147903005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32135 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-29 20:03:33 +00:00
pquitslund@google.com d6d365cdcc Format fix for assert statements. 
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//149363007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32133 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-29 19:46:52 +00:00
pquitslund@google.com b66342b854 Remove workaround for missing setter function returns (dartbug.com/15914). 
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//145953006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32091 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-28 22:51:27 +00:00
pquitslund@google.com 99595ef86b Remove workaround for missing abstract keyword for ClassTypeAliases (dartbug.com/15912). 
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//144743003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32086 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-28 22:25:38 +00:00
pquitslund@google.com 13961dc1f6 Improved linebreaking for imports (darbug.com/16366) and non-breaking line support. 
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//147983005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32084 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-28 21:37:05 +00:00
scheglov@google.com 37b6debef7 New analyzer snapshot. 
There are some problems with JDT and line comments.
Interesting, that it works almost everywhere, and also worked coupld weeks ago.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//137143010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32052 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-28 04:24:41 +00:00
pquitslund@google.com aac07d9e6b dartfmt line wrapping bypass option support. 
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//139263011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32034 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-27 22:23:52 +00:00
pquitslund@google.com ad389194c3 dartfmt line length command line option support. 
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//146833014

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32027 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-27 19:06:17 +00:00
brianwilkerson@google.com bc169d77e7 Add other time to perf report 
R=scheglov@google.com

Review URL: https://codereview.chromium.org//139403007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31980 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-23 18:17:03 +00:00
pquitslund@google.com f04199eda4 Line pre-chunking. 
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//132983008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31941 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-18 00:17:12 +00:00
scheglov@google.com 3ad3ff9a2e New analyzer snapshot. 
Extracts SdkLibrariesReader_LibraryBuilder into sdk.dart library.
https://code.google.com/p/dart/issues/detail?id=14791

R=brianwilkerson@google.com, devoncarew@google.com
BUG=

Review URL: https://codereview.chromium.org//135653008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31939 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-18 00:05:43 +00:00
lrn@google.com 3b3e87cabc Revert "Rename internal library dart:_collection-dev to dart:_internal." 
Dartium needs updating too.

Committed: https://code.google.com/p/dart/source/detail?r=31827

R=floitsch@google.com

Review URL: https://codereview.chromium.org//133273011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31877 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-16 12:06:38 +00:00
pquitslund@google.com a779c9f54c Fix to ensure only modified files are written to (dartbug.com/16093). 
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//130843005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31863 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-16 00:36:06 +00:00
pquitslund@google.com 4a8ca537b5 dartfmt patch file side-stepping. 
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//138143009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31848 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-15 20:12:17 +00:00
pquitslund@google.com 7605b96c4b Interpolated String hack-around. 
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//136453008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31846 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-15 19:18:25 +00:00
lrn@google.com ead87f47e9 Revert "Rename internal library dart:_collection-dev to dart:_internal." 
Dartium needs updating too.

Review URL: https://codereview.chromium.org//133273011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31827 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-15 12:27:44 +00:00
lrn@google.com 0098710559 Rename internal library dart:_collection-dev to dart:_internal. 
BUG= http://dartbug.com/14140
R=floitsch@google.com

Review URL: https://codereview.chromium.org//133893007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31823 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-15 09:24:46 +00:00
pquitslund@google.com bb92c20bfb Test roll-back pending line-breaker fixes [TBR]. 
Net-net: the line-breaker is dropping tokens and needs to be disabled while I investigate; until it is re-enabled, this test will fail.

Review URL: https://codereview.chromium.org//138213006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31792 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-14 16:49:23 +00:00
pquitslund@google.com fdb7d2f1a0 Whitespace testing fixes and bit-flip to turn on simple line breaking. 
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//137533005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31791 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-14 16:46:05 +00:00
scheglov@google.com 38d028e67f Issue 8742. Preserve leading line comments during java2dart translation. 
https://code.google.com/p/dart/issues/detail?id=8742

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//137863002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31790 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-14 16:28:59 +00:00
pquitslund@google.com 63aefc6dd0 Line-break indenter plumbing. 
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//136983004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31759 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-13 22:08:28 +00:00
pquitslund@google.com 400fb9e232 Line breaking plumbing (continued). 
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//136863003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31751 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-13 18:20:54 +00:00
scheglov@google.com 7a418f273f Add copyright header to generated analyzer files. 
R=brianwilkerson@google.com, danrubel@google.com
BUG=

Review URL: https://codereview.chromium.org//136143002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31743 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-13 16:01:36 +00:00
scheglov@google.com 06b58b48de Generate names for anonymous Java classes using enclosing classes and members. 
R=brianwilkerson@google.com, devoncarew@google.com
BUG=

Review URL: https://codereview.chromium.org//136223002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31741 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-13 16:00:21 +00:00
scheglov@google.com cf456d685b Translate index. 
No tests yet.
I'll need some time to find out how to translate Mockito based tests to Dart.

R=brianwilkerson@google.com, devoncarew@google.com
BUG=

Review URL: https://codereview.chromium.org//135803003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31729 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-13 01:12:17 +00:00
scheglov@google.com 9efe9ba519 New analyzer snapshot. 
Mostly to remove unnecessary casts.
But also includes your latest changed for Alan.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//134533007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31717 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-10 22:27:52 +00:00
pquitslund@google.com 5ccad24462 dartfmt commandline argument tweaks. 
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//129813007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31703 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-10 19:51:25 +00:00
pquitslund@google.com 4cb2537a37 Line-breaking plumbing and bits and pieces. 
Some tentative abstractions for implementing simple line breaking algorithms.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//132383002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31683 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-09 23:04:33 +00:00
scheglov@google.com 217d980fcd Analyzer snapshot. 
Rewrite TimeCounter to use Stopwatch.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//128443003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31623 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-08 20:27:55 +00:00
pquitslund@google.com b8ce88220a Fix to handle loop variables not declared in the for. 
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//118333003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31554 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-07 17:02:08 +00:00
pquitslund@google.com ad48998e7e Formatter fixes (symbols, natives, function type aliases, oh my). 
Last stragglers that make a run over the SDK go green (modulo patch files that is).

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//124863004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31513 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-06 22:22:53 +00:00
pquitslund@google.com bff4cb2a13 Formatter support for metadata. 
As per the spec:

"Metadata can appear before a library, class, typedef, type parameter, constructor, factory, function, field, parameter, or variable declaration and before an import or export directive."

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//125253005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31502 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-06 19:15:08 +00:00
scheglov@google.com 9841d6b210 Remove debug output and copy java_io.dart into resources. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//115523004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31496 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-06 18:24:11 +00:00
pquitslund@google.com b85d86bb23 Function Decl formatter fixes (external and getters/setters) --- (dartbug.com/15914). 
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//102763007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31491 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-06 17:51:40 +00:00
pquitslund@google.com 49d306b1e0 Formatter workaround for missing abstract keyword in ClassTypeAliases (dartbug.com/15912). 
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//125103003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31484 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-06 17:11:36 +00:00
pquitslund@google.com 2f1411eada Fix and test for leading comment handling (dartbug.com/15876). 
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//109153006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31453 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-03 22:29:25 +00:00
pquitslund@google.com ec7d3bf800 Path fix for data-driving formatting tests. 
R=brianwilkerson@google.com, kustermann@google.com

Review URL: https://codereview.chromium.org//119583002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31445 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-03 19:40:53 +00:00
pquitslund@google.com 45ef7ffacc Style guide acceptance tests. 
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//119323005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31444 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-03 19:03:11 +00:00
scheglov@google.com 6acc230eb9 Attempt to fix VM build. 
I need to be able to find SDK location both locally and on bot.

TBR

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//119323009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31442 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-03 17:47:55 +00:00
brianwilkerson@google.com e3e5f44bad Capture and print times for the isInstanceOf method. 
I'm not sure how to test these changes without re-running the translator, but I'll be happy to do so if someone can show me how.

Jaime: will it break anything to write an additional piece of timing information?

R=danrubel@google.com, jwren@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//123533002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31441 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-03 17:28:27 +00:00
scheglov@google.com fb931a0028 New analyzer snapshot. 
Without Angular.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//123763002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31440 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-03 16:31:28 +00:00
pquitslund@google.com bda0d5f25c Test fix in quest for build greenness [TBR]. 
Review URL: https://codereview.chromium.org//99583011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31284 260f80e4-7a28-3924-810f-c04153c831b5
 2013-12-19 17:21:28 +00:00
pquitslund@google.com 21730c7eb8 Test jig for data-driving dartfmt tests. 
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//98693013

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31283 260f80e4-7a28-3924-810f-c04153c831b5
 2013-12-19 17:02:50 +00:00
pquitslund@google.com db0d15dbe2 dartfmt gets opinionated about 'gratuitous' linebreaks. 
IOW: we now collapse lines that are broken.

NOTE: EOL comments are sure to break this; CL to address to follow.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//113693003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31243 260f80e4-7a28-3924-810f-c04153c831b5
 2013-12-18 22:57:53 +00:00
pquitslund@google.com 5353a7771a Formatter line continuation awareness hooks. 
DO indent continued lines with at least four spaces.

https://www.dartlang.org/articles/style-guide/#do-indent-continued-lines-with-at-least-four-spaces

NOTE: these are just the hooks.  As per our conversations, we need to encode opinions about what continuations should be allowed before we support them.  The tests are left, commented out, to serve as tracer bullets when we get there.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//109423004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31210 260f80e4-7a28-3924-810f-c04153c831b5
 2013-12-17 22:38:35 +00:00