dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
50,229 Commits 2 Branches 0 Tags
0d2bcc17dbb60a8026cdb79bb249dca07ea92533
Commit Graph

50229 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Florian Loitsch 0d2bcc17db Update status files. 
Change-Id: Iebfba17da59a161aea16e802787c2b5cf4722845
Reviewed-on: https://dart-review.googlesource.com/7540
Reviewed-by: Florian Loitsch <floitsch@google.com>
 2017-09-21 07:22:04 +00:00
Florian Loitsch 9572b5e2ec Update Changelog entry for strong zones. 
Change-Id: I15dac60dfec77315dd3701c066c546fe979f3f0a
Reviewed-on: https://dart-review.googlesource.com/7400
Reviewed-by: Kevin Moore <kevmoo@google.com>
 2017-09-21 06:56:22 +00:00
Harry Terkelsen f8d4291164 update status for passing test [TBR] 
Change-Id: I9a7a4fda137822fc0b80de9d43332aab610dcc35
Reviewed-on: https://dart-review.googlesource.com/7485
Reviewed-by: Harry Terkelsen <het@google.com>
Commit-Queue: Harry Terkelsen <het@google.com>
 2017-09-20 23:06:37 +00:00
William Hesse f598b4766c Remove mac-vm-kernel builder from the CQ until we have >4 machines to run it. 
Bug:
Change-Id: Ibb07ce966bdedb20551f079ce5899d83b7ebb8a6
Reviewed-on: https://dart-review.googlesource.com/7403
Reviewed-by: William Hesse <whesse@google.com>
 2017-09-20 22:57:46 +00:00
Vijay Menon 8470c871d6 Enable polyfill in d8 modules 
This enables running benchmarks (e.g., DeltaBlue) on d8.  d8 tip (with
es6 modules) appears quite a bit faster than the latest dev nodejs (with common modules).

Change-Id: Iedcc97fac57c48b925ae7c1b6cba4bbedeba4d0b
Reviewed-on: https://dart-review.googlesource.com/7443
Commit-Queue: Vijay Menon <vsm@google.com>
Reviewed-by: Jennifer Messerly <jmesserly@google.com>
 2017-09-20 22:47:21 +00:00
Bob Nystrom 74e4ccdeb8 Migrate block 120. 
Change-Id: Ia5a433e70ab3bdf953a116a0b65de42138125d2b
Reviewed-on: https://dart-review.googlesource.com/6347
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2017-09-20 22:23:58 +00:00
Zachary Anderson 406d59f9bf [sdk] Update version file correctly 
fixes #30794

Change-Id: Icd412d36d34dc1da01a6b0fec8107b3a49d03e3a
Reviewed-on: https://dart-review.googlesource.com/7481
Reviewed-by: Ryan Macnak <rmacnak@google.com>
 2017-09-20 22:05:27 +00:00
Brian Wilkerson 0c005a39d2 Remove unused import (TBR) 
Change-Id: I1f22fb743d2148a485d304920f5a5e2c921cd904
Reviewed-on: https://dart-review.googlesource.com/7460
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2017-09-20 21:46:55 +00:00
Konstantin Shcheglov 6d0515f9ca Return SimpleIdentifier or PrefixedIdentifier from _buildIdentifier(). 
R=brianwilkerson@google.com, paulberry@google.com

Bug:
Change-Id: Ifaecb13e6869166deb10c6211cf075761c185100
Reviewed-on: https://dart-review.googlesource.com/7449
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2017-09-20 21:31:20 +00:00
Paul Berry 45521d17c4 Change main functions in test files to take optional args. 
This will allow these tests to be run inside google3, where the test
framework calls main with no arguments.

Change-Id: I139a9b100fe3a1eb3003933ec9fef4298706ff5d
Reviewed-on: https://dart-review.googlesource.com/7342
Reviewed-by: Peter von der Ahé <ahe@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2017-09-20 21:07:27 +00:00
Konstantin Shcheglov c59eaf1788 Move TypeProvider creation into KernelResynthesizer and create loadLibrary functions. 
R=brianwilkerson@google.com, paulberry@google.com

Bug:
Change-Id: Idabf9baa72de55d9a501a9b91317aad004dcf5dc
Reviewed-on: https://dart-review.googlesource.com/7447
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2017-09-20 20:48:50 +00:00
Brian Wilkerson 2a58b64937 Gardening: Update status file to fix the bots (TBR) 
Change-Id: Iaeb9c9c7ca5aee6b4e8ff90f30713e119824b6d0
Reviewed-on: https://dart-review.googlesource.com/7401
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2017-09-20 20:46:34 +00:00
Konstantin Shcheglov 9bdda4b1d3 Run NonErrorResolverTest in strong mode. Extract not strong tests. 
Plus a tiny fix for not considering a class with a static method
named "call" a Function.

R=brianwilkerson@google.com, paulberry@google.com

Bug:
Change-Id: I46c470c9d5dfb9f3cda9d5c5ac432962975f6773
Reviewed-on: https://dart-review.googlesource.com/7444
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2017-09-20 20:46:11 +00:00
pq abfd9594fe dart2js test expectation updates (block 136 continued) [TBR]. 
More staus file whack-a-mole.

Addresses:

python tools/test.py -m release -c dart2js -r d8 --minified --dart2js-with-kernel --use-sdk --dart2js-batch --reset-browser-configuration language_2/mixin_with_two_implicit_constructors_test
python tools/test.py -m release -c dart2js -r d8 --checked --minified --fast-startup --use-sdk --dart2js-batch --reset-browser-configuration language_2/mock_writable_final_field_test
python tools/test.py -m release -c dart2js -r d8 --host-checked --dart2js-batch --reset-browser-configuration language_2/mock_writable_final_field_test

Bug:
Change-Id: Ia2f44a57b36d2c35dadf3ab4b4d2d9c483d6552c
Reviewed-on: https://dart-review.googlesource.com/7445
Reviewed-by: Phil Quitslund <pquitslund@google.com>
 2017-09-20 20:32:59 +00:00
Jennifer Messerly 3224db05be fix #30792 -- fix variables shadowing parameters in an async function 
Change-Id: I40667f607450af8695aafc613358d401cd395af2
Reviewed-on: https://dart-review.googlesource.com/7042
Reviewed-by: Vijay Menon <vsm@google.com>
 2017-09-20 20:09:25 +00:00
Ben Konyi fe01ec1d12 Migrated test block 179 to Dart 2.0. 
Some changes were required to stream_transformer_test to make it strong
mode clean. Other minor changes involved migrating from unittest->test.

Bug:
Change-Id: Ia21144090710137e4803c651cf9e3fd62e17f5f7
Reviewed-on: https://dart-review.googlesource.com/3707
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
 2017-09-20 19:29:01 +00:00
Emily Fortuna ac98f741d5 Make JRecordFields not instance members (they were falsely categorized as such because the boxes were "classes"). 
Bug:
Change-Id: I5ea7ab26e5bb7c52a59b4f81b1489190b2d00fd0
Reviewed-on: https://dart-review.googlesource.com/7220
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2017-09-20 19:26:08 +00:00
Dan Rubel 7e25f2a336 tests for annotation at EOF 
Change-Id: I43aafd04dba8511cb603c6ca31a8135d868f52ef
Reviewed-on: https://dart-review.googlesource.com/7300
Reviewed-by: Peter von der Ahé <ahe@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2017-09-20 18:24:24 +00:00
Konstantin Shcheglov 8df6c79b9d Create (empty) initializers for parameters resynthesized from Kernel. 
R=brianwilkerson@google.com, paulberry@google.com

Bug:
Change-Id: Ifeddbd315b5c8d541c0db9a577d4cbddcfbdeba0
Reviewed-on: https://dart-review.googlesource.com/7380
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2017-09-20 18:04:00 +00:00
Konstantin Shcheglov e4fa080f69 Rework getElement() in resynthesizer. 
So that it is not recursive anymore.

This also fixes a bug with private classes.
There is no library URI qualifier for classes, even if they are private.

R=brianwilkerson@google.com, paulberry@google.com

Bug:
Change-Id: Ibeb8bd18fed9b116a40b2f2ff357f97283bc7b0d
Reviewed-on: https://dart-review.googlesource.com/7382
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2017-09-20 17:59:57 +00:00
Konstantin Shcheglov 9a8621b60a Add NamedNode.nameOffset, fill it for constructors, and use in Analyzer. 
R=ahe@google.com, kmillikin@google.com, paulberry@google.com, sigmund@google.com

Bug:
Change-Id: If0f815e86049381e9db3386f243789e9b4f9f5ce
Reviewed-on: https://dart-review.googlesource.com/6780
Reviewed-by: Paul Berry <paulberry@google.com>
 2017-09-20 17:54:30 +00:00
pq 0d9032c644 Update test expectations for multiline_strings_test on windows [TBR]. 
See: https://github.com/dart-lang/sdk/issues/30336

.gitattributes updated.

Bug:
Change-Id: I7481362e64159ba28b8448d19acca5817010739d
Reviewed-on: https://dart-review.googlesource.com/7383
Reviewed-by: Phil Quitslund <pquitslund@google.com>
 2017-09-20 17:52:26 +00:00
pq 84ac5aa1c6 Updated test expectations for dart2js d8 (in quest for greenness). 
Bug:
Change-Id: I689be0aac6f266ea757eb142fb5d18414f4203f9
Reviewed-on: https://dart-review.googlesource.com/7381
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2017-09-20 17:40:43 +00:00
Alexander Thomas c6d1edc4ec Disable co19 WebGL tests unless the builder_tag is set to run_webgl_tests to combat flakiness 
Bug: 29961
Change-Id: Ia5c0268a1b27181cef35e679e1410d104c345fc9
Reviewed-on: https://dart-review.googlesource.com/7360
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
 2017-09-20 17:01:47 +00:00
Florian Loitsch 9f85da73e3 Update status file. 
Change-Id: I8f4dc1f933799e8dea6f8d81061b4b07f7fbdc71
Reviewed-on: https://dart-review.googlesource.com/7363
Reviewed-by: Florian Loitsch <floitsch@google.com>
 2017-09-20 16:51:34 +00:00
pq 86e4c97346 Re-stage migration of test block 136 to Dart 2.0. 
Bug:
Change-Id: I562ceec87bc946bb43467ca118c88991a368657f
Reviewed-on: https://dart-review.googlesource.com/6781
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2017-09-20 16:23:00 +00:00
Florian Loitsch bb026e5d29 Fix typing error. 
Change-Id: Ib10a42863316ce6f15648345cf980236871c2f01
Reviewed-on: https://dart-review.googlesource.com/7361
Reviewed-by: Florian Loitsch <floitsch@google.com>
 2017-09-20 16:16:27 +00:00
Florian Loitsch 1483fc16fb Update co19-status file with bug number. 
Change-Id: Id1a93dc120f15be82dfea91fe779f4993354a562
Reviewed-on: https://dart-review.googlesource.com/7320
Reviewed-by: Florian Loitsch <floitsch@google.com>
 2017-09-20 15:51:56 +00:00
Florian Loitsch 38bf70d7ac Use generic functions in zones. 
Migrated from https://chromiumcodereview.appspot.com/2893893002/

Change-Id: I0bd6dc1438eb1e6762e7760a08b5a760b07d4b10
Reviewed-on: https://dart-review.googlesource.com/4942
Reviewed-by: Florian Loitsch <floitsch@google.com>
Commit-Queue: Florian Loitsch <floitsch@google.com>
 2017-09-20 15:46:06 +00:00
Paul Berry a8afd3ab16 Remove reified_dart.dart, batch_consistency.dart, and dartk.dart. 
These files all have to do with the old "dartk" front end, which is no
longer used.

Change-Id: I67041bf0a3a8a9213153123d9f79ac1632cc4d24
Reviewed-on: https://dart-review.googlesource.com/7101
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2017-09-20 15:33:16 +00:00
Morten Krogh-Jespersen a535f656c2 Adding table outputs to consoles. 
Bug:
Change-Id: Idea8360620f2f8370114ff231e6ffb38bfca9ab3
Reviewed-on: https://dart-review.googlesource.com/7262
Commit-Queue: Morten Krogh-jespersen <mkroghj@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2017-09-20 13:02:06 +00:00
Samir Jindel 8ebdd7662f [kernel-coq] Build class and function table, allow mutually recursive functions and classes. 
Bug:
Change-Id: I0d1fb82bccdf8174e4ab5ffdd38301600ecf4dd2
Reviewed-on: https://dart-review.googlesource.com/6620
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2017-09-20 12:51:34 +00:00
Erik Ernst 8562c8ff1b Adjusted spec of initializing formal type annotation 
During migration of lib/mirrors/initializing_formals_test.dart to lib_2
it became apparent that strong mode makes it an error to have different
type annotations on an initializing formal and the corresponding field.
The language team discussed this and decided that we will take a middle
way: These type annotations can differ, but the initializing formal
must have a subtype.

This CL adjusts the spec to say that. In line with the rest of the
spec it is still a static warning (we will migrate all the static
warnings to errors as a separate step).

Change-Id: I66656c2933b7f86b78f0b06eadbf5edc0f58a3c6
Reviewed-on: https://dart-review.googlesource.com/7264
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Commit-Queue: Erik Ernst <eernst@google.com>
 2017-09-20 11:38:26 +00:00
Lasse R.H. Nielsen 83de2423ae Revert "Simplify logic for creating a single IsolateRunner in analyzer." 
This reverts commit 7867fed521.

Reason for revert: 
Type error caught by DDC where the type of the function passed to isolate.run isn't what the runner expects.

Original change's description:
> Simplify logic for creating a single IsolateRunner in analyzer.
> 
> Change-Id: I8583f9947fde8f4cf87d7feb64c8eb170a19e81d
> Reviewed-on: https://dart-review.googlesource.com/6941
> Reviewed-by: Konstantin Shcheglov <scheglov@google.com>

TBR=lrn@google.com,scheglov@google.com

Change-Id: I5a0e46e345673dee447fd848c064dd0039832fb1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/7280
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
 2017-09-20 11:05:28 +00:00
Lasse Reichstein Holst Nielsen 7867fed521 Simplify logic for creating a single IsolateRunner in analyzer. 
Change-Id: I8583f9947fde8f4cf87d7feb64c8eb170a19e81d
Reviewed-on: https://dart-review.googlesource.com/6941
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2017-09-20 09:14:59 +00:00
Lasse R.H. Nielsen 1d9ed20e06 Add >>> operator to specification. 
Change-Id: Icade60331f708f895906dad9445878c6f32f9131
Reviewed-on: https://dart-review.googlesource.com/6621
Reviewed-by: Florian Loitsch <floitsch@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
 2017-09-20 07:51:46 +00:00
Stephen Adams 617f6ac197 Weaken constructor initializer assertion 
Accept a missing super-constructor call if one of the constructor
initializers always throws.  This matches dynamic error code generated
for various warnings, including duplicate final initializers.

Change-Id: If188c9d8d6d02bf9667123fbf679f1c103b5ef5a
Reviewed-on: https://dart-review.googlesource.com/7240
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2017-09-20 02:18:21 +00:00
Ben Konyi 192579020c Migrated test block 121 to Dart 2.0. 
Bug:
Change-Id: I194436597ba39b2e2b872fb58b77314ab925b3aa
Reviewed-on: https://dart-review.googlesource.com/7080
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2017-09-19 23:36:24 +00:00
Ryan Macnak 3d21a46b72 Limit preserialized JSON for timeline events from Dart code to the arguments. 
Avoids string copies in C++ and map copies in Dart.

Also remove some vestiages of removed feature that allowed an embedder to add pre-encoded events to the timeline.

Change-Id: I962a67093ba461c991d9169b0391c44af1d489db
Bug: https://github.com/dart-lang/sdk/issues/30787
Reviewed-on: https://dart-review.googlesource.com/6762
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Zach Anderson <zra@google.com>
 2017-09-19 23:29:55 +00:00
Paul Berry 2d74043f3a Implement type promotion of type parameter bounds. 
Fixes #30804.

Change-Id: I16094e54514b2109fda4b388083d2467a0b11bc7
Reviewed-on: https://dart-review.googlesource.com/7105
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2017-09-19 23:19:46 +00:00
Emily Fortuna 9a531f9b50 Get async/await working with the entity model. 
Bug:
Change-Id: I803cb8f8a681563d76d6eed56116267f64a9ba8a
Reviewed-on: https://dart-review.googlesource.com/7106
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2017-09-19 22:29:34 +00:00
keertip e4d28e60fc Update DEPS to pull in packages for zone strong changes 
Bug:
Change-Id: If69f46c9f5d7643e954400b63d1b867bbae7f39b
Reviewed-on: https://dart-review.googlesource.com/7103
Reviewed-by: Kevin Moore <kevmoo@google.com>
Commit-Queue: Keerti Parthasarathy <keertip@google.com>
 2017-09-19 21:48:23 +00:00
Vijay Menon 6ce85d5f99 Revert "Remove support for functions in asserts in DDC." 
This reverts commit 8140e1db64.

Change-Id: If505903ba475324392d6c6bcdae3392f523aadc8
Reviewed-on: https://dart-review.googlesource.com/7107
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Vijay Menon <vsm@google.com>
 2017-09-19 21:46:13 +00:00
Alexander Markov 26c08fb53a [VM, Compiler] Add null checks to AOT call specializer 
This CL inserts CheckNull instructions into appropriate places where
calls to int and double operators are specialized in AotCallSpecializer.
These checks are required for correctness.

Also, this CL adds tranformation of CheckedSmiComparison into int64
RelationalOp/EqualityOp instructions during canonicalization, as more
accurate type information may become available at later compilation
stages. This optimization counters early insertion of CheckedSmiComparison
instructions performed by AotCallSpecializer speculatively, without
sufficient knowledge of types (with sufficient knowledge it would insert
int64 operations at the first place).

Issue: https://github.com/dart-lang/sdk/issues/30480
Change-Id: I150cd25bd5d9b4c9fc1c2e7d175025760ca9702d
Reviewed-on: https://dart-review.googlesource.com/6348
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
 2017-09-19 21:44:24 +00:00
pq 5fa545bc84 STATUS file tweaks for string_literals_test dart2js crashers on windoze. 
Bug:
Change-Id: I50c6569db54dc36e0f97163a5c42b568eb25cfff
Reviewed-on: https://dart-review.googlesource.com/7120
Reviewed-by: Jaime Wren <jwren@google.com>
 2017-09-19 21:10:21 +00:00
Dan Rubel 9c1d97bb9c update parser to use token.isModifier 
Change-Id: Iee07cbde6c45b621bb13d1774c1d9f4bd97268ea
Reviewed-on: https://dart-review.googlesource.com/6840
Reviewed-by: Peter von der Ahé <ahe@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2017-09-19 20:27:03 +00:00
Emily Fortuna 5402179bd4 Properly pass on this as a free variable when inside closures. 
Bug:
Change-Id: Iba32dbc40e9361030a885b50a9e816c0ac123884
Reviewed-on: https://dart-review.googlesource.com/7102
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2017-09-19 20:16:45 +00:00
Brian Wilkerson f6e3e1f549 Add outline support for the test package 
Change-Id: Iff938d55082b3b222cf801ea53d4eaf5feb1e094
Reviewed-on: https://dart-review.googlesource.com/6980
Reviewed-by: Devon Carew <devoncarew@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2017-09-19 18:59:54 +00:00
pq 54c29a24f5 Fix STATUS for string_interpolate_test [TBR]. 
Bug:
Change-Id: Iecfc7bd23cc85d8607bca72ca95a039bb37486aa
Reviewed-on: https://dart-review.googlesource.com/7100
Reviewed-by: Phil Quitslund <pquitslund@google.com>
 2017-09-19 18:06:28 +00:00
Brian Wilkerson c0bf4ab395 Handle recursive import/export graph in completions 
Change-Id: Ia164c13f3119f569d781292353acc17243c8a464
Reviewed-on: https://dart-review.googlesource.com/7000
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2017-09-19 18:01:04 +00:00