934142766a
Remove discarding libraries context on timeout.
...
Use `linkLibraries` before analysis (after save) instead.
Change-Id: I0b13888398b32cefb6815717c3b0f525492abac0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/168767
Reviewed-by: Keerti Parthasarathy <keertip@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-10-22 16:43:00 +00:00
23947aa37a
bulk fix tests for excludes / ignores
...
Regression tests for: https://github.com/dart-lang/sdk/issues/43869
Change-Id: I7909c23b583af93cbabc4d291d31eba04dca104c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/168765
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Phil Quitslund <pquitslund@google.com >
2020-10-22 15:14:50 +00:00
6103487f9e
Remove unused imports with shared prefixes
...
Bug: https://github.com/dart-lang/sdk/issues/38784
Change-Id: I2c5477bbb36b17ad9ac4cf5e9584dd66f66afe1e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/168760
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2020-10-21 19:37:34 +00:00
96796b9751
[Analyzer] Add commit characters to LSP completion items
...
Change-Id: I71b1fa18a0fd9a4051359551803bff975381a835
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/168653
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Danny Tuppeny <danny@tuppeny.com >
2020-10-21 18:34:33 +00:00
382dbb6861
handle hashCode fields when creating ==
...
Fixes: https://github.com/dart-lang/sdk/issues/43867
Change-Id: I6ee0ee4feebce13e576a351bbe9578b705076422
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/168582
Commit-Queue: Phil Quitslund <pquitslund@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-10-20 22:38:01 +00:00
a880c3b180
provide context on producer exceptions
...
Change-Id: Iea3028af5de2bdd4712319ea2609d1b14888c1a6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/168584
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Phil Quitslund <pquitslund@google.com >
2020-10-20 22:34:21 +00:00
691d07575b
Add tests for flutter-specific uses of data-driven fixes
...
This also adds a fix for a bug found by the tests. There are a couple of
failing tests, but they're failing because the support required for them
hasn't been implemented yet, not because of a bug.
Change-Id: Ia24dffc02aac0c4b61c9c7d8e2d744211f5b4bea
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/168401
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-10-19 21:44:27 +00:00
35ce26e0db
Validate ignore comments
...
This adds checks for three cases:
- error codes for diagnostics that are not being produced,
- error codes that can't be ignored (with a severity of error), and
- error codes that are already being ignored.
I originally also checked for names that are not defined as error codes
(which turned up at least one valid issue in the Flutter repo), but we
don't have a list of all valid names against which to compare because
plugins can add new diagnostics.
It should be noted that, as written, these diagnostics can't be ignored,
despite being hints. The reason is as follows: in order to detect
diagnostics that are not being produced, these checks need to have a
list of the diagnostics that _are_ produced. If an ignore comment
attempted to ignore one of these hints, this validation would occur
before the hint had been generated, so that comment would in turn appear
to be unnecessary.
If we need them to be ignorable, then we can special case them so that
they are never reported as being unnecessary.
And after running this over the Flutter repo I commented out two of the
three codes because there are violations. Many of the violations are
valid and need to be cleaned up. Some are the result of "ignore" being
used for other purposes. The Flutter team has said that we can replace
their use of "ignore" in order to enable these hints, but I don't have
time to do that right now and I'd like to get this landed before it bit
rots again.
Change-Id: I1704105621bef5a5c49202267c99aa1d950a26a9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/156402
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2020-10-18 16:53:06 +00:00
c3c6ada631
Support data-driven update of deprecated parameters in methods that are not renamed
...
Change-Id: I52039796668225102b9a2d81b4a276556d763324
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/168121
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-10-16 16:49:22 +00:00
aad1a677c0
Deprecate GenericTypeAliasElement
...
See also https://dart-review.googlesource.com/c/sdk/+/166680
Change-Id: I6018f3bf5796dcc8ab059aab5b29d01e7336581b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/167727
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-10-15 16:03:26 +00:00
cb7ac82c32
Fix the computation of valid kinds
...
We were previously missing some cases, such as property access nodes,
while accepting too many, such as unknown cases wrapped as an argument
in a method invocation. This fixes both of those cases.
Change-Id: Id489fda9ed23ab19c42f1be451f8747ff8113ca9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/167721
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-10-14 19:29:48 +00:00
fbfc723de7
Use CompoundAssignmentExpression instead of LHS element/type.
...
This adds some technical debt in form of using writeOrReadElement in
clients, which can be paid incrementally by migrating these places to
handling assignment like expressions one by one. Doing it all in one
CL was too much. But now the underlaying AST resolution will be
sound.
In the next breaking change we will remove
setAssignmentBackwardCompatibility(), so stop setting elements/types
for assignment targets.
Change-Id: I11626876cfed25653edb0cc18544aba51cef5965
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/165622
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-10-14 18:45:08 +00:00
ece17f73b0
[Analyzer] Ask user whether to proceed with renames that produce errors
...
Fixes https://github.com/Dart-Code/Dart-Code/issues/2745 .
Change-Id: Ia2770f18ebca410bce93bd2f3042e294083dc435
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/167621
Commit-Queue: Danny Tuppeny <danny@tuppeny.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-10-14 17:46:58 +00:00
a1682401b5
Add flag to transforms indicating whether they should be applied when running in a bulk fix mode
...
Change-Id: I9a2add74524bdff4280e84a7d45a207e7321c458
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/167421
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-10-13 17:39:08 +00:00
1fcb032798
Do not generate void when overriding a setter
...
Bug: https://github.com/dart-lang/sdk/issues/43767
Change-Id: I373793360ffc58f28cb7a58b1b16c360b560ba51
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/167363
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-10-13 16:30:08 +00:00
3d039130f2
Remove unnecessary override.
...
This avoids a nuisance hint from the analyzer.
Change-Id: I9ddabf596858e3e833a9cea1e9d2efd7ce6923de
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/167140
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2020-10-12 16:35:22 +00:00
97ad2d69af
re-land pubspec analysis
...
Change-Id: I047687f2b64bfdc149bfde2fed6dc8f5d722e7a6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/167042
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Phil Quitslund <pquitslund@google.com >
2020-10-12 14:43:52 +00:00
666dad0086
Use the information we have about the kind of element when computing fixes
...
This puts in place support for using the element kind when determining
whether a transform applies. It is not as fully tested as it should be
but I plan to add more tests in future CLs.
Change-Id: Ife89c49384d1ceba9de5b18b7ef197018747ee25
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/167000
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2020-10-11 16:17:11 +00:00
52370de8fa
Enforce prefer_typing_uninitialized_variables in analysis_server
...
Change-Id: I09294ac48ab0f86a93cd1dcdcc53cca20546fb31
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/166720
Reviewed-by: Devon Carew <devoncarew@google.com >
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-10-08 20:00:05 +00:00
c21b906182
disable pubspec linting
...
Disables the fix in https://dart-review.googlesource.com/c/sdk/+/164249 pending a fix to `sort_pub_dependencies` which is producing a false positive that is blocking the Flutter engine roll.
See: https://github.com/dart-lang/sdk/issues/43529
See: https://github.com/dart-lang/linter/issues/2271
Change-Id: Ica6262153b89259ba67b5a43eeeafe2bdd482b44
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/166703
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Dan Field <dnfield@google.com >
2020-10-08 19:39:55 +00:00
f84bba2897
get libraries to fix from the context collection
...
Fixes: https://github.com/dart-lang/sdk/issues/43694
Also implements recursive fix semantics consistent with `dart analyze`.
Change-Id: I349650a0c1704c2e2be84287b46de17ecc132d56
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/166602
Commit-Queue: Phil Quitslund <pquitslund@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-10-08 01:34:08 +00:00
bd6c31ad9a
Do not match on parameter names
...
One of the bugs I recently found caused the transform for a getter to be
applied against a parameter. This CL fixes that particular issue by
correctly computing the element name to be the name of the enclosing
invocation rather than the parameter.
It also introduces an `ElementMatcher` to hold the data currently being
used to match elements with the intent that more information will be
added in the future to prevent similar sorts of mismatches.
Change-Id: I14abbece334b3dc660d3854b817362c441efa11d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/166600
Reviewed-by: Phil Quitslund <pquitslund@google.com >
2020-10-07 21:37:20 +00:00
ae466ef7d5
analysis_server: Bump to pedantic 1.9
...
Change-Id: Iec6c21abe09ecfbd74c4e1b18c0f519c0416467b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/163304
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-10-07 13:41:35 +00:00
31ea2200b8
Convert to list to avoid 'Adding to unmodifiable list' exception.
...
Change-Id: I1c5a6dad96435d8059d5d05362ab938cb91435b0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/166303
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Keerti Parthasarathy <keertip@google.com >
2020-10-06 22:13:53 +00:00
00594be05c
don’t bulk fix options-filtered errors
...
Change-Id: Ifa902ffa1a30a5282f4dae3e1a9487583f9c27ff
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/166126
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Phil Quitslund <pquitslund@google.com >
2020-10-06 00:40:23 +00:00
dbff41c62c
Add failing test for issue 43667
...
Change-Id: I5ad0f6d67a99003ca847fe6fbad1db88d24f246c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/165981
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-10-05 15:59:35 +00:00
71d2e6de69
lint diagnostic reporting for pubspecs
...
See: https://github.com/dart-lang/sdk/issues/43529
Change-Id: Iaf05102b3f6473913d900286c31779cdb1d59926
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/164249
Commit-Queue: Phil Quitslund <pquitslund@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-10-05 15:35:25 +00:00
36fa250a43
Support top-level variables as their own element kind
...
Change-Id: I2b929778d8f1c08b5930696ecc6f8f9553be4ebb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/165681
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-10-01 18:30:30 +00:00
52e1604f3c
Support bulk fixing deprecated diagnostics
...
Change-Id: I40b45d2eca24dae2d8d1c3bf8ac059d9e03fcdee
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/165624
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-10-01 17:16:17 +00:00
93fc5a9bf6
Add a quick fix to remove unnecessary null comparisons
...
Change-Id: I92eac9d06c7c7e3ca4508ba6b1b06761df94817c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/165481
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-10-01 04:31:32 +00:00
1ea4b88c31
[Analyzer] Send progress notifications for refactor command execution
...
See https://github.com/dart-lang/sdk/issues/43459 .
Change-Id: I055e4f61499675b9e1ec26e25d894b855f3170c7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/165363
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Danny Tuppeny <danny@tuppeny.com >
2020-09-30 17:29:34 +00:00
bd5125edb1
[Analyzer] Send a "content modified" response if files are modified during a refactor
...
See https://github.com/dart-lang/sdk/issues/43459 .
Change-Id: I2e32ba0ba1020d18ea574caac42e79ec184a5562
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/165362
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Danny Tuppeny <danny@tuppeny.com >
2020-09-30 17:23:54 +00:00
55e80eb936
Add support for more data-driven fixes to the bulk fix processor
...
Change-Id: I8a12e47c146d59db1a2ee689c5afbd8018349539
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/165380
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-09-30 17:18:05 +00:00
468556c58d
[Analyzer] Cancel LSP refactor requests when another refactor request arrives
...
See https://github.com/dart-lang/sdk/issues/43459 .
Change-Id: I52bf26e80b0d6ddb577c89b5a18ff7563e614cb4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/165321
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Danny Tuppeny <danny@tuppeny.com >
2020-09-30 16:27:29 +00:00
ca16e49baa
[Analyzer] Close streams to remove listeners in LSP tests
...
Change-Id: I7b000de76c81c1d4786d4ced35b6e6f40b0f6ca4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/165320
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Danny Tuppeny <danny@tuppeny.com >
2020-09-30 16:27:29 +00:00
5f01aec706
Enable bulk application of more data-driven fixes
...
Change-Id: Ieffd7093bb207fe3754cda8d03dde6c781971375
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/165144
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-09-30 13:43:34 +00:00
aa5cb76916
[Analyzer] Make LSP literal types optional in constructors and validate their values
...
Change-Id: Id6dddd4ed4819a75da4226ee57d73a65c15c9048
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/164965
Commit-Queue: Danny Tuppeny <danny@tuppeny.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-09-30 09:39:22 +00:00
665a40c675
[Analyzer] Add support for LSP's $/progress statuses for Analyzing status
...
Change-Id: Ia11d24a4323f2fcc21cb5d36528b89104d5fcb6b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/164963
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-09-29 20:03:14 +00:00
fe580d63c4
Add support for a couple of data-driven fixes to the bulk fix processor
...
Change-Id: I202029bdb4a39ec3f604df5cd59f94fb22d2e488
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/165081
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-09-29 19:43:48 +00:00
144a4545a0
[Analyzer] Update LSP toJson() functions to call toJson() on child fields
...
Change-Id: I596af3142ea3f1a279d3d98390cfe7e4d9d90cbd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/164962
Commit-Queue: Danny Tuppeny <danny@tuppeny.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-09-29 17:42:47 +00:00
8b567447dc
[Analyzer] Use new NAMED_REQUIRED ParameterKind for signature help
...
Change-Id: Ia4d23cb51f4e3729e8d40fa5a38dd8b2a8771c03
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/162006
Commit-Queue: Danny Tuppeny <danny@tuppeny.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-09-29 07:38:14 +00:00
5a087b90ce
Report another error in the data-driven data file
...
Change-Id: Ia252f69f70caeee6343978c7f8528b092e48c973
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/164804
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-09-28 19:37:57 +00:00
9fc21c8414
Fix a bug in data-driven fixes template support
...
The parser was returning null where a null was not expected.
Change-Id: Ie0dd72a96d384cd62bc03d8af4fa6a3733980731
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/164803
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-09-28 18:22:26 +00:00
f2dea6ca34
handle parts in the bulk fix loop
...
Fixes: https://github.com/dart-lang/sdk/issues/43564
Change-Id: I1b8f0859f5e13f2fbab1724a78bd243f755b4ccf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/164680
Commit-Queue: Phil Quitslund <pquitslund@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-09-25 23:52:34 +00:00
f0d1fe173c
utility that reports bulk-fixable lints
...
Change-Id: Ia3946edc36955430c5141b004293093ab09c923d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/164604
Commit-Queue: Phil Quitslund <pquitslund@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-09-25 22:53:34 +00:00
d11734f5a0
bulk fix for prefer_inlined_adds
...
Change-Id: I0d165fcc2068ccb05b1ef202cae29c4e415a430a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/164603
Commit-Queue: Phil Quitslund <pquitslund@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-09-25 21:55:54 +00:00
434a4d4919
Offer diagnostics for new metadata file to LSP clients
...
We are in the process of adding a new YAML file for configuring the
fixes in the server, and server is producing diagnostics when the file
content isn't valid. This is an attempt to make those diagnostics
available for clients.
I wasn't sure where to add tests for this, so a pointer would be
appreciated.
Change-Id: Ibd60d70867c6f10835b6f9014006d50b91259549
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/164460
Reviewed-by: Danny Tuppeny <danny@tuppeny.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-09-25 18:05:24 +00:00
2f5844a184
bulk fix for prefer_const_constructors
...
Change-Id: I54579790f7fd35cb79ac2f28609a620d1a4f9c2b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/164423
Commit-Queue: Phil Quitslund <pquitslund@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-09-25 17:44:24 +00:00
def50905c2
Make flow analysis handling of is/==/??=/?. consistent with mixed mode semantics
...
Bug: https://github.com/dart-lang/language/issues/1143
Change-Id: Id177f8b19c15ef246f21ddd840410cddfee2e5cc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/163600
Commit-Queue: Johnni Winther <johnniwinther@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2020-09-25 08:35:03 +00:00
ea20802e2e
bulk fix for prefer_collection_literals
...
Change-Id: Idc83fdc00296388f9e7b0eb35ae4d195577906ef
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/164401
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Phil Quitslund <pquitslund@google.com >
2020-09-24 21:13:37 +00:00
Konstantin Shcheglov