dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
76,143 Commits 2 Branches 0 Tags
088524efa6a35bd64ea2ec00c60dae3111298334
Commit Graph

76143 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Konstantin Shcheglov 088524efa6 Issue 43890. Implement applying resolution to IndexExpression. 
Bug: https://github.com/dart-lang/sdk/issues/43890
Change-Id: I537d157ca9ff583b09e7c09ff580202b9dc4ced3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/168778
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-10-22 19:27:10 +00:00
Alexander Aprelev feeb7ad461 [vm/concurrency] Add write-lock assertion to Class::SetFields protecting Class fields. 
This is follow-up to https://dart-review.googlesource.com/c/sdk/+/168140 which added write-lock to protect Class functions.

Bug: https://github.com/dart-lang/sdk/issues/36097
Change-Id: Idb2070d005c44509fc6701f2eb297b90e7ded581
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/168772
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Alexander Aprelev <aam@google.com>
 2020-10-22 19:07:20 +00:00
Nate Bosch 471e8fcd04 Update to latest package:async 
Change-Id: Id072725c6e7c663c0fabdca5d2f001507fe6d9dc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/168775
Auto-Submit: Nate Bosch <nbosch@google.com>
Commit-Queue: Nate Bosch <nbosch@google.com>
Commit-Queue: Jake Macdonald <jakemac@google.com>
Reviewed-by: Jake Macdonald <jakemac@google.com>
 2020-10-22 17:16:55 +00:00
Alexander Markov f4afdb3d76 [Tests] Skip slow co19 tests on simarm* and aot/debug configurations 
These tests involve large list literals which are very slow to
compile in AOT/debug mode, or they perform a large amount of work
which is too slow on simulated architectures (simarm, simarm64).

Closes https://github.com/dart-lang/sdk/issues/43614

Change-Id: Iafe1407247cc69e641d1e63f47b4c3d9f6eea35f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/168782
Reviewed-by: Siva Annamalai <asiva@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
 2020-10-22 17:09:40 +00:00
Nate Bosch 27596771f9 Update to the latest package:collection 
Adds a `sample` extension on Iterable.

Change-Id: I495c1048e0403410d58a4b125d942406614fddc9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/168800
Auto-Submit: Nate Bosch <nbosch@google.com>
Commit-Queue: Nate Bosch <nbosch@google.com>
Commit-Queue: Jake Macdonald <jakemac@google.com>
Reviewed-by: Jake Macdonald <jakemac@google.com>
 2020-10-22 17:08:50 +00:00
Jacob MacDonald 1a6539a0ee Dont add default enabled experiments to the map of parsed experiment flags, 
this breaks the SDK build once NNBD is enabled by default, because it thinks
the experiment is explicitly enabled (effectively making 2.10 the release
version)

Bug: https://github.com/dart-lang/sdk/issues/43872
Change-Id: I65ac4e6499109b04c79dbd33145ede09b6b893c8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/168774
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Jake Macdonald <jakemac@google.com>
 2020-10-22 16:56:40 +00:00
Konstantin Shcheglov 934142766a Remove discarding libraries context on timeout. 
Use `linkLibraries` before analysis (after save) instead.

Change-Id: I0b13888398b32cefb6815717c3b0f525492abac0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/168767
Reviewed-by: Keerti Parthasarathy <keertip@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-10-22 16:43:00 +00:00
Janice Collins 361dc84ed1 Update dartdoc to 0.36.1. 
Release notes:  https://github.com/dart-lang/dartdoc/releases/tag/v0.36.1

Change-Id: If0c4037d3b1828a29d85720c8daf36317665656b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/168773
Auto-Submit: Janice Collins <jcollins@google.com>
Commit-Queue: Janice Collins <jcollins@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2020-10-22 16:26:30 +00:00
pq 23947aa37a bulk fix tests for excludes / ignores 
Regression tests for: https://github.com/dart-lang/sdk/issues/43869

Change-Id: I7909c23b583af93cbabc4d291d31eba04dca104c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/168765
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-10-22 15:14:50 +00:00
Alexander Aprelev 37abbb2e3d [vm/concurrency] Introduce program_lock to guard program structure changes. 
This CL adds acquisiton of write lock and check for whether write lock is held when updating class functions, primarily populated during class finalization. Read locks will be added in successive CLs, so is extending of the locks coverage to all aspects of program structure changes.

Bug: https://github.com/dart-lang/sdk/issues/36097
Change-Id: I3dba6bc23db4e45599a20717226210f12e7fd2b3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/168140
Commit-Queue: Alexander Aprelev <aam@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
 2020-10-22 13:08:10 +00:00
Tess Strickland b64d20e434 [vm] Print symbol names and offsets in simulator backtraces. 
When running the simulator on precompiled mode, source information
is lost, so only the filename is valid with the line and column
information printed as -1.  For each frame, this CL adds the symbol name
of the instructions section and a hexadecimal offset from the start of
the section, which can be used with the native_stack_traces package. The
absolute address of the VM and isolate instructions are also included
at the start of the backtrace.

Cq-Include-Trybots: luci.dart.try:vm-kernel-precomp-linux-release-simarm-try,vm-kernel-precomp-linux-release-simarm64-try,vm-kernel-linux-release-simarm-try,vm-kernel-linux-release-simarm64-try
Change-Id: Ie67f914b156ead48fccc3069ced6a26940b80673
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/168822
Commit-Queue: Tess Strickland <sstrickl@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
 2020-10-22 12:58:40 +00:00
William Hesse a1d19ac096 Allow MacOSX SDK versions 10.x and 11.x in build scripts 
Fixes: https://github.com/dart-lang/sdk/issues/43871
Change-Id: Ic86d65311c198c677caaa1c7fb51d779baa7a335
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/168825
Reviewed-by: Alexander Thomas <athom@google.com>
 2020-10-22 12:53:55 +00:00
Clement Skau d68567d7c3 Adds a few more generated files to .gitignore. 
Change-Id: I8cda4c5b1aea8d21d163d9c7835edb873ae53cfc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/168484
Reviewed-by: Tess Strickland <sstrickl@google.com>
Commit-Queue: Clement Skau <cskau@google.com>
 2020-10-22 11:42:09 +00:00
Paul Berry 7fde117f83 Sort declarations in migration_info.dart 
Change-Id: I449c55bd570f60f4190be25a42e36d8c2b22a29e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/168781
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2020-10-22 11:19:00 +00:00
Paul Berry 26ab3421ec Fix long line. 
This was causing spurious linter output from the analyzer.

Change-Id: I76863ac5bada1461d485c4a0c2e044bbef6bd180
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/168721
Reviewed-by: Jens Johansen <jensj@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2020-10-22 11:19:00 +00:00
Johnni Winther c8c87f40e5 [cfe] Update test 
Unbreaks bots. The CQ missed the needed updates due to simultaneous commits.

Change-Id: I5d36806e5b30796211b4b1971c53bc81e45e3407
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/168824
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2020-10-22 10:13:40 +00:00
Sigurd Meldgaard 3a4c1905d8 Bump pub 
in this revision:

```
> git log --format="%C(auto) %h %s" f0c7771b38155d3829a60d60b5dba2784b100811..master
 5b4df5a6 Update README.md (#2688)
 d9b314bf Don't show 'precompiling' from `global run` unless in terminal (#2687)
 49201120 Top level command (#2622)
 196e4c9e Re-enable --mark=null-safety (#2685)
```

Change-Id: I3ddefa2e3bb549eef17c9e1f2aa5dc1820a72427
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/168541
Reviewed-by: Jonas Jensen <jonasfj@google.com>
Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>
 2020-10-22 08:31:59 +00:00
Johnni Winther f371096b58 [cfe] Remove unneeded 2.10 annotation in CFE tests 
The files are meant to be opted in and fixing the version 2.10 will
make them break when the current sdk version is changed.

Change-Id: I4124524f4c764bce4ef45e58ce15d806fb35db06
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/168820
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2020-10-22 08:07:49 +00:00
Johnni Winther 89249a1de2 [cfe] Add tests in which a mixin application declares a member 
The added tests exhibit forwarding stubs injected into mixin
application classes. These are currently not handled fully or
consistently throughout the CFE and can lead to crashes and errors.

Change-Id: Ib6a14c6adc48daa35f4a3a8e5b705ec3cf7f606d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/168652
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2020-10-22 08:07:19 +00:00
Johnni Winther ed3b948b88 [cfe] Use origin location for member signatures 
This is relanding https://dart-review.googlesource.com/c/sdk/+/168203
after it was reverted due to a problem in
https://dart-review.googlesource.com/c/sdk/+/168200

Change-Id: Id70d3e960b1edf1c5cdf92518b8e476084b1bb49
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/168645
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2020-10-22 07:45:29 +00:00
Johnni Winther 1514336465 [cfe] Use CombinedMemberSignature for creating simple legacy member signatures 
This is relanding https://dart-review.googlesource.com/c/sdk/+/168202 after
it was reverted due to a problem in
https://dart-review.googlesource.com/c/sdk/+/168200

Change-Id: If84af1edc73ded3aa372efa59355569f56601352
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/168644
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2020-10-22 07:45:29 +00:00
Johnni Winther c41fabbb48 [cfe] Use CombinedMemberSignature to create noSuchMethod forwarders 
This is relanding https://dart-review.googlesource.com/c/sdk/+/168201
after it was reverted due to a problem in
https://dart-review.googlesource.com/c/sdk/+/168200

Change-Id: I350ae8af38b48d909716289c99092be2a638f3fd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/168643
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2020-10-22 07:45:29 +00:00
Johnni Winther b42f954364 [cfe] Use experiment release version when non-nullable is enabled explicitly 
Even when non-nullable is enabled by default, enabling the experiment
explicitly should result in the experiment release version (and not
the experiment enabled version) to be used for opting in.

For this change, the semantics of parseExperimentalFlags was change
to _not_ normalize the flags to a full mapping including default values.
For this reason all uses of such maps are renamed to
'explicitExperimentalFlags'.

Closes #43879

Change-Id: I0d0262e68ec1403549abcfd305ae3a4404fe93e3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/168654
Reviewed-by: Jake Macdonald <jakemac@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2020-10-22 06:17:39 +00:00
Robert Nystrom 2cbf8f91f1 Roll dart_style 1.3.8 into the SDK. 
This can safely be done without updating the pre-built SDK. The only
change is a bug fix where the formatter would previously fail and now
successfully formats.

Change-Id: I34e9305bc47621582923635b84906b70118fce88
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/168580
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Nate Bosch <nbosch@google.com>
Reviewed-by: Nate Bosch <nbosch@google.com>
 2020-10-22 00:35:59 +00:00
Alexander Markov d014a0f59b Remove bytecode mode of Dart SDK build 
This change cleans up build.py --bytecode and gn.py --bytecode options.

Change-Id: Ie251e7049ce3f8f9da28d35eda139b60ee23af98
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/167842
Reviewed-by: Régis Crelier <regis@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
 2020-10-21 22:43:14 +00:00
Nate Bosch 17af4fea92 Update to latest package:http 
Change-Id: Id6b6ecce87c6635cc711867816473ba47d5be118
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/167680
Commit-Queue: Nate Bosch <nbosch@google.com>
Auto-Submit: Nate Bosch <nbosch@google.com>
Reviewed-by: Kevin Moore <kevmoo@google.com>
 2020-10-21 22:32:14 +00:00
Ryan Macnak 584fd79bc8 [vm, gc] Allow immediates in weak tables, and simplify serialization id tracking. 
Allow weak tables to contain immediate objects (Smis) by adjusting the sentinel value for an empty entry to a value which is never a valid Smi nor heap object. Immediates go into the old-space table, since they also don't need to be updated after a scavenge.

Remove the clustered serializer's separate Smi id table.

Change-Id: Ia34ebe92be17f6568f0d4e5090e9abf5e77dadb3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/168620
Reviewed-by: Régis Crelier <regis@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
 2020-10-21 21:17:54 +00:00
Brian Wilkerson fd44a07616 Fix handling of excludes from analysis options file in AnalysisContextCollection 
Bug: https://github.com/dart-lang/sdk/issues/35519
Change-Id: I76856c0418336ab62ac153f03a6a017088a65847
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/168762
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
 2020-10-21 21:17:04 +00:00
Jaime Wren 70a3627d57 Update dartdev smoke tests for Dart version 2.12 
I also took the time to
- add the smoke tests to the dartdev test_all.dart file
- change the order of the asserts to fail fast and with better messages if there are failures


Bug: https://github.com/dart-lang/sdk/issues/43842
Change-Id: Ic35e52145bf3f9d6871dcec07395966a02ca3d11
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/168761
Reviewed-by: Leaf Petersen <leafp@google.com>
Commit-Queue: Jaime Wren <jwren@google.com>
 2020-10-21 20:06:54 +00:00
Ryan Macnak 4364d40585 [vm, gc] Account for card remembering during become. 
Bug: https://github.com/dart-lang/sdk/issues/43862
Change-Id: I2587a976d74919cdd6b4fdf2baf68b66a8e88ccd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/168623
Reviewed-by: Alexander Aprelev <aam@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
 2020-10-21 19:53:44 +00:00
Sam Rawlins 6103487f9e Remove unused imports with shared prefixes 
Bug: https://github.com/dart-lang/sdk/issues/38784
Change-Id: I2c5477bbb36b17ad9ac4cf5e9584dd66f66afe1e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/168760
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2020-10-21 19:37:34 +00:00
Regis Crelier 0ace625d6d [VM/finalizer] Remove checks from finalizer now performed in CFE. 
Also stop passing the class 'being parsed' to finalization methods.

Change-Id: I7c2256c2a8ace468021ba0ba5be10b6bfb839480
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/168621
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Régis Crelier <regis@google.com>
 2020-10-21 19:36:56 +00:00
Sam Rawlins 1a2f33c4db Bump stream_channel and watcher 
Change-Id: I643a4237fb65b04780d7a8d6408adca2e0e8cedd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/168740
Reviewed-by: Kevin Moore <kevmoo@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2020-10-21 19:24:48 +00:00
Alexander Aprelev 4dd903d730 [frontend-server] Fix uri/path handling in frontend_server_test. 
Use of path instead of uri breaks test on Windows.

Change-Id: Ie40d155def0ad17b0963c9af1dfa1f1c5e2a8c0c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/168744
Commit-Queue: Alexander Aprelev <aam@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
 2020-10-21 19:19:19 +00:00
Sam Rawlins afcc072d83 Remove unused imports from analyzer_plugin 
Bug: https://github.com/dart-lang/sdk/issues/38784
Change-Id: Ib92f3880224243b800689d48cb3c287656a48981
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/168741
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2020-10-21 19:16:44 +00:00
Janice Collins 77be14d718 Update dartdoc to 0.36.0 and remove unnecessary extra parameter to 
invocation on the bots.

Release notes: https://github.com/dart-lang/dartdoc/releases/tag/v0.36.0

Change-Id: Ie15dfd538ee54b17b04c7d556fc61deddab463f6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/168600
Commit-Queue: Janice Collins <jcollins@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
 2020-10-21 19:11:14 +00:00
Paul Berry 96d3efcf48 Exclude pkg/_fe_analyzer_shared/test/constants/data_2 from analysis. 
This directory contains test data that isn't expected to analyze
cleanly.

Change-Id: I130db36badad76655546de7acf8f4382c54433e0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/168720
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2020-10-21 19:03:34 +00:00
Danny Tuppeny 96796b9751 [Analyzer] Add commit characters to LSP completion items 
Change-Id: I71b1fa18a0fd9a4051359551803bff975381a835
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/168653
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Danny Tuppeny <danny@tuppeny.com>
 2020-10-21 18:34:33 +00:00
Jaime Wren 1a5e52b7ba Update dartdev to be ready for the NNBD SDK migration. 
This change resolves http://dartbug.com/43842

'--enable-experiment' tests were removed as experiments tend to graduate out of the experiment phase.

Change-Id: If806848a24dca68f18868ee03ad98155aee156c2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/168403
Commit-Queue: Jaime Wren <jwren@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
 2020-10-21 18:26:14 +00:00
Stephen Adams ba6a17ab29 [dart2js] Make --benchmarking-x imply --csp 
This is a temporary assignment of the meaning of `--benchmarking-x`.

Change-Id: I453aca3fa2782498664aad05f0d637af5e91bd34
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/168402
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Stephen Adams <sra@google.com>
 2020-10-21 17:54:13 +00:00
cv692001 ec51b7a866 Corrected the format for VM experiment flag 
Done the changes as explained and completed the assigned task  by Correcting the format for VM experiment flag

 #41676

Closes https://github.com/dart-lang/sdk/pull/43874
https://github.com/dart-lang/sdk/pull/43874

GitOrigin-RevId: 8bc9d44a22b028d2790b5e8001cd44f45dff1a9d
Change-Id: I8154257f750815d8f8c9760457b51be449e10b45
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/168700
Reviewed-by: Michael Thomsen <mit@google.com>
 2020-10-21 16:09:38 +00:00
Alexander Markov 3e77a430b8 [vm/compiler] Verify that intrinsic parameters are boxed 
Intrinsic functions (both asm and graph intrinsics) do not expect
unboxed parameters in most cases. This change adds checks to verify
that and avoid generating incorrect code silently, in case parameters
become unboxed.

Fixes https://github.com/dart-lang/sdk/issues/43819

Change-Id: I71c1499bf8232f241316ae6b3cdeb57dec18fbb5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/168622
Reviewed-by: Martin Kustermann <kustermann@google.com>
Reviewed-by: Aske Simon Christensen <askesc@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
 2020-10-21 15:50:13 +00:00
Alexander Aprelev deba2f7e65 [frontend-server] Make frontend-server tests ready for flipping nnbd switch on. 
Bug: https://github.com/dart-lang/sdk/issues/43844
Change-Id: I12cdf00b9c8517d1f10fbc6a59c6ad69e138953e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/168624
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Alexander Aprelev <aam@google.com>
 2020-10-21 14:46:23 +00:00
pq 1d7eb3f7d2 pluralize fix summary 
Fixes: https://github.com/dart-lang/sdk/issues/43870

Change-Id: I871f556200323128b4c63368acf61ebec4e97696
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/168680
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-10-21 14:44:13 +00:00
Jens Johansen 38b70871e4 [CFE] Don't allow generate-messages to write empty files 
Previously, if editing messages.yaml and making a mistake one could
end up with empty "codes_generated.dart" and
"fasta_codes_cfe_generated.dart" meaning that nothing could compile
before doing a `git checkout <file>` on it.

Now instead generate-messages will just not do that.

Change-Id: I072d805772201af218609e7e45e5a6a2316de593
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/168648
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2020-10-21 14:24:03 +00:00
Johnni Winther fa6399ff81 [cfe] Add messages in preparation for enabling non-nullable by default 
The added messages handle the situation in which null safety is enabled
by default but is turned off either by language version or by explicitly
passing --enable-experiment=no-non-nullable

Change-Id: Iec43daf19a80f555e838635c83542fdb243b8ed4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/168647
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2020-10-21 13:51:03 +00:00
Johnni Winther 5c51990a80 [cfe] Handle void as return context in sync function expressions 
Closes #43174

Change-Id: I6b1cc04cbf2d65d9b877dfabf3e0f535f2491a94
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/168542
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2020-10-21 13:43:03 +00:00
Johnni Winther 81e345ca64 [cfe] Add test that exercises super member override checks for covariant parameters. 
The code exercised by the test is located in ClassBuilder.handleSeenCovariant

Change-Id: I140e60fff01f60461ebaa6edfe193dbb7858c641
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/168642
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2020-10-21 12:55:13 +00:00
Clement Skau 7f0bd5e811 [VM] Removes _Future's and _StreamImpl's _awaiter. 
Changes debugger.cc to use the 'lazy async stack' mechanism for
unwinding async stacks, which means we no longer have to manually
keep track of the caller.

This also allows us to get rid of _asyncStarListenHelper.

Bug: https://github.com/dart-lang/sdk/issues/42457
Change-Id: I536e9da4af275998140ae5f05e3a43e07c77cfc7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/167561
Commit-Queue: Clement Skau <cskau@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
 2020-10-21 12:38:23 +00:00
Jens Johansen 29fa4e8148 [CFE et al] Compile flutter platform as agnostic for test; set component mode more 
Bug: dartbug.com/43844 dartbug.com/43807
Change-Id: Iba662f0955897244aaac86ceace73b213fa06319
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/168482
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2020-10-21 10:04:41 +00:00