Commit Graph

6 Commits

Author SHA1 Message Date
Matthias Hausner 4b6ef00d59 Cancel async generator only when it yields
Async generators should only react to a cancellation when they
yield a value. Otherwise, the cancellation is ignored.

The example in dartbug.com/23436 should therefore never terminate,
because the generator function contains no yield statement.

This CL fixes bug 23436 by implementing the expected behavior, i.e.
not terminating the generator. If a yield statement is added to the
generator, the finally clause is executed once only, as expected.

BUG=23436
R=floitsch@google.com

Review URL: https://codereview.chromium.org/1683763002 .
2016-02-09 10:44:57 -08:00
Lasse R.H. Nielsen da8baacae4 Make root-zone handleUncaughtError rethrow with the correct stack.
Adds _rethrow function which reifies the stack trace of an async
error on the VM. There is no corresponding JS functionality, it still
just throws an AsyncError wrapper.

Fixes issue #24163
BUG= http://dartbug.com/24163
R=iposva@google.com, turnidge@google.com

Review URL: https://codereview.chromium.org//1383983002.
2015-10-05 08:16:52 +02:00
Florian Loitsch debf1d6f7c Don't zone-register async callbacks for every await call in the VM.
This has the nice side-effect that the stack_trace package provides nicer chains.
Fixes issue 23394.

R=hausner@google.com

Committed: https://github.com/dart-lang/sdk/commit/4dae43d63727268f2e0cc45d6020246eb49177b8
Reverted: https://github.com/dart-lang/sdk/commit/cb4f9fc925c5a92c6cf756751e38296383f66507

Review URL: https://codereview.chromium.org//1274133002 .
2015-08-17 19:26:50 +02:00
Florian Loitsch cb4f9fc925 Revert "Don't zone-register async callbacks for every await call in the VM."
This reverts commit 4dae43d637.

Review URL: https://codereview.chromium.org//1296973002 .
2015-08-17 16:43:35 +02:00
Florian Loitsch 4dae43d637 Don't zone-register async callbacks for every await call in the VM.
This has the nice side-effect that the stack_trace package provides nicer chains.
Fixes issue 23394.

R=hausner@google.com

Review URL: https://codereview.chromium.org//1274133002 .
2015-08-17 15:58:19 +02:00
iposva@google.com ad008bf8ba - Move timer implementation closer to the rest of message handling.
R=zra@google.com

Review URL: https://codereview.chromium.org//878323002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43225 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-28 00:39:35 +00:00