dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
36,958 Commits 2 Branches 0 Tags
07552fb3f6ec4a8f2e893ee88bf08bb4a4a00a45
Commit Graph

36958 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Florian Loitsch 07552fb3f6 Mark analyzer test as slow. 
Review URL: https://codereview.chromium.org/1781343002 .
 2016-03-11 13:52:02 +01:00
Erik Ernst 4dd22a87bb Adds tests for syntactic support for generic methods. 
This CL adds tests for syntactic support for declaration of type
parameters on methods and named functions, and for passing actual type
parameters in invocations.

The status files declare all the tests to be `CompiletimeError`s
(there is no support for `// AnalyzerOptions=`, so no `--options=..`
can be passed to `dartanalyzer`, even though it does succeed with
`--options=tests/language/X.options` where `X` is the name of the
test).

BUG=
R=brianwilkerson@google.com, leafp@google.com, regis@google.com

Review URL: https://codereview.chromium.org/1779173003 .
 2016-03-11 10:27:37 +01:00
Stephen Adams dc95698672 Type inference cleanup 
- No longer attribute queries to type inference. Queries are attributed to client.

- Remove vestigial CPA code

- Don't compare target sets for additions and deletions if they are
  the same (most of the time we revisit the dynamic call site due to
  a change in a returned result).

R=sigmund@google.com

Review URL: https://codereview.chromium.org/1777393003 .
 2016-03-10 17:25:22 -08:00
Zachary Anderson 202e077815 Uses a finalizer to delete zlib filter resources 
Also other misc. cleanup.

R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/1777643003 .
 2016-03-10 15:42:00 -08:00
Konstantin Shcheglov 4e8e1e2e04 Improve search for constructors and import elements. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1778363003 .
 2016-03-10 14:57:42 -08:00
Regis Crelier ea7929d2fb Ignore bounds in compile time type tests, since they will have been checked at 
run time (fixes issue 25935).
Add regression test.

R=rmacnak@google.com

Review URL: https://codereview.chromium.org/1780333002 .
 2016-03-10 14:22:44 -08:00
John McCutchan 53cae0aed9 Add ability for embedder to provide private timeline trace data 
- Add three new embedder hooks registered with Dart_SetEmbedderTimelineCallbacks
  - Dart_EmbedderTimelineStartRecording
  - Dart_EmbedderTimelineStopRecording
  - Dart_EmbedderTimelineGetTimeline

- Add unit test for record start / stop notification.
- Add unit test for get timeline.

This should allow Flutter to remove their hacked up timeline service RPCs.

R=chinmaygarde@google.com, rmacnak@google.com

Review URL: https://codereview.chromium.org/1783953002 .
 2016-03-10 13:32:48 -08:00
Chinmay Garde a044cf9633 Avoid specifying DART_SHARED_LIB in the static library GN targets 
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/1781943002 .
 2016-03-10 11:12:18 -08:00
Konstantin Shcheglov 5271cd3259 Fix for indexing synthetic elements. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1779233002 .
 2016-03-10 10:57:08 -08:00
Sigmund Cherem f80b3d0ce0 Update status on cpsir bot: these new tests crash the compiler for a known 
reason.

TBR=sra@google.com

Review URL: https://codereview.chromium.org/1777293003 .
 2016-03-10 10:04:01 -08:00
Brian Wilkerson f42380ccbb Improve the error message when there is an infinite loop in tasks 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1783853002 .
 2016-03-10 09:04:26 -08:00
Brian Wilkerson 83df52b590 Move more behavior out of ContextManagerCallbacks and into ContextManager 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1784523002 .
 2016-03-10 08:36:35 -08:00
Brian Wilkerson ec08de7df8 Get more data to track down issue 25884 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1775913005 .
 2016-03-10 08:21:40 -08:00
Brian Wilkerson 1a455bcb9d Move element handles out of generated 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1780883002 .
 2016-03-10 07:40:33 -08:00
Florian Loitsch a6d55e8ae4 Merge pull request #25949 from a14n/patch-1 
Update num.dart
 2016-03-10 14:13:06 +01:00
Florian Schneider 631ac120bb VM: Fix --noopt build by using ZoneHandle. 
BUG=
R=vegorov@google.com

Review URL: https://codereview.chromium.org/1777093003 .
 2016-03-10 13:47:07 +01:00
Johnni Winther 78e8677f83 Fix shared messages. 
Remembered to publish, forgot to test!

Review URL: https://codereview.chromium.org/1780803004 .
 2016-03-10 11:20:56 +01:00
Johnni Winther b31a2566d4 Use specific messages for const constructor with body. 
BUG=
R=floitsch@google.com

Review URL: https://codereview.chromium.org/1768143003 .
 2016-03-10 10:09:17 +01:00
Florian Schneider dd0564d9b0 Fix non-x64 builds. 
BUG=

Review URL: https://codereview.chromium.org/1783753002 .
 2016-03-10 09:50:45 +01:00
Florian Schneider bec43a3b8f Simplify the VM's typed_data constructors. 
Remove _new native functions to have one indirection less
when constructing typed data lists.

BUG=
R=asiva@google.com

Review URL: https://codereview.chromium.org/1782003002 .
 2016-03-10 09:38:08 +01:00
Siva Annamalai 7520ecc48b Do not start the service isolate when generating the core library snapshot as it does not load any files or resolve URIs. This ensures that we do not have a race condition of the main isolate shutting down the service isolate before it gets to start. 
R=fschneider@google.com

Review URL: https://codereview.chromium.org/1782493002 .
 2016-03-09 23:24:45 -08:00
danrubel d26d023ce7 update tests for execution on windows 
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1774623006 .
 2016-03-09 22:33:35 -05:00
Brian Wilkerson ef1c632679 Clean up some warnings (issue 25964) 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1778663006 .
 2016-03-09 17:32:49 -08:00
Sigmund Cherem 76a77d8b42 Skip tests in cpsir+checked mode until it is implemented 
TBR=sra@google.com

Review URL: https://codereview.chromium.org/1780843002 .
 2016-03-09 17:21:49 -08:00
Brian Wilkerson d03381c587 Fix NPE in rename local (issue 25933) 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1776743006 .
 2016-03-09 17:02:15 -08:00
Stephen Adams ae13804e09 dart2js: Destroy some type inference graph edges after type inference. 
Removing the `_assignments` and `users` collections from TypeInformation
nodes causes interior nodes (e.g. Phi, Narrow) to become unreachable and
available for GC. This seems to trim 1%-5% off the final heap of an SSA
compile.

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/e85ac191344cdbecfdd39d99ff50209bb3dc837f

Reverted: https://github.com/dart-lang/sdk/commit/9292d1bc2baa05c4ac97ec12d8d922811a181d02

Review URL: https://codereview.chromium.org/1776533002 .
 2016-03-09 16:45:19 -08:00
Kevin Moore 6f6b345f75 Added details of dartfmt change to 1.15 changelog 
Moved Dartium updates under new Tools section

R=rnystrom@google.com

Review URL: https://codereview.chromium.org/1777483009 .
 2016-03-09 15:19:30 -08:00
Regis Crelier ba69c8a898 Enumerate URIs of all types in type errors in order to help the user diagnose 
the error (it was previously only printed for types with identical names).
Cleanup and simplify construction of type errors.

R=hausner@google.com, srdjan@google.com

Review URL: https://codereview.chromium.org/1778133002 .
 2016-03-09 15:16:47 -08:00
Konstantin Shcheglov 4d48fa56d0 Listen for context add/remove and unit invalidation to update the index. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1783503004 .
 2016-03-09 14:52:19 -08:00
Stephen Adams 9292d1bc2b Revert "dart2js: Destroy some type inference graph edges after type inference." 
BUG=

Review URL: https://codereview.chromium.org/1775253004 .
 2016-03-09 14:07:48 -08:00
Alan Knight 4641732ddb Remove websql_test/functional suppression 
BUG=

Review URL: https://codereview.chromium.org/1777013003 .
 2016-03-09 14:05:14 -08:00
Alan Knight 051451d7e6 Trying to fix SQLResultSetRowList's subscript operator to do type conversion 
BUG=

Review URL: https://codereview.chromium.org/1779023002 .
 2016-03-09 14:02:30 -08:00
pq f56704cd41 DEPS bump to pickup the latest linter. 
Includes:

* Fix to skip overriding members in API doc checks (`public_member_api_docs`).
* Fix to suppress lints on synthetic nodes/tokens (#193).
* Message fixes (`annotate_overrides`, `public_member_api_docs`).
* Fix to exclude setters from return type checks (#192).

BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1770763007 .
 2016-03-09 13:30:56 -08:00
danrubel 14983f0a26 extract resource path test utils 
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1777913003 .
 2016-03-09 16:26:14 -05:00
Konstantin Shcheglov 00b6f98166 Separate index objects for each analysis context. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1778113002 .
 2016-03-09 13:24:12 -08:00
Stephen Adams 42070892a4 Create map for dump_info on demand. 
Saves about 1% of heap for non --dump-info compile.

R=sigmund@google.com

Review URL: https://codereview.chromium.org/1777823002 .
 2016-03-09 13:15:05 -08:00
Brian Slesinsky ae009e0870 Fix regression for import suggestions 
Imports weren't being suggested for implicit source files,
for example files from other analysis roots.

BUG=
R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/1759333002 .
 2016-03-09 12:59:46 -08:00
Stephen Adams e85ac19134 dart2js: Destroy some type inference graph edges after type inference. 
Removing the `_assignments` and `users` collections from TypeInformation
nodes causes interior nodes (e.g. Phi, Narrow) to become unreachable and
available for GC. This seems to trim 1%-5% off the final heap of an SSA
compile.

R=sigmund@google.com

Review URL: https://codereview.chromium.org/1776533002 .
 2016-03-09 12:47:10 -08:00
Srdjan Mitrovic 60ce67d91f Fix sticky error propagation from thread to isolate 
BUG=
R=asiva@google.com, iposva@google.com

Review URL: https://codereview.chromium.org/1769183003 .
 2016-03-09 12:40:43 -08:00
Ryan Macnak ed52614322 Fix incorrect assertion failures in noopt regarding removing classes that still have constants. 
R=asiva@google.com

Review URL: https://codereview.chromium.org/1776243002 .
 2016-03-09 12:11:23 -08:00
Konstantin Shcheglov 5a927c7373 Add hacks into build_sdk_summaries to workaround bugs in build tools. 
Paul thinks that there is a bug in gyp or make, and we should generate
only one output. So, we generate the whole bundle with all summaries
and index information. And then we have separate actions that take
this bundle and extract one output each - spec.sum and strong.sum files.

R=paulberry@google.com, whesse@google.com
BUG=

Review URL: https://codereview.chromium.org/1775973003 .
 2016-03-09 11:37:17 -08:00
Konstantin Shcheglov 21ed1750ce Issue 25962. Check for the number of arguments vs. number of required parameters. 
Unfortunately I was not able to reproduce the problem.

R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/25962

Review URL: https://codereview.chromium.org/1776353003 .
 2016-03-09 11:33:01 -08:00
pq e7e205f00b Add error codes to server protocol (#25958). 
See: https://github.com/dart-lang/sdk/issues/25958

BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1774913006 .
 2016-03-09 10:44:03 -08:00
Bob Nystrom 8defa5f77c Split resolver_test.dart into smaller files. 
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1782463002 .
 2016-03-09 10:42:09 -08:00
William Hesse 00e6b92e20 Change bleeding-edge version to 1.16.0, merge stable and bleeding-edge changelog. 
BUG=
R=kevmoo@google.com, mit@google.com

Review URL: https://codereview.chromium.org/1781703002 .
 2016-03-09 19:14:31 +01:00
pq fb3eae598a CLI support for enableConditionalDirectives. 
BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1778683004 .
 2016-03-09 10:04:41 -08:00
pq 402f27e26d Fix enableConditionalDirectives option handling. 
Net-net: we weren't copying this value over when copying context options.

BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1774213003 .
 2016-03-09 10:01:28 -08:00
Kevin Moore 3ab25d2803 fix changelog formatting 2016-03-09 09:48:26 -08:00
Kevin Moore 3cb353b4c5 update version that analyzer changes landed 
Follow-up on https://github.com/dart-lang/sdk/commit/18f46ec2a7855a9d699e6539fa41187ffba359e2

Review URL: https://codereview.chromium.org/1784443002 .
 2016-03-09 09:46:57 -08:00
Matthias Hausner 5db2c56b5b Fix crash when setting breakpoint in Observatory 
Fix bug in code that determines end token pos of classes, handle
typedef classes correctly.

BUG=25880
R=floitsch@google.com, johnmccutchan@google.com

Review URL: https://codereview.chromium.org/1767113007 .
 2016-03-09 08:55:54 -08:00