dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
36,958 Commits 2 Branches 0 Tags
07552fb3f6ec4a8f2e893ee88bf08bb4a4a00a45
Commit Graph

204 Commits

Author SHA1 Message Date
pq e7e205f00b Add error codes to server protocol (#25958). 
See: https://github.com/dart-lang/sdk/issues/25958

BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1774913006 .
 2016-03-09 10:44:03 -08:00
Dan Rubel 9fe92127e5 update setAnalysisRoots to accept package spec file 
As part of addressing https://github.com/dartino/atom-dartino/issues/13,
this CL updates the setAnalysisRoots API to allow package spec files
in the packageRoots map.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1711353003 .
 2016-02-19 10:57:16 -05:00
Paul Berry bc551cb308 Beef up analysis server integration test messages. 
When an integration test fails, in can be difficult to figure out why,
especially if the test had to forcibly terminate the analysis server
process.  These messages should help debug the problem.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1669473004 .
 2016-02-04 12:48:21 -08:00
Ivan Posva a3f816e75b - Fix usage of Platform.packageRoot. 
BUG=

Review URL: https://codereview.chromium.org/1533693003 .
 2015-12-17 13:08:19 -08:00
Konstantin Shcheglov 2f0f398c73 Fix lints: unnecessary_brace_in_string_interp 
Also fixes two cases of empty_constructor_bodies.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1521883002 .
 2015-12-13 13:05:00 -08:00
Konstantin Shcheglov 168556a3e4 Tweaks for hover. 
1. Include full signature of classes - extends, with and implements clauses.

2. Provide statis type only for variables - for all other elements the static type is always the same as in the signature.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1513943005 .
 2015-12-11 14:25:46 -08:00
Konstantin Shcheglov 1f5973e24e Explicitly specify that FilePath is not just absolute, but also a normalized path. 
It was implied, and every client I know of uses absolute and normalized paths.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1506323002 .
 2015-12-09 11:30:54 -08:00
pq 2fdcb1bd74 Promote diagnostic.getDiagnostics() (#25061). 
* removes rolling average support
* removes "experimental" tag
* bumps API version

Fixes #25061.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1509033003 .
 2015-12-09 09:29:26 -08:00
Paul Berry 7d3c4743db Merge remote-tracking branch 'origin/master' into analyzer-breaking-0.27 2015-12-03 14:22:24 -08:00
Brian Wilkerson b9644af695 Remove the old task model 
Review URL: https://codereview.chromium.org/1490233007 .
 2015-12-03 10:14:06 -08:00
pq 43f027fc05 Analysis request getReachableSources (#24893). 
Implements a new request to get reachable sources.

This solves a specific issue for flutter (e.g., inferring execution type by checking the transitive closure of reachabe sources for `dart:flutter`) but can be more generallly useful for other client-side smarts (e.g., "is this a web entry point?" or "is this a test?").

More context here: https://github.com/dart-lang/sdk/issues/24893

R=brianwilkerson@google.com, devoncarew@google.com

Review URL: https://codereview.chromium.org/1491013002 .
 2015-12-02 13:26:35 -08:00
pq c0466f28f5 Rolling average work queue diagnostic (#24933). 
Background: https://github.com/dart-lang/sdk/issues/24933

Salient bits:

* sampling will only start if a client registers interest in diagnostics.
* sampling will stop if clients stop requesting diagnostics.
* sample results are coming back as a string (but a double would be better).
* the mapping of context folders to averages in not garbage collected; since it's only potentially leaking `_Average` objects (and not contexts) when folders are deleted, I think that's fairly benign.

BUG=24933
R=brianwilkerson@google.com, devoncarew@google.com

Review URL: https://codereview.chromium.org/1463923003 .
 2015-11-20 14:24:47 -08:00
pq 6d9cb5e48a Move diagnostics to diagnostics domain (#24931). 
Still flagged `experimental` so no docs created.

See: https://github.com/dart-lang/sdk/issues/24931

BUG=24931
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1453433002 .
 2015-11-16 14:10:10 -08:00
pq 82e83bb34d Experimental getDiagnostics request (#24480). 
* Adds `getDiagnostics` request with *very* provisional diagnostics payload (primary goal here is to plumb this fully through and iterate).
* Updates codegenerator to skip doc generation for experimental APIs.

Additional context here: https://github.com/dart-lang/sdk/issues/24480.

BUG=24480
R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/1416093007 .
 2015-11-05 15:05:21 -08:00
Konstantin Shcheglov 069ba985de Fix protocol for EXTRACT_LOCAL_VARIABLE and coveringExpressionOffsets/lengths. 
Unfortunately we have to make coveringExpressionOffsets and coveringExpressionLengths optional.
Otherwise new clients cannot correctly parse responses from old servers.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/1407333006 .
 2015-11-03 10:19:41 -08:00
pq c4ccdb462a LineInfo line-end detection fixes. 
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1413783005 .
 2015-10-27 09:39:30 -07:00
pq 808f32d61d Fix to give LineInfo to options error spans. 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1417363007 .
 2015-10-26 21:09:48 -07:00
Konstantin Shcheglov c0d68a5437 DAS specification changes - spelling and ElementKind.FILE addition. 
ElementKind.FILE will be used in search.findElementReferences

1. In the 'element' field of responce when a URI is at the given offset.

2. In the only element of the 'path' field of SearchResult(s) for URI references to a URI or a library identifier.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1409333002 .
 2015-10-17 10:03:03 -07:00
pq 6bce9b2373 One extension manager (to bind them all). 
TL;DR Moves all plugin registration to AE's extension manager.

The rub is that plugin registration wasn't happening right which cropped up in integration testing.  Included is a test that verifies that options are getting properly threaded through to the linter.  (This test failed when we had two Extension Managers.)

R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/1398033004 .
 2015-10-13 16:37:42 -07:00
Paul Berry 9767634564 Fix manual editing of integration_test_methods.dart. 
In commit 9ad256cf18,
integration_test_methods.dart (an auto-generated file) was edited
manually.  The only necessary changes were to imports--the other changes
were the result of sorting declarations and running the formatter.

This CL replicates the necessary changes in the code generator and
re-runs it, un-doing the other changes.  This should fix the test
"pkg/analysis_server/tool/spec/check_all_test".

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1397353002 .
 2015-10-12 06:49:02 -07:00
Brian Wilkerson 9ad256cf18 Move the wire protocol support into the public API 
R=paulberry@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/1398293002 .
 2015-10-11 07:34:28 -07:00
Brian Wilkerson a296d57a5c Comment out debugging code 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1398503004 .
 2015-10-09 08:09:53 -07:00
Brian Wilkerson 190cc1ae82 Remove an unused test 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1396983004 .
 2015-10-09 08:09:04 -07:00
Paul Berry b76da2d61e Turn on the new task model by default in analysis server. 
The previous option for enabling the task
model ("--enable-new-task-model") is replaced with an option for
disabling it ("--disable-new-task-model").

BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1390843002 .
 2015-10-06 13:49:52 -07:00
danrubel d14a963546 only send final completion notification 
This shaves 1 ms off the average completion notification response time

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1389473002 .
 2015-10-06 14:21:29 -04:00
Konstantin Shcheglov b107dec41a Spec change: include covering expressions into Extract Local protocol. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1388783003 .
 2015-10-05 14:44:32 -07:00
pq 8697392367 AnalysisError hasFix attr (Implements #23874). 
R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/1385523002 .
 2015-10-05 09:46:17 -07:00
Konstantin Shcheglov 9d48af9ee3 Specification change for the 'libraryName' and 'partOfLibraryName' fields in Outline. 
R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org//1375163003 .
 2015-10-01 09:53:20 -07:00
Konstantin Shcheglov da29a447c4 New analysis.implemented notification specification. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1372623004 .
 2015-09-25 09:57:29 -07:00
Keerti Parthasarathy 6f775acc7b add performance tests 
BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1366923003 .
 2015-09-25 08:35:42 -07:00
Brian Wilkerson 42d1d4532d Reformat code to minimize churn 
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1310263003 .
 2015-09-09 08:19:18 -07:00
Konstantin Shcheglov 58f5005cb1 Add the optional 'superOnly' request parameter for 'search.getTypeHierarchy'. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1325543006 .
 2015-09-03 13:03:01 -07:00
Paul Berry 03a156c891 Plumb "enableSuperMixins" option through analysis server (implements DEP 34). 
Partially addresses #23772.

R=scheglov@google.com

Review URL: https://codereview.chromium.org//1301533003 .
 2015-08-20 09:47:26 -07:00
Brian Wilkerson 908708d655 More fixes for failures on the Windows bot 
R=paulberry@google.com

Review URL: https://codereview.chromium.org//1266923004 .
 2015-08-05 08:13:28 -07:00
Konstantin Shcheglov aa30cad380 Proposal for the 'edit.organizeDirectives' request. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/23921

Review URL: https://codereview.chromium.org//1258563008 .
 2015-08-03 07:59:26 -07:00
danrubel e196c15ca1 performance measurement mods: 
* apply source path translation in the order in which they are defined
* print elapse times in milliseconds
* log overlay content if server exception occurs
* simplify diagnostic port initialization
* add option to start server using new task model

BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1249793007 .
 2015-07-22 12:17:04 -04:00
Konstantin Shcheglov d5d0017e21 Tweak for navigation for URIs. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1246833002 .
 2015-07-20 15:07:00 -07:00
Konstantin Shcheglov 55cb93b422 Add '--useAnalysisHighlight2' option to generate version 2 of semantic highlight. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1241193002 .
 2015-07-20 10:37:46 -07:00
Brian Wilkerson 2ffa8de794 Add notification of analyzed files 
R=paulberry@google.com

Review URL: https://codereview.chromium.org//1232393005 .
 2015-07-13 15:07:33 -07:00
Brian Wilkerson 10b7db100f Revert "Update Analysis Server highlight API and implementation." 
This reverts commit 739847402b.

Rolling the wire protocol API version forward caused existing clients to break, so we're rolling it back until we can find a backward compatible way of adding the new functionality.

R=paulberry@google.com

Review URL: https://codereview.chromium.org//1236433003 .
 2015-07-13 09:49:55 -07:00
Konstantin Shcheglov d7c2f4550b Issue 23640. Implement 'analysis.getNavigation' request. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/23640

Review URL: https://codereview.chromium.org//1232683003 .
 2015-07-10 15:31:25 -07:00
Konstantin Shcheglov 739847402b Update Analysis Server highlight API and implementation. 
I think this is a good enough compromise between the existing and IDEA granilarity.

Eclipse plugin CL will follow.

(IN)VALID_STRING_ESCAPE are not implemented yet.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1227143003 .
 2015-07-09 11:19:44 -07:00
Konstantin Shcheglov 7e194d8fb5 Change navigation regions generation for constructors. 
In IDEA we use navigation regions for resolution.
And so far all navigation regions are for separate identifiers.
This CL splits single regions like "new A.named()" into separate "A" and "named" regions.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1218183007.
 2015-07-06 11:27:19 -07:00
danrubel 1647483615 move performance measurement to benchmark/integration 
BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1219023006.
 2015-07-01 12:09:43 -04:00
danrubel d2bd01852f performance measurement improvements 
* report mean, 90th, 99th, and std-dev
* increase analysis wait time to 60 seconds
* add option for analysis server localhost diagnostics
* report running old vs new task model
* do not check if src dir exists so that scripts are more portable
* set clientRequestTime for each request
* ensure dir paths have trailing separators

BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1221893003.
 2015-06-30 18:08:10 -04:00
danrubel d907a4265e (TBR) improve integration test failure message 
BUG=

Review URL: https://codereview.chromium.org//1194393002.
 2015-06-22 07:04:28 -04:00
Dan Rubel ab5371e9b7 analysis server performance measurement driver first cut 
* reads instrumentation file (log file support later)
* tracks initial analysis elapse time
* skeleton structure for adding more operations and tracking

BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1163713005
 2015-06-04 10:11:59 -04:00
Brian Wilkerson 07dd6b7649 Add lineLength parameter to edit.format request (issue 23519) 
R=jwren@google.com

Review URL: https://codereview.chromium.org//1154303005
 2015-06-01 09:39:02 -07:00
scheglov@google.com 9efb25fa50 Use package:test_reflective_loader instead of reflective_tests. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1101003002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45365 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-22 20:54:29 +00:00
brianwilkerson@google.com 4422b7c01e Fix error handling for formatting and update the spec 
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1099633004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45296 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-20 20:57:33 +00:00