dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
36,958 Commits 2 Branches 0 Tags
07552fb3f6ec4a8f2e893ee88bf08bb4a4a00a45
Commit Graph

91 Commits

Author SHA1 Message Date
Brian Wilkerson ef1c632679 Clean up some warnings (issue 25964) 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1778663006 .
 2016-03-09 17:32:49 -08:00
Brian Slesinsky ae009e0870 Fix regression for import suggestions 
Imports weren't being suggested for implicit source files,
for example files from other analysis roots.

BUG=
R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/1759333002 .
 2016-03-09 12:59:46 -08:00
pq f506639391 Back out ignore quick-fix. 
As per, https://github.com/dart-lang/sdk/issues/25926, we'll migrate this behavior to the IDE side.

BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1770733002 .
 2016-03-07 09:25:28 -08:00
pq 1f0a0b5a5c Quick fix to ignore a specific error (#25915). 
See: https://github.com/dart-lang/sdk/issues/25915

BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1764853002 .
 2016-03-04 11:11:06 -08:00
Konstantin Shcheglov aed5431106 Issue 24988. Parse source for sorting. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/24988

Review URL: https://codereview.chromium.org/1507083002 .
 2015-12-07 14:01:24 -08:00
Konstantin Shcheglov bb1914e175 Make FixContributor asynchronous. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1461313004 .
 2015-11-20 14:57:00 -08:00
Konstantin Shcheglov ae1bee3859 Make AssistContributor asynchronous. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1461343002 .
 2015-11-20 12:18:26 -08:00
Konstantin Shcheglov f49612ba51 Covering expression offsets/lengths integration. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1411973006 .
 2015-11-03 10:45:17 -08:00
Konstantin Shcheglov 069ba985de Fix protocol for EXTRACT_LOCAL_VARIABLE and coveringExpressionOffsets/lengths. 
Unfortunately we have to make coveringExpressionOffsets and coveringExpressionLengths optional.
Otherwise new clients cannot correctly parse responses from old servers.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/1407333006 .
 2015-11-03 10:19:41 -08:00
Brian Wilkerson 9ad256cf18 Move the wire protocol support into the public API 
R=paulberry@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/1398293002 .
 2015-10-11 07:34:28 -07:00
Konstantin Shcheglov 0b01edac17 More tests for 'Organize Directives'. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1380893003 .
 2015-10-02 13:11:34 -07:00
Konstantin Shcheglov 6c029f9cb1 Issue 24440. Fix for renaming libraries using 'part of' directives. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/24440

Review URL: https://codereview.chromium.org//1364853007 .
 2015-09-25 14:24:05 -07:00
Konstantin Shcheglov c48cc7b913 Check for reset during 'await' in refactoring manager. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1281983002 .
 2015-08-10 11:19:03 -07:00
Brian Wilkerson 908708d655 More fixes for failures on the Windows bot 
R=paulberry@google.com

Review URL: https://codereview.chromium.org//1266923004 .
 2015-08-05 08:13:28 -07:00
Konstantin Shcheglov ca28e0ff4b Forgotten test. 
TBR

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1259263004 .
 2015-08-04 08:35:53 -07:00
Konstantin Shcheglov 92f49b892d Implementation of 'edit.organizeDirectives'. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1255413003 .
 2015-08-03 22:44:35 -07:00
Konstantin Shcheglov 64ff591f56 Organize directives implementation. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1266393002 .
 2015-08-03 13:49:57 -07:00
Brian Wilkerson 07dd6b7649 Add lineLength parameter to edit.format request (issue 23519) 
R=jwren@google.com

Review URL: https://codereview.chromium.org//1154303005
 2015-06-01 09:39:02 -07:00
Brian Wilkerson ad52c9eab9 Add support for specifying files needing analysis 
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1152013002
 2015-05-21 14:34:04 -07:00
Konstantin Shcheglov a8b7d1afe0 Convert two tests to use async/await. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1140373002
 2015-05-18 09:51:09 -07:00
scheglov@google.com d798e3e262 Issue 23477. Fix for Quick Fixes in overlay-only files. 
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=23477

Review URL: https://codereview.chromium.org//1145443003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45826 260f80e4-7a28-3924-810f-c04153c831b5
 2015-05-15 20:47:03 +00:00
brianwilkerson@google.com ac3613e2bb Re-apply change to move to plugin package 
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1094083003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45408 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-24 18:54:24 +00:00
brianwilkerson@google.com 3d536efcfe Revert breaking change 
Review URL: https://codereview.chromium.org//1101213002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45384 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-23 22:12:20 +00:00
brianwilkerson@google.com 24c853446a Convert analyzer and analysis_server to use the plugin package 
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1063153004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45382 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-23 20:32:35 +00:00
scheglov@google.com 9efb25fa50 Use package:test_reflective_loader instead of reflective_tests. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1101003002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45365 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-22 20:54:29 +00:00
brianwilkerson@google.com 4422b7c01e Fix error handling for formatting and update the spec 
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1099633004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45296 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-20 20:57:33 +00:00
paulberry@google.com cd1dd1864b Fix additional cases where analysis server might send null, violating protocol. 
In addition, modify the code generation so that these protocol
violations will be caught by assertions during unit tests.
Previously, they would only be caught at runtime by client code.

R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//1083223003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45211 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-16 15:41:39 +00:00
paulberry@google.com cb319b21cd Fix "edit.format" to follow protocol when there is no selection. 
BUG=dartbug.com/23230
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1092653002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45210 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-16 14:44:55 +00:00
brianwilkerson@google.com 46064e8f2f Create a public API for contributing fixes and make fixes pluggable 
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1080653003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45079 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-10 21:01:10 +00:00
brianwilkerson@google.com cd58e290c4 Reformat 
R=paulberry@google.com

Review URL: https://codereview.chromium.org//969113002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44151 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-02 22:43:12 +00:00
scheglov@google.com acec842aee Add 'Convert Method to Getter' proposal only if it is an available refactoring. 
So, that we don't show it for method with parameter or returning null.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//945113002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43936 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-20 23:18:21 +00:00
scheglov@google.com 55a3255070 Return RequestErrorCode.NO_INDEX_GENERATED for search/refactoring requests. 
Also remove passing a SearchEngine instance into Quick assists/fixes - they don't use it.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//923103004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43819 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-17 20:01:45 +00:00
scheglov@google.com 865b217511 Issue 22381. Fix for navigating to constructor from redirecting factory constructor. 
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22381

Review URL: https://codereview.chromium.org//921833002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43731 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-12 17:58:29 +00:00
scheglov@google.com c93b24904d Issue 22157. Cancel a pending refactoring request on receiving a new one. 
R=brianwilkerson@google.com, paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22157

Review URL: https://codereview.chromium.org//884453002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43201 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-27 19:24:19 +00:00
pquitslund@google.com 6fb12789e7 Analysis server format service wiring (and protocol doc update). 
R=brianwilkerson@google.com, danrubel@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//833903005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42835 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-13 20:34:10 +00:00
scheglov@google.com a38a503d86 Replace @ReflectiveTestCase() with @reflectiveTest. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//849863002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42821 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-13 17:11:24 +00:00
scheglov@google.com f6d7bd629f Improve tests for refactoring exceptions. Catch initial exceptions. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//816133002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42574 260f80e4-7a28-3924-810f-c04153c831b5
 2014-12-30 18:50:57 +00:00
scheglov@google.com 11bdb14559 Catch exceptions in refactorings and return them as a SERVER_ERROR. 
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21907

Review URL: https://codereview.chromium.org//815233002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42526 260f80e4-7a28-3924-810f-c04153c831b5
 2014-12-19 21:51:02 +00:00
scheglov@google.com 1c082a63ab Don't send a refactoring feedback in case of a fatal initial problem. 
R=brianwilkerson@google.com, danrubel@google.com
BUG=

Review URL: https://codereview.chromium.org//793373004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42350 260f80e4-7a28-3924-810f-c04153c831b5
 2014-12-12 22:55:52 +00:00
scheglov@google.com 0cd030eeb8 Issue 21613. Fix for renaming FieldFormalParameterElement. 
R=paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21613

Review URL: https://codereview.chromium.org//749173002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41929 260f80e4-7a28-3924-810f-c04153c831b5
 2014-11-24 16:00:28 +00:00
scheglov@google.com b8da9bc651 Format and sort analyzer and analysis_server packages. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//725143004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41792 260f80e4-7a28-3924-810f-c04153c831b5
 2014-11-17 22:23:53 +00:00
scheglov@google.com affc91a881 Issue 21552. Fixes for navigation, hover and rename in instance creation expressions. 
R=brianwilkerson@google.com, paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21552

Review URL: https://codereview.chromium.org//717513003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41651 260f80e4-7a28-3924-810f-c04153c831b5
 2014-11-11 03:01:21 +00:00
scheglov@google.com 772a0c6b22 Fix 'Unused local variable' hints in analyzer and analysis_server. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//709493002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41576 260f80e4-7a28-3924-810f-c04153c831b5
 2014-11-06 18:32:54 +00:00
scheglov@google.com 68831585dd Fix for renaming import without an import prefix. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//640253004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41021 260f80e4-7a28-3924-810f-c04153c831b5
 2014-10-09 16:25:07 +00:00
scheglov@google.com 6596936e55 Fix for starting 'Rename LibraryElement' refactoring. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//619223002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40866 260f80e4-7a28-3924-810f-c04153c831b5
 2014-10-02 03:00:32 +00:00
scheglov@google.com 99156246f8 Include 'potentialEdits' into refactoring feedback. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//611823003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40750 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-28 18:59:00 +00:00
scheglov@google.com 5d01fcbedf Implement 'edit.sortMembers' request. 
R=paulberry@google.com, brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//601083005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40735 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-26 20:09:21 +00:00
scheglov@google.com bc768460d4 Integrate CONVERT_GETTER_TO_METHOD refactoring into server. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//605063002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40712 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-26 15:26:23 +00:00
scheglov@google.com c56440ec34 Integrate CONVERT_METHOD_TO_GETTER into the server. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//591083003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40549 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-22 17:04:50 +00:00
scheglov@google.com fac2a62392 Reset refactoring manager on any analysis. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//589843002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40542 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-22 14:56:26 +00:00