4e8e1e2e04
Improve search for constructors and import elements.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1778363003 .
2016-03-10 14:57:42 -08:00
5271cd3259
Fix for indexing synthetic elements.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1779233002 .
2016-03-10 10:57:08 -08:00
83df52b590
Move more behavior out of ContextManagerCallbacks and into ContextManager
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1784523002 .
2016-03-10 08:36:35 -08:00
ef1c632679
Clean up some warnings (issue 25964)
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1778663006 .
2016-03-09 17:32:49 -08:00
4d48fa56d0
Listen for context add/remove and unit invalidation to update the index.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1783503004 .
2016-03-09 14:52:19 -08:00
00b6f98166
Separate index objects for each analysis context.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1778113002 .
2016-03-09 13:24:12 -08:00
ae009e0870
Fix regression for import suggestions
...
Imports weren't being suggested for implicit source files,
for example files from other analysis roots.
BUG=
R=brianwilkerson@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org/1759333002 .
2016-03-09 12:59:46 -08:00
e7e205f00b
Add error codes to server protocol ( #25958 ).
...
See: https://github.com/dart-lang/sdk/issues/25958
BUG=
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org/1774913006 .
2016-03-09 10:44:03 -08:00
402f27e26d
Fix enableConditionalDirectives option handling.
...
Net-net: we weren't copying this value over when copying context options.
BUG=
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org/1774213003 .
2016-03-09 10:01:28 -08:00
5b117e9e18
Use the fact that some index lists are sorted.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1776143002 .
2016-03-08 13:43:43 -08:00
3af20476d1
Add AnalysisContext.onResultInvalidated(descriptor).
...
This method will be used to remove index entries corresponding to
invalidated resolved units.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1776023002 .
2016-03-08 12:55:06 -08:00
b9ee5c20eb
Implement SearchEngine.searchMemberReferences().
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1768353002 .
2016-03-07 13:41:12 -08:00
f2111c2497
Search for direct and indirect subclasses.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1770083002 .
2016-03-07 11:30:44 -08:00
2293a22b7f
Implement searchMemberDeclarations() / searchTopLevelDeclarations().
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1770953002 .
2016-03-07 11:14:05 -08:00
8dbbb55a2e
Implement search for names defined in index.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1771903002 .
2016-03-07 10:40:01 -08:00
28f8a64210
Remove SearchEngine.searchElementDeclarations().
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1769063002 .
2016-03-07 09:57:15 -08:00
f506639391
Back out ignore quick-fix.
...
As per, https://github.com/dart-lang/sdk/issues/25926 , we'll migrate this behavior to the IDE side.
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1770733002 .
2016-03-07 09:25:28 -08:00
9f448d00fe
Support for searching of libraries, import prefixes and import elements.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1767113002 .
2016-03-07 08:34:34 -08:00
ec906bf12b
Implement search for local elements.
...
We don't use Index for them, instead of visit coresponding AST subtrees
and add SearchMatch(es).
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1760243004 .
2016-03-05 07:50:11 -08:00
aa7bea0d6a
New SearchEngine implementation - references only.
...
And only for the elements for which we have information in the index.
References to other kinds of elements - local variables, parameters,
etc can be implemented using AST visitors. To be implemented in next CLs.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1763133002 .
2016-03-04 12:08:04 -08:00
1f0a0b5a5c
Quick fix to ignore a specific error ( #25915 ).
...
See: https://github.com/dart-lang/sdk/issues/25915
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1764853002 .
2016-03-04 11:11:06 -08:00
adcf43968f
Ignore not ClassDeclaration target of an unknown method invocation.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1764743002 .
2016-03-03 11:23:32 -08:00
5831cfb1bb
Fix issue where errors aren't reported for a new overlay
...
A new overlay was not being marked as an explicitly added
source, even if it's within the directory of an analysis
context. As a result, errors were not being reported.
I believe this only happens if there's no underlying file.
Therefore it seems difficult to reproduce in an IDE, but
it comes up in a stress test.
BUG=
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org/1753083003 .
2016-03-03 10:42:45 -08:00
8cd8d219ca
Handle incomplete rule options gracefully.
...
Net-net: this fixes the case where we get storms of UNDEFINED_LINT_WARNINGs when parsed yaml nodes have null values.
BUG=
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org/1752183003 .
2016-03-03 09:58:30 -08:00
80531d974d
Make SearchMatch usable for the new index - remove the element field.
...
The 'element' is still accessible, but as a computed property.
In many cases we don't need to know the containing element, and need
only the unit source, or the LibraryElement. So, by computing it on
demand we may save some time and make SearchMatch usable with the
new index - where we don't know the Element.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1764553002 .
2016-03-03 08:40:57 -08:00
7d2976c7d5
Add instantiate method on ParameterizedType and InterfaceType,
...
and deprecate the old substitute4 in favor of instantiate.
BUG=
R=brianwilkerson@google.com , jmesserly@google.com
Review URL: https://codereview.chromium.org/1758913002 .
2016-03-02 15:06:38 -08:00
c9e82c7e67
Fill the new index in Analysis Server.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1749333004 .
2016-03-02 14:00:17 -08:00
faf59757c8
Optimize ElementId search, rename the test file.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1755313002 .
2016-03-02 13:02:52 -08:00
6d1bf8b0fa
Initial new index implementation.
...
Only getRelations() is implemented, and maybe not the most performant
implementation yet.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1755263002 .
2016-03-02 12:05:05 -08:00
d223676c7f
Fix @override quick-fix to respect doc comments.
...
BUG=
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org/1751163002 .
2016-03-01 13:01:57 -08:00
841f8e6cf2
Move shouldFileBeAnalyzed into ContextManager
...
R=paulberry@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org/1748763002 .
2016-03-01 12:40:56 -08:00
e225e619cd
Issue 25827. Don't propose to remove the type of an incomplete variable declaration.
...
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/25827
Review URL: https://codereview.chromium.org/1753893002 .
2016-03-01 12:20:24 -08:00
954d61f363
Partially revert notification of package map computation
...
R=paulberry@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org/1750763002 .
2016-02-29 14:37:00 -08:00
c4d7f41650
Move folderMap from AnalysisContext to ContextManager
...
R=paulberry@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org/1750683002 .
2016-02-29 14:04:46 -08:00
549a7a4d00
Quick-fix for annotate_overrides lint ( #25416 ).
...
An interim approach to shoe lint-awareness into the dart FixProcessor. Once we have a a shareable processor base class we can migrate these bits into a dedicated LintFixProcessor contributed by the LintServerPlugin.
See: https://github.com/dart-lang/sdk/issues/25416
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1736383002 .
2016-02-26 14:23:05 -08:00
5c2afc8d09
Start work to remove the context manager callbacks
...
R=paulberry@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org/1739913003 .
2016-02-26 13:11:46 -08:00
44fc8ec8f3
Make add/remove type Quick Assists less obtrusive.
...
It is nice to have them until after the variable name, but not OK to
have them on initializers, especially when the initializer has a
closure.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1737563002 .
2016-02-25 08:20:23 -08:00
9fe92127e5
update setAnalysisRoots to accept package spec file
...
As part of addressing https://github.com/dartino/atom-dartino/issues/13 ,
this CL updates the setAnalysisRoots API to allow package spec files
in the packageRoots map.
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org/1711353003 .
2016-02-19 10:57:16 -05:00
026748533f
Add @override when implement missing overrides for fields.
...
This makes the code generated by DAS closer to the code generated by
the IDEA plugin.
R=brianwilkerson@google.com , jwren@google.com
BUG=
Review URL: https://codereview.chromium.org/1705283002 .
2016-02-17 13:30:23 -08:00
71e7ed86c0
Move scanner out of generated and clean up imports
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1693083004 .
2016-02-14 07:48:44 -08:00
6188d18eec
rework completion request resolve imports
...
* rename resolveDirectives --> resolveImports
* rework resolveImports to return list of ImportElement rather than Directive
* new resolveDirectives test
* set priority source during completion tests
This and https://codereview.chromium.org/1685653002/ fixes https://github.com/dart-lang/sdk/issues/25690
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org/1693933002 .
2016-02-13 23:15:52 -05:00
3fc06a4aa7
abort completion request - fixes #24271
...
This CL aborts completion requests (returns empty list of completions)
if either a newer completion request is received
or the source changes after the completion request was received.
In addition, I wrapped calls to AnalysisFutureHelper computeAsync
in exception handlers so that it will be easier to track async exceptions
back to the code that requested the computations.
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org/1685653002 .
2016-02-10 12:45:53 -05:00
bdd0d637fe
We need to perform analysis differently based on some option settings (such as strong mode), but there is currently a single SDK that is shared across all contexts no matter which option values are being used. This causes us to inconsistently analyze different portions of the SDK depending on which outer context was the first to request the analysis.
...
This is at least a first step toward solving this problem by allowing multiple SDKs to be created, one for each unique set of options.
R=paulberry@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org/1686613002 .
2016-02-09 11:05:34 -08:00
fa08150ca6
Support for embedder dependency changes ( #25606 ).
...
Adds logic to detect when a library embedder is added as a dependency and reconfigures the `SourceFactory` appropriately.
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org/1653733002 .
2016-02-09 09:39:59 -08:00
20d31ea8c3
Compute ElementImpl.hashCode using location.
...
We need this to ensure that Impl and Handle have the same hash.
This reduces number of shared test failures from 267 to 67 when using
SDK summaries.
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org/1677213003 .
2016-02-09 07:06:22 -08:00
960b9c3409
Issue 25650. Generate unique parameter names when create a method or function.
...
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/25650
Review URL: https://codereview.chromium.org/1664423002 .
2016-02-04 13:59:27 -08:00
fb520065b8
Issue 25686. Add 'var' for untyped unimplemented fields.
...
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/25686
Review URL: https://codereview.chromium.org/1668273002 .
2016-02-04 13:32:49 -08:00
bc551cb308
Beef up analysis server integration test messages.
...
When an integration test fails, in can be difficult to figure out why,
especially if the test had to forcibly terminate the analysis server
process. These messages should help debug the problem.
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org/1669473004 .
2016-02-04 12:48:21 -08:00
37767eff86
Hooks for injecting embedder resolver providers.
...
BUG=
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org/1666573006 .
2016-02-04 11:03:43 -08:00
4239eadd74
WEB-20151. Include type arguments into type proposals.
...
R=brianwilkerson@google.com
BUG= https://youtrack.jetbrains.com/issue/WEB-20151
Review URL: https://codereview.chromium.org/1661763002 .
2016-02-02 18:36:11 -08:00
Konstantin Shcheglov