dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
113,742 Commits 2 Branches 0 Tags
tonycloud/dev
Commit Graph

44 Commits

Author SHA1 Message Date
Sam Rawlins f15d149926 Prepare dart_internal for the next SDK version bump 
Change-Id: Idfdd2ca9f1e9d953c1baed8ce7b59c7e3a0d7508
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/491820
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Ivan Inozemtsev <iinozemtsev@google.com>
 2026-03-31 09:14:02 -07:00
Ivan Inozemtsev a5fe41a609 Prepare dart_internal for the next SDK version bump 
Change-Id: I7b57a9e2433c0b589b4c1454b9b0fd9ddaf3ee8d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/460042
Commit-Queue: Ivan Inozemtsev <iinozemtsev@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
 2025-12-08 05:41:34 -08:00
Ivan Inozemtsev 5f220762a8 Update the changelog and pubspec version for dart_internal 
This is a follow-up for
https://dart-review.googlesource.com/c/sdk/+/436221

Change-Id: Ia6ba22782da7c0fe2148c5a11a528c20c6da51e9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/449960
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Auto-Submit: Ivan Inozemtsev <iinozemtsev@google.com>
 2025-09-16 13:35:11 -07:00
Ivan Inozemtsev 7bdc2bb483 Update SDK version constraint in dart_internal 
Required for further increasing of version main branch.

Change-Id: I8454ca16c6a4d6d9f9e0cef1537515c731d181c7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/449804
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Auto-Submit: Ivan Inozemtsev <iinozemtsev@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2025-09-16 10:20:49 -07:00
Ivan Inozemtsev 2f601f5312 Update SDK version constraint in dart_internal 
Required for https://dart-review.googlesource.com/c/sdk/+/434804.

Change-Id: I3a7f60e6750a6b2e277cb53b35680ddf98012416
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/436221
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Auto-Submit: Ivan Inozemtsev <iinozemtsev@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2025-06-23 08:26:20 -07:00
Ivan Inozemtsev 24120c84d0 [release] Bump version on main to 3.9 
Change-Id: Id694e90aad9e0ca50e4e09e40c2795f210c60e3d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/419700
Commit-Queue: Ivan Inozemtsev <iinozemtsev@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
Auto-Submit: Ivan Inozemtsev <iinozemtsev@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
 2025-04-08 11:16:58 -07:00
Sigurd Meldgaard 2fe05bd568 Reland "Migrate to use pub workspace" 
This is a reland of commit b9b77058a9

Original change's description:
> Migrate to use pub workspace
>
> Use `pub get` to generate `.dart_tool/package_config.json` on gclient sync.
>
> All pkg/ (and a few third_party) packages that are developed inside the sdk repo are included in the workspace from the root `pubspec.yaml`.
>
> All dependencies that are pulled in via DEPS are added as path dependencies via `dependency_overrides` in the root `pubspec.yaml`.
>
> Bug: https://github.com/dart-lang/sdk/issues/56220
> Change-Id: I38c12b608c68da54c57821116cf9aa6696936746
> Tested: relies on CQ of existing tests. Should have no effect on functionality
> CoreLibraryReviewExempt: only core library change is adding a `// ignore:` comment. Should have no influence on functionality
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/397164
> Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>
> Reviewed-by: Alexander Thomas <athom@google.com>

Bug: https://github.com/dart-lang/sdk/issues/56220
Change-Id: I29afabade2d2447dea05121cb87ff50bb21a4b76
Cq-Include-Trybots: luci.dart.try:flutter-linux-try,flutter-web-try
Tested: relies on CQ of existing tests. Should have no effect on functionality
CoreLibraryReviewExempt: only core library change is adding a `//
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/415561
Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
 2025-03-20 06:19:16 -07:00
Sigurd Meldgaard 6c4de1ab7e Revert "Migrate to use pub workspace" 
This reverts commit b9b77058a9.


Revert "Add missing sample pubspec to workspace"

This reverts commit 892ea15ac7.


These seem to break the engine.

Change-Id: Ieee26deb7928c3869a1b6265326c3ce568ffe731
Tested: this is a revert.
CoreLibraryReviewExempt: this is a revert
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/415582
Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
 2025-03-14 09:08:20 -07:00
Sigurd Meldgaard b9b77058a9 Migrate to use pub workspace 
Use `pub get` to generate `.dart_tool/package_config.json` on gclient sync.

All pkg/ (and a few third_party) packages that are developed inside the sdk repo are included in the workspace from the root `pubspec.yaml`.

All dependencies that are pulled in via DEPS are added as path dependencies via `dependency_overrides` in the root `pubspec.yaml`.

Bug: https://github.com/dart-lang/sdk/issues/56220
Change-Id: I38c12b608c68da54c57821116cf9aa6696936746
Tested: relies on CQ of existing tests. Should have no effect on functionality
CoreLibraryReviewExempt: only core library change is adding a `// ignore:` comment. Should have no influence on functionality
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/397164
Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
 2025-03-14 05:21:40 -07:00
Sigurd Meldgaard 6f1fe1a145 Bump language version for pkg/dart_internal 
Extracted from https://dart-review.googlesource.com/c/sdk/+/397164

Change-Id: Ia0cfed4b83cfeb51cfac0e5e90973f13de553b14
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/412082
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>
 2025-02-25 06:55:03 -08:00
Alexander Thomas f72b1ae9dd Bump dart_internal to allow Dart 3.8 
Change-Id: Iec15b24cdf8f87cafbb3285841968325f90f9fa3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/403989
Commit-Queue: Ivan Inozemtsev <iinozemtsev@google.com>
Reviewed-by: Ivan Inozemtsev <iinozemtsev@google.com>
Auto-Submit: Alexander Thomas <athom@google.com>
 2025-01-16 04:25:47 -08:00
Robert Nystrom 6dc203f192 Bump dart_internal's SDK constraint to accept the upcoming dev version. 
Change-Id: I7b7f47cdd8acffbbcd9af5528d8f94f01a1d4189
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/377862
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
 2024-07-30 17:48:56 +00:00
Robert Nystrom dc372831e3 Bump dart_internal again to work with the latest dev builds. 
Change-Id: I18d79f4009def65855c6e75caaf54b78acd0d13a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/365306
Reviewed-by: Leaf Petersen <leafp@google.com>
 2024-05-02 23:06:47 +00:00
Robert Nystrom fc2700ad7d Allow dart_internal to work with the upcoming Dart version. 
Change-Id: I800f3a1a3c8f099b4eedbd4f3ed36109e4af827e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/365285
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Nate Bosch <nbosch@google.com>
Commit-Queue: Nate Bosch <nbosch@google.com>
 2024-05-02 21:35:49 +00:00
Robert Nystrom 86146ed6cf Bump dart_internal to allow Dart 3.3. 
Change-Id: Ie11f05583cedbbb7a0e91e0d6924cc1ca1871561
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/352681
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Nate Bosch <nbosch@google.com>
Commit-Queue: Nate Bosch <nbosch@google.com>
 2024-02-14 19:49:32 +00:00
William Hesse 7d802ca199 Increase maximum sdk version constraint on dart_internal to 3.3.0 
The dart_internal has a maximum sdk version constraint so it
can be deprecated and removed once it is no longer used.
Increasing it from <3.2.0 to <3.3.0.
The package is still used internally, and downloaded by Flutter
from pub.

Change-Id: I210ac7453950388544d03d768ad9261d51a7f060
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/316540
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Nate Bosch <nbosch@google.com>
Commit-Queue: William Hesse <whesse@google.com>
 2023-07-27 00:29:42 +00:00
Robert Nystrom ce9e38fff1 Update package:dart_internal to work with SDK 3.2.0. 
Fixes #52742.

Change-Id: I11cebf22f48788632e45cacc1e43c3be069a03dd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/310323
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
 2023-06-21 01:14:38 +00:00
Robert Nystrom 7b3c81f06d Update package:dart_internal to allow Dart SDK 3.0.0. 
Change-Id: I564b60940475f40fa842e03d9b03ef0f7b06e9ae
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/297820
Reviewed-by: Kevin Moore <kevmoo@google.com>
Reviewed-by: Michael Thomsen <mit@google.com>
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Kevin Moore <kevmoo@google.com>
 2023-04-24 19:51:09 +00:00
William Hesse b7288f5b88 [dart_internal] Support 2.19 
Change-Id: I09a42936da6311d451bdc2579a3d796b2e96626e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/251944
Reviewed-by: Michael Thomsen <mit@google.com>
 2022-07-19 09:00:36 +00:00
Devon Carew 3dbed884c2 [pkg] use package:lints when analying pkg/ 
Change-Id: Ib25573375ea1f54e07846af6fcd9cd74a8fefb7a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/250784
Reviewed-by: Nate Bosch <nbosch@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2022-07-07 14:29:22 +00:00
Devon Carew 2a20d4be24 [pkg] ensure each publishable package has a repository pubspec field 
Change-Id: I06c0d10c87c3f329098352a7abe9ef9fa0b1532e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/241504
Reviewed-by: Kevin Moore <kevmoo@google.com>
Reviewed-by: Nate Bosch <nbosch@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2022-04-19 22:13:51 +00:00
Alexander Thomas bca5b896e5 [dart_internal] Support 2.18 
Change-Id: Iea0fb68809ad7b45795f87116cb3c38ccf6f5f9d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/240543
Auto-Submit: Alexander Thomas <athom@google.com>
Reviewed-by: Kevin Moore <kevmoo@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
 2022-04-07 20:27:20 +00:00
Robert Nystrom 836aeecb91 Update dart_internal to allow SDK 2.17. 
Change-Id: Ic3295690f9f4cf2d0a84cfbba59b7cd107c22f4f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/230000
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
 2022-01-26 09:26:18 +00:00
Alexander Thomas 9131467317 Bump dart_internal to support Dart 2.16 
Change-Id: Ia4e933fbc7bdcacc340545438355e16830525569
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/220012
Auto-Submit: Alexander Thomas <athom@google.com>
Commit-Queue: Kevin Moore <kevmoo@google.com>
Reviewed-by: Kevin Moore <kevmoo@google.com>
 2021-11-12 17:13:13 +00:00
Robert Nystrom 61109c447a Bump dart_internal to support Dart 2.15. 
Change-Id: I459caf39d812d7c9e799617cf59f38c138b14d32
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/210062
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Kevin Moore <kevmoo@google.com>
Reviewed-by: Kevin Moore <kevmoo@google.com>
 2021-08-12 21:21:01 +00:00
Kevin Moore 351de9e165 pkg:dart_internal bump support Dart SDK version 
Also shorten description

Change-Id: Ida9c7ba0f8c6beb10f218ba53803352b469c7a83
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/196044
Reviewed-by: Nate Bosch <nbosch@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Kevin Moore <kevmoo@google.com>
 2021-04-20 16:24:28 +00:00
Robert Nystrom 2ad6249c05 Bump dart_internal to allow 2.12.0. 
Change-Id: I05cc978b2b4b7dbd1bf1e1f4d45375646ea90bff
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/186400
Reviewed-by: Nicholas Shahan <nshahan@google.com>
Commit-Queue: Nicholas Shahan <nshahan@google.com>
Auto-Submit: Bob Nystrom <rnystrom@google.com>
 2021-02-23 00:37:06 +00:00
Kevin Moore 47b5a1e9f5 Support the latest SDK with pkg:dart_internal 
Change-Id: Ife3c77834df9f781d447a7d3cbc842fb7e44be49
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/170140
Commit-Queue: Kevin Moore <kevmoo@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Nate Bosch <nbosch@google.com>
Auto-Submit: Kevin Moore <kevmoo@google.com>
 2020-11-02 21:51:39 +00:00
Robert Nystrom d966206c6d Add Dart 2.11 to dart_internal SDK constraint. 
Change-Id: I5d6f6dd89f99b7b6b88f7683c90f49311823c82e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/164252
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Jake Macdonald <jakemac@google.com>
Reviewed-by: Jake Macdonald <jakemac@google.com>
 2020-09-24 04:15:39 +00:00
Robert Nystrom 5be77279cd Migrate package:dart_internal to null safety. 
This also highlighted a couple of mistakes in the patch files for

dart:_internal and the test.
Change-Id: I60b4e7d5673d64f85a95108c9e03f9328249b9d0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/153021
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Jake Macdonald <jakemac@google.com>
Auto-Submit: Bob Nystrom <rnystrom@google.com>
 2020-08-17 23:06:35 +00:00
Kevin Moore bb6cb64287 Remove author from pubspec, add changelog, update repository 
Change-Id: I8778fad420f4354cd55d8d79cf3d93e842a94b5a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/156584
Reviewed-by: Nicholas Shahan <nshahan@google.com>
Commit-Queue: Nicholas Shahan <nshahan@google.com>
 2020-07-30 21:09:23 +00:00
Nicholas Shahan 851d3875ea [dart_internal] Bump sdk lower bound to 2.0.0 
This is simply to get around the new restriction on publishing
packages that depend on a dev version of the sdk.

Change-Id: I523d6732ee2c0bc7b45a73050bff6b327372e5d6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/156564
Reviewed-by: Kevin Moore <kevmoo@google.com>
Commit-Queue: Kevin Moore <kevmoo@google.com>
Auto-Submit: Nicholas Shahan <nshahan@google.com>
 2020-07-30 20:23:25 +00:00
Nicholas Shahan b5eca11669 Expand SDK constraint on dart_internal to include 2.9.0 
Change-Id: I338463eb12517798af85cd83c771ae40c3c6015d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/156280
Reviewed-by: Jake Macdonald <jakemac@google.com>
Commit-Queue: Nicholas Shahan <nshahan@google.com>
 2020-07-29 18:17:35 +00:00
Robert Nystrom 12e81d336f Bump the SDK constraint on dart_internal to permit Dart 2.8.0. 
Change-Id: I8f9dfcd2c361b28f62e7388fc642414efbd120aa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141021
Reviewed-by: Nicholas Shahan <nshahan@google.com>
Commit-Queue: Nicholas Shahan <nshahan@google.com>
Auto-Submit: Bob Nystrom <rnystrom@google.com>
 2020-03-26 17:51:53 +00:00
Robert Nystrom 5adff879e3 Widen the SDK constraint on dart_internal to include 2.7.0. 
Change-Id: I55e9b1224f69268ccfb8ba345d3a9d62d3d93838
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127449
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Nicholas Shahan <nshahan@google.com>
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Nicholas Shahan <nshahan@google.com>
 2019-12-06 00:54:30 +00:00
Nicholas Shahan 8d7daafdaf [dart_internal] Bump SDK upper-bound to <2.7.0 
Change-Id: I5c43563149010d9715e32370a5f983d45d09039c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/117164
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Nicholas Shahan <nshahan@google.com>
 2019-09-13 22:01:16 +00:00
Robert Nystrom b6455ab53a Expand the version range for dart_internal to allow 2.5.x versions. 
Change-Id: If258cf17fa6abec57d0245024d0e47675567680d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112922
Reviewed-by: Nicholas Shahan <nshahan@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
 2019-08-14 00:36:16 +00:00
Nicholas Shahan 4f71abcd71 [dart_internal] Bump SDK constraint upper-bound to <2.5.0 
Issue: #37324
Change-Id: Ibea63bb775c83484523fb8d6caeda918df25e849
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106949
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Nicholas Shahan <nshahan@google.com>
 2019-06-21 00:39:25 +00:00
Nicholas Shahan f5224b53e4 [dart_internal] Bump SDK constraint upper-bound to <2.4.0 
Change-Id: Iaad5890187b02562ae97ccc5195b0576cb58e564
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99860
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Nicholas Shahan <nshahan@google.com>
 2019-04-20 00:58:51 +00:00
Nicholas Shahan e29835749a [dart_internal] Bump SDK constraint upper-bound to <2.3.0 
Change-Id: I0e992e40150a7eb0af7f6a039597eca89f5d9a9c
Reviewed-on: https://dart-review.googlesource.com/c/94355
Reviewed-by: Kevin Moore <kevmoo@google.com>
Commit-Queue: Nicholas Shahan <nshahan@google.com>
 2019-02-26 17:39:50 +00:00
Nicholas Shahan c8cf355c54 Bump package dart_internal's SDK constraint upper-bound to <2.2.0 
Change-Id: I74914268c1e15fae85ef39977ab51c8aa08761f3
Reviewed-on: https://dart-review.googlesource.com/c/79426
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Nicholas Shahan <nshahan@google.com>
 2018-10-15 21:37:56 +00:00
Bob Nystrom b8e4af7588 Increase dart_internal's lower SDK bound. 
(This is mainly needed to allow using it with bleeding edge SDKs.)

Change-Id: Ie90d4dd51c03b1f48b42066041e9f5b743d791cb
Reviewed-on: https://dart-review.googlesource.com/44401
Reviewed-by: Natalie Weizenbaum <nweiz@google.com>
 2018-03-01 00:40:53 +00:00
Bob Nystrom 6238a55450 Get ready to publish dart_internal. 
We need to use it in the observable package, which is externally
available, so it needs to be able to access it from pub.

Change-Id: I85a1488decb5ef4acd062e2fb3556e7d589e2c8c
Reviewed-on: https://dart-review.googlesource.com/44385
Reviewed-by: Leaf Petersen <leafp@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
 2018-02-28 23:53:14 +00:00
Bob Nystrom 03c8767f73 Here's a start at exposing an API to address https://github.com/dart-lang/sdk/issues/31371. 
There is no actual implementation here yet (that's your job :) ), but there is:

- An external method in dart:_internal, extractTypeArguments().
- Empty patch methods for that for the VM, dart2js, and DDC. These need to have implementations
  filled in.
- A "dart_internal" package to expose a subset of the API. It gives you:

    extractListTypeArgument()
    extractMapTypeArguments()

  We'll bring this into Google, but not publish it externally unless we find we really need to.
- A test for the behavior. It probably has bugs since I can't run it.

See: https://github.com/dart-lang/sdk/issues/31371
Change-Id: I7d9f9a3a36f8e8be106440375c80d584898c83cb
Reviewed-on: https://dart-review.googlesource.com/26467
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Régis Crelier <regis@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>
 2017-12-08 21:57:00 +00:00